TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
36,654 Commits 2 Branches 0 Tags 294 MiB
01ac925b78
Commit Graph

36654 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Vipul A M
01ac925b78 remove unused match variables in selector 2013-03-31 19:08:40 +05:30
Carlos Antonio da Silva
3b0b573ac3 Make comment about uglifier in generated Gemfile consistent between branches 
Introduced in 59d20af2238f7ab553f41b96282722889d8d4393.
 2013-03-30 16:01:04 -03:00
Carlos Antonio da Silva
9e4bbce9d7 Fix indent and change "or" usage to "||" in schema dumper tests 2013-03-30 15:53:52 -03:00
Carlos Antonio da Silva
6ee17918e1 Improve AP changelog entry about layout method with nil return 
Add a note about getting the "no layout" behavior by returning "false"
to make it easier for people that might need to change their code.

Related to #8458. [ci skip]
 2013-03-30 15:48:39 -03:00
Carlos Antonio da Silva
2d1eebfd88 Refactor index algorithm lookup so that it only builds the available options once 
This way the available options are only built for actually fetching the
algorithm in case the option is given.

The options are going to be necessary a second time only in case the option
is given but does not exist, which is supposed to be due to a typo or
something like that, so no problem.
 2013-03-30 15:26:46 -03:00
Carlos Antonio da Silva
07dfc0a05f Minor doc improvement about index algorithms [ci skip] 2013-03-30 15:22:08 -03:00
Carlos Antonio da Silva
0c5552a3dd Fix typos in AP: "overriden" => "overridden" 2013-03-30 15:17:08 -03:00
Carlos Antonio da Silva
09c55dcc5d Review some tests from AMo::Errors to remove "should" usage 
Also remove duplicated tests for Errors#as_json and minor improvements
in some tests.
 2013-03-30 15:04:09 -03:00
Carlos Antonio da Silva
3d0c0c6c95 Improve changelog entry for ActiveModel::Errors#full_messages_for [ci skip] 
Add a working example of how to use this new method.
 2013-03-30 14:38:13 -03:00
Carlos Antonio da Silva
7860bf11d8 Do not calculate values if they are not going to be used 
When building the indexes list in PostgreSQL, IndexDefinition objects
are only created if the query for the related attributes really returns
something matching the attributes.

In case it does not, the variables for building the definition objects were
being created but not used.
 2013-03-30 14:11:43 -03:00
Carlos Antonio da Silva
cbfa91a216 Make docs a little bit more consistent with colons [ci skip] 2013-03-30 14:04:06 -03:00
Carlos Antonio da Silva
5ad8660135 Fix code examples indent in new index options docs [ci skip] 2013-03-30 14:04:05 -03:00
Carlos Antonio da Silva
d9ac2afc8f Use new hash style in doc examples [ci skip] 2013-03-30 14:04:05 -03:00
Rafael Mendonça França
ec55f37027 Merge pull request #9991 from Passionate/patch-1 
improve readability
 2013-03-30 10:03:24 -07:00
Carlos Antonio da Silva
e0b2271026 Minor reviews in AR changelog [ci skip] 2013-03-30 13:54:34 -03:00
Guillermo Iguaran
d98ab530cb Use last released version of thor 2013-03-30 11:47:26 -05:00
Rafael Mendonça França
6e170e1b71 Merge pull request #10004 from choudhuryanupam/master 
Refactored to remove unnecessary setup
 2013-03-30 09:46:09 -07:00
Carlos Antonio da Silva
bacae8739b Merge pull request #10003 from tkhr/refactor-scoping-test-files 
Reorganize scoping test files
 2013-03-30 09:12:35 -07:00
Carlos Antonio da Silva
6a3794b404 Merge pull request #9997 from vipulnsward/hash_destructive_merge 
Change merge to merge! to avoid creating new objects
 2013-03-30 08:55:16 -07:00
Carlos Antonio da Silva
2432469e7f Merge pull request #10007 from vipulnsward/fix_AS_typos 
Fix some typos in AS
 2013-03-30 08:47:06 -07:00
Xavier Noria
92d6dacc34 configure API generation lazily 
Do the absolute bare minimum needed to define this task, no need to compute
gem paths everytime you call rake.
 2013-03-30 11:34:35 +01:00
Xavier Noria
2645f6844f be lazy configuring the RDoc files 
This code is executed every time you run a rake task, there is no need to, specially
adding a penalty to test suites.
 2013-03-30 11:34:35 +01:00
Xavier Noria
f01b7570c5 be lazy loading SDoc 2013-03-30 11:34:35 +01:00
Vijay Dev
5190871822 fix upgrading guide [ci skip] 
I see no need to list the Gemfile contents (twice!) to convey this
message.
 2013-03-30 15:58:39 +05:30
Vijay Dev
6d8c070821 Merge branch 'master' of github.com:lifo/docrails 
Conflicts:
	activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb
	activerecord/test/cases/adapter_test.rb
	guides/source/testing.md

[ci skip]
 2013-03-30 15:46:14 +05:30
Vipul A M
5a0e583f40 fix some typos in AS 2013-03-30 14:01:42 +05:30
Anupam Choudhury
2ff2f839ca Refactored to remove unnecessary setup 2013-03-30 13:16:31 +05:30
Takehiro Adachi
7be9e88682 split relation_scoping_test.rb's default scoping tests into another file 2013-03-30 13:23:01 +09:00
Takehiro Adachi
e4da432a3a rename named_scope_test.rb to a proper file name 
The file name should be name_scoping_test.rb and the class should be
`NamedScopingTest` according to ActiveRecord::Scoping::Name
 2013-03-30 13:15:37 +09:00
Takehiro Adachi
1fde758297 move tests for NamedScope and DefaultScope under test/cases/scoping/ 
The scoping/default.rb and scoping/named.rb got moved under scoping/ in
commit 2b22564c4efaa63d4bbc006762838c4025c1bdca,
but the tests never did.
 2013-03-30 13:13:18 +09:00
Xavier Noria
022ed6c763 adds the API home page to the gemspec, needed for doc:rails 2013-03-30 01:03:02 +01:00
Xavier Noria
4ecf1f8724 typo 2013-03-30 00:38:59 +01:00
Xavier Noria
2cc934a03d registers the new doc:rails behaviour in the changelog 2013-03-30 00:10:52 +01:00
Xavier Noria
2595611dc3 rdoc is no longer a gem dependency, sdoc becomes a runtime dependency 2013-03-30 00:10:52 +01:00
Xavier Noria
84c0ac3b56 unifies API generation 2013-03-30 00:10:52 +01:00
Xavier Noria
3235537030 moves RDOC_MAIN.rdoc to railties 
The goal of these refactors is to have the same code generating
edge and doc:rails APIs, and the rails gem is not available in
LOAD_PATHS because it has no lib directory.
 2013-03-30 00:10:52 +01:00
Xavier Noria
7a5aa720c4 encapsulates API generation in Rails::API::Task 2013-03-30 00:10:52 +01:00
Xavier Noria
ab6cdf7e74 changes the RDoc title of the API 
Nowadays the documentation of Ruby on Rails is more than the API.
 2013-03-30 00:10:52 +01:00
Jonathan Roes
6bd1bbe7cf More typo / wording fixes 2013-03-29 19:53:34 -03:00
Jonathan Roes
8fcc1bed04 Proofreading tweaks 
- Consistent hash structure
- Rewording / typo fixes
 2013-03-29 19:43:10 -03:00
Neeraj Singh
d4dad040c3 explain method invertible_for [ci skip] 2013-03-29 15:38:16 -04:00
Steve Klabnik
b22ec860ab Merge pull request #9998 from neerajdotname/association-doc 
fixes for association doc
 2013-03-29 12:06:34 -07:00
Neeraj Singh
f3cabb3c05 Do not use deprecate method [ci skip] 2013-03-29 15:02:54 -04:00
Neeraj Singh
6807114bb5 fix broken sentence [ci skip] 2013-03-29 15:02:13 -04:00
Vipul A M
bd674fd4e5 change merge to merge! 2013-03-29 20:58:46 +05:30
Xavier Noria
1003f5bd6d removes bindir from the rails gemspec 
Nowadays the rails gem itself has no executables.
 2013-03-29 13:27:56 +01:00
Xavier Noria
8db99d3be8 removes activerecord/examples/associations.png 
This seems to be a legacy file, I cannot find any place where it is used.
 2013-03-29 12:01:30 +01:00
Vinicius Quaiato
0462276909 Merge pull request #130 from crafters/master 
Adding info that Gemfile group :assets doesn't exists anymore
 2013-03-28 23:09:22 -07:00
Vinicius Quaiato
9c6ccb3224 info that Gemfile *group :assets* was removed 
Adding info that Gemfile *group :assets* was removed on upgrading_ruby_on_rails.md
 2013-03-29 03:04:50 -03:00
Paritosh Piplewar
737f618f38 improve readability 2013-03-29 05:29:08 +05:30