TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
53,682 Commits 2 Branches 0 Tags 294 MiB
0d4aa374a2
Commit Graph

3678 Commits

Author SHA1 Message Date
Claudio B.
bd65ba7721 Merge pull request #21906 from scottgonzalez/form-helpers 
Minor cleanup for form helpers guide
 2015-10-08 07:25:41 -07:00
Scott González
8be6b47d1f Minor cleanup for form helpers guide [ci skip] 2015-10-08 08:48:56 -04:00
Andy Lampert
705847578e Improve readability in CSRF section of guide 2015-10-07 22:11:34 -06:00
Rafael Mendonça França
172c25e7b6 Revert "Update asset_pipeline.md" 
This reverts commit afe672185d5eba95f387c46f855ae7a21ea69fa5.

Reason: This change was done by mistake. This option is at the `config`
object not in the `config.assets`.

See
cfb371e96a/railties/lib/rails/application/configuration.rb (L16)
 2015-10-07 15:46:04 -03:00
Miguel Parramon
6de2813919 Fix "Esperanto" name 
Correct spelling is "Esperanto": 

https://en.wikipedia.org/wiki/Esperanto
 2015-10-07 17:54:50 +02:00
Richard Schneeman
ffdbfb2704 Merge pull request #21899 from scottgonzalez/layouts-and-rendering-typo 
Fix typo in docs
 2015-10-07 10:08:38 -05:00
Scott González
0070fc7686 Fix pluralization in docs [ci skip] 2015-10-07 10:30:44 -04:00
Scott González
ab62af7c93 Fix typo in docs [ci skip] 2015-10-07 10:27:46 -04:00
tanmay3011
148d1217a1 [ci skip] Change 'an URL' to 'a URL' as URL doesn't have a vowel sound 2015-10-06 23:34:05 +05:30
kentendo
afe672185d Update asset_pipeline.md 2015-10-05 17:29:49 -07:00
Eileen M. Uchitelle
db448209bd Merge pull request #21796 from dv/docs-change-to-parse-nested-query 
Change "parse_query" to "parse_nested_query"
 2015-10-05 12:56:41 -04:00
David Verhasselt
b4f4de0500 Remove TIP on parse_query 
[ci skip]
 2015-10-05 19:55:00 +03:00
Sean Griffin
dcdf231b38 Merge pull request #20981 from dkoprov/ar_postgres_enum_docs_addition 
Add more info on working with postgres ENUM type
 2015-10-04 18:58:04 -06:00
Claudio B.
5dfc7a9006 Merge pull request #21857 from cllns/fix-myspace-example-wording 
Update text on CSS Injection
 2015-10-04 10:14:09 -07:00
Vijay Dev
7976b6d306 Merge branch 'master' of github.com:rails/docrails 2015-10-04 12:33:14 +00:00
Aaron Patterson
24f9c03d52 Revert "removing Rack::Runtime from the default stack." 
This reverts commit 37423e4ff883ad5584bab983aceb4b2b759a1fd8.

Jeremy is right that we shouldn't remove this.  The fact is that many
engines are depending on this middleware to be in the default stack.
This ties our hands and forces us to keep the middleware in the stack so
that engines will work.  To be extremely clear, I think this is another
smell of "the rack stack" that we have in place.  When manipulating
middleware, we should have meaningful names for places in the req / res
lifecycle **not** have engines depend on a particular constant be in a
particular place in the stack.  This is a weakness of the API that we
have to figure out a way to address before removing the constant.

As far as timing attacks are concerned, we can reduce the granularity
such that it isn't useful information for hackers, but is still useful
for developers.
 2015-10-03 14:21:31 -07:00
Sean Collins
19b626a31a Update text on CSS Injection / Myspace 
[skip ci]
 2015-10-03 12:42:33 -06:00
amitkumarsuroliya
208a33e387 Fixed deprecated string to specify the middleware [ci skip] 2015-10-03 18:19:32 +05:30
Kasper Timm Hansen
1b00c36d85 Merge pull request #21851 from y-yagi/use_class_to_specify_middleware 
use class to specify the middleware [ci skip]
 2015-10-03 12:57:09 +02:00
yuuji.yaginuma
70b09eda03 use class to specify the middleware [ci skip] 
using string for middleware class names is deprecated in 83b767cef90abfc4c2ee9f4b451b0215501fae9a
 2015-10-03 19:26:24 +09:00
Aaron Patterson
37423e4ff8 removing Rack::Runtime from the default stack. 
The runtime header is a potential target for timing attacks since it
returns the amount of time spent on the server (eliminating network
speed).  Total time is also not accurate for streaming responses.

The middleware can be added back via:

```ruby
config.middleware.ues ::Rack::Runtime
```
 2015-10-02 14:45:31 -07:00
Roque Pinel
e2b3ccd1aa Refactor AS::Callbacks halt config and fix the documentation 
Move from `AS::Callbacks::CallbackChain.halt_and_display_warning_on_return_false`
to `AS::Callbacks.halt_and_display_warning_on_return_false` base on
[this
discussion](https://github.com/rails/rails/pull/21218#discussion_r39354580)

Fix the documentation broken by 0a120a818d413c64ff9867125f0b03788fc306f8
 2015-10-01 13:04:20 -04:00
Niall Burkley
391043ab04 Fix documentation for has_many dependant options. 
* A `has_many` dependant association accepts `[:destroy, :delete_all, :nullify,
:restrict_with_error, :restrict_with_exception]` as options.
Currently the documentation references `delete` instead of `delete_all`
* Adds documentation for other options
 2015-09-29 17:34:27 +02:00
David Verhasselt
c0d3209b2e Make fuzzy sentence more clear 
[ci skip]
 2015-09-28 15:16:03 +03:00
Eileen M. Uchitelle
3c52b2000c Merge pull request #21738 from cllns/remove-to_s-from-example 
[Engines Guide] Remove to_s example, since it's outside the scope
 2015-09-25 12:24:51 -04:00
yui-knk
82f69a7a33 [ci skip] Add : before code blocks. 2015-09-25 13:14:14 +09:00
Sean Collins
30769669e3 Remove to_s example 
It's outside the scope of the Engines guide

[skip ci]
 2015-09-24 10:15:52 -06:00
Yves Senn
8516d76c62 Merge pull request #21740 from cllns/add-jbuilder-notes 
[ci skip]

[Action View Overview Guide] Add note about Jbuilder
 2015-09-24 08:38:17 +02:00
Juanito Fatas
cb45950c27 Add a missing period to layouts_and_rendering.md [ci skip] 2015-09-24 14:28:56 +08:00
Sean Collins
961779997c Add note about Jbuilder 
[skip ci]
 2015-09-23 13:57:52 -06:00
Sean Collins
11f00fd3e3 Change the paths for both Gemfile lines to be 'engines/blorgh' 
They're now consistent.

Also changes the quotes to be single, so we only have one type of quote per line

[skip ci]
 2015-09-23 12:29:17 -06:00
Sean Collins
1b9e2bc5aa Remove leading slash from path 
The leading slash denotes an absolute path,
rather than a relative one (which is more popular)

[ci skip]
 2015-09-22 22:05:06 -06:00
Thiago Augusto
c4c70322c4 Update i18n.md [ci skip] 2015-09-22 13:22:53 -03:00
Thiago Augusto
89c53ece47 Update routing.md 2015-09-22 10:17:43 -03:00
amitkumarsuroliya
a2f78cb947 fix to_time output in ActiveSupport guide. Since 48583f8bf7 , to_time returns times formatted as YYYY-MM-DD HH:MM:SS UTC [ci skip] 
`to_time` method returns in `YYYY-MM-DD HH:MM:SS UTC` format after this commit 48583f8bf7 .
 2015-09-20 18:01:26 +05:30
amitkumarsuroliya
c7000d93e7 correcting word smpt -> smtp in ActionMailer guide [ci skip] 
`smpt.gmail.com` should be `smtp.gmail.com`
 2015-09-20 16:32:03 +05:30
yuuji.yaginuma
ac29778b09 remove association reload option from guide [ci skip] 
The option was deprecated in 6eae366d0d2e5d5211eeaf955f56bd1dc6836758
 2015-09-20 11:35:10 +09:00
amitkumarsuroliya
ccbf1597b7 Replace #=> with # => [ci skip] 
@rafaelfranca suggested in f7c7bcd9c2 that code examples should display
the result after  `# =>` and not after `#=>`.
 2015-09-19 13:45:13 +05:30
Ronak Jangir
9b016cff1a Fixed unclosed tags in kindle guide source [ci skip] 2015-09-19 12:15:34 +05:30
Aaron Patterson
38d2bf5fd1 mostly remove the ParamsParser middleware 
This can still be added to the middleware stack, but is really not
necessary.  I'll follow up with a commit that deprecates the constant
 2015-09-18 15:36:55 -07:00
Xavier Noria
2a9cf79957 let the guides home point to the new release series endpoints [ci skip] 2015-09-18 12:27:31 -07:00
Vijay Dev
e80b39c390 Merge branch 'master' of github.com:rails/docrails 2015-09-18 12:30:41 +00:00
Bradley D
119f38f795 Change AbstractRequest to ActionDispatch::Request 
AbstractRequest has been deprecated, updating to refer to ActionDispatch::Request instead.

[ci skip]
 2015-09-17 16:43:51 -06:00
Jeremy Daer
4d77e02d34 Clarify CSRF <script> purpose and protection. Note how to deal with your own <script> tags. 
Ref #21618

[ci skip]
 2015-09-16 08:56:16 -07:00
Claudio B.
7a93952287 Merge pull request #21644 from AvnerCohen/i18n_backend 
Update documentation to remove 'desirable' suggestion for what is not a clear cut approach
 2015-09-16 05:55:22 -07:00
Eileen M. Uchitelle
3edc7f7a1c Merge pull request #21618 from designgrill/master 
Improved explanation of the <script> tag CSRF behavior
 2015-09-16 07:56:32 -04:00
Avner Cohen
aecfc9360f Update documentation to remove 'desirable' suggestion for what is not a clear cut approach 2015-09-16 11:58:43 +03:00
Arthur Nogueira Neves
29886d9304 Merge pull request #20897 from lukechesser/guide-fix-for-acceptance-validation 
Update Validation guide for acceptance method
 2015-09-14 21:18:19 -04:00
Anshul Agrawal
570cd24816 Improved explanation of the <script> tag CSRF behavior 2015-09-14 11:35:16 +05:30
Rafael Mendonça França
65f189da2d Merge pull request #21568 from amitsuroliya/mysql_version_update 
Updated MySQL documentation link to MySQL latest version 5.7 everywhe…
 2015-09-13 03:46:25 -03:00