TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
10,712 Commits 2 Branches 0 Tags 294 MiB
0e2fbd80e2
Commit Graph

10712 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Emilio Tagua
0e2fbd80e2 Merge commit 'rails/master' 
Conflicts:
	activerecord/lib/active_record/calculations.rb
	activerecord/lib/active_record/connection_adapters/mysql_adapter.rb
	activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb
 2009-08-10 18:07:33 -03:00
Emilio Tagua
eb3ae44cca Merge commit 'rails/master' 
Conflicts:
	activerecord/lib/active_record/migration.rb
 2009-08-10 10:40:11 -03:00
Kamal Fariz Mahyuddin
600a89f208 find_cmd should return the full path of the db command 
[#1488 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-08-10 00:04:37 -07:00
codeape
8c32248acb Introduce grouped_collection_select helper. 
[#1249 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-08-09 23:58:43 -07:00
Erik Ostrom
7d16e94d82 Correctly handle offsets in Multibyte::Chars#index and #rindex. 
The offset in codepoints was being passed directly to the wrapped string's index/rindex method. Now we translate the offset into bytes first.

[#3028 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-08-09 23:30:41 -07:00
Cristi Balan
3e35ba2481 Add tests for scoping schema_migrations index by global table prefix and suffix 
[#1543 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-08-09 22:59:04 -07:00
Tim Peters
7eaed4fefe Use table prefix and suffix for schema_migrations index. 
[#1543 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-08-09 22:56:37 -07:00
Jeff Dean
22f3398253 Introduce validates_with to encapsulate attribute validations in a class. 
[#2630 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-08-09 22:47:56 -07:00
Fabien Jakimowicz
797588543e Add support for errors in JSON format. 
[#1956 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-08-09 22:40:20 -07:00
Jay Pignata
793a9f122f Fixing isolation test 
[#3022 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-08-09 22:33:23 -07:00
Daniel Sheppard
b3381cacaf Fix that JSON parser fails to read escaped backslashes. 
[#973 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-08-09 22:30:44 -07:00
Leonardo Borges
0c391b46fb PostgreSQL: XML datatype support 
[#1874 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-08-09 22:24:54 -07:00
Jaime Bellmyer
9c1bac0b7f raises an exception on habtm join table inserts if join table contains a primary key. Caches this check to save time on subsequent inserts. 
[#2086 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-08-09 22:19:18 -07:00
Jaime Bellmyer
f0602214e0 raises exception (ActiveRecord::ConfigurationError with message) on habtm association creation if join table contains a primary key 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-08-09 22:17:39 -07:00
Morgan Schweers
d2d464e26e Fix that creating a table whose primary key prefix type is :table_name generates an incorrectly pluralized primary key. 
[#872 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-08-09 21:57:56 -07:00
Jeremy Kemper
47f7c936a2 Fix test dependency on taggings 2009-08-09 21:30:55 -07:00
Gabe da Silveira
7e3364ac46 Fix that counter_cache breaks with has_many :dependent => :nullify. 
[#1196 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-08-09 21:18:16 -07:00
Jatinder Singh
5704ecffad AR should respect default values for MySQL BINARY and VARBINARY columns. 
[#1273 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-08-09 21:05:26 -07:00
Joshua Peek
734e903af5 Deprecate router generation "best match" sorting 2009-08-09 22:53:16 -05:00
Prem Sichanugrist
82dd725fc1 Fix that irregular plural inflections should not be double-pluralized: 'people'.pluralize should return 'people' not 'peoples'. 
[#1183 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-08-09 20:28:57 -07:00
Joshua Nichols
84d24cdae8 Only load db/schema.rb if it exists; otherwise, display a message to run db:migrate or remove active_record in environment.rb. 
[#3012 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-08-09 20:18:56 -07:00
Jeremy Kemper
279b785839 pare down core_ext dependency 2009-08-09 19:32:38 -07:00
Erik Ostrom
4dda9b644d Add rindex to ActiveSupport::Multibyte::Chars. 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-08-09 19:05:19 -07:00
railsbob
e06a0b03c8 has_many :through create should not raise validation errors 
[#2934 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-08-09 18:44:45 -07:00
jeem
e4ceea3795 make private_and_public_methods unmemoizable [#2372 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2009-08-09 20:04:48 -05:00
Andrew Moreland
ca92d44e76 Support deep-merging HashWithIndifferentAccess. 
[#2732 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-08-09 17:32:04 -07:00
Max Lapshin
0af4b0755f Make sure link_to generates the form with the specified :href if any [#2254 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-08-10 00:58:40 +01:00
Tristan Dunn
a0f69722be Allow ho:through#build when the owner is a new record [#1749 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-08-10 00:46:16 +01:00
Tristan Dunn
0472839d68 Prevent overwriting of table name in merging SQL conditions [#2949 state:resolved] 2009-08-10 00:41:36 +01:00
Gabe da Silveira
00d6c76660 Enable has_many :through for going through a has_one association on the join model [#2719 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-08-10 00:30:44 +01:00
Arthur Zapparoli
810b59a2a9 Removed duplicated tests [#3026 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-08-10 00:08:40 +01:00
Arthur Zapparoli
ce2422ceaf Model#human_attribute_name now accept symbols [#3025 status:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2009-08-09 23:55:54 +01:00
Matt Duncan
920ef4e6f3 Fixed to_label_tag to accept id attribute without changing for attribute [#2660 status:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2009-08-09 23:54:21 +01:00
Grzegorz Forysinski
e391c7a97c Ensure ActiveResource#load works with numeric arrays [Grzegorz Forysinski, Elad Meidar] 
[#2305 state:resolved]

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-08-09 23:39:38 +01:00
Vladimir Meremyanin
08ec22054f Make sure association conditions work with :include and :joins [#358 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-08-09 23:10:23 +01:00
Jordan Brough
916b18adeb Active Resource recognizes 410 as Resource Gone now [#2316 state:resolved] [Jordan Brough, Jatinder Singh] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-08-09 22:56:32 +01:00
Tristan Dunn
1af9bd58a0 No longer require database name for MySQL to allow cross database selects. 
[#1122 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-08-09 14:35:57 -07:00
Hugo Peixoto
202b091373 Added both the documentation and a test case for the collection path name customization feature. 
[#1218 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-08-09 14:26:36 -07:00
Bence Nagy
e1b73b9752 path_names could be used to customize collection actions too 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-08-09 14:26:36 -07:00
Jatinder Singh
1fc1986d6d Make ActiveResource#exists? work [#3020 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-08-09 22:24:57 +01:00
Joshua Nichols
0ec64bea92 Added back support for destroying an association's object by id. [#2306 status:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2009-08-09 21:46:52 +01:00
José Valim
ae47f7575d Improving test coverage for Range#sum [#2489] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-08-09 21:46:52 +01:00
David Burger
1382f4de1f Fix that Hash#to_xml and Array#to_xml shouldn't modify their options hashes [#672 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-08-09 21:46:52 +01:00
Hugo Peixoto
870750ed4b With multiparameter date attributes, the behaviour when empty fields are present is now coherent with the one described in the date_select documentation. 
[#1715 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-08-09 13:39:47 -07:00
Roy Nicholson
3e0951632c Add ability to set SSL options on ARes connections. 
[#2370 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-08-09 13:24:05 -07:00
Elise Huard
c5896bfd84 validate uniqueness with limit in utf8 
[#2653 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-08-09 12:50:04 -07:00
Jeremy Kemper
87e2c1895f Fix failing dependencies test relying on . being in LOAD_PATH 2009-08-09 12:40:16 -07:00
Jeremy Kemper
d0bcf51191 Extract repetitive method 2009-08-09 12:14:25 -07:00
Jeremy Kemper
635f68dca9 Uses &:foo 2009-08-09 12:11:50 -07:00
Jeremy Kemper
db42f1bf67 Fix standalone test missing developer fixture 2009-08-09 11:58:07 -07:00