Commit Graph

9648 Commits

Author SHA1 Message Date
Joshua Peek
11af089cee Extract ActionController rescue templates into Rescue and ShowExceptions middleware.
This commit breaks all exception catching plugins like ExceptionNotifier. These plugins should be rewritten as middleware instead overriding Controller#rescue_action_in_public.
2009-05-02 23:02:22 -05:00
Jeremy Kemper
1c6fcbfd2d Fix implicit ordering expectation 2009-05-02 15:30:00 -07:00
Jeremy Kemper
186fee48c7 Merge branch 'master' of git@github.com:rails/rails 2009-05-02 15:21:19 -07:00
Jeremy Kemper
945bf9c254 Check for sibling Active Support first 2009-05-02 15:16:12 -07:00
Joshua Peek
24affdc88c Deprecate Controller.process interface 2009-05-02 15:37:29 -05:00
Joshua Peek
f32cf44870 Switch functional tests to run through the rack interface instead of process 2009-05-02 15:29:18 -05:00
Joshua Peek
a8b75c480f Functional test runner finalizes response just like the integration test runner. In both runners, the @response object will now behave the same.
Some functional tests will need to be updated if they are relying on preprocessed data on the response.
2009-05-02 14:57:40 -05:00
Joshua Peek
3900f4007e Deprecate assert_redirect_to's partial hash matching 2009-05-02 14:23:44 -05:00
Ruy Asan
3be3470fab Added routing test for irregular ID requirements and custom member action.
[#2595 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2009-05-01 15:02:32 -07:00
Ruy Asan
99c103be11 Fixed bug with polymorphic has_one :as pointing to an STI record
[#2594 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2009-05-01 14:47:56 -07:00
Alexander Podgorbunsky
db0bfe4ede Default scope :order should be overridden by named scopes.
[#2346 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2009-05-01 14:44:24 -07:00
Pratik Naik
853c229bbd Rename vendor/rack to vendor/rack-1.1.pre 2009-05-01 20:24:14 +01:00
Pratik Naik
432e631d5c Vendor Rack edge ( commit : 815342a8e15db564b766f209ffb1e340233f064f ) 2009-05-01 20:12:49 +01:00
steve
60a6284a46 Tests should use ActiveRecord::Base.connection.rollback_db_transaction to rollback a transaction
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
2009-05-01 16:00:09 +01:00
steve
5501b99a19 Ensure ActiveRecord::Base.connection_pool.with_connection creates a new connection only when needed [#1752 state:resolved]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
2009-05-01 14:58:10 +01:00
Ken Collins
b193f23390 Use table_exists? in #initialize_schema_migrations_table [#1923 state:resolved]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
2009-05-01 14:24:40 +01:00
Joshua Peek
664ae187a9 Update some old tests to use AC TestProcess 2009-04-30 23:46:35 -05:00
Joshua Peek
05bd863c02 alias method chain process with test 2009-04-30 23:46:35 -05:00
Joshua Peek
1fcc7dbcc8 Move TestRequest#query_parameters into AD TestRequest 2009-04-30 23:46:34 -05:00
Jeremy Kemper
dc9f53b05b Selectively require rake sshpublisher so full gem isn't required 2009-04-30 21:02:23 -07:00
Jeremy Kemper
9b852af497 Explicitly require builder for to_xml 2009-04-30 20:34:11 -07:00
Joshua Peek
0fa1e75d41 Set rack.input instead of RAW_POST_DATA in TestRequest 2009-04-30 20:04:55 -05:00
Joshua Peek
261ec996de Missed stray @request_uri 2009-04-30 19:36:18 -05:00
Joshua Peek
a6fff94baf Move TestRequest cookies accessor into AD TestRequest 2009-04-30 19:23:50 -05:00
Joshua Peek
d54604c352 Depend on unreleased rack 1.1 2009-04-30 19:10:05 -05:00
Jeremy Kemper
6ae839bf48 Merge branch 'master' of git@github.com:rails/rails 2009-04-30 16:45:39 -07:00
John F. Douthat
e59835bd09 Fix action-cached exception responses.
Methods raising ActiveRecord::RecordNotFound were returning 404 on first request and 200 OK with blank body on subsequent requests.

[#2533 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2009-04-30 16:43:01 -07:00
Jeremy Kemper
f0b9e28619 Fix render :json => nil [#2589 state:resolved] 2009-04-30 16:34:00 -07:00
Joshua Peek
00d1a57e9f Start moving TestRequest and TestResponse into ActionDispatch 2009-04-30 17:26:03 -05:00
Joshua Peek
64e66cf161 Vendor new Rack::Mock changes 2009-04-30 14:40:46 -05:00
Joshua Peek
9bac470c7a Group integration test helpers and delegate other helpers to request and response objects 2009-04-30 14:28:42 -05:00
Joshua Peek
ba9887c9c0 Switch to action_dispatch rack namespace 2009-04-30 13:45:12 -05:00
Joshua Peek
7b3b7cb2ab Move generic assertions into ActionDispatch 2009-04-30 11:55:53 -05:00
Joshua Peek
98dd726687 Test::Unit work arounds are handled by ActiveSupport 2009-04-30 11:42:01 -05:00
Joshua Peek
988513ac7a Framework backtrace cleaning is handled by ActiveSupport now 2009-04-30 11:42:01 -05:00
Jeremy Kemper
79420e71e0 Work around Float faux precision 2009-04-30 01:33:07 -07:00
Jeremy Kemper
7eef11eb65 Convert params keys to strings 2009-04-29 23:29:11 -07:00
Jeremy Kemper
091965c0fc Prefer behavior check to RUBY_VERSION to catch 1.8 backports 2009-04-29 23:12:34 -07:00
Emilio Tagua
db892ea775 Fix duplicated test name
[#2581 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2009-04-29 15:46:43 -07:00
David Dollar
7149ddd2a1 Additional tests for the gem subsystem
* test_gem_ignores_development_dependencies
  * test_gem_guards_against_duplicate_unpacks
  * test_gem_does_not_unpack_framework_gems

[#2236 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2009-04-29 08:07:57 -07:00
Jeremy Kemper
d6c584618f Merge branch 'master' of git@github.com:rails/rails 2009-04-28 23:19:53 -07:00
David Dollar
599f2cfb4a Attempt to deal with more cases of gems with native components.
This commit adds a rudimentary check for 'unbuilt' gems, so that we can abort
the application load if there are any gems that have native components that
have not yet been built.

The rake task gems:build has now only builds 'unbuilt' gems as a result.

The rake task gems:build:force has been added to deal with cases of incomplete
builds, or any case where you need to force the build of all of your gems.

Changes the gems:build task to get its gem list by parsing directory entries
in vendor/gems, which sidesteps the chicken/egg issues involved with having a
gem unpacked into vendor/gems without before its native bits are compiled.

[#2266 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2009-04-28 23:16:47 -07:00
Joshua Peek
c0a372ba87 Deprecate template, session, assigns, and layout accessors on response object. Instead access them through the controller instance. This mainly affects functional test assertions. 2009-04-28 23:29:46 -05:00
Joshua Peek
8925e89c63 Deprecate response.assigns 2009-04-28 23:29:46 -05:00
Joshua Peek
d63b42da36 Move header injection back into integration tests 2009-04-28 23:29:46 -05:00
Joshua Peek
afa7d7ff05 Fix validate_request method name 2009-04-28 23:29:45 -05:00
Jeremy Kemper
acd5db300b Rejig active support dependencies to behave better with the boot process 2009-04-28 18:25:35 -07:00
Jeremy Kemper
b825bef74c Fix missing core extension dependencies 2009-04-28 17:58:51 -07:00
Emilio Tagua
4246a79a99 Show executed queries when assert_sql assertion fails [#2573 state:resolved]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
2009-04-28 22:11:47 +01:00
Yehuda Katz + Carl Lerche
ab83db9d06 Fixes ActionMailer to work with the ActionView refactoring 2009-04-27 12:34:25 -07:00