TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
55,861 Commits 2 Branches 0 Tags 294 MiB
1600c67ff9
Commit Graph

55861 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jon Moss
1600c67ff9 Add CHANGELOG.md entry for #22950 
[ci skip]
 2016-01-20 17:05:47 -05:00
Rafael França
6226f8f066 Merge pull request #23130 from vipulnsward/html_safe_to_raw 
Changed html_safe to raw in AV
 2016-01-20 02:10:42 -05:00
Vipul A M
b387d9a14a html_safe is not supposed to be public API for AV. This change removes usage of html_safe in favour of raw() in AV helpers. 
Also changed usage of html_safe to make use of raw() instead so that the intended behaviour is verified with raw()
 2016-01-20 12:38:59 +05:30
प्रथमेश Sonpatki
715cbd3fdc Merge pull request #23129 from Amit-Thawait/master 
Pluralize counter_cache column name in example [ci skip]
 2016-01-20 12:37:46 +05:30
Amit Thawait
e1e6d3438b Pluralize counter_cache column name in example [ci skip] 2016-01-20 11:58:11 +05:30
Matthew Draper
56a9341689 Merge pull request #22950 from maclover7/adapterize-storage-actioncable 
Adapterize storage for ActionCable
 2016-01-20 16:09:20 +10:30
Rafael França
8f208e0f90 Merge pull request #23111 from prathamesh-sonpatki/fix-changelog 
Update CHANEGLOG for https://github.com/rails/rails/pull/20005 [ci skip]
 2016-01-20 00:01:21 -05:00
Prathamesh Sonpatki
e677cc1170 Update CHANEGLOG for https://github.com/rails/rails/pull/20005 [ci skip] 2016-01-20 08:39:57 +05:30
schneems
fe55163f11 Revert "Its ideal to set Vary: Accept-Encoding, irrespective of whether gzipped version exists or not. This is helpful for CDN's to later distinguish assets, based on previous, current copies and introduced gzip version if any." 
This reverts commit 067c52f608568e35181830a5c1016e382650e655.

Conversation: https://github.com/rails/rails/pull/23120#issuecomment-173007011
 2016-01-19 16:22:40 -06:00
Sean Griffin
12cd2c494d Add ModelSchema::type_for_attribute to the public API 
We want this method to be the single canonical source of information
about type metadata related to a model. This is the method I've been
continuously recommending people use if they need this sort of access,
as I have no plans to remove or change it at any point in the future.

We can do ourselves a favor and get people to use this instead of
relying on some other part of the internals that they shouldn't be by
making this method public.
 2016-01-19 13:19:54 -07:00
Richard Schneeman
a4c82d8e64 Merge pull request #23120 from vipulnsward/always-set-vary-for-static-assets 
Its ideal to set Vary: Accept-Encoding, irrespective of whether gzipped or not
 2016-01-19 13:33:51 -06:00
Rafael França
71491c631f Merge pull request #23125 from Gaurav2728/update_puma_as_webserver 
[ci skip] update guide for Puma web server instead of Webrick
 2016-01-19 14:23:56 -05:00
Gaurav Sharma
1474619196 [ci skip] update guide for Puma web server instead of Webrick 
Rails 5.0 default server puma web server. following commit - https://github.com/rails/rails/commit/ae48ea69
 2016-01-20 00:50:47 +05:30
Yves Senn
e0b5533be6 Merge pull request #23124 from vipulnsward/rake-rails 
- Changed from bin/rake to bin/rails at more application places. [ci skip]
 2016-01-19 20:15:31 +01:00
Vipul A M
d0c62d9d1e - Changed from bin/rake to bin/rails at more application places. 
- Only ones left are from the upgrading guide, and command line guide explicit section about rake

Follow up of https://github.com/rails/rails/pull/23119
[ci skip]
 2016-01-20 00:34:31 +05:30
Richard Schneeman
ba24d42828 Merge pull request #23123 from schneems/schneems/strong_params_method_missing 
[close #23084] Deprecated StrongParameters
 2016-01-19 13:02:46 -06:00
Jon Moss
1347f08521 Merge pull request #23119 from Gaurav2728/update_guide_to_bin_rails_command 
use bin/rails default instead of rake commands [ci skip]
 2016-01-19 13:49:48 -05:00
schneems
875a0b6e4f Link to docs instead of listing methods 2016-01-19 12:32:55 -06:00
Vipul A M
067c52f608 Its ideal to set Vary: Accept-Encoding, irrespective of whether gzipped version exists or not. This is helpful for CDN's to later distinguish assets, based on previous, current copies and introduced gzip version if any. 
For ref: https://www.fastly.com/blog/best-practices-for-using-the-vary-header

This change sets `Vary` header always, to be on safer side
 2016-01-19 23:48:59 +05:30
Gaurav Sharma
352a8892fd use bin/rails default instead of rake commands [ci skip] 
I go through the `http://edgeguides.rubyonrails.org/` and found `rake` commands in various files that are in RAILS 5.0 implement by `bin/rails` command. I try to change all that can be directly use `bin/rails …`
 2016-01-19 23:47:14 +05:30
schneems
3f2ac413b7 Add methods to StrongParameters 
It's reasonable to expose different value readers.
 2016-01-19 12:06:29 -06:00
schneems
66d705b3e7 [close #23084] Deprecated StrongParameters 
We can provide a more flexible upgrade experience by warning users they are using unsafe methods instead of forcing the safe API by deprecating before removal. This PR provides this functionality.
 2016-01-19 12:05:44 -06:00
David Heinemeier Hansson
3af3c19fd0 Merge pull request #23122 from vipulnsward/guides-revamp 
Guides header changes
 2016-01-19 18:54:23 +01:00
Vipul A M
c96727135a - Remove dead links and take users to just the home page instead 
- Add new logo for guides header
[ci skip]
 2016-01-19 23:22:25 +05:30
Yves Senn
1131f47d5d Merge pull request #23121 from prathamesh-sonpatki/fix-tests 
Fix test failure on PostgreSQL by sorting the result before comparison
 2016-01-19 18:47:33 +01:00
Prathamesh Sonpatki
e55ba530c1 Fix test failure on PostgreSQL by sorting the result before comparison 2016-01-19 22:45:25 +05:30
Yves Senn
3ea4476942 run type column through attribtues API type casting. 
Closes #21986.

This makes it possible to write custom types that define a different
mapping for STI columns.
 2016-01-19 17:31:16 +01:00
Abdelkader Boudih
f8234313fe Merge pull request #23117 from vipulnsward/22297-ar-exception-raise 
Mention that halting chain does not re-raise  `ActiveRecord::RecordIn…
 2016-01-19 11:19:17 +00:00
प्रथमेश Sonpatki
1599868610 Merge pull request #23116 from vipulnsward/22648-html-safe-text 
Make text about render :html option clearer to state, text will get e…
 2016-01-19 16:02:10 +05:30
Vipul A M
8b0b0b0675 Mention that halting chain does not re-raise ActiveRecord::RecordInvalid exception as well, similar to ActiveRecord::Rollback 
Fixes #22297

[ci skip]
 2016-01-19 15:21:53 +05:30
Vipul A M
0764e67863 Make text about render :html option clearer to state, text will get escaped if not marked as safe by using html_safe 
Fixes #22648
[ci skip]
 2016-01-19 15:15:25 +05:30
Kasper Timm Hansen
a48f893cba Merge pull request #23114 from y-yagi/refer_to_rails_command_instead_of_rake_in_environment_error 
refer to rails command instead of rake in environment error
 2016-01-19 10:27:12 +01:00
yuuji.yaginuma
0e835960c7 refer to rails command instead of rake in environment error 
It has been to use an overall rails command in ea4f0e2baba8653b03fba154357842933cf7b778, in order to unify.
 2016-01-19 17:15:59 +09:00
Kasper Timm Hansen
bb4c63c703 Merge pull request #23112 from prathamesh-sonpatki/association-guides-fixes 
Fix discrepancies in associations guide [ci skip]
 2016-01-19 07:51:52 +01:00
Prathamesh Sonpatki
43c750bacb Fix discrepancies in associations guide [ci skip] 
- Followup of 71ff088a09
 2016-01-19 12:02:23 +05:30
प्रथमेश Sonpatki
034b2a7ca9 Merge pull request #23110 from amitsuroliya/application_record 
`ApplicationRecord` instead of  `ActiveRecord::Base` in Association G…
 2016-01-19 11:42:52 +05:30
amitkumarsuroliya
b4803e6ea7 ApplicationRecord instead of ActiveRecord::Base in Association Guides [ci skip] 2016-01-19 11:09:52 +05:30
Jon Moss
ae31da20cd Fix code review comments 
- adapter -> pubsub (re)rename internally
- Change variable names to match method names
- Add EventMachine `~> 1.0` as a runtime dependency of ActionCable
- Refactor dependency loading for adapters
 2016-01-18 19:37:25 -05:00
Jon Moss
980e01eb10 Add em-hiredis and redis as default Gems for new applications 2016-01-18 18:59:31 -05:00
Jon Moss
67af248d51 Small PostgreSQL adapter refactors / cleanup 
- Escape the channel name when subscribing in PG
- Refactor popping the queue to make it easier to read
 2016-01-18 18:59:31 -05:00
Jon Moss
4c5d5b75ab ActionCable::StorageAdapter ==> ActionCable::SubscriptionAdapter 2016-01-18 18:59:30 -05:00
Jon Moss
6aeaed4c1a All Redis deps are now optional, Postgres --> PostgreSQL adapter 2016-01-18 18:59:30 -05:00
Jon Moss
75489642c8 config_opts => cable, per @kaspth 2016-01-18 18:59:28 -05:00
Matthew Draper
78ff63ee41 Listener no longer needs to be a singleton 
We now only create one adapter instance for the server, so it can hold
the listener. This in turn allows the listener to get the PG connection
from the adapter, which will be a good place to allow more flexible
configuration.
 2016-01-18 18:59:01 -05:00
Jon Moss
bc413e814b Tests passing and small refactoring 2016-01-18 18:59:01 -05:00
Matthew Draper
9631c67710 Blanket unsubscribe doesn't appear to be used 2016-01-18 18:59:01 -05:00
Matthew Draper
05d753ff31 Don't execute callbacks on our main listener thread 2016-01-18 18:59:01 -05:00
Matthew Draper
2815db3569 Pull the action methods directly onto the adapter 2016-01-18 18:59:00 -05:00
Jon Moss
7b79ae0335 Add Postgres adapter 2016-01-18 18:59:00 -05:00
Jon Moss
439154250c Refactor storage_adapter 2016-01-18 18:59:00 -05:00