Commit Graph

17784 Commits

Author SHA1 Message Date
Jeremy Kemper
17a6dfb745 It's snowing! 2010-08-14 13:17:30 +02:00
Subba Rao Pasupuleti
f8f437191f no callbacks should be created for empty array [#5289 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-14 13:17:30 +02:00
Subba Rao Pasupuleti
b61ff257e9 tidy up validations length code [#5297 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-14 13:17:29 +02:00
Greg Campbell
1577eafe77 Add missing ActiveModel::Validations require
[#5311 state: resolved]

ActiveModel::Validations uses Hash#except, but does not require it from
ActiveSupport.  (This wasn't showing up in the tests, because it was
required in the helper, and was also required in
ActiveModel::Serialization).

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-14 13:17:29 +02:00
Neeraj Singh
8fdecaaef2 Ensure we can nest include calls [#5285 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-14 13:17:29 +02:00
Santiago Pastorino
535082fe3e deprected -> deprecated 2010-08-14 03:55:14 -03:00
Mark Hayes
b680d153d2 in Rendering objects with RecordIdentifier example, locals should reference @account not @buyer 2010-08-12 12:52:17 -07:00
Xavier Noria
08c37ebf6f be more precise re :validate and :autosave 2010-08-12 19:30:51 +02:00
Xavier Noria
4134d7db34 Merge remote branch 'docrails/master' 2010-08-12 17:36:09 +02:00
Xavier Noria
8af2186d26 revises some autosave docs, style and content 2010-08-12 17:31:04 +02:00
Paco Guzman
8a2b69b727 applied guidelines to "# =>" 2010-08-12 17:09:58 +02:00
José Valim
e4943e93c2 Make update_attribute behave as in Rails 2.3 and document the behavior intrinsic to its implementation. 2010-08-12 12:04:16 -03:00
Xavier Noria
599c505837 commit review: applies guidelines to "# =>" 2010-08-12 16:41:34 +02:00
Neeraj Singh
cfad74cfef updating documentation for named_scope and default_scope 2010-08-12 10:23:20 -04:00
Mark Turner
1049bae132 fixed indentation in test cases
Signed-off-by: wycats <wycats@gmail.com>
2010-08-11 23:55:53 -07:00
wycats
c6160898c8 Replace snowman with utf8=✓ 2010-08-11 18:37:57 -07:00
Paul Hieromnimon
007c4da9ae Raising exception if fixture file can't be found 2010-08-11 15:47:34 -07:00
Aaron Patterson
7de03ec765 subtracting blank strings is slightly faster than blank? 2010-08-11 15:45:06 -07:00
Xavier Noria
ccc89f4899 AS guide: some revisions 2010-08-12 00:17:20 +02:00
Xavier Noria
1ee3593d65 no need to assign if we are gonna return 2010-08-12 00:17:10 +02:00
Aaron Patterson
06dc884454 avoid multiple hash lookups 2010-08-11 15:00:08 -07:00
Aaron Patterson
ce529b4759 dry up the hash dup and avoid sending nil values 2010-08-11 15:00:02 -07:00
Aaron Patterson
0f502ab88f avoiding tap saves us time 2010-08-11 11:44:08 -07:00
Aaron Patterson
2b8f24998e unless Array#empty? is faster than if Array#present? 2010-08-11 11:44:04 -07:00
Aaron Patterson
3c11e92616 stop using private methods 2010-08-11 11:43:57 -07:00
José Valim
25f1e015c0 Ensure @config is not a reserved instance variable in controllers. [#5342 state:resolved] 2010-08-11 10:26:07 -03:00
José Valim & Carlos Antonio da Silva
f08b58dd0c layout_for works again with objects as specified in the documentation and Rails 2.3 [#5357 state:resolved] 2010-08-11 10:23:07 -03:00
Nick Sieger
f5c5cdd4ae Missed one spot for --skip-active-record, which means that new Gemfile isn't set up right
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-08-11 00:42:45 -03:00
Gonçalo Silva
58add1b63c added support for more printers 2010-08-10 10:23:40 -07:00
Santiago Pastorino
a6c6cbfb55 ActiveModel::Base doesn't exist, include_root_in_json is a class_attribute for the classes which includes this module 2010-08-10 11:53:58 -03:00
José Valim
e86cced311 Revert "require_dependency should require using the normal mechanism if possible to avoid double-requires"
This was causing double requires since 991cd59a225b90ab1ba3 was reverted.
This reverts commit 8bf79739b4219eb1d6464e6eb4853e92e81d7621.
2010-08-10 11:18:58 -03:00
Xavier Noria
fff917e37d fixes a typo reported by rymai 2010-08-10 15:34:54 +02:00
Xavier Noria
2a984806ca AS guide: removes some duplication, and makes a second pass on method delegation 2010-08-10 11:52:37 +02:00
Xavier Noria
347d604792 adds the AS guide to the guides index 2010-08-10 04:10:32 +02:00
Xavier Noria
5fc8af4712 AS guide: documents Module#redefine_method 2010-08-10 04:10:32 +02:00
Xavier Noria
ae147b45bb AS guide: documents Module#(instance_)method_names 2010-08-10 04:10:32 +02:00
Tobias Lütke
cb9295c8a1 Added test case to verify that transaction callbacks are correctly propagated to class observers 2010-08-09 21:36:06 -04:00
Xavier Noria
a5d401aa99 AS guide: documents Module#delegate 2010-08-10 03:28:59 +02:00
Xavier Noria
41328815c0 AS guide: documents Process.daemon 2010-08-10 01:55:09 +02:00
Xavier Noria
898bd38d7a AS guide: documents date/datetime/time arithmetic with durations 2010-08-10 01:30:37 +02:00
Brandon Tilley
dd1b33078a Fixed problem with markup that caused an extra symbol in a function name when rendered. 2010-08-09 15:46:39 -07:00
Jeremy Kemper
394f4c9679 Merge remote branch 'brianmario/mysql2' 2010-08-09 15:17:17 -07:00
Brian Lopez
188855501b move mysql2 adapter into core 2010-08-09 14:52:00 -07:00
Brian Lopez
94cff67bd1 ignore this test for mysql2 2010-08-09 12:50:09 -07:00
Brian Lopez
ee9c950f2f bringing over latest from master 2010-08-09 12:43:49 -07:00
wycats
7171161124 rename _snowman to _e 2010-08-09 12:06:25 -07:00
wycats
6767946374 Improve best_standards_support to use only IE=Edge in development mode 2010-08-09 11:48:31 -07:00
Neeraj Singh
190e270db2 adding more documentation for autosave option 2010-08-09 13:37:51 -04:00
Xavier Noria
4f7565c4de adds missing requires for Object#try 2010-08-09 15:25:21 +02:00
Xavier Noria
505546af70 form helpers guide: fixes an example 2010-08-09 14:11:05 +02:00