TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
45,789 Commits 2 Branches 0 Tags 294 MiB
1a6ca03aec
Commit Graph

45789 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Łukasz Strzałkowski
1a6ca03aec Remove redundant NullSerializer 
Use one from ActiveSupport::MessageEncryptor module.
 2014-08-13 23:09:19 +02:00
Guillermo Iguaran
c69e21d36b Merge pull request #16427 from ryandao/full_stack_source_extract 
Full stack source extract
 2014-08-08 10:00:18 -05:00
Santiago Pastorino
7a3d8e20de Merge pull request #16426 from tgxworld/fix_false_positive 
Fixes to TestCaseTest.
 2014-08-08 11:33:10 -03:00
Robin Dupret
f4c8ce9dc8 Fix the #const_regexp's documentation [ci skip] 
Originally introduced in f9086d63, the documentation of this method is
wrong as #const_regexp returns a string to easy the interpolation inside
regular expressions.
 2014-08-08 16:13:38 +02:00
Rafael Mendonça França
ca9851ae18 Merge pull request #16430 from guillermo/patch-1 
Fix typo in plugins doc
 2014-08-08 11:05:02 -03:00
Guillermo Álvarez Fernández
b20d11133d Fix typo in plugins doc 2014-08-08 15:13:40 +02:00
Carlos Antonio da Silva
700968e5fe Merge pull request #16428 from tomkadwill/activerecord_associations_name_param 
[ci skip] Changed 'first argument' to '+name+ argument'
 2014-08-08 08:35:57 -03:00
Tom Kadwill
9ef0f0f69f [ci skip] Changed 'first argument' to '+name+ argument' 2014-08-08 10:00:23 +01:00
Ryan Dao
28595e0128 Update actionpack CHANGELOG 2014-08-08 15:04:55 +07:00
Ryan Dao
1ed264bc60 Retrieve source code for the entire stack trace 
Provide the ability to extract the source code of the entire exception stack
trace, not just the frame raising the error. This improves debugging
capability of the error page, especially for framework-related errors.
 2014-08-08 15:04:55 +07:00
Guo Xiang Tan
aaef6a3860 Fixes to TestCaseTest. 2014-08-08 12:29:52 +08:00
Zachary Scott
30529dc00f Rephrase how we explain RecordInvalid exception in the context of 
`#create!` regarding validations in contrast to the behavior of
`#create`. Also describe creating multiple objects using an array of
hashes as the +attributes+ parameter. [ci skip] /cc #16384
 2014-08-07 19:05:21 -07:00
Zachary Scott
f18552a872 Merge pull request #16384 from tomkadwill/improved_create_documentation 
[ci skip] Added +object+ and +attributes+ to create! description for rdoc
 2014-08-07 19:01:45 -07:00
David Heinemeier Hansson
fbe38c9e9d Pull spring gem entry into the Gemfile template instead of gemfile_entries so it can be grouped with the other development tools 2014-08-07 16:34:27 -07:00
David Heinemeier Hansson
089661b69a Merge branch 'master' of github.com:rails/rails 2014-08-07 16:10:20 -07:00
David Heinemeier Hansson
cc1de71bfa Stop using padding in the generated Gemfile -- it looks shit 2014-08-07 16:10:14 -07:00
Aaron Patterson
e81453ef92 need to call super 2014-08-07 16:03:09 -07:00
Aaron Patterson
8121eefc22 add a new constructor that runs load hooks 2014-08-07 15:50:46 -07:00
Aaron Patterson
2296989826 defer running after_config hooks until after the object is allocated 2014-08-07 15:28:53 -07:00
Rafael Mendonça França
42c569e71e Merge pull request #16424 from gregors/remove_dead_code 
remove dead file_watcher code
 2014-08-07 19:01:46 -03:00
Gregory Ostermayr
6c9669e8f0 remove dead file_watcher code 2014-08-07 16:19:20 -04:00
Aaron Patterson
399f5f6346 use the uri parser so that newer version of Ruby work 2014-08-07 12:10:31 -07:00
Aaron Patterson
69adfc9de6 Merge pull request #16421 from tsukasaoishi/prevant_manycall_showtables 
Tables existence check query is executed in large quantities
 2014-08-07 09:40:53 -07:00
tsukasaoishi
4e83815ce9 change to empty? from blank? 2014-08-08 01:03:09 +09:00
Yves Senn
12cf864abb Merge pull request #16422 from tgxworld/fix_spelling 
Closes #16422
 2014-08-07 17:27:18 +02:00
Guo Xiang Tan
4c30b4fc21 Fix spelling. 2014-08-07 17:26:56 +02:00
tsukasaoishi
8aead812ba Tables existence check query is executed in large quantities 
When Rails starts, tables existence check query is executed
number of models.
In case of mysql,

    SHOW TABLES LIKE 'table1';
    SHOW TABLES LIKE 'table2';
    SHOW TABLES LIKE 'table3';
    ...
    SHOW TABLES LIKE 'table999';

Add process to get the names of all tables by one query.
 2014-08-07 22:41:23 +09:00
Carlos Antonio da Silva
9a0e0594ab Fix typo [ci skip] 2014-08-07 09:17:23 -03:00
Santiago Pastorino
e2689d1dad Merge pull request #16412 from yevhene/master 
Fix in has_secure_password for passwords containing only spaces.
 2014-08-07 09:13:24 -03:00
Santiago Pastorino
f0fdba8b1d Merge pull request #16419 from tgxworld/remove_legacy_code 
Remove ActionController::RaiseActionExceptions.
 2014-08-07 09:10:30 -03:00
Guo Xiang Tan
14508aec70 Remove ActionController::RaiseActionExceptions. 
The latest modification to the code was done in https://github.com/rails/rails/commit/5e3517ea. In Rails 3.2,
`ActionController#rescue_action` was deprecated and `rescue_action_without_handler` is no longer being used.
 2014-08-07 17:43:36 +08:00
Tom Kadwill
38b6b5db58 [ci skip] Updated create! documentation description and added +attributes+ for rdoc 2014-08-07 08:54:03 +01:00
Rafael Mendonça França
e6e81f856e Define id_was to get the previous value of the primary key 
Currently when we call id_was and we have a custom primary key name
Active Record will return the current value of the primary key. This
make impossible to correctly do an update operation if you change the
id.

Fixes #16413
 2014-08-06 23:46:31 -03:00
Rafael Mendonça França
ee255794b3 Test using turbolinks master 
See
153f1b0f04
 2014-08-06 22:48:22 -03:00
Rafael Mendonça França
ca9736e78c Fix DateTime comparison with DateTime::Infinity object 
Fixes #16406
 2014-08-06 22:43:37 -03:00
Aaron Patterson
d25fe31c40 lazily instantiate application subclasses 
this means we can meaningfully override methods in the subclass
 2014-08-06 18:27:16 -07:00
Aaron Patterson
2090615d39 refactor Redirecting so we do not need a controller instance 2014-08-06 14:17:57 -07:00
Yevhene Shemet
f8dcb365df Allow password to contain spaces only. 2014-08-06 22:11:06 +03:00
Akira Matsuda
3dfcae6afa defined? should actually work in current implementation 
So this trick is not needed to be documented anymore.
 2014-08-07 01:59:58 +09:00
Santiago Pastorino
d5be08347f Merge pull request #16402 from bogdan/select_with_empty_block 
Fixed #select form builder helper to support block without html output
 2014-08-06 10:48:52 -03:00
Yves Senn
a819211984 Merge pull request #16359 from skanev/after-bundle-in-rails-templates 
Add an after_bundle callback in Rails templates

Conflicts:
	railties/CHANGELOG.md
 2014-08-06 08:49:00 +02:00
Yves Senn
ec54acd1e0 Merge pull request #16316 from rails/senny/purge_schema_maintenance 
purge database before loading schema, take 2
 2014-08-06 08:26:13 +02:00
Yves Senn
f15cef67f7 schema rake tasks are specific about the configuration to act on. 
The rake tasks and the `DatabaseTakss` adapter classes used to
assume a configuration at some places. This forced the rake
tasks to establish a specific connection before calling into
`load_schema`.

After #15394 this started to cause issues because it could
`purge` the wrong database before loading the schema.
 2014-08-06 08:25:18 +02:00
Yves Senn
53dba73dc1 Revert "Revert "Merge pull request #15394 from morgoth/fix-automatic-maintaining-test-schema-for-sql-format"" 
This reverts commit 5c87b5c5248154cf8aa76cce9a24a88769de022d.
 2014-08-06 08:25:18 +02:00
Aaron Patterson
acb371ca3f call the routes method on engines 
if we access the instance, we can free up lots of codes
 2014-08-05 16:50:50 -07:00
Aaron Patterson
9a36fac810 a rails application should be an engine subclass 2014-08-05 16:30:08 -07:00
Aaron Patterson
70673759a0 no reason to lazily instantiate the routes 
especially if you're just going to add a call two lines down that
populates the cache. common.
 2014-08-05 16:28:55 -07:00
Jeremy Kemper
b89c5a043e Merge pull request #16364 from arthurnn/make_transaction_one_class 
Clarify Transaction responsibilities by breaking unneeded inheritance hierarchy.
 2014-08-05 10:05:10 -07:00
Aaron Patterson
ed180eea48 just assign the instance variables on the test 2014-08-05 09:51:47 -07:00
Guillermo Iguaran
ab54ec7248 We don't need parenthesis for this 2014-08-05 11:51:12 -05:00