TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
64,226 Commits 2 Branches 0 Tags 294 MiB
1e73c1d4f7
Commit Graph

64226 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Vipul A M
1e73c1d4f7 Merge pull request #30255 from lourenci/change-assets-path-of-pipeline 
Fix asset pipeline guide [ci skip]
 2017-08-15 02:00:24 +05:30
Leandro Lourenci
794d0e669e Fix asset pipeline guide [skip ci] 2017-08-14 17:15:34 -03:00
George Claghorn
3cfadd5fa2 Move test to its proper place 
ActiveStorage::Filename is a model, so its test case belongs in test/models.
 2017-08-14 16:04:11 -04:00
Rafael França
09dfabccd1 Merge pull request #30231 from kamipo/remove_unused_source_type_info 
Remove unused `source_type_info` in `RuntimeReflection`
 2017-08-14 16:01:21 -04:00
Rafael França
a684d7b4a0 Merge pull request #30244 from yhirano55/refactor_max_age_seconds 
Refactor max-age seconds
 2017-08-14 16:00:52 -04:00
Rafael França
f9f5772336 Merge pull request #30233 from kamipo/remove_duplicated_join_id_for 
Remove duplicated `join_id_for`
 2017-08-14 16:00:24 -04:00
Rafael França
f8a2562c5c Merge pull request #30235 from bogdanvlviv/omit-additional-removing-cable_yml 
Omit additional removing `config/cable.yml`
 2017-08-14 15:56:09 -04:00
Rafael França
58e07e94fa Merge pull request #30239 from bogdanvlviv/improve-plugin_generator_code 
Improve plugin generator codebase
 2017-08-14 15:55:52 -04:00
Rafael França
160473a1a6 Merge pull request #30252 from rails/activestorage-service-ci 
Run Active Storage service tests in CI
 2017-08-14 15:52:46 -04:00
Rafael Mendonça França
85fa9bdd55 Merge pull request #30241 from yhirano55/optimize_routes_indentation 
Optimize routes indentation
 2017-08-14 15:52:31 -04:00
Rafael França
5ccdd0bb6d Merge pull request #29891 from pat/frozen-string-literals-railties 
Railties updates for frozen string literals.
 2017-08-14 15:00:37 -04:00
Kasper Timm Hansen
5a5b4816f1 Merge pull request #30206 from yukihirop/improve_activerecord_rdoc 
Add document that you rake test single file by using DB(ex. postgresql)
 2017-08-14 20:42:12 +02:00
Kasper Timm Hansen
114bab9fa4 Merge pull request #29994 from y-yagi/fix_test_runner_help 
Show minitest options in test runner help
 2017-08-14 20:40:47 +02:00
Pat Allan
7f6a31433a Allow for frozen string pragma in generated files. 2017-08-14 19:57:45 +02:00
Pat Allan
7b01ae0bc3 Add frozen string pragma to expected routes files. 2017-08-14 19:50:20 +02:00
George Claghorn
3841fdc4e7 Run Active Storage service tests in CI 2017-08-14 13:48:17 -04:00
Pat Allan
acea68de02 Adding frozen_string_literal pragma to Railties. 2017-08-14 19:08:09 +02:00
Pat Allan
d435c92721 Railties updates for frozen string literals. 2017-08-14 19:00:24 +02:00
Ryuta Kamizono
5949cc05d3 Merge pull request #30251 from yhirano55/fix_testing_guide 
Fix testing guide [skip ci]
 2017-08-15 00:41:58 +09:00
Yoshiyuki Hirano
89ab59ea4d Fix testing guide [skip ci] 2017-08-14 23:57:50 +09:00
Matthew Draper
a0bd13fca3 Merge pull request #30250 from koic/should_escape_regexp_wildcard_character 
Should escape regexp wildcard character `.`
 2017-08-14 23:48:21 +09:30
Vipul A M
c4434171cd Merge pull request #30249 from yhirano55/fix_debugging_rails_application_guide 
Fix debugging rails application [ci skip]
 2017-08-14 18:59:03 +05:30
Yoshiyuki Hirano
b44b393243 Fix debugging rails application [ci skip] 2017-08-14 22:25:47 +09:00
Koichi ITO
2b6e85c190 Should escape regexp wildcard character . 2017-08-14 22:17:50 +09:00
Kasper Timm Hansen
57585b6f3b Merge pull request #30171 from kaspth/verifier-encryptor-null-serializer-metadata 
Perform self-serialization once metadata is involved.
 2017-08-14 14:15:48 +02:00
Kasper Timm Hansen
ee7acadfc6 Merge pull request #30240 from y-yagi/clear_mail_after_test 
Clear mail after test
 2017-08-14 14:03:39 +02:00
Matthew Draper
dbcf7dc79c Merge pull request #30243 from kamipo/fix_ci_failure_due_to_reference_type_mismatch 
Fix CI failure due to reference type mismatch
 2017-08-14 19:47:04 +09:30
Yoshiyuki Hirano
77e8b9b586 Refactor max-age seconds 2017-08-14 17:44:15 +09:00
Ryuta Kamizono
a516dfd4b4 Fix CI failure due to reference type mismatch 
`Firm.id` is a bigint if mysql2 adapter is used, but `firm_id` is an
integer. It will cause an out of range error.

https://travis-ci.org/rails/rails/jobs/264112814#L776
https://travis-ci.org/rails/rails/jobs/264112835#L919
 2017-08-14 17:27:54 +09:00
Yoshiyuki Hirano
d1dabde8a2 Optimize routes indentation 2017-08-14 08:12:56 +09:00
yuuji.yaginuma
2f469dc308 Clear mail after test 
If clear it before the test, the mail of the last executed test will not
be correctly cleared.

Therefore, executing the test with seed below will result in an error.

```
./bin/test -w --seed 55480
Run options: --seed 55480

# Running:

...........................................................................................................................................................F

Failure:
MailDeliveryTest#test_does_not_increment_the_deliveries_collection_on_error [/home/yaginuma/program/rails/master_y_yagi/rails/actionmailer/test/delivery_methods_test.rb:221]:
--- expected
+++ actual
@@ -1 +1 @@
-[]
+[#<Mail::Message:47011389364640, Multipart: false, Headers: <Date: Mon, 14 Aug 2017 07:48:40 +0900>, <From: test-sender@test.com>, <To: test-receiver@test.com>, <Message-ID: <5990d748ea5b2_29342ac1af8bcf40886f7@yaginuma.mail>>, <Subject: Test Subject>, <Mime-Version: 1.0>, <Content-Type: text/plain>, <Content-Transfer-Encoding: 7bit>>]

bin/test test/delivery_methods_test.rb:216
```
 2017-08-14 07:49:13 +09:00
bogdanvlviv
cc15b343e5
Remove :force from PASSTHROUGH_OPTIONS for plugin generator 
`:force` is setted inside the method `generate_test_dummy`
 2017-08-13 23:38:24 +03:00
bogdanvlviv
08e894e8e8
Register --api option for plugin generator by PASSTHROUGH_OPTIONS constant 2017-08-13 23:34:08 +03:00
Kasper Timm Hansen
e9275965f2
Perform self-serialization once metadata is involved. 
Adds support for metadata even when using ActiveSupport::MessageEncryptor::NullSerializer.
 2017-08-13 20:40:59 +02:00
Matthew Draper
691af78900 Merge pull request #30237 from koic/remove_unnecessary_include_in_rubocop 
Remove unnecessary Include parameter in rubocop.yml
 2017-08-14 02:39:32 +09:30
Koichi ITO
3281300e79 Remove unnecessary Include parameter in rubocop.yml 2017-08-14 01:57:29 +09:00
bogdanvlviv
05ba550b68
Omit additional removing config/cable.yml by the app generator 
`config/cable.yml` is never created if `--skip-action-cable` is given.
 2017-08-13 18:51:47 +03:00
Matthew Draper
dbe1647b84 Merge pull request #30230 from koic/use_frozen_string_literal 
Use frozen string literal
 2017-08-14 01:06:26 +09:30
Ryuta Kamizono
439ba4429d Remove duplicated join_id_for 
The primary key on the owner record is abstracted as `join_foreign_key`.
 2017-08-13 23:06:43 +09:00
Ryuta Kamizono
bdae5b5d61 Remove unused source_type_info in RuntimeReflection 
`source_type_info` is only used for `constraints` in
`PolymorphicReflection`.
 2017-08-13 22:31:03 +09:00
Koichi ITO
d17264d93f Use frozen string literal in root files 2017-08-13 22:14:24 +09:00
Koichi ITO
0ea00bb5b0 Use frozen string literal in ci/ 2017-08-13 22:07:54 +09:00
Koichi ITO
7d85e0f95c Use frozen string literal in tools/ 2017-08-13 22:04:59 +09:00
Koichi ITO
ef2016f888 Use frozen string literal in tasks/ 2017-08-13 22:04:42 +09:00
Koichi ITO
1f37d846a9 Use frozen string literal in guides/ 2017-08-13 22:04:09 +09:00
Matthew Draper
788f46d486 Wait for the Delayed Job worker thread to finish 2017-08-13 22:03:40 +09:30
Matthew Draper
6dc9c91c82 Merge pull request #30228 from kamipo/fix_random_ci_failure 
Fix random CI failure due to non-deterministic sorting order
 2017-08-13 21:42:10 +09:30
Matthew Draper
4ec5b7610d Merge pull request #30211 from koic/frozen_activestorage 
Use frozen string literal in Active Storage
 2017-08-13 21:39:38 +09:30
Ryuta Kamizono
625bdb164e Fix random CI failure due to non-deterministic sorting order 
https://travis-ci.org/rails/rails/jobs/263617099#L769-L775
 2017-08-13 20:41:19 +09:00
Matthew Draper
c8c2029041 Merge pull request #30079 from kamipo/move_test_not_compatible_with_serialize_macro 
Move `test_not_compatible_with_serialize_macro` to `JSONSharedTestCases`
 2017-08-13 20:16:41 +09:30