TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
28,800 Commits 2 Branches 0 Tags 294 MiB
27ebb3dc8c
Commit Graph

28800 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jonathan Rochkind
27ebb3dc8c deprecated clear_stale_active_connections! can call #reap instead of no-op'ing, #reap does the same thing 2012-03-12 11:14:22 -04:00
Andrew White
ca99beb4a9 Add documentation for find_or_create_by_{attribute}! method. 2012-03-12 15:02:18 +00:00
Andrew White
eee32af45e Add dynamic find_or_create_by_{attribute}! method. 2012-03-12 14:16:19 +00:00
José Valim
1e2de2cb74 Merge pull request #5390 from arunagw/picked_commits 
fix activerecord query_method regression with offset into Fixnum
 2012-03-12 05:16:19 -07:00
Denis Jean
a2c2f40661 fix activerecord query_method regression with offset into Fixnum 
add test to show offset query_methods on mysql & mysql2

change test to cover public API
 2012-03-12 17:44:10 +05:30
José Valim
0533ee45a7 Merge pull request #5387 from panthomakos/autoload 
Improved ActiveSupport::Autoload Performance
 2012-03-12 01:16:19 -07:00
Pan Thomakos
6b480d2e82 Improved ActiveSupport::Autoload performance. 
`ActiveSupport::Autoload#autoload` performance is improved in the default
case where a path is present. Since the full path name is not generated, it
isn't necessary to determine the full constant name either. This results in a
3x performance gain and reduces the number of Ruby objects generated. For a full
benchmark check [this gist](https://gist.github.com/2020228).
 2012-03-11 23:26:48 -07:00
José Valim
6c0d5a19a4 Merge pull request #5366 from parndt/fix_issue_5324 
Fixes #5324 by removing default size options from input:text and default cols and rows options from textarea.
 2012-03-11 15:04:23 -07:00
José Valim
d6ec3f0898 Merge pull request #5372 from jsl/add_before_send_to_actionmailer 
Add ability to define callbacks in ActionMailer
 2012-03-11 14:59:06 -07:00
Philip Arndt
f12f071ece Documented the removal of size from text_field based helpers and cols, rows from text_area helper. 2012-03-12 10:39:45 +13:00
Philip Arndt
8b5198a417 Fix unintended removal of 'cols' from a text_area example. 2012-03-12 10:33:47 +13:00
Justin S. Leitgeb
4f28c4fc9a Add ability to define callbacks in ActionMailer using AbstractController::Callbacks. 
Prior to this commit, there isn't a good way of adding things like
default inline attachments to an email.  This Stack Overflow thread
shows people using hooks like the 'default' method in ActionMailer::Base
to call a Proc for message configuration:

http://stackoverflow.com/questions/5113121/rails-use-same-attachment-for-all-emails-using-layout

This has the unintended side effect of setting a message header, so it's not a good solution.

This pull request adds support for message modifications by including AbstractController:Callbacks
in ActionMailer::Base. It includes tests and documentation for the functionality
provided by including this module.
 2012-03-11 14:05:31 -05:00
José Valim
4d2d0d9906 Merge pull request #5373 from nertzy/fix_comments_about_to_partial_path 
Fix comments about to_partial_path
 2012-03-11 01:17:08 -08:00
Michael Koziarski
411a826583 Merge pull request #5326 from lest/patch-2 
configure how unverified request will be handled
 2012-03-10 16:16:35 -08:00
Grant Hutchins
e78c5eeba1 Fix comments about to_partial_path 2012-03-10 17:40:27 -05:00
Santiago Pastorino
d5d241cb2c @controller already includes url_helpers in with_routing method 2012-03-10 19:27:03 -02:00
Santiago Pastorino
687db9f86d Add missing require 2012-03-10 19:15:29 -02:00
Santiago Pastorino
147c20b629 Fix broken tests 2012-03-10 19:15:29 -02:00
José Valim
f5e5a5bb74 Merge pull request #5371 from jsl/fix_actionmailer_tests 
Fix actionmailer tests broken by #4751a69
 2012-03-10 13:06:54 -08:00
Justin S. Leitgeb
da1a9203b4 Fix actionmailer tests broken by #4751a69 2012-03-10 15:48:55 -05:00
Santiago Pastorino
4751a699c9 AbstractController.action_methods should return a Set 2012-03-10 18:37:30 -02:00
Santiago Pastorino
b0a93d650f Merge pull request #5367 from carlosantoniodasilva/middleware-api 
Change api_only to http_only and add MiddlewareStackProxy docs
 2012-03-10 06:42:58 -08:00
Carlos Antonio da Silva
ec40f6cec0 Change api_only to http_only 
[Carlos Antonio da Silva & Santiago Pastorino]
 2012-03-10 10:15:35 -03:00
Carlos Antonio da Silva
6b28c94e20 Add some docs for MiddlewareStackProxy methods and api_only! 
[Carlos Antonio da Silva & Santiago Pastorino]
 2012-03-10 10:15:35 -03:00
Philip Arndt
3384ee24ad Fixes #5324 by removing default size options from input:text and default cols and rows options from textarea. 2012-03-10 23:30:39 +13:00
José Valim
3e776496d0 Merge pull request #5364 from carlosantoniodasilva/active-model-serialization-include 
Active model serialization :include returning string keys
 2012-03-10 01:06:30 -08:00
Carlos Antonio da Silva
3508da50f0 Rename variable to avoid using name "include" 
Better syntax highlight :)
 2012-03-09 22:07:59 -03:00
Carlos Antonio da Silva
3d04d726fd Remove Array#wrap usage in AMo serialization 2012-03-09 21:56:05 -03:00
Carlos Antonio da Silva
10c3304db6 Make sure serializable hash with :include always returns string keys 2012-03-09 21:51:12 -03:00
José Valim
a39ee47312 Install latest bundler on Travis. 2012-03-09 22:19:55 +01:00
José Valim
3742152310 Bump bundler dependency. 2012-03-09 22:10:43 +01:00
Sergey Nartimov
245941101b configure how unverified request will be handled 
can be configured using `:with` option in `protect_from_forgery` method
or `request_forgery_protection_method` config option

possible values:
- :reset_session (default)
- :exception

new applications are generated with:

    protect_from_forgery :with => :exception
 2012-03-09 19:33:06 +03:00
José Valim
ee0879f6ce Merge pull request #5356 from carlosantoniodasilva/rake-test-system 
Use one system call whenever possible, group rake and Dir.chdir calls
 2012-03-09 06:25:34 -08:00
José Valim
74d5d9a334 Merge pull request #5352 from avakhov/ar_finder_sql_uniq_ids 
In AR depths use &:to_i before :uniq to process mixed arrays likes ["1", 1] correct
 2012-03-09 03:35:15 -08:00
Alexey Vakhov
48a7df9a9f In AR depths use &:to_i before :uniq to process mixed arrays likes ["1", 1] correct 2012-03-09 15:21:12 +04:00
José Valim
225eff9d61 Merge pull request #5351 from shanna/master 
Missing active_model/naming.rb dependency.
 2012-03-08 23:26:48 -08:00
Vijay Dev
ba35527fe7 Minor changelog fixes [ci skip] 2012-03-09 12:29:29 +05:30
Vijay Dev
acc7e50385 Merge pull request #5349 from rafaelfranca/changelog-fix 
Fix my name in the CHANGELOG to follow the convention
 2012-03-08 22:29:55 -08:00
Vijay Dev
2741f2cd6d Merge pull request #5348 from rafaelfranca/fix-warning 
Remove warning of unused variable
 2012-03-08 22:29:00 -08:00
Shane Hanna
2b97b8fb9e Added missing ActiveModel::Naming dependency. 
ActiveModel::Name constructor expects to be able to call #blank? on a
String but the core Object#blank? extension is never required.
 2012-03-09 15:46:24 +11:00
Rafael Mendonça França
d804790634 Fix my name in the CHANGELOG to follow the convention 
Also add missing entries and use the formating convention
 2012-03-09 00:54:21 -03:00
Rafael Mendonça França
9f69f01569 Remove warning of unused variable 2012-03-08 23:58:05 -03:00
Aaron Patterson
657095d8bb ensure that released connections move between threads 2012-03-08 16:12:49 -08:00
Aaron Patterson
d523504c2f make active_connection? return true only if there is an open connection in use for the current thread. fixes #5330 2012-03-08 15:40:23 -08:00
Carlos Antonio da Silva
73e8e70066 Use one system call whenever possible, group rake and Dir.chdir calls 2012-03-08 19:57:17 -03:00
Vijay Dev
8a714c4d80 fix incorrect changelog headings [ci skip]. 
Last commit message should not have said 'Rails 4' either
 2012-03-09 02:30:49 +05:30
Vijay Dev
db6542178c changelog updates for Rails 4 [ci skip] 2012-03-09 02:22:17 +05:30
Vijay Dev
188d1d2787 Merge branch 'master' of github.com:lifo/docrails 2012-03-09 00:07:59 +05:30
Vijay Dev
97e7d43146 Revert "Add rails glossary of common terms & concepts" 
This reverts commit fd584a63deb8d2f1e8969d8527e7a9dbd9d68848.

Reason: This is not suitable for a Rails guide in my opinion.
 2012-03-08 23:54:55 +05:30
Aaron Patterson
085cb3b9af Merge pull request #5287 from nashby/hash-slice-extract 
refactor Hash#slice and Hash#extract!
 2012-03-08 09:54:34 -08:00