TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
51,339 Commits 2 Branches 0 Tags 294 MiB
281581f76f
Commit Graph

51339 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Claudio B.
281581f76f Merge pull request #20278 from dleve123/cleanup-contributing-docs-section 
Cleanup docs for contributing to rails docs
 2015-05-23 18:07:15 -07:00
Daniel Levenson
0fcef173d4 Reword sentences in contributing docs for clarity. 
[skip ci]

- removes use "squash" where it doesn't apply to git
- "is a help" -> "helps"
- "if your comment simply says" -> "... simply reads"
 2015-05-23 19:05:56 -04:00
Daniel Levenson
1cb94077d9 Reword a sentence about GH Issues in contributing guide. 
[skip ci]

"Everyone's Issues" read pretty weird to me, specifically
the use of capitalization. I changed the link text
to be "issue list", which seems to better "go with
the flow", IMHO.
 2015-05-23 18:53:21 -04:00
Aaron Patterson
c10630b642 remove useless ivar 
I should have deleted this earlier with 42e66fac38b54dd53d062fb5d3376218ed2ffdae
 2015-05-23 11:39:43 -07:00
Aaron Patterson
cf985d1a4e add a branch to eliminate multiple nil checks 
if we add an else conditional to the `presence` check, we can eliminate
the second `||` branch in the caller
 2015-05-23 11:38:23 -07:00
Arun Agrawal
989296ff09 Merge pull request #20275 from prathamesh-sonpatki/remove-div-for-from-guides 
Remove div_for from guides [ci skip]
 2015-05-23 15:14:52 +02:00
Prathamesh Sonpatki
d3da208048 Remove div_for from guides [ci skip] 
Followup of https://github.com/rails/rails/pull/20244.
 2015-05-23 17:47:20 +05:30
Aaron Patterson
42e66fac38 move request id manipulation to the request object 
this way we can keep the knowledge of `env` hash keys in one place.
 2015-05-22 16:29:16 -07:00
Zachary Scott
334140c927 Merge pull request #20231 from karanarora/Spelling-fix 
Rails documentation standard is american english. [ci skip]
 2015-05-22 14:35:16 -07:00
karanarora
0750330941 Spelling/typo/grammatical fixes [ci skip] 
spelling fix [ci skip]

example to be consistent [ci skip]

grammatical fix

typo fixes [ci skip]
 2015-05-23 03:01:33 +05:30
Yves Senn
3873fc5c1c Merge pull request #20255 from eliotsykes/link-associations-to-exists-guide 
Link association.exists?(...) to AR::Base.exists? guide [ci skip]
 2015-05-22 10:44:09 +02:00
Eliot Sykes
4311f05124 Link association.exists?(...) to API docs [ci skip] 2015-05-22 09:27:51 +01:00
Yves Senn
1214f0b74f Merge pull request #20254 from eliotsykes/link-relatively-to-configuring-guide 
Make link to configuring guide relative [ci skip]
 2015-05-22 09:21:12 +02:00
Eliot Sykes
b539760014 Make link to configuring guide relative [ci skip] 2015-05-22 07:55:54 +01:00
Rafael Mendonça França
023d50c583 Merge pull request #20252 from waynn/patch-5 
"maybe" => "may be"
 2015-05-22 00:49:09 -03:00
Waynn Lue
f25997a9d9 "maybe" => "may be" 2015-05-21 20:11:41 -07:00
Rafael Mendonça França
d13b4e2fc4 Merge pull request #20251 from davydovanton/doc-memory-store 
Add nodoc label for protected Cache methods
 2015-05-21 19:21:46 -03:00
Anton Davydov
15df1dc2b0 [skip ci] Add nodoc label for protected Cache methods 2015-05-22 00:42:26 +03:00
Rafael Mendonça França
dc537669f2 Merge pull request #20250 from davydovanton/doc-mem-cache-store 
Update documentation for MemCacheStore::build_mem_cache [ci skip]
 2015-05-21 17:30:13 -03:00
Anton Davydov
b485eb33fa [skip ci] Update documentation for MemCacheStore::build_mem_cache 2015-05-21 23:24:12 +03:00
Xavier Noria
d345ce9630 revises a test to account for case-insensitive file systems 
The patched test assumed the file system is case-sensitive, but that is not
necessarily the case. In particular, this test did not pass in the recommended
setup for the dev box, because the /vagrant shared folder is case-insensitive.

After looking at some gems that provide access to file system metadata I have
chosen to go with the check you can see in the patch because, albeit it's a bit
dirty creating a file, it is super easy to understand and clearly portable.

References https://github.com/rails/rails-dev-box/issues/102.
 2015-05-21 21:45:51 +02:00
Abdelkader Boudih
448bf47fe7 Merge pull request #20247 from davydovanton/doc-array-inquirer 
Update documentation for ArrayInquirer#any?
 2015-05-21 19:31:54 +01:00
Anton Davydov
8d1a292047 [skip ci] Update documentation for ArrayInquirer#any? 2015-05-21 21:28:17 +03:00
Kasper Timm Hansen
39037b70ef Merge pull request #20244 from y-yagi/remove_div_for_from_guide 
remove reference to `div_for` method from guide [ci skip]
 2015-05-21 13:04:37 +02:00
yuuji.yaginuma
88787e780b remove reference to div_for method from guide [ci skip] 
`div_for` removed in 01e94ef
 2015-05-21 19:35:52 +09:00
Yves Senn
b052a46268 Merge pull request #20235 from davydovanton/doc-update-date 
[skip ci] Update documentation for Date class
 2015-05-21 08:55:09 +02:00
Anton Davydov
30f8318047 [skip ci] Update documentation for Date class 2015-05-21 02:03:41 +03:00
Arthur Nogueira Neves
f271f43f10 Merge pull request #20022 from repinel/remove-mocha1 
Remove use of mocha in the railties path tests
 2015-05-20 23:13:18 +02:00
Arthur Nogueira Neves
c36423984d Merge pull request #17788 from sivagollapalli/master 
Issue#17703 Test case for tempfile attribute
 2015-05-20 22:41:19 +02:00
Rafael Mendonça França
6577d049ef Merge pull request #20230 from ronakjangir47/american_style 
Rails documentation standard is american english. [ci skip]
 2015-05-20 14:12:08 -03:00
Ronak Jangir
0d615c3ff9 Rails documentation standard is american english. [ci skip] 2015-05-20 22:42:09 +05:30
Rafael Mendonça França
85fb209e52 Merge pull request #20228 from karanarora/Spelling-fix 
Rails documentation standard is american english. [ci skip]
 2015-05-20 12:30:17 -03:00
karanarora
bb4ef33b0a Rails documentation standard is american english. [ci skip] 2015-05-20 20:39:41 +05:30
Rafael Mendonça França
66780af027 Merge pull request #20225 from manish-shrivastava/master 
updated Inline format at activerecord rdoc
 2015-05-20 11:07:22 -03:00
Manish shrivastava
6252d0aece updated Inline format at activerecord rdoc 
For Inline formats, changed ` (single backticks)   to <tt> tag at active record rdoc as single backticks (`) don't work with rdoc. for inline format.
 2015-05-20 19:15:33 +05:30
Arun Agrawal
879f316995 Fix broken link for minitest. [ci skip] 
For more details see #20222
 2015-05-20 14:55:58 +02:00
Yves Senn
21474f143a Merge pull request #20222 from Gaurav2728/gaurav-update_ruby_links 
[ci skip] updated ruby doc links; for rails next version of ruby will be 2.2x
 2015-05-20 14:25:21 +02:00
Gaurav Sharma
3e238b6b0f [ci skip] update ruby doc links; for rails next version ruby 2.2+ will be supported only 2015-05-20 17:41:17 +05:30
Kasper Timm Hansen
5d5447b0cb Merge pull request #20221 from Gaurav2728/gaurav-debugging_rails_guide_update 
Rails 5.0 will target Ruby 2.2+, correct rails guide example [ci skip]
 2015-05-20 14:08:57 +02:00
Gaurav Sharma
a9aefffea6 Rails 5.0 will target Ruby 2.2+, correct rails guide example [ci skip] 2015-05-20 17:18:24 +05:30
Santiago Pastorino
0f9ab4f348 Merge pull request #20219 from karanarora/Typo-fix 
typo fix [ci skip]
 2015-05-20 07:48:26 -03:00
karanarora
ec8b7a543e typo fix [ci skip] 2015-05-20 15:21:00 +05:30
Yves Senn
1ceeadad3b add missing punctuation in changelog. [ci skip] 2015-05-20 11:26:09 +02:00
Arun Agrawal
e00d63e2c6 Merge pull request #20217 from amitsuroliya/fix_netaddr_link 
Fix NetAddr link [ci skip]
 2015-05-20 10:34:05 +02:00
Arun Agrawal
edb0eaab9f Merge pull request #20218 from ronakjangir47/postgresql 
Updated postgresql documentation link to use latest version [ci skip]
 2015-05-20 10:32:43 +02:00
amitkumarsuroliya
ac20dd73ac Fix NetAddr link [ci skip] 2015-05-20 14:01:00 +05:30
Ronak Jangir
76fbfe9e6c Updated postgresql documentation link to use latest version [ci skip] 2015-05-20 14:00:31 +05:30
Richard Schneeman
07f1a503ac Merge pull request #20215 from repinel/validates_acceptance_doc 
[ci skip] add to doc that acceptance validator allows `nil` by default
 2015-05-19 22:27:54 -05:00
Carlos Antonio da Silva
df93b4d113 Fix docs markup for option_groups_from_collection_for_select [ci skip] 2015-05-19 23:27:56 -03:00
Roque Pinel
8f09a8396f [ci skip] add to doc that acceptance validator allows nil by default 2015-05-19 22:20:10 -04:00