TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
4,063 Commits 2 Branches 0 Tags 294 MiB
2b0d668efc
Commit Graph

4063 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
David Heinemeier Hansson
2b0d668efc Dont run FCGIDispatcher tests if mocha is not available 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5118 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-15 09:34:14 +00:00
Jeremy Kemper
760f6ae3f4 Stray code. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5117 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-15 07:11:38 +00:00
Jeremy Kemper
3f1acf49bd Deprecation tests. Remove warnings for dynamic finders and for the foo_count ethod if it's also an attribute. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5116 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-15 07:02:05 +00:00
Jeremy Kemper
d0c000ab9e assert_deprecated returns result of block 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5115 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-15 05:54:18 +00:00
Jeremy Kemper
069b0eaf0b assert_deprecated matches any warning caught in block 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5114 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-15 03:56:25 +00:00
Jeremy Kemper
643571ca25 alias_method_chain yields method target and punctuation to simplify wrapper method definition. Used by the deprecate module method. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5113 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-15 03:42:54 +00:00
Jeremy Kemper
3d3ba58dbb remove implicit primary actions - more pain than gain. test collection actions for other http methods. strip whitespace. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5111 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-14 19:53:04 +00:00
Rick Olson
6dbac689a8 Add chained replace/update support for assert_select_rjs [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5110 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-14 17:50:46 +00:00
Jeremy Kemper
3ab1cb6a6a Mock Time.now for more accurate Touch mixin tests. Closes #6213. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5106 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-14 00:50:42 +00:00
Jeremy Kemper
d54406271b session_migration generator adds an index on updated_at. Closes #6207. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5105 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-13 23:35:55 +00:00
Jeremy Kemper
5589c734a8 Improve yaml fixtures error reporting. Closes #6205. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5104 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-13 23:31:54 +00:00
Jeremy Kemper
9aeddc5538 script/server creates the tmp/pids directory. Closes #6204. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5103 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-13 23:25:02 +00:00
David Heinemeier Hansson
6b70c799f8 All verbs should use formatted urls [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5097 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-13 04:14:18 +00:00
David Heinemeier Hansson
73a8d7393f Make sure that formatted routes for all verbs are created. Still needs to resolve two failing tests after this refactoring [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5096 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-13 04:04:19 +00:00
Jeremy Kemper
89840c40ce Load helpers in alphabetical order for consistency. Resolve cyclic javascript_helper dependency. Closes #6132, closes #6178. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5095 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-12 22:07:18 +00:00
Jeremy Kemper
7661c2b50a Skip params with empty names, such as the &=Save query string from <input type=submit/>. Closes #2569. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5094 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-12 20:57:09 +00:00
Jeremy Kemper
74f60c032e alias_method_chain works with accessor= methods also. Closes #6153. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5091 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-12 07:10:43 +00:00
Jeremy Kemper
3c0e7b1b51 Fix script/console --sandbox for internal transactions changes. Closes #5738. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5088 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-12 01:17:11 +00:00
David Heinemeier Hansson
b0a32f85c2 test svn 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5087 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-12 01:09:52 +00:00
Jamis Buck
3f0952d9df Fix assert_tag so that :content => "foo" does not match substrings, but only exact strings. Use :content => /foo/ to match substrings. closes #2799 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5086 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-10 02:51:38 +00:00
Jamis Buck
5bf41ed8bc Add test case to test attribute matching by assert_tag 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5082 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-09 22:05:21 +00:00
Jamis Buck
45b5555f4c Make mime version default to 1.0. closes #2323 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5081 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-09 21:56:38 +00:00
Jamis Buck
4d9ca4d9fb Make sure quoted-printable text is decoded correctly when only portions of the text are encoded. closes #3154. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5080 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-09 21:14:43 +00:00
Jamis Buck
3e7aa0391f Make sure DOS newlines in quoted-printable text are normalized to unix newlines before unquoting. closes $166 and #4452 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5079 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-09 20:16:42 +00:00
Jeremy Kemper
0a84624bd7 Optimistic locking: raise ActiveResource::ResourceConflict on 409 Conflict response. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5078 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-09 00:11:12 +00:00
David Heinemeier Hansson
2c6747f858 Split Form.serialize into Form.serialize and Form.serializeElements. The latter can be used stand-alone to serialize an array of elements you pass in, instead of the entire form [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5077 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-08 22:12:40 +00:00
David Heinemeier Hansson
e2d8451024 We cant make MySQL 5 happy if it means making SQLite and PostgreSQL cry. So currently MySQL 5 is not fully supported for Rails when youre using eager loading (closes #6133, #6135). I have contacted MySQL to make them fix http://bugs.mysql.com/bug.php?id=13551 [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5075 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-08 22:01:00 +00:00
David Heinemeier Hansson
d7e4f5f22e Since to_sing, we need to check for empty string 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5074 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-08 19:23:33 +00:00
David Heinemeier Hansson
84bfdafa08 Added parentheses around FROM clauses generated by Base and associations since MySQL 5 claim that to be the standard (and will screw up joins if its not there), see http://bugs.mysql.com/bug.php?id=13551 [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5073 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-08 18:14:02 +00:00
Jeremy Kemper
f1b639cffb Update descriptive messages for exceptions thrown by cgi_methods. Closes #6103. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5070 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-08 07:25:14 +00:00
Rick Olson
8d9e6609f8 Basic validation support [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5068 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-08 00:07:30 +00:00
Jeremy Kemper
7c4b6a55b6 Rollback [4917]. Closes #785. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5067 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-07 21:34:35 +00:00
Nicholas Seckar
9d9ac01c7d Add descriptive messages to the exceptions thrown by cgi_methods. Closes #6091. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5066 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-07 20:10:14 +00:00
Nicholas Seckar
840b5763ff Too much dotware 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5065 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-07 16:55:59 +00:00
Nicholas Seckar
e3c2151f7f Remove the uncanny default of adding all app/models/*/ directories to the load path. References #6031. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5064 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-07 16:53:58 +00:00
Thomas Fuchs
a5df861852 Fix loop_on_multiple_args to work, again (not my day), fixes #6078 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5063 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-07 14:16:58 +00:00
Thomas Fuchs
cb6309bcc9 Ahem, now for real 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5062 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-07 12:57:39 +00:00
Thomas Fuchs
984312cf85 Fix a warning in prototype_helper_test, fixes #6077 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5061 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-07 12:56:48 +00:00
Thomas Fuchs
8734da9bca Update JavaScriptGenerator#show/hide/toggle/remove to new Prototype syntax for multiple ids, fixes #6068 [petermichaux@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5057 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-07 09:19:35 +00:00
Nicholas Seckar
00685ad8fd Update UrlWriter to support :only_path. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5054 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-06 22:21:36 +00:00
Nicholas Seckar
93659978d5 Fix loadable_constants_for_path to handle load paths that do not end with a slash. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5053 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-06 20:31:28 +00:00
David Heinemeier Hansson
5a5f85d5be Get symbol definitions of methods converted to strings [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5045 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-06 04:00:37 +00:00
Rick Olson
5360e47431 added passing test for using partials with an xml builder 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5044 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-06 03:51:45 +00:00
David Heinemeier Hansson
83313fccc0 Backed out of locals hash as it caused trouble with Builder, see ticket for more 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5043 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-06 03:38:11 +00:00
David Heinemeier Hansson
8c9ce617c9 Fixed JavaScriptHelper#link_to_function and JavaScriptHelper#button_to_function to have the script argument be optional [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5039 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-06 01:31:04 +00:00
Nicholas Seckar
7441b19d0c Fix logic error in determining what was loaded by a given file. Closes #6039. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5035 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-05 23:36:14 +00:00
David Heinemeier Hansson
951b4d2799 Still need the regular assertions 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5028 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-05 23:04:14 +00:00
Nicholas Seckar
1d554b84f8 Equate Kernel.const_missing with Object.const_missing. Fixes #5988. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5023 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-05 22:36:28 +00:00
David Heinemeier Hansson
bd09d9aafb caller is necessary for proper trace in deprecation 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5021 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-05 22:08:33 +00:00
David Heinemeier Hansson
9598176390 Better bundling of new assertions and make integration tests work again 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5020 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-05 21:28:22 +00:00