TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
56,149 Commits 2 Branches 0 Tags 294 MiB
2f8ba24ec6
Commit Graph

56149 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Rafael França
2f8ba24ec6 Merge pull request #23359 from kamipo/make_to_primary_key 
Make to primary key instead of an unique index for internal tables
 2016-02-01 01:53:57 -02:00
Matthew Draper
55e33667a6 Remove development dependencies from actioncable.gemspec 
None of the other components use them, so we should be consistent.
 2016-02-01 13:22:47 +10:30
Rafael França
f9c57f1b4b Merge pull request #23373 from kamipo/remove_duplicated_composite_primary_key_tests 
Remove duplicated composite primary key tests
 2016-02-01 00:40:13 -02:00
Rafael França
cea81220dd Merge pull request #23389 from kamipo/extract_explain_pretty_printer 
Extract `ExplainPrettyPrinter` to appropriate files
 2016-02-01 00:28:14 -02:00
Rafael Mendonça França
c2079f86f8 Revert "Merge pull request #23366 from maclover7/add-configuation-ar-docs" 
This reverts commit 96355e87cba247246234386b0af9273cc5d59db9, reversing
changes made to a00c36feea6c0271b5ad48a949ef294514fdef52.

See https://github.com/rails/rails/pull/23366#issuecomment-177714429
 2016-02-01 00:23:43 -02:00
Ryuta Kamizono
f3eccd942a Remove duplicated composite primary key tests 2016-02-01 11:20:30 +09:00
Ryuta Kamizono
351e39c27a Extract ExplainPrettyPrinter to appropriate files 2016-02-01 11:14:50 +09:00
Rafael França
43dff0a7b1 Merge pull request #23372 from kamipo/use_index_in_create_in_test_schema 
Use `t.index` in `create_table` instead of `add_index` in test schema
 2016-02-01 00:01:50 -02:00
Rafael França
c9daa2690a Merge pull request #23374 from prathamesh-sonpatki/migration-compatiblity-tests 
Added test for backward compatibility of null constraints on timestamp columns
 2016-01-31 23:59:29 -02:00
Akira Matsuda
87e2f7e336 🙊 ⚠️ 2016-02-01 10:35:19 +09:00
Rafael França
75fcb52e57 Merge pull request #23360 from kamipo/oid_money_precision_is_unused 
`OID::Money.precision` is unused since #15239
 2016-01-31 23:34:46 -02:00
Rafael França
dedc68753c Merge pull request #23388 from prathamesh-sonpatki/update-gemfile-lock 
Update Gemfile.lock
 2016-01-31 22:54:23 -02:00
Prathamesh Sonpatki
ad9ed7e36c Update Gemfile.lock 
- Leftover from 93abf58787.
 2016-02-01 06:18:04 +05:30
Arthur Nogueira Neves
b98ca654b8 Merge pull request #23380 from yui-knk/override_calculate_constructables_at_each_concrete_class 
Remove `case macro` from `calculate_constructable`
 2016-01-31 18:32:14 -05:00
yui-knk
615dcadba0 Remove case macro from calculate_constructable 
Rails has abstract Reflection classes (`MacroReflection`,
`AssociationReflection` etc.) and concrete Reflection classes
(e.g. `HasManyReflection`, `HasOneReflection` etc.).
In many case `calculate_constructable` returns `true`, so
change `calculate_constructable` to always return `true` and
override this method if necessary.
 2016-02-01 08:02:33 +09:00
Kasper Timm Hansen
5c9cccaf25 Merge pull request #23387 from mcfiredrill/clarify-touching-callbacks 
clarify the touch true option does not trigger after_save/update [ci skip]
 2016-01-31 23:13:24 +01:00
Guillermo Iguaran
d6e0eeb1c6 Merge pull request #23370 from maclover7/actioncable-main-travis-build 
Move Action Cable back to the main build
 2016-01-31 16:56:03 -05:00
Tony Miller
8d25a8aa8c clarify the touch true option does not trigger after_save/update [ci skip] 
I've gotten tripped up more than a few times on this, thinking that
using `belongs_to` with `touch: true` would trigger my after_save or
after_update callbacks. The same text is in the documentation for the
touch method itself, but I think its helpful to repeat it again here.
It might save people some time.
 2016-02-01 06:29:00 +09:00
Jon Moss
ddd84f6193 Remove unused method 2016-01-31 16:14:26 -05:00
Vipul A M
acddd032d0 Merge pull request #22857 from bdewater/interlock-doc 
Update middleware docs regarding ActionDispatch::LoadInterlock [ci skip]
 2016-02-01 01:56:43 +05:30
Bart de Water
6cdc36a026 Update middleware docs regarding ActionDispatch::LoadInterlock [ci skip] 2016-01-31 21:18:37 +01:00
Kasper Timm Hansen
81052c8cd9 Merge pull request #23169 from y-yagi/rake_proxy_in_engine 
make rake proxy work in rails engines
 2016-01-31 20:53:50 +01:00
Kasper Timm Hansen
662889cf36 Merge pull request #23379 from yui-knk/define_association_class_on_each_concrete_class 
Each concrete classes have responsibility to return `association_class`
 2016-01-31 20:51:49 +01:00
Matthew Draper
93abf58787 Drop the runtime dependency on coffee-rails 2016-02-01 05:14:02 +10:30
Matthew Draper
d6f2000a67 Wrangle the asset build into something that sounds more general 2016-02-01 05:03:03 +10:30
Matthew Draper
ca9603fc35 Merge pull request #23369 from maclover7/actioncable-assets-redux 
Action Cable Assets Compilation redux
 2016-02-01 05:02:48 +10:30
Santiago Pastorino
b7a6dc91bc Merge pull request #23368 from y-yagi/remove_backward_compatibility_code_for_minitest_4 
remove backward compatibility code for Minitest 4
 2016-01-31 15:23:02 -03:00
Matthew Draper
4c38319cc2 Wait for EventMachine to finish starting 2016-02-01 03:01:32 +10:30
yui-knk
7e4b2abeee Each concrete classes have responsibility to return association_class 2016-01-31 22:51:36 +09:00
Prathamesh Sonpatki
6e2302ee59 Added test for backward compatibility of null constraints on timestamp columns 2016-01-31 15:02:46 +05:30
Vipul A M
8dfb876048 Merge pull request #23371 from kamipo/remove_odd_backtick 
Remove odd ` [ci skip]
 2016-01-31 14:09:36 +05:30
Ryuta Kamizono
8e083e1502 Use t.index in create_table instead of add_index in test schema 
For reduce bootstrap queries in tests.
 2016-01-31 17:36:04 +09:00
Ryuta Kamizono
7d67c318f6 Remove odd ` [ci skip] 2016-01-31 16:43:52 +09:00
Jon Moss
9d426d3fe3 Move Action Cable back to the main build 2016-01-30 21:04:00 -05:00
Jon Moss
cb040aa0e5 Add Action Cable asset building as release step 2016-01-30 20:51:18 -05:00
Jon Moss
09a7060659 Improvements and reorganization of assets 2016-01-30 20:44:42 -05:00
Javan Makhmali
896950a605 Add task to create precompiled action_cable.js and reorganize to accommodate 2016-01-30 20:41:54 -05:00
yuuji.yaginuma
3ffa5a15cc make rake proxy work in rails engines 2016-01-31 09:49:48 +09:00
Jon Moss
96355e87cb Merge pull request #23366 from maclover7/add-configuation-ar-docs 
Add configuration section to "Active Record Basics" guide
 2016-01-30 19:47:22 -05:00
Jon Moss
3ded07e7c8 Add configuration section to "Active Record Basics" guide 
This is to fill in some missing information as apart of #22931.

It's on purpose that the sample `Message` model inherits from
`ActiveRecord::Base` -- Active Record is not meant to be coupled to
Rails, and we can't guarantee that users outside of the Rails world will
have an `ApplicationRecord` class that inherits from
`ActiveRecord::Base`.

[ci skip]
 2016-01-30 19:46:00 -05:00
Jon Moss
a00c36feea Merge pull request #23364 from maclover7/fix-23358 
Small cleanup to Testing Guide
 2016-01-30 15:11:36 -05:00
Jon Moss
d2bd7bba8e Small cleanup to Testing Guide 
- inbuilt --> built-in
- Remove random spaces from code examples

[ci skip]
 2016-01-30 15:10:25 -05:00
Vipul A M
153438f749 Merge pull request #23358 from vipulnsward/testing-guide-pass-3 
Pass 3 over testing guide
 2016-01-31 01:30:09 +05:30
Vipul A M
c01948cc57 Pass 3 over testing guide 
- Various grammar fixes
- Added assertions for update controller action tests
- Added user helper tests
- Fix typos

[ci skip]
 2016-01-31 01:28:50 +05:30
Vipul A M
b212bef139 Merge pull request #23363 from pra85/patch-1 
typo fix [ci skip]
 2016-01-31 01:00:59 +05:30
Prayag Verma
4663cab624 typo fix [ci skip] 
Spelling mistake - direcotry > directory
 2016-01-31 00:59:14 +05:30
Jon Moss
2e465e138b Merge pull request #23362 from vipulnsward/20821-save-doc-update 
- Updated persistence documentation to make it clear that save and sa…
 2016-01-30 14:20:17 -05:00
Vipul A M
6c54f6c746 - Updated persistence documentation to make it clear that save and save! won't update a record if validation fails. 
- Also fixed `update` method's documention to be uniform about this statement.
Fixes #20821

[ci skip]

[Vipul A M & pseidemann ]
 2016-01-31 00:36:23 +05:30
Ryuta Kamizono
bee8bb5801 OID::Money.precision is unused since #15239 
p PostgreSQLAdapter::OID::Money.precision
    # => 19

    p PostgreSQLAdapter::OID::Money.new.precision
    # => nil
 2016-01-31 03:59:30 +09:00
Ryuta Kamizono
ff16a39922 Make to primary key instead of an unique index for internal tables 2016-01-31 03:26:57 +09:00