TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
56,215 Commits 2 Branches 0 Tags 294 MiB
33681d0001
Commit Graph

3905 Commits

Author SHA1 Message Date
Sean Griffin
118232aef4 Merge pull request #19686 from tsun1215/index_errors 
Errors can be indexed with nested attributes

Close #8638
 2015-10-26 16:05:16 -06:00
AnnaErshova
6eada87b61 Edits default config/boot.rb to match what's generated by Rails 4.2. 2015-10-26 15:22:30 -04:00
Markov Alexey
6f9d7f346b Fix punctuation [ci skip] 2015-10-23 23:20:00 +03:00
Xavier Noria
b9d1e101b4 API guidelines reword re the Oxford comma [ci skip] 2015-10-22 20:56:50 +02:00
Xavier Noria
23eb2e1a99 Revert "[ci skip] removed extra comma" 
Reason: That one is an Oxford comma, as per our guidelines. See:

     http://edgeguides.rubyonrails.org/api_documentation_guidelines.html#comma

This reverts commit f184cd34f9ef35ddf85a23c2fb02cc05d3fb26b3.
 2015-10-22 20:48:54 +02:00
hemali jain
f184cd34f9 [ci skip] removed extra comma 2015-10-23 01:49:46 +08:00
Sean Griffin
cd46bfc54f Fix minor typo from #20038 
We use one period after spaces, not two.
 2015-10-20 16:41:26 -06:00
Sean Griffin
7e434d6d2d Merge pull request #20038 from imanel/numeric_prepend 
Use Module.prepend instead of alias_method and unify behavior of all Numeric extensions
 2015-10-20 16:37:39 -06:00
Sean Griffin
59dee0f04b Update #20768 to address feedback 2015-10-20 15:56:21 -06:00
Vladimir Rybas
23f57413d0 [Rails Guides] Clarify belongs_to_required_by_default option 
Original:
    * `config.active_record.belongs_to_required_by_default` is a boolean
      value and controls whether `belongs_to` association is required by
      default.

Modified version:
    * `config.active_record.belongs_to_required_by_default` is a boolean
      value and controls whether validation error is triggered by
      default if `belongs_to` association is not present or not valid.
 2015-10-20 15:55:49 -06:00
Sean Griffin
cceaa5c853 Merge pull request #20795 from benjiwheeler/validation_guide_ret_val 
activerecord guide: clarified roles of valid method and errors object [ci skip]
 2015-10-20 15:50:25 -06:00
yui-knk
666e2cc654 [ci skip] Replace "destroy method" with destroy action 
Sure this is `destroy` method of PhotosController, but in this chapter
these methods which mapped by the router are called "action".
For example:

```ruby
get '/patients/:id', to: 'patients#show'
```

is described to dispatch "controller's `show` action".
 2015-10-20 20:24:07 +09:00
Simon H
407c87011d added Rails 4 context for migrations:install task 2015-10-19 17:33:02 -06:00
Benny Klotz
476b14a32d Updated existing custom configuration for rails 5 where config.x 
namespace is not needed anymore.

Added custom configuration through config_for which parses a yml file in
config folder.
 2015-10-19 13:11:31 +02:00
Tim Wade
3c0ae9da87
[ci skip] Improve readability in active model basics guide 
* adds/removes a few words
* removes an unnecessary comma
 2015-10-18 07:35:54 -07:00
schneems
101821410b [ci skip] Add backend queue starting documentation 
If you can't start your queue, you won't process much. This change adds external links to the Queue backends that have Active Job specific docs.
 2015-10-16 18:24:58 -05:00
Anna Ershova
5cde56e173 Update active_record_migrations.md 
Add 'db/'; corrects structure.rb to structure.sql
 2015-10-15 16:37:11 -04:00
AnnaErshova
0166adcee8 Clarifies db can be set up from structure.sql also 
I added that *structure.sql* file can be used when *db:reset* is run.

*db:reset* tasks states *db:reset* loads database from *db/schema.rb*
or *db/structure.sql* depending on the configuration (although
*db/schema.rb* is the default), hence the change.
 2015-10-15 09:36:57 -04:00
Christian Wesselhoeft
0d34b550a4 Fix formatting of ActiveRecord PostgreSQL guide. 2015-10-13 14:50:19 -06:00
Eric Turner
dfedaf3795 [ci skip] Fix typo in deep_dup docs 2015-10-12 14:05:53 +09:00
amitkumarsuroliya
aa37991e43 Improved KeyError messages on bang version, since commit e768c519fb bang version produces KeyError [ci skip] 2015-10-11 02:40:29 +05:30
Claudio B.
bd65ba7721 Merge pull request #21906 from scottgonzalez/form-helpers 
Minor cleanup for form helpers guide
 2015-10-08 07:25:41 -07:00
Scott González
8be6b47d1f Minor cleanup for form helpers guide [ci skip] 2015-10-08 08:48:56 -04:00
Andy Lampert
705847578e Improve readability in CSRF section of guide 2015-10-07 22:11:34 -06:00
Rafael Mendonça França
172c25e7b6 Revert "Update asset_pipeline.md" 
This reverts commit afe672185d5eba95f387c46f855ae7a21ea69fa5.

Reason: This change was done by mistake. This option is at the `config`
object not in the `config.assets`.

See
cfb371e96a/railties/lib/rails/application/configuration.rb (L16)
 2015-10-07 15:46:04 -03:00
amitkumarsuroliya
37b3684233 Replace an UNIQUE with a UNIQUE as UNIQUE doesn't have a vowel sound [ci skip] 
`A UNIQUE` we pronounce URL as 'yu-ni-k’. We use this everywhere. So, be consistent with it.
 2015-10-07 23:05:01 +05:30
Miguel Parramon
6de2813919 Fix "Esperanto" name 
Correct spelling is "Esperanto": 

https://en.wikipedia.org/wiki/Esperanto
 2015-10-07 17:54:50 +02:00
Ronak Jangir
495722a956 Fixed wording in Assertion docs, changed ‘Assert’ -> ‘Asserts’ 2015-10-07 21:07:46 +05:30
Richard Schneeman
ffdbfb2704 Merge pull request #21899 from scottgonzalez/layouts-and-rendering-typo 
Fix typo in docs
 2015-10-07 10:08:38 -05:00
Scott González
0070fc7686 Fix pluralization in docs [ci skip] 2015-10-07 10:30:44 -04:00
Scott González
ab62af7c93 Fix typo in docs [ci skip] 2015-10-07 10:27:46 -04:00
tanmay3011
148d1217a1 [ci skip] Change 'an URL' to 'a URL' as URL doesn't have a vowel sound 2015-10-06 23:34:05 +05:30
kentendo
afe672185d Update asset_pipeline.md 2015-10-05 17:29:49 -07:00
Eileen M. Uchitelle
db448209bd Merge pull request #21796 from dv/docs-change-to-parse-nested-query 
Change "parse_query" to "parse_nested_query"
 2015-10-05 12:56:41 -04:00
David Verhasselt
b4f4de0500 Remove TIP on parse_query 
[ci skip]
 2015-10-05 19:55:00 +03:00
Sean Griffin
dcdf231b38 Merge pull request #20981 from dkoprov/ar_postgres_enum_docs_addition 
Add more info on working with postgres ENUM type
 2015-10-04 18:58:04 -06:00
Claudio B.
5dfc7a9006 Merge pull request #21857 from cllns/fix-myspace-example-wording 
Update text on CSS Injection
 2015-10-04 10:14:09 -07:00
Vijay Dev
7976b6d306 Merge branch 'master' of github.com:rails/docrails 2015-10-04 12:33:14 +00:00
Aaron Patterson
24f9c03d52 Revert "removing Rack::Runtime from the default stack." 
This reverts commit 37423e4ff883ad5584bab983aceb4b2b759a1fd8.

Jeremy is right that we shouldn't remove this.  The fact is that many
engines are depending on this middleware to be in the default stack.
This ties our hands and forces us to keep the middleware in the stack so
that engines will work.  To be extremely clear, I think this is another
smell of "the rack stack" that we have in place.  When manipulating
middleware, we should have meaningful names for places in the req / res
lifecycle **not** have engines depend on a particular constant be in a
particular place in the stack.  This is a weakness of the API that we
have to figure out a way to address before removing the constant.

As far as timing attacks are concerned, we can reduce the granularity
such that it isn't useful information for hackers, but is still useful
for developers.
 2015-10-03 14:21:31 -07:00
Sean Collins
19b626a31a Update text on CSS Injection / Myspace 
[skip ci]
 2015-10-03 12:42:33 -06:00
amitkumarsuroliya
208a33e387 Fixed deprecated string to specify the middleware [ci skip] 2015-10-03 18:19:32 +05:30
Kasper Timm Hansen
1b00c36d85 Merge pull request #21851 from y-yagi/use_class_to_specify_middleware 
use class to specify the middleware [ci skip]
 2015-10-03 12:57:09 +02:00
yuuji.yaginuma
70b09eda03 use class to specify the middleware [ci skip] 
using string for middleware class names is deprecated in 83b767cef90abfc4c2ee9f4b451b0215501fae9a
 2015-10-03 19:26:24 +09:00
Aaron Patterson
37423e4ff8 removing Rack::Runtime from the default stack. 
The runtime header is a potential target for timing attacks since it
returns the amount of time spent on the server (eliminating network
speed).  Total time is also not accurate for streaming responses.

The middleware can be added back via:

```ruby
config.middleware.ues ::Rack::Runtime
```
 2015-10-02 14:45:31 -07:00
Roque Pinel
e2b3ccd1aa Refactor AS::Callbacks halt config and fix the documentation 
Move from `AS::Callbacks::CallbackChain.halt_and_display_warning_on_return_false`
to `AS::Callbacks.halt_and_display_warning_on_return_false` base on
[this
discussion](https://github.com/rails/rails/pull/21218#discussion_r39354580)

Fix the documentation broken by 0a120a818d413c64ff9867125f0b03788fc306f8
 2015-10-01 13:04:20 -04:00
Niall Burkley
391043ab04 Fix documentation for has_many dependant options. 
* A `has_many` dependant association accepts `[:destroy, :delete_all, :nullify,
:restrict_with_error, :restrict_with_exception]` as options.
Currently the documentation references `delete` instead of `delete_all`
* Adds documentation for other options
 2015-09-29 17:34:27 +02:00
David Verhasselt
c0d3209b2e Make fuzzy sentence more clear 
[ci skip]
 2015-09-28 15:16:03 +03:00
Eileen M. Uchitelle
3c52b2000c Merge pull request #21738 from cllns/remove-to_s-from-example 
[Engines Guide] Remove to_s example, since it's outside the scope
 2015-09-25 12:24:51 -04:00
yui-knk
82f69a7a33 [ci skip] Add : before code blocks. 2015-09-25 13:14:14 +09:00
Sean Collins
30769669e3 Remove to_s example 
It's outside the scope of the Engines guide

[skip ci]
 2015-09-24 10:15:52 -06:00
Yves Senn
8516d76c62 Merge pull request #21740 from cllns/add-jbuilder-notes 
[ci skip]

[Action View Overview Guide] Add note about Jbuilder
 2015-09-24 08:38:17 +02:00
Juanito Fatas
cb45950c27 Add a missing period to layouts_and_rendering.md [ci skip] 2015-09-24 14:28:56 +08:00
Sean Collins
961779997c Add note about Jbuilder 
[skip ci]
 2015-09-23 13:57:52 -06:00
Sean Collins
11f00fd3e3 Change the paths for both Gemfile lines to be 'engines/blorgh' 
They're now consistent.

Also changes the quotes to be single, so we only have one type of quote per line

[skip ci]
 2015-09-23 12:29:17 -06:00
Sean Collins
1b9e2bc5aa Remove leading slash from path 
The leading slash denotes an absolute path,
rather than a relative one (which is more popular)

[ci skip]
 2015-09-22 22:05:06 -06:00
Thiago Augusto
c4c70322c4 Update i18n.md [ci skip] 2015-09-22 13:22:53 -03:00
Thiago Augusto
89c53ece47 Update routing.md 2015-09-22 10:17:43 -03:00
amitkumarsuroliya
a2f78cb947 fix to_time output in ActiveSupport guide. Since 48583f8bf7 , to_time returns times formatted as YYYY-MM-DD HH:MM:SS UTC [ci skip] 
`to_time` method returns in `YYYY-MM-DD HH:MM:SS UTC` format after this commit 48583f8bf7 .
 2015-09-20 18:01:26 +05:30
amitkumarsuroliya
c7000d93e7 correcting word smpt -> smtp in ActionMailer guide [ci skip] 
`smpt.gmail.com` should be `smtp.gmail.com`
 2015-09-20 16:32:03 +05:30
yuuji.yaginuma
ac29778b09 remove association reload option from guide [ci skip] 
The option was deprecated in 6eae366d0d2e5d5211eeaf955f56bd1dc6836758
 2015-09-20 11:35:10 +09:00
amitkumarsuroliya
ccbf1597b7 Replace #=> with # => [ci skip] 
@rafaelfranca suggested in f7c7bcd9c2 that code examples should display
the result after  `# =>` and not after `#=>`.
 2015-09-19 13:45:13 +05:30
Ronak Jangir
9b016cff1a Fixed unclosed tags in kindle guide source [ci skip] 2015-09-19 12:15:34 +05:30
Aaron Patterson
38d2bf5fd1 mostly remove the ParamsParser middleware 
This can still be added to the middleware stack, but is really not
necessary.  I'll follow up with a commit that deprecates the constant
 2015-09-18 15:36:55 -07:00
Xavier Noria
2a9cf79957 let the guides home point to the new release series endpoints [ci skip] 2015-09-18 12:27:31 -07:00
Vijay Dev
e80b39c390 Merge branch 'master' of github.com:rails/docrails 2015-09-18 12:30:41 +00:00
Bradley D
119f38f795 Change AbstractRequest to ActionDispatch::Request 
AbstractRequest has been deprecated, updating to refer to ActionDispatch::Request instead.

[ci skip]
 2015-09-17 16:43:51 -06:00
Jeremy Daer
4d77e02d34 Clarify CSRF <script> purpose and protection. Note how to deal with your own <script> tags. 
Ref #21618

[ci skip]
 2015-09-16 08:56:16 -07:00
Claudio B.
7a93952287 Merge pull request #21644 from AvnerCohen/i18n_backend 
Update documentation to remove 'desirable' suggestion for what is not a clear cut approach
 2015-09-16 05:55:22 -07:00
Eileen M. Uchitelle
3edc7f7a1c Merge pull request #21618 from designgrill/master 
Improved explanation of the <script> tag CSRF behavior
 2015-09-16 07:56:32 -04:00
Avner Cohen
aecfc9360f Update documentation to remove 'desirable' suggestion for what is not a clear cut approach 2015-09-16 11:58:43 +03:00
Arthur Nogueira Neves
29886d9304 Merge pull request #20897 from lukechesser/guide-fix-for-acceptance-validation 
Update Validation guide for acceptance method
 2015-09-14 21:18:19 -04:00
Anshul Agrawal
570cd24816 Improved explanation of the <script> tag CSRF behavior 2015-09-14 11:35:16 +05:30
Rafael Mendonça França
65f189da2d Merge pull request #21568 from amitsuroliya/mysql_version_update 
Updated MySQL documentation link to MySQL latest version 5.7 everywhe…
 2015-09-13 03:46:25 -03:00
Lachlan Campbell
0ab07181c9 Remove RHTML reference in Action Controller docs [ci skip] 2015-09-10 20:25:48 -04:00
yuuji.yaginuma
8b7950e25e add description of passing a block to add_source [ci skip] 
block support added in 8cc01e0b2bfa75a613720c535d34e451f5de769c
 2015-09-10 21:12:11 +09:00
amitkumarsuroliya
08c0ef777f Updated MySQL documentation link to MySQL latest version 5.7 everywhere [ci skip] 
Bumps from `5.6` to `5.7`
 2015-09-10 07:38:18 +05:30
Eileen M. Uchitelle
b455cadbfd Merge pull request #21333 from imtayadeway/ar-querying-docs 
Improve the AR querying docs
 2015-09-09 11:19:23 -04:00
Tim Wade
736ee9e104
[ci skip] Update MySQL docs reference to latest 
Bumps to 5.7
 2015-09-09 08:15:38 -07:00
Tim Wade
a0d7db760d
[ci skip] Improve readability in AR querying guide 
* rewords a few awkwardly worded sentences
* adds some punctuation
* adds a few missing words
 2015-09-09 08:15:23 -07:00
Yves Senn
8d1af2b10c Merge pull request #21512 from X0nic/guides-clarify-timeout-error 
[Rails Guides] clarify `ActiveRecord::ConnectionTimeoutError`
 2015-09-08 17:28:59 +02:00
arvind
dad0c2677c Replace AR with ActiveRecord to make it more readable [ci skip] 2015-09-08 16:02:16 +05:30
Rafael Mendonça França
8167d18c71 Merge pull request #21534 from Vratislav/clarify-custom-config-guide 
[Rails Guides] Clarify custom code configuration [ci skip]
 2015-09-07 17:52:29 -03:00
Ronak Jangir
953a83e918 Removed Extra ‘the’ [ci skip] 2015-09-06 14:20:06 +05:30
Nathan Lee
7dc490b709 [Rails Guides] clarify ActiveRecord::ConnectionTimeoutError 
Original:
    * ActiveRecord::ConnectionTimeoutError - could not obtain a database
      connection within 5 seconds. The max pool size is currently 5;
      consider increasing it:

Modified version:
    * ActiveRecord::ConnectionTimeoutError - could not obtain a database
      connection within 5.000 seconds (waited 5.000 seconds)

[ci skip]
 2015-09-05 22:23:37 -06:00
Juanito Fatas
c7cc81d211 Add missing and remove unnecessary periods in testing.md [ci skip] 2015-09-05 21:08:32 +08:00
yuuji.yaginuma
40c96f7be5 fix module name typo in API app guide [ci skip] 2015-09-04 14:38:54 +09:00
yuuji.yaginuma
75d96ac831 add a description of the return value that was missing [ci skip] 2015-09-03 07:32:27 +09:00
Ignatius Reza
7a11b10e3d [ci skip] fix invalid package name for libmysqlclient-dev 
tested on Ubuntu Desktop 15.04
 2015-09-02 18:30:03 +09:00
kishore-mohan
cf82b2e034 typo "description not clear corrected with proper description and action_controller_overview file Rails' -> Rails" [ci skip] 2015-09-02 09:19:47 +05:30
amitkumarsuroliya
a274c78c26 typo fix [ci skip] 
sub-project's should be sub-projects' at all places
 2015-09-01 18:27:23 +05:30
Rafael Mendonça França
57393957e1 Merge pull request #17351 from akshat-sharma/master 
Add case_sensitive option for confirmation validation
 2015-09-01 02:42:43 -03:00
Akshat Sharma
2438a1cf4e Add case_sensitive option for confirmation validation 
Case :- 1. In case of email confirmation one needs case insensitive comparison
        2. In case of password confirmation one needs case sensitive comparison

[ci skip] Update Guides for case_sensitive option in confirmation validation
 2015-09-01 10:42:51 +05:30
Sean Griffin
13c6903451 Merge pull request #21432 from yui-knk/fix/what_change_method_can_reverse 
[ci skip] Update what methods `Migration#change` can reverse
 2015-08-30 19:20:22 -06:00
yui-knk
df9cfc055a [ci skip] Update what methods Migration#change can reverse 
* Documentations and comments about what methods
  `Migration#change` can reverse is out of date.
  For example `change_column_default` is now reversible
  by this [commit](https://github.com/rails/rails/pull/20018).

* Comments about `CommandRecorder` dose not match with Rails Guide.
  For example `add_foreign_key` is listed only on Rails Guide.
 2015-08-31 10:08:38 +09:00
yuuji.yaginuma
341151da5b fix typo in method name [ci skip] 2015-08-30 22:16:27 +09:00
Shivani
ac1c888b95 [ci skip] Better description for starting up with new Rails project 
These changes rephrases the description with better explanation of step by step process.
 2015-08-28 15:31:59 +02:00
Konstantinos Rousis
7ddf72d008 fix reference to undefined variable in email testing guide [ci skip] 2015-08-28 09:39:06 +02:00
Claudio B.
65684d76fd Merge pull request #21409 from piton4eg/patch-9 
Fix Configuring Active Record  [ci skip]
 2015-08-27 19:11:51 -07:00
yuuji.yaginuma
c98fd25120 remove link to outdated article in plugins guide [ci skip] 
linked article is a description of the plugins in Rails 2.1.
 2015-08-28 09:18:08 +09:00
Alexey Markov
0c85705f38 Fix Configuring Active Record [ci skip] 2015-08-27 23:16:44 +03:00
Aaron Patterson
d47438745e remove RackDelegation module 
Since all controller instances are required to have a request and
response object, RackDelegation is no longer needed (we always have to
delegate to the response)
 2015-08-26 11:53:15 -07:00
Robin Dupret
f59de082bf Fix a tiny typo [ci skip] 2015-08-25 16:13:34 +02:00
Robin Dupret
f150decfe2 A quick pass over the testing guide 
* Fixtures are loaded for all the tests by default (not only model and
  controller tests).
* Fix a few typos and improve the markup at some levels.
* Wrap changes to 80 chars

[ci skip]
 2015-08-25 16:13:34 +02:00
Robin Dupret
be19bf3728 Merge pull request #21354 from yui-knk/fix/migration_file_timestamp 
[ci skip] Fix migration file's timestamp
 2015-08-24 19:04:50 +02:00
yui-knk
454e0c1c8d [ci skip] Fix migration file's timestamp 
In rails generally migration file's timestamp is "YYYYMMDDHHMMSS".
 2015-08-24 21:21:44 +09:00
Yves Senn
5500e28eb3 Merge pull request #21091 from y-yagi/add_activejob_section_to_instrumentation_guide 
add Active Job section to instrumentation guide [ci skip]
 2015-08-24 13:33:45 +02:00
Yves Senn
a256a5790a Merge pull request #21320 from piton4eg/patch-8 
Small fixes [ci skip]
 2015-08-24 11:56:16 +02:00
Yves Senn
5abff7cff7 guides, move incomplete example to corresponding option. #21349 
[ci skip]

This example is dependent on the `:end_at` option and has been removed
from `4-2-stable` (d167b811520a6f800b86c77b805d15505a251bb8)
 2015-08-24 11:47:59 +02:00
Vijay Dev
4f252cddc1 Merge branch 'master' of github.com:rails/rails 
Conflicts:
	guides/source/security.md
 2015-08-24 06:05:07 +00:00
Vijay Dev
bc36ffeec0 Revert "[ci skip] Fix to a, b or c format" 
This reverts commit 9876a16904f817e11713bc85479dd70da1de454b.

Reason: Oxford commas are preferred. This is now documented in
the documentation guidelines.
 2015-08-24 04:32:24 +00:00
Vijay Dev
5bcb454ba4 add commas removed earlier [ci skip] 2015-08-24 04:32:09 +00:00
yui-knk
58e02ac839 [ci skip] Fix the grammar 
This is discussed on https://github.com/rails/rails/pull/21334
 2015-08-24 13:19:48 +09:00
Alexey Markov
0fb2600bbb Fix docs for debugging [ci skip]: 
* fix command list for thread
* add omitted end of code
* fix description for `continue` and `finish` command
 2015-08-24 08:13:26 +04:00
shunsukeaida
10c73386ae Remove a link to the site that seems to be gone. [ci skip] 
Followup to #20637.
 2015-08-23 23:39:04 +09:00
yuuji.yaginuma
6e46ba397e fix syntax error in strip_links example [ci skip] 
can not use double quotes in double quoted string without escape
 2015-08-23 21:07:05 +09:00
Richard Schneeman
55320fa9eb Merge pull request #21334 from yui-knk/doc/about_comma_style 
[ci skip] Add style guide about comma
 2015-08-22 21:07:33 -05:00
yui-knk
fedfc3bc12 [ci skip] Add style guide about comma 2015-08-23 09:53:31 +09:00
Santiago Pastorino
4115a12da1 Merge pull request #20757 from bquorning/http-status-codes-changed-in-rack 
Rack changed their status codes to IETF RFC 7231
 2015-08-22 16:35:13 -03:00
Jon Atack
94a0c1c584 [skip ci] Debugging Rails Guide fixes 
- Fixes:

"we want go deep" -> "we won't go deep"

"to next next line" -> "to the next line"

- Minor improvements in clarity and grammar.

Cheers :)
 2015-08-22 10:55:59 +02:00
Alexey Markov
0b18876e15 Add bold to lists' titles [ci skip] 2015-08-21 10:19:38 +03:00
Benjamin Quorning
3ec3ac6192 4.2 release notes about render status options 2015-08-21 09:04:51 +02:00
Benjamin Quorning
4bcab1cdb8 Rack changed their status codes to IETF RFC 7231 
rack/rack#754
 2015-08-21 09:04:50 +02:00
Alexey Markov
81cec09aac Small fixes [ci skip] 2015-08-20 21:36:58 +03:00
maclover7
8e35ab8610 Add code of conduct to README.md and to contributing guide [ci skip] 2015-08-18 19:53:31 -04:00
Alexey Markov
76c2f01fcb Small fixes [ci skip] 2015-08-17 23:09:31 +03:00
Kasper Timm Hansen
65d3bf9153 Merge pull request #21270 from jonatack/update-debugging-guide-byebug-info 
Update the Debugging Rails Guide [skip ci]
 2015-08-17 22:01:24 +02:00
Jon Atack
60a3122171 Update the Debugging Rails Guide 
[skip ci].

- Update to the current output when running `byebug help`.

- Remove the alias `exit` because it does not work and seems to have
been removed from Byebug, as confirmed by the source code here:
https://github.com/deivid-rodriguez/byebug/blob/master/lib/byebug/comman
ds/quit.rb

- Added the useful `q!` instead to avoid the "Really quit? (y/n)"
prompt.
 2015-08-17 20:23:26 +02:00
Zachary Scott
7985908bea reorganize testing guide. [Zachary Scott & Yves Senn] 
[ci skip]

Better reading flow for the information presented in this guide.
The first part is written in a similar fashion as the "Getting Started
Guide" and can be read from start to finish. The second section
introduces the different testing components that Rails provides and
explains how and when to use them.

The guide is still work in progress.
 2015-08-17 16:23:59 +02:00
Sean Griffin
249a06d3be Merge pull request #21135 from DropsOfSerenity/master 
make disable_with default in submit_tag
 2015-08-17 06:49:00 -06:00
Robin Dupret
b803798b9d Tiny documentation fixes [ci skip] 
* Add missing `def` and remove useless `do` keywords.
* Move `:nodoc:` in front of the methods' definition so that methods
  under these ones are correctly visible on the API.
 2015-08-16 14:16:20 +02:00
Alexey Markov
b00c436101 Small fixes [ci skip] 2015-08-15 00:19:47 +03:00
Brooks Reese
8e94137a12 [ci skip] SQL is written using statements, not sentences 2015-08-13 12:43:49 -05:00
Robin Dupret
9d70ec3551 Merge pull request #21120 from dhiachou/patch-1 
How to pass arguments to ActiveJob Jobs [ci skip]
 2015-08-13 16:58:24 +02:00
Dhia Eddine Chouchane
8b2f418972 [ci skip] How to pass arguments to ActiveJob Jobs 
A section explaining how to pass arguments to Jobs has been added.

[ci skip] How to pass arguments to ActiveJob Jobs

Removed the "how to pass arguments" from what you will know section

[ci skip] improving Enqueue Job section

Using GuestsCleanupJob rather than MyJob for coherence.

[ci skip] Passing args section merged with enqueuing jobs

Passing args is now explained through examples withing Enqueuing the Jobs section

[ci skip] Unnecessary example removed

[ci skip] Typo fixed (missing as)
 2015-08-13 15:06:39 +01:00
Andreas Lietz
03615fc283 [ci skip] Clarified asset pipeline guide 2015-08-13 11:25:48 +02:00
Rafael Mendonça França
fd27305782 Merge pull request #21211 from brooksreese/resrc_io_website_closed 
[ci skip] Removed link to reSRC.io - site closed
 2015-08-12 12:39:19 -03:00
Brooks Reese
61004e292b [ci skip] Removed link to reSRC.io - site closed 2015-08-12 10:30:07 -05:00
Matthew Draper
aea7e93ba4 Merge pull request #21204 from brooksreese/ruby_v_before_tip 
[ci skip] Swap ruby -v and the installation tip
 2015-08-12 14:20:47 +09:30
Brooks Reese
5d11fc4866 [ci skip] Swap ruby -v and the installation tip 2015-08-11 21:02:09 -05:00
Justin Schiff
3822a322a8 Make disable_with default in submit_tag 
Prevents double submission by making disable_with the default.

Default disable_with option will only be applied if user has not
specified her/his own disable_with option, whether that is in the
`data-disable-with` string form or the
`:data => { :disable_with => "Saving..." }` hash form. disable_with
will default to the value attribute.

A configuration option was added to opt out of this functionality if
the user so desires.
`config.action_view.automatically_disable_submit_tag = false`
 2015-08-11 16:35:10 -07:00
Yves Senn
df5ada78c0 Merge pull request #21195 from brooksreese/fix_broken_link_markup 
[ci skip] Fix broken link markup
 2015-08-11 17:34:59 +02:00
Brooks Reese
f5c3f41bae [ci skip] Fix broken link markup 2015-08-11 10:03:50 -05:00
Robin Dupret
f51d142881 Tiny documentation fixes [ci skip] 2015-08-11 15:35:35 +02:00
Rafael Mendonça França
99ae9b1698 Merge pull request #21138 from dhiachou/patch-2 
Outdated information about session storage updated [ci skip]
 2015-08-11 09:00:49 -03:00
Brooks Reese
ab360318cf [ci skip] Add link to testing guide 2015-08-10 12:34:14 -05:00
Brooks Reese
c939bb7e8a [ci skip] Modify introduction text and bullets to be consistent with other guides 2015-08-10 09:49:28 -05:00
Yves Senn
8d70f40da5 docs, use hash instead of a string for order. [ci skip] 
Closes #21121
 2015-08-10 09:18:56 +02:00
Claudio B.
644c4efdc9 Merge pull request #21177 from brooksreese/single_crud_operation 
[ci skip] Note that each action maps to a specific CRUD operation
 2015-08-09 11:12:03 -07:00
Brooks Reese
0082ffeff1 [ci skip] Note that each action maps to a specific CRUD operation 2015-08-09 11:16:20 -05:00
Claudio B.
175d8acf43 Merge pull request #21166 from brooksreese/migration_seed_explanation 
[ci skip] Give in-depth explanation of migrations vs. seeds.rb
 2015-08-08 13:18:17 -07:00
Brooks Reese
4445e79157 [ci skip] Give in-depth explanation of migrations vs. seeds.rb 2015-08-08 14:37:21 -05:00
melissawahnish
1896be9741 [ci skip] Adding a note to Action Mailer Basics documentation that Google increased its 
security measures so using the example for Gmail will return a “Password Incorrect” error,
and you will receive an email from Google that they blocked a sign-in attempt.  You can change
your Gmail settings or use another ESP.

I discovered this when I was testing a simple mailer example app and was just going to
use my personal Gmail account for the test.  I think it would be best to note this change
since now Gmail may not be the best option for a quick test.  I hope this saves time for other Rails
developers.  The Gmail example does show a good example of how to configure the smpt settings.
 2015-08-08 14:02:33 -04:00
yuuji.yaginuma
c0747e2f39 use uuid method to define the UUID type [ci skip] 2015-08-08 18:37:22 +09:00
yui-knk
235155302e [ci skip] Add an explanation for status option 2015-08-08 12:27:55 +09:00
Aaron Patterson
81cfdf2489 stop using @_env in the controller instance 
Actions are processed through `dispatch`, so they should have the
request set on them before any user land code can be executed.  Lets
stop setting _env on the controller, and give access to it through the
`env` method.
 2015-08-07 16:00:57 -07:00
Zachary Scott
f7ebdb1ac5 Remove XML Serialization from core. 
This includes the following classes:

- ActiveModel::Serializers::Xml
- ActiveRecord::Serialization::XmlSerializer
 2015-08-07 11:01:48 -04:00
Tom Copeland
7a3566ea3f Fix doc typo 2015-08-07 10:12:56 -04:00
yui-knk
222e9c5f83 [ci skip] Remove identity.active_record 
This is removed by this commit
cf: https://github.com/rails/rails/pull/5261
 2015-08-07 13:47:49 +09:00
Mehmet Emin İNAÇ
c7375fd162 Added bin/update script to update application automatically 
use system!

fix changelog

use bundle check first and use rake

use system instead system! for bundle check
 2015-08-07 04:01:34 +03:00
Alexey Markov
35aa47d524 Small fix 2015-08-06 22:35:05 +03:00
Andreas Lietz
0b92d80cec Corrected instructions for using Sass 2015-08-06 12:18:18 +02:00
Dhia Eddine Chouchane
a42ca131a5 [ci skip] Typo fixed 2015-08-06 09:21:03 +01:00
Dhia Eddine Chouchane
87f0e6719f Outdated information about session storage updated [ci skip] 
The guide contains information about Rails 2 storing mechanism, but not Rails 4. 
Enhanced the accuracy and coherence of information (There was a part saying "Older versions of Rails use CookieStore, which uses `secret_token` instead of `secret_key_base` that is used by EncryptedCookieStore." while there was no mention of EncryptedCookieStore before)
 2015-08-06 09:08:11 +01:00
Kasper Timm Hansen
7a3ca69959 Merge pull request #20800 from xijo/make_active_job_locale_aware 
Make ActiveJob locale aware
 2015-08-04 11:56:57 +02:00
Claudio B.
98ce161668 Merge pull request #21076 from r11runner/guide-join-tables 
migration and association guides: added some remarks about join tables
 2015-08-03 21:17:04 -07:00
Johannes Opper
3860e6b2bf Fixes #20799 
When `#perform_later` is called the locale isn't stored on the
queue, which results in a locale reset when the job is performed.

An example of the problem:

    I18n.locale = 'de'
    HelloJob.perform_now # german message, correct

but

    I18n.locale = 'de'
    HelloJob.perform_later # english message, incorrect

This PR attaches the current I18n.locale to every job during the
serialization process. It is then restored during deserialization
and used to perform the job with the correct locale.

It falls back to the default locale if no serialized locale is
found in order to provide backward compatibility with previously
stored jobs. It is not necessary to clear the queue for the update.
 2015-08-04 00:38:18 +02:00
r11runner
d73a524b6e [ci skip] migration and association guides: added some remarks about join tables 2015-08-04 00:09:38 +02:00
Robin Dupret
63c03077f3 Correctly close a fenced code block [ci skip] 2015-08-03 13:22:42 +02:00
Andrew White
aa79574d09 Add note to routing guide about overriding defaults [ci skip] 
Fixes #21085.
 2015-08-03 11:50:12 +01:00
Kasper Timm Hansen
3a5c3f5304 Merge pull request #21052 from robin850/caching-guide 
Publish the "Caching with Rails" guide
 2015-08-03 12:30:16 +02:00
claudiob
39e0d811b7 Improve the "Caching with Rails" guide's introduction [ci skip] 2015-08-03 12:08:36 +02:00
Robin Dupret
f6e48148be Add a section about "Collection caching" [ci skip] 2015-08-03 12:08:33 +02:00
yuuji.yaginuma
ac65bff337 correct example of button_tag [ci skip] 
wrapper div has been removed in cbb917455f306cf5818644b162f22be09f77d4b2
 2015-08-02 19:11:23 +09:00
yuuji.yaginuma
79b74d2d38 add Active Job section to instrumentation guide [ci skip] 2015-08-02 08:47:21 +09:00
yui-knk
2ea95a522a [ci skip] 
Add descriptions about `ActiveRecord::Base#to_param` to

* `ActionDispatch::Routing::Base#match`
* Overriding Named Route Parameters (guide)

When passes `:param` to route definision, always `to_param` method of
related model is overridden to constructe an URL by passing these
model instance to named_helper.
 2015-08-01 23:08:53 +09:00
Anton Chuchkalov
dc4b03fe9a Remove yepnope mention from form helpers guide because it's deprecated [ci skip] 2015-07-30 14:48:55 +02:00
yui-knk
9876a16904 [ci skip] Fix to a, b or c format 2015-07-30 13:52:22 +09:00
yui-knk
978cca8b13 [ci skip] field_error_proc is used in ActionView::Helpers::ActiveModelInstanceTag 
so replace `Active Record` with `Active Model`
 2015-07-29 22:04:48 +09:00
Celestino Gomes
da4a37f63c Publish the "Caching with Rails" guide [ci skip] 2015-07-28 23:20:23 +02:00
Robin Dupret
c21cc877e0 Add a "Managing dependencies" part to the caching guide [ci skip] 2015-07-28 23:20:17 +02:00
Robin Dupret
a934b571e5 Tiny edits to the "Caching with Rails" guide 
* Fix a few typos
* Remove reference to the old `memcache-client` gem
* Remove the "ActiveSupport::Cache::EhCacheStore" part from the guide as
  the gem doesn't seem to be maintained anymore.
* Move the "Custom Cache Stores" part under the "AS::Cache::Store" part
  as they are pretty related.

[ci skip]
 2015-07-28 15:06:04 +02:00
Robin Dupret
e18bf1dc49 Tiny documentation edits [ci skip] 2015-07-28 15:05:41 +02:00
yui-knk
2962da6bb9 [ci skip] Add a link to action_controller_overview.html 2015-07-28 20:52:07 +09:00
yui-knk
818427caf1 [ci skip] Now Action View is completely separated from Action Pack 2015-07-28 20:23:15 +09:00
Ryan Bigg
b95cca958a Ryan Bigg has changed jobs. 2015-07-27 15:17:01 +10:00
yui-knk
33a72824b8 [ci skip] Fix to a, b and c format 2015-07-25 10:21:32 +09:00
yui-knk
f9015ada7e [ci skip] Fix minor typo 
* Remove `,`
* Fix `&lt`; -> `&lt;`
 2015-07-24 23:07:16 +09:00
yui-knk
1b6131d385 [ci skip] Fix before_filter -> before_action 2015-07-24 22:48:21 +09:00
yui-knk
0868b4cec9 [ci skip] Minor fix 
* add a space
* add a `.`
 2015-07-24 22:15:08 +09:00
Dmitry Koprov
2ffae197c3 adds more info on working with postgres ENUM type 2015-07-23 16:02:27 +03:00
Dave Powers
0e2cc9bc0d Fix minor typo in testing guide 
[ci skip]
 2015-07-20 13:08:08 -04:00
Sean Griffin
2a0a264b39 Merge pull request #20763 from maurogeorge/default_scope_create-doc 
Add a note about default_scope and create records [ci skip]
 2015-07-18 09:04:54 -04:00
Claudio B.
e5bfe7149a Merge pull request #20909 from yui-knk/fix/test-commnad 
[ci skip] Add `bundle exec` to test run command
 2015-07-17 03:08:46 -07:00
yui-knk
2312ea5bb4 [ci skip] Add bundle exec to test run command 2015-07-17 12:14:27 +09:00
Mauro George
2ef1de02ed Add a note about default_scope and create records 
[ci skip]
 2015-07-16 18:24:39 -03:00
Tim Wade
dffd91c320
[skip ci] Improve grammar/style in DB pooling guide. 2015-07-16 14:06:12 -07:00
Luke Chesser
29acc869db Update validation guide for acceptance method 2015-07-16 00:53:42 -04:00
Aditya Kapoor
a413111c18 [ci skip] add note for individual stub creation 2015-07-15 18:07:22 +05:30
Robin Dupret
48609420b8 Merge pull request #20736 from antoine-lizee/docs 
[ci skip] docs: making clear that perform_caching has a limited impact
 2015-07-13 22:41:45 +02:00
antoine.lizee
89a55edd59 [ci skip] doc: making clear that perform_caching has a limited impact 2015-07-13 11:35:18 -07:00
Anton Chuchkalov
0d7185d138 fix typo in caching guide [ci skip] 2015-07-12 16:11:52 +03:00
Vijay Dev
14354f1955 Merge branch 'master' of github.com:rails/docrails 2015-07-11 17:45:02 +00:00
Tony Miller
4edaa88583 the key is that the behavior is incorrect [ci skip] 2015-07-11 10:58:25 +09:00
Tony Miller
5c3db80fee saying that "behaviour" "behaves" is kind of awkward, how about "works" 2015-07-10 23:58:39 +09:00
Tony Miller
f0e922fe4c [ci skip] change sentence about reporting bugs in contributing guide 
I think I know what this sentence is trying to say, but the sentence
didn't really make sense, bugs don't fix things! How about this take on
it? 😅
 2015-07-10 23:32:28 +09:00
Robin Dupret
4c9f47141b Merge pull request #20765 from maurogeorge/activejob-exception 
Add Deserialization section on guides at ActiveJob Exception [ci skip]
 2015-07-09 14:00:26 +02:00
Mauro George
5e2273f42c Add Deserialization section on guides at ActiveJob Exception 
[ci skip]
 2015-07-08 18:22:32 -03:00
Ben Wheeler
f0ebfda59e activerecord guide: clarified roles of valid method and errors object [ci skip] 2015-07-08 11:18:16 -04:00
yui-knk
8f4ed7f900 [ci skip] Add bundle exec to Running a Single Test 2015-07-08 13:07:15 +09:00
Yves Senn
4cc5917dce docs, clarify the meanaing of return values from validation methods. 
[ci skip]

Closes #20792.

Custom validation methods are implemented in terms of
callbacks. The `validate` callback chain can't be halted using return
values of individual callbacks.
 2015-07-07 14:39:58 +02:00
Robin Dupret
472984b4d9 Merge pull request #20779 from maurogeorge/secrets-guides 
Add to Security guides the secrets.yml [ci skip]
 2015-07-06 14:35:20 +02:00
Mauro George
35373fd54b Add to Security guides the secrets.yml 
[ci skip]
 2015-07-06 09:21:15 -03:00
yuuji.yaginuma
bba409e143 remove reference to country_options_for_select and country_select from guide [ci skip] 
these methods were removed in 2d27b82d4cf446543539ad20afcbad256d8aeff7
 2015-07-05 10:58:55 +09:00
Vijay Dev
f09678b7b1 Merge pull request #20764 from maurogeorge/mailer_image 
Create Adding images in Action Mailer Views on guides
 2015-07-04 23:18:22 +05:30
Mauro George
9cc438f559 Create Adding images in Action Mailer Views on guides 
[ci skip]
 2015-07-03 07:38:56 -03:00
Thomas Osborn
b3bfbbf10e changes names in guides to better reflect diversity [ci-skip] 2015-07-02 16:21:28 -07:00
Rafael Mendonça França
6c3fcc58ff Merge pull request #20741 from radar/integration_tool_doc 
Improve integration_tool documentation
 2015-06-30 05:26:51 -03:00
Ryan Bigg
be0b218c42 integration_tool defaults to :test_unit 
As per railties/lib/rails/test_unit/railtie.rb, where it sets it explicitly.

This can be confirmed by starting a new Rails console session in a new app and running this code:

Rails.application.config.app_generators.rails[:integration_tool]

I also beefed up the documentation slightly to be more explicit about what this configuration setting does.
 2015-06-30 18:23:07 +10:00
Rafael Mendonça França
1a433020bb Merge pull request #20734 from srikanthps/master 
To fix #20644
 2015-06-29 21:22:08 -03:00
Jordon Dornbos
f5d6aaa31b fix pluralization in doc [ci skip] 2015-06-29 16:54:57 -07:00
Mehmet Emin İNAÇ
33fac9917d Minor addition to getting started guide for foreign_key description of references migration [ci skip] 2015-06-29 22:58:45 +03:00
Srikanth Shreenivas
1b1afc62f8 To fix #20644 
Added a note on development kit for Windows Users.  This is required as Windows users can get frustrated when their first rails project creation would fail as some native gem won't get built.
 2015-06-30 00:25:47 +05:30
yui-knk
d9212f6408 [ci skip] Fix action_controller_overview 2015-06-28 22:32:42 +09:00
Xavier Noria
fd495a8d18 updates a migration example in the Getting Started guide [ci skip] 
Closes #20705.
 2015-06-28 12:12:28 +02:00
Rohan Daxini
88973f8d36 Maintaining consistency in wordings [ci skip] 
"reproduce" word is better suited then "replicate" as its also used at other places in this same document having same context. It will then be consistent across document.
 2015-06-27 22:35:43 +05:30
Zachary Scott
e67386a8c4 Merge pull request #20652 from ankit1910/change_doc 
Change documentation for collection.build and collection.create [ci-skip]
 2015-06-27 10:29:53 -04:00
Rafael Mendonça França
859c8c3f67 Merge pull request #20018 from sikachu/change-column-default-recorder 
Add reversible syntax for change_column_default
 2015-06-27 01:45:22 -03:00
Dmitry Pak
e7de3e4ac6 Change routes.rb look in getting started [ci skip] 2015-06-27 02:16:02 +03:00
Prem Sichanugrist
f9c841927a Update guide for new change_column_default syntax 2015-06-26 16:25:13 -04:00
Guillermo Iguaran
8cc01e0b2b Merge pull request #20697 from 5t111111/add-block-to-add_source 
add_source in Application Template should take a block for gem entries
 2015-06-25 16:56:13 -05:00
Hirofumi Wakasugi
e6be33f1dd cherry-pick test and source doc from #20050 2015-06-25 15:25:49 +09:00
yuuji.yaginuma
4e0c39f662 remove nonexistent hook from instrumentation guide [ci skip] 2015-06-25 13:09:05 +09:00
Rafael Mendonça França
1022796ac0 Merge pull request #20674 from yui-knk/fix/guide2 
[ci skip] Make clear what `this method` is
 2015-06-23 12:55:30 -03:00
yui-knk
7a74d81916 [ci skip] Make clear what this method is 
In this sentence, there are three candidates of `this method`

* default_url_options
* url_for
* helper method(s)

so make it clear.
 2015-06-24 00:27:53 +09:00
yui-knk
0ad43eb70d [ci skip] Fix hash key to symbol 2015-06-24 00:26:32 +09:00
Robin Dupret
707144a31e Remove the paragraph about Rails::Server#middleware 
As of 56903585, the Rack::ContentLength middleware isn't included by
default anymore.

The only remaining middleware is Rack::Lock ; since it's only included
when using WEBrick, it's certainly not worth documenting it in the
guides.

[ci skip]
 2015-06-23 17:06:47 +02:00
Andrey Nering
35bbeabbb6 Minor fixes [ci skip] 2015-06-22 13:56:26 -03:00
Vijay Dev
f6797a7683 Merge branch 'master' of github.com:rails/docrails 
Conflicts:
	guides/source/configuring.md
 2015-06-21 18:37:55 +00:00
ankit1910
8f6e0b71b0 Change documentation for collection.build and collection.create [ci-skip] 2015-06-21 22:32:52 +05:30
Gaurish Sharma
29a64f2384 Remove broken links 
[ci skip]
 2015-06-21 10:31:33 +05:30
Yves Senn
40bdf0dd4c Merge pull request #20117 from jfine/action-mailer-smtp-settings-update 
Add openssl_verify_mode and sync other smtp_settings with API docs [ci skip]
 2015-06-19 12:04:58 +02:00
yuuji.yaginuma
79da980448 correct example output of references migration [ci skip] 
this behavior was changed in 99a6f9e60ea55924b44f894a16f8de0162cf2702
 2015-06-19 08:16:36 +09:00
Robin Dupret
068ab23a33 Tiny documentation fixes [ci skip] 2015-06-18 11:38:08 +02:00
Robin Dupret
3f767aa9cf Merge pull request #20054 from trosborn/master 
updates caching guide to reflect current Rails capabilities [ci skip]
 2015-06-18 11:23:13 +02:00
yuuji.yaginuma
576a83c6f1 remove Rails::Rack::Debugger from guides [ci skip] 
Rails::Rack::Debugger was removed in 93559da4826546d07014f8cfa399b64b4a143127
 2015-06-18 09:16:11 +09:00
Thomas Osborn
9c1cfcbccc updates caching guide to reflect current Rails capabilities [ci skip] 2015-06-17 16:40:44 -07:00
Xavier Noria
7789dfe779 i18n guide: warn about default_url_options caching and locale selectors [ci skip] 2015-06-15 21:41:08 +02:00
Xavier Noria
c865b8298f document that default_url_options is cached per request [ci skip] 2015-06-15 21:41:08 +02:00
Robin Dupret
7e30085bd0 A pass over the API application guide [ci skip] 
* Fix a few remaining typos
* Wrap lines to 80 chars
* Fix the conversion from Textile to Markdown
* Update the part about `Rack::Cache` which isn't included anymore and
  speak about Active Support's provided middleware
* Remove references to out-of-date methods and middlewares (e.g.
  respond_with) and update the list of modules and middlewares to match
  the actual code-base.
* Remove the middleware's description and links to the Rack guide
 2015-06-15 11:41:52 +02:00
Yves Senn
9ad36601f1 pg guide, explain the state of using UUID primary keys. Closes #20518. 
[ci skip]

The PostgreSQL 9.4 docs suggest to use `pgcrypto`.
Howerver `create_table id: :uuid` will still default to `uuid_generate_v4()`
 2015-06-15 11:34:41 +02:00