Piotr Sarnacki
36fcb776dd
Fix warning by removing |map| from routes.draw
2010-09-08 19:28:00 +02:00
Piotr Sarnacki
6258f7c972
Change app to main_app in mounted_helpers
2010-09-08 19:27:59 +02:00
Piotr Sarnacki
18aee33335
Do not require passing :app to mounted helpers, it's actually useless and not DRY
2010-09-08 19:27:59 +02:00
Aaron Patterson
a5d894ce56
attributes should be constructed with table objects
2010-09-07 16:47:10 -07:00
Aaron Patterson
0c7a4daaa1
attributes should be associated with tables
2010-09-07 16:38:49 -07:00
Aaron Patterson
c6015cbcd8
serialized attributes should be serialized before validation [ #5525 state:resolved]
2010-09-07 13:39:27 -07:00
Aaron Patterson
c8a2dd3cac
no need to freeze this string
2010-09-07 13:13:13 -07:00
Jakub Suder
2524cf404c
fixed some issues with JSON encoding
...
- as_json in ActiveModel should return a hash
and handle :only/:except/:methods options
- Array and Hash should call as_json on their elements
- json methods should not modify options argument
[#5374 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2010-09-07 11:33:10 -07:00
Aaron Patterson
2e8a3d0f43
removing useless code, cleaning variable names
2010-09-07 11:28:01 -07:00
Aaron Patterson
604281221c
select should raise error when no block or no parameter is passed
2010-09-07 10:48:14 -07:00
Aaron Patterson
d00f1c18eb
select does not need a *args
2010-09-07 10:33:20 -07:00
ISHIKAWA Takayuki
816ea74c8e
revision of typo: crytographically [ #5566 state:resolved]
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-09-07 11:03:37 -03:00
Santiago Pastorino
e8c7f1af0f
unscoped has nothing so merging with a relation just returns the relation
2010-09-07 03:33:06 -03:00
Aaron Patterson
b541a963bd
cleaning up confusing logic
2010-09-06 18:56:16 -07:00
Piotr Sarnacki
32157a2dd2
Add documentation on serving assets from engine strategies
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-06 17:09:31 +02:00
Piotr Sarnacki
7c78cc3cca
Use railties:copy_migrations instead of db:copy_migrations
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-06 14:38:45 +02:00
Piotr Sarnacki
ec6fa6d3ef
Modified changelog for 3.1.0
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-06 14:38:41 +02:00
Piotr Sarnacki
24d2d6726e
Added task for creating symlinks to engines' public directories
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-06 14:38:36 +02:00
Carlos Antonio da Silva
c915ddd386
Start cleanup of deprecations in ActionView
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-06 13:42:46 +02:00
Carlos Antonio da Silva
022fd876bb
Cleanup Action Dispatch assertions tests
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-06 13:42:11 +02:00
Carlos Antonio da Silva
9532d746a9
Cleanup deprecations in Action Dispatch
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-06 13:41:12 +02:00
Carlos Antonio da Silva
11fccc5f06
Cleanup deprecation warnings in Action Controller
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-06 13:40:45 +02:00
Carlos Antonio da Silva
ed2650646e
Refactor AR validations a bit
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-06 13:40:06 +02:00
Carlos Antonio da Silva
9b610049bb
Cleanup deprecation warnings in active record
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-06 13:39:55 +02:00
Carlos Antonio da Silva
a18b73b43c
Remove all deprecation warnings in activeresource
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-06 13:38:38 +02:00
Carlos Antonio da Silva
7204bb0feb
Remove deprecation warnings in railties
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-06 13:38:12 +02:00
Pratik Naik
3bd3e992ff
Improved indentation
2010-09-06 11:54:02 +01:00
Santiago Pastorino
0a7b481903
Use scoped here to get the scoped where
2010-09-05 20:30:43 -03:00
Carlos Antonio da Silva
c91605b15b
Refactor a bit dependencies logging
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-05 18:14:47 +02:00
Carlos Antonio da Silva
9a776c2978
Improve dependencies by not calling constantize(const) twice while removing unloadable constants
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-05 18:14:47 +02:00
Carlos Antonio da Silva
69a4c67a3f
Fix docs related to param_key in ActiveModel::Naming
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-05 18:14:37 +02:00
José Valim
8a3461b8c1
Remove a few tests from old router that do not make sense with the new one.
2010-09-05 15:59:35 +02:00
José Valim
9757bfff9b
Merge remote branch 'drogus/remove_deprecated_routes'
...
This merge removes the deprecated routes mapper from Rails and update its tests.
2010-09-05 15:45:12 +02:00
Santiago Pastorino
e20012b64b
Make number_to_human and number_with_precision work with negatives
2010-09-05 10:21:55 -03:00
Santiago Pastorino
d717ff9e52
Fix indentation errors
2010-09-05 10:07:37 -03:00
Santiago Pastorino
88dfe16d95
Fix code style a bit
2010-09-05 10:06:09 -03:00
Ben Sharpe
b80cf265be
Fix number_to_human(0) exception [ #5532 state:resolved]
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-09-05 09:56:13 -03:00
Piotr Sarnacki
e909afccc9
Deleted test with extended regexp - it fails with no reason, probably rack-mount is doing something weird with that regexp
2010-09-05 13:44:39 +02:00
Łukasz Strzałkowski
5b550523b7
Fixed 2 broken tests for router.
...
They were broken after rebase/merge
2010-09-05 13:44:39 +02:00
Łukasz Strzałkowski
8f2c0bf1a0
This test is invalid for new router
2010-09-05 13:44:39 +02:00
Łukasz Strzałkowski
faba03850a
Removed deprecated_mapper - we don't need it anymore
2010-09-05 13:44:39 +02:00
Łukasz Strzałkowski
eac8b9cf05
Removed tests for setting default value of *path in route
...
If we want to have this - we have to change Rack::Mount source
2010-09-05 13:44:38 +02:00
Łukasz Strzałkowski
b478ff9150
Made test_generate pass
...
I've removed assertions with @routes.generate(:use_route => ...). I'm not 100% sure if not supporting :use_route in new router is intentional or it should rather be supported and backported from 2.3.x.
2010-09-05 13:44:38 +02:00
Łukasz Strzałkowski
af72cf4799
If it's unused there's no reason to keep it commented. It will always remain in git history, so removing it.
2010-09-05 13:44:38 +02:00
Piotr Sarnacki
b7bfeaa9fc
Fix action mailer tests after old mapper removal
2010-09-05 13:44:38 +02:00
Piotr Sarnacki
ca3936dbd6
Ported missing functionality from Rails 2.3.x, raise error on wrong regexps in :constraints in routes
2010-09-05 13:44:38 +02:00
Piotr Sarnacki
c15bb4901b
Fixed routes to use new API in a few more actionpack tests
2010-09-05 13:44:37 +02:00
Łukasz Strzałkowski
442e54967c
Removed rest of errors and failures in routing_test.rb. Almost all squashed, only few left
2010-09-05 13:44:37 +02:00
Piotr Sarnacki
3088b4f84f
raise error on invalid HTTP methods or :head passed with :via in routes
2010-09-05 13:44:37 +02:00
Piotr Sarnacki
8958f332bb
Implemented resources :foos, :except => :all option
2010-09-05 13:44:37 +02:00