Commit Graph

21131 Commits

Author SHA1 Message Date
Xavier Noria
3b10b8a201 implements ActiveRecord::Base.connection_config to be able to check the configuration of the current connection at runtime 2011-03-05 01:35:02 +01:00
Santiago Pastorino
28f1c21b50 Fix CI 2011-03-04 21:38:38 -02:00
Jon Leighton
8987cda2bb When preloading has_and_belongs_to_many associations, we should only instantiate one AR object per actual record in the database. (Even when IM is off.) 2011-03-04 15:16:07 -08:00
Jon Leighton
af27262ec3 Fix a couple of tests in join_model_test.rb which were failing when the identity map is turned off 2011-03-04 14:49:19 -08:00
Santiago Pastorino
056f05adcd Make CI test with and without IM 2011-03-04 19:03:47 -02:00
Diego Carrion
1f47061b48 reverted tests deleted by 080345baca1076a9788d, refactored implementations should not invalidate the validations
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-03-04 18:07:48 -02:00
Diego Carrion
7872cc992b refactored Time#<=> and DateTime#<=> by removing unnecessary calls without losing performance
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-03-04 16:50:24 -02:00
Alexander Uvarov
0db915efd1 Add an option to FormBuilder to omit hidden field with id
[#4551 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-03-04 16:38:08 -02:00
José Valim
f00a398456 log and readme should respect --quiet 2011-03-04 13:05:27 +01:00
Aaron Patterson
1db4969dc9 only compute path.to_s once 2011-03-02 15:17:29 -08:00
Aaron Patterson
dc89e29f49 remove to_s implementation so that inspect is helpful 2011-03-02 15:17:13 -08:00
Aaron Patterson
b247c8d71a * LocalCache strategy is now a real middleware class, not an anonymous class
posing for pictures.
2011-03-02 14:05:06 -08:00
Dalibor Nasevic
b7cf1f4ccf No need of instance variable
[#6502 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-03-02 18:01:26 -02:00
Aaron Patterson
272ede9b9a require deprecation so that we can deprecate methods! 2011-03-02 10:42:43 -08:00
Aaron Patterson
72405efe64 anonymous classes have blank names on ruby 1.8 2011-03-02 10:23:04 -08:00
Aaron Patterson
1f2e7214aa make sure string keys are always looked up from the class cache 2011-03-02 10:11:28 -08:00
Aaron Patterson
9198372421 Ruby 1.8: Y U NO FUN? 2011-03-02 09:43:27 -08:00
Aaron Patterson
dd41387f34 use newer class cache api 2011-03-02 09:35:10 -08:00
Aaron Patterson
69e348013b adding deprecation noticies to deprecated class cache methods 2011-03-02 09:31:40 -08:00
Aaron Patterson
66245441d4 adding backwards compat for class cache references. <3<3 2011-03-02 09:18:05 -08:00
Cheah Chu Yeow
2ee5555744 Fix Action caching bug where an action that has a non-cacheable response always renders a nil response body. It now correctly renders the response body.
Note that only GET and HTTP 200 responses can be cached.

[#6480 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-03-02 13:11:07 -02:00
Dalibor Nasevic
e4cf28f3a0 Fixed typos in asset_host_test
[#6501 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-03-02 12:48:33 -02:00
Aaron Patterson
f345e2380c yo dawg, directly use the class cache rather than the cache of the cache 2011-03-01 17:43:45 -08:00
Aaron Patterson
7b6bfe84f3 refactor Reference to a ClassCache object, fix lazy lookup in Middleware so that anonymous classes are supported 2011-03-01 17:20:35 -08:00
Aaron Patterson
50ed1a25a4 initialize ivars 2011-03-01 17:20:35 -08:00
Alexander Uvarov
24faddd60c Move ActiveModel::AttributeMethods#attribute_methods_generated? to ActiveRecord, so it's flexible now
[#6428 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
2011-03-01 20:22:45 +01:00
Aaron Patterson
fd26afc93b Enumerable gives us include?, so remove include? 2011-03-01 10:21:44 -08:00
Aaron Patterson
648fd60ecf prefer composition over inheritance with AD::MS 2011-03-01 10:14:09 -08:00
Aaron Patterson
e477fc1147 fixing test case test on 1.9.3dev 2011-03-01 10:14:09 -08:00
Sam Elliott
9cf3b1f671 Remove warnings about redefined test methods
[#6490 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-03-01 12:39:04 -02:00
Aaron Patterson
46bb424287 Revert "compute ext in initialize, and use an attr_reader"
This reverts commit 2dbb73bdda3b81947fd112486ac4285fb1a6e3a9.

Conflicts:

	actionpack/lib/action_dispatch/middleware/static.rb
2011-02-28 19:47:09 -08:00
Aaron Patterson
f279422e33 no need to pass a regex to Regexp.compile 2011-02-28 18:03:06 -08:00
Aaron Patterson
2dbb73bdda compute ext in initialize, and use an attr_reader 2011-02-28 17:54:00 -08:00
Aaron Patterson
c563f71e53 Merge branch 'fuuu'
* fuuu:
  Move JoinDependency and friends from ActiveRecord::Associations::ClassMethods to just ActiveRecord::Associations
  Rewrote AssociationPreload.
2011-02-28 17:13:39 -08:00
Aaron Patterson
54fdd33f33 use a subclass of AS::TZ for testing html output 2011-02-28 16:30:14 -08:00
Aaron Patterson
19c763f783 reduce two method calls per request, 1 to method_missing and one to send 2011-02-28 15:47:25 -08:00
Jon Leighton
b171b9e73d Move JoinDependency and friends from ActiveRecord::Associations::ClassMethods to just ActiveRecord::Associations 2011-02-28 22:12:43 +00:00
Jon Leighton
d90b4e2615 Rewrote AssociationPreload. 2011-02-28 22:12:34 +00:00
Josh Kalderimis
7112cf5e02 Updated the AS guides with some information on the difference between Date.today and Date.current. 2011-02-28 14:05:49 -08:00
Josh Kalderimis
0f8d2794f2 updated Time, Date and DateTime current methods in AS to use Time.zone and not Time.zone_default.
[#6410 state:committed]
2011-02-28 14:05:49 -08:00
Xavier Noria
de9713186d revises a few details in public/index.html 2011-02-28 20:03:40 +01:00
Ben Orenstein
726599df98 Remove redundant to_sym call.
[#6483 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-02-28 16:43:12 -02:00
Aaron Patterson
a8dae084c9 skip this on oracle 2011-02-28 09:15:19 -08:00
Oriol Gual and Josep M. Bach
f42562f97b Make ActiveSupport::Configurable work with modules
[#6486 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-02-28 13:30:32 -02:00
Diego Carrion
a0629927b2 added activesupport/test/tmp to gitignore
[#6484 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-02-28 13:14:16 -02:00
Santiago Pastorino
53b17e9ad0 javascript_include_tag shouldn't raise if you register an expansion key with nil value 2011-02-28 11:52:00 -02:00
Santiago Pastorino
801e314006 Add tests for register expansion methods with key = [] 2011-02-28 11:30:12 -02:00
Santiago Pastorino
a00bed0c48 Revert "Properly interpolate i18n keys in modules [#5572 state:resolved]"
This breaks #6448, you should use :"module/class" as key for namespacing
[#6448 state:committed]

This reverts commit 8d30193b08bd2321a7a78a1f481bd5e4d4d45557.
2011-02-27 21:30:03 -02:00
Santiago Pastorino
acf0688fdd failing test for i18n key collision with namespaced models 2011-02-27 21:23:52 -02:00
Jeff Kreeftmeijer
86ad8a6c87 Make sure the Thor generator LoadError does not output --dev twice [#6431 state:resolved]
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-02-27 18:53:18 -02:00