Commit Graph

21287 Commits

Author SHA1 Message Date
Joshua Peek
3e7985c9c1 Add sprockets environment to Application 2011-03-21 17:58:28 -05:00
Aaron Patterson
88636f7195 escaping binary data encoding when inserting to sqlite3. Thanks Naruse! [#6559 state:resolved] 2011-03-21 14:49:07 -07:00
Aaron Patterson
ea8fcfb729 schemas set by set_table_name are respected by the mysql adapter. [#5322 state:resolved] 2011-03-21 11:20:45 -07:00
Iain Hecker
96b9fc4400 Reapply extensions when using except and only 2011-03-21 10:29:45 -07:00
Aaron Patterson
55bf087da1 SJIS is an alias to Windows-31J in ruby trunk. Use SHIFT_JIS for this test 2011-03-21 10:00:30 -07:00
José Valim
1413c9b1d5 Improved resolver docs a bit 2011-03-19 16:06:50 -07:00
Chris Kowalik
d76fadbd7d [action_view] docs for FileSystemResolver 2011-03-20 07:01:47 +08:00
Chris Kowalik
de1fe5e8a7 [action_view] added custom patterns to template resolver 2011-03-20 07:01:46 +08:00
Santiago Pastorino
445241d713 define_attr_method should be able to define methods that returns nil 2011-03-17 23:17:20 -03:00
Aaron Patterson
4532b39f5f remove misleading comment 2011-03-17 10:31:12 -07:00
Aaron Patterson
00f0879367 dup strings on return so that in place modifications do not break anything. I am looking at you "compute_table_name" 2011-03-17 10:26:11 -07:00
Santiago Pastorino
c834a751d2 define_attr_method correctly defines methods with invalid identifiers 2011-03-16 21:20:44 -03:00
Santiago Pastorino
fda45f4fc4 Add a define_attr_method test 2011-03-16 21:08:02 -03:00
Santiago Pastorino
5232077517 Add test for define_attr_method using as name an invalid identifier 2011-03-16 21:01:49 -03:00
Santiago Pastorino
cb44e99de4 Add test for define_attribute_method using as name an invalid identifier 2011-03-16 21:01:04 -03:00
Josh Kalderimis
0eae625256 fixes an issue with number_to_human when converting values which are less than 1 but greater than -1 [#6576 state:resolved]
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-03-16 15:11:00 -03:00
Andrew White
e8458d37c5 Fix typo in assertion message 2011-03-16 10:28:40 +00:00
Norman Clarke
7bd70dcd6c Add messages to plain assertions.
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-03-15 10:44:14 -03:00
Aaron Patterson
9f2706d770 use a list to represent the supported verbs for a route object 2011-03-14 18:26:30 -07:00
Aaron Patterson
9ba2d422f5 stop splatting arguments so that we can understand wtf is going on 2011-03-14 16:17:05 -07:00
Aaron Patterson
833a90594e RegexpWithNamedGroups is only used for path_info, so only apply to path info 2011-03-14 15:17:29 -07:00
Xavier Noria
21b12d89a6 Merge branch 'master' of git://github.com/lifo/docrails 2011-03-14 22:09:52 +01:00
Xavier Noria
a0826cceea be be -> be 2011-03-14 22:06:27 +01:00
Xavier Noria
de5e41f855 move the tips about :allow_(nil|blank) near their explanations, also no need to say these are options for all validators if they are not 2011-03-14 22:03:23 +01:00
Jack Dempsey
dfa9e28113 silence @dummy_path not defined warnings 2011-03-14 02:54:44 +08:00
Jack Dempsey
88d8ca2ef9 use parens and silence ambiguous args warnings 2011-03-14 02:54:44 +08:00
Anders Elfving
9b64399684 Adjust unique constraint comment to include info about the RecordNotUnique exception 2011-03-13 11:49:56 +01:00
Andrew White
47871b025e Remove invalid test
The test fails on PostgreSQL when trying to load the records as
the comments_count field is not included in the GROUP BY clause.
2011-03-13 08:43:19 +00:00
Manuel Meurer
deae670e9a Change ActionView::ViewPathSet to ActionView::PathSet 2011-03-13 15:14:51 +07:00
Lars Smit
c540b35441 Removed double texts 2011-03-13 09:07:23 +01:00
José Valim
9f5b1e1ed0 Revert "It should be possible to use ActiveSupport::DescendantTracker without getting ActiveSupport::Dependencies for free."
This reverts commit 46f6a2e3889bae420589f429b09722a37dbdf18d.

Caused failures on CI. rake test:isolated on activesupport directory show them.
2011-03-13 08:35:50 +01:00
Santiago Pastorino
157c37f558 Refactor length validation 2011-03-12 21:12:44 -02:00
Andriy Tyurnikov
f48d3d4df6 length validation for fixnums
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-03-12 21:12:44 -02:00
Chris Oliver
015192560b Fixed a bug when empty? was called on a grouped Relation that wasn't loaded
[#5829 state:resolved]

Signed-off-by: Andrew White <andyw@pixeltrix.co.uk>
2011-03-12 22:31:21 +00:00
Rolf Timmermans
1a3fe8ce42 Prevent callbacks in child classes from being executed more than once. 2011-03-13 01:35:29 +08:00
Rolf Timmermans
46f6a2e388 It should be possible to use ActiveSupport::DescendantTracker without getting ActiveSupport::Dependencies for free. 2011-03-13 01:33:10 +08:00
Mike Gehard
58de03f077 Add additional text to NotImplementedErrors [#6328 state:resolved]
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-03-12 13:43:23 -02:00
Rolf Timmermans
63c8ea9a6a adds a couple of missing AS dependencies 2011-03-12 14:30:09 +01:00
Aaron Patterson
acd4bfb537 Just define methods directly on the class rather than use the module
indirection.

clever--
2011-03-11 18:16:47 -08:00
Aaron Patterson
89c5b9aee7 do not automatically add format to routes that end in a slash 2011-03-11 18:06:22 -08:00
Paco Guzman
0a51e43866 remove some blanks 2011-03-11 23:08:55 +01:00
José Valim
53794cf7b5 Add missing require 'thread' to BufferedLogger. 2011-03-11 13:29:39 -08:00
Samuel Kadolph
94031ef422 Add require 'date' to use Date.today in plugin template MIT-LICENSE 2011-03-12 03:27:42 +08:00
Prem Sichanugrist & Xavier Noria
68802d0fbe Filter sensitive query string parameters in the log [#6244 state:committed]
This provides more safety to applications that put secret information in the query string, such as API keys or SSO tokens.

Signed-off-by: Xavier Noria <fxn@hashref.com>
2011-03-11 00:16:18 +01:00
Mike Gehard
ee7c48678f Minor formatting changes and remove a comment 2011-03-10 10:08:30 -05:00
Vijay Dev
439ccdc3cf update plugin urls to reflect official maintainers 2011-03-10 19:58:55 +05:30
David Aaron Fendley
6fba542f44 Added note re: functional tests and HTTP methods. 2011-03-09 18:06:50 -06:00
Santiago Pastorino
51a269b228 Fix typo 2011-03-09 20:17:30 -02:00
Diego Carrion
8e73e589a8 publicise ActionMailer::MailHelper.format_paragraph
[#6550 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-03-09 18:36:39 -02:00
Diego Carrion
f65023cbda expose ActionMailer::MailHelper in the RDoc 2011-03-09 14:56:44 -03:00