TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
35,586 Commits 2 Branches 0 Tags 294 MiB
408227d9c5
Commit Graph

35586 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Guillermo Iguaran
408227d9c5 Merge pull request #9207 from dylanahsmith/mysql-quote-numeric 
active_record: Quote numeric values compared to string columns.
 2013-02-07 12:16:53 -08:00
Carlos Antonio da Silva
dca0b57d03 Skip schema dumper extensions test if connection does not support it 
Travis failed because the postgresql version installed there does not
support extensions, so we just need to skip this for now.
 2013-02-07 08:33:35 -02:00
Dylan Smith
a712e08ebe active_record: Quote numeric values compared to string columns. 2013-02-07 04:59:33 -05:00
Carlos Antonio da Silva
1b75666f7f Run schema dumper extensions without creating real extensions 
There is no need to create the extension in the database just to test if
it's dumped, we can stub that instead.
 2013-02-06 23:03:48 -02:00
Carlos Antonio da Silva
86f4db97aa Do not print anything related to extensions when they don't none exist 
When extensions are supported but there's no one enabled in the
database, we should not print anything related to them in schema.rb.
 2013-02-06 22:57:10 -02:00
Carlos Antonio da Silva
73510b1fb2 Add blank line after extensions to separate from tables in schema 2013-02-06 22:49:00 -02:00
Carlos Antonio da Silva
3ee3eddf61 Fix indentation of extensions in schema 2013-02-06 22:47:23 -02:00
Carlos Antonio da Silva
f88c336e37 Call super to use the abstract adapter implementation instead 2013-02-06 22:42:29 -02:00
Carlos Antonio da Silva
7173919af9 Add changelog entry for #9203 about schema dumper with db extensions 
[ci skip]
 2013-02-06 22:42:29 -02:00
Aaron Patterson
34ac46ceeb Merge pull request #9203 from jaggederest/dumping_pgsql_extensions 
Adding database extension support to schema.rb
 2013-02-06 16:18:06 -08:00
Justin George
fba496f2c0 add ActiveRecord::AbstractAdapter#extensions and ActiveRecord::ConnectionAdapters::PostgreSQLAdapter#extensions to allow dumping of enabled extensions to schema.rb, add ActiveRecord::SchemaDumper#extensions to dump extensions to schema.rb 2013-02-06 16:01:25 -08:00
Justin George
e2fdfa9c07 improve tests to check for existence of extensions method, and skip testing dumped extensions if they are unsupported by the database 2013-02-06 16:01:25 -08:00
Justin George
c0990f040f Add some tests to enumerate how extensions should be stored in the schema output 2013-02-06 16:01:25 -08:00
Carlos Antonio da Silva
2f0c26bf59 Update changelog from #9128 with author name 
And improve AS changelog a bit [ci skip]
 2013-02-06 19:02:40 -02:00
Jeremy Kemper
c7598134a4 Merge pull request #9128 from jamesotron/iso8601-sub-second-accuracy 
Modify TimeWithZone#as_json to return 3DP of sub-second accuracy.
 2013-02-06 12:33:28 -08:00
Rafael Mendonça França
f14dcc058e Update actionpack/CHANGELOG.md 
[ci skip]
 2013-02-06 18:01:32 -02:00
Rafael Mendonça França
329c82380e Merge pull request #9039 from senny/warn_on_controller_option_with_ruby_constant_syntax 
ruby constant syntax is not supported as routing `:controller` option.
 2013-02-06 11:59:58 -08:00
Yves Senn
69f28a7d8d ruby constant syntax is not supported as routing :controller option. 
The current implementation only works correctly if you supply the `:controller`
with directory notation (eg. `:controller => 'admin/posts'`).

The ruby constant notation (eg. `:controller => 'Admin::Posts`) leads to unexpected problems with `url_for`.

This patch prints a warning for every non supported `:controller` option. I also added documentation how
to work with namespaced controllers. The warning links to that documentation in the rails guide.
 2013-02-06 20:56:09 +01:00
José Valim
99bb2fd892 Update .gitignore 
Get rid of old .rvmrc and .rbenv-version files.
 2013-02-05 14:03:13 -07:00
Rafael Mendonça França
b713f1b3cc Enable hstore extensions on tests if it is not enabled and database supports it 2013-02-05 17:47:50 -02:00
Rafael Mendonça França
655e95c8c3 Merge pull request #9192 from adammck/ignore-dot-ruby-version 
Ignore .ruby-version
 2013-02-05 09:00:16 -08:00
Adam Mckaig
36acc0a7f4 Ignore .ruby-version 2013-02-05 11:46:51 -05:00
Carlos Antonio da Silva
c163916810 Merge pull request #9178 from robertomiranda/best-standard-support-guide 
Update upgrading guide with ActionDispatch::BestStandardsSupport removal [ci skip]
 2013-02-04 15:50:10 -08:00
robertomiranda
ebcb53c1cf Update upgrading guide with ActionDispatch::BestStandardsSupport removal 2013-02-04 18:02:52 -05:00
Aaron Patterson
5efce21a80 Merge pull request #9177 from zenspider/master 
Added test:all and test:all:db tasks to speed up full test runs
 2013-02-04 14:59:44 -08:00
Ryan Davis
0e006373e0 Added test:all and test:all:db tasks to speed up full test runs. 
Speed up depends on the number of test phases (N) you have for your
app, but it is roughly a 1/N improvement. In my app, it goes from
15.51s to 5.56s.

Inspired by http://ngauthier.com/2012/02/quick-tests-with-bash.html

Reviewed by @tenderlove
 2013-02-04 14:50:04 -08:00
Guillermo Iguaran
cb48bbeb00 Merge pull request #9175 from robertomiranda/add--rc-desc 
Add --rc description on the command line
 2013-02-04 13:30:15 -08:00
robertomiranda
3a5b38bc3d Add --rc description on the command line 2013-02-04 16:25:44 -05:00
Rafael Mendonça França
5720de7a39 Merge pull request #9174 from robertomiranda/railsrc-cli-option 
Use --rc=PATH instead of --rc PATH
 2013-02-04 13:09:13 -08:00
robertomiranda
51030364ec Use --rc= instead of --rc 2013-02-04 16:05:38 -05:00
Carlos Antonio da Silva
65113fd2c8 Merge pull request #8520 from senny/8516_assert_template_with_locals 
Improved `assert_template` when matching :locals with partials
 2013-02-04 05:51:36 -08:00
Yves Senn
cce94e7232 partials inside directory work with assert_template 
previously when a partial was placed inside a directory
(eg. '/dir/_partial'), `assert_template` did not replace
the '_' prefix when looking through rendered tempaltes,
which resulted in an error.

I modified it to replace both, the leading '_' and the last '_'
after a '/'.
 2013-02-04 14:46:50 +01:00
Yves Senn
c21ab338cb descriptive assert_template error when partial wasn't rendered 
When `assert_template` is used with the :locals option, and the
partial was not rendered, a method_missing error was raised.
This changes first checks, if the partial actually was rendered
and raises a descriptive error.
 2013-02-04 14:46:50 +01:00
Rafael Mendonça França
e16110c4b8 Take care of whitespaces and changing the hash syntax 2013-02-04 09:59:22 -02:00
Aaron Patterson
443be7584c Merge pull request #9152 from dahakawang/master 
test for issue 8931
 2013-02-03 22:07:40 -08:00
Xavier Noria
633d953f02 Merge pull request #9164 from yuki24/put_rdoc_at_the_end_of_RUNNING_UNIT_TESTS 
Put .rdoc at the end of the files named RUNNING_UNIT_TESTS
 2013-02-03 00:06:21 -08:00
Yuki Nishijima
c8a25386d3 Put .rdoc at the end of the files named RUNNING_UNIT_TESTS 
So that they are printed nicely on GitHub.
 2013-02-03 15:49:48 +09:00
Guillermo Iguaran
ecd004e658 Merge pull request #9154 from robertomiranda/add-rc-desc 
Add --no-rc description on the command line
 2013-02-02 07:15:38 -08:00
robertomiranda
9e18ce7f93 Add --no-rc description on the command line 2013-02-02 09:57:07 -05:00
Rafael Mendonça França
d3524852e2 Merge pull request #9151 from gogogarrett/patch-1 
Fix link to point to new RefineryCMS repo
 2013-02-02 05:01:22 -08:00
Xavier Noria
08b60fc2e5 Merge remote-tracking branch 'docrails/master' 2013-02-02 10:33:19 +01:00
Xavier Noria
6a86873552 Revert "Detail middleware initialization points in the initialization guide [ci skip]" 
I feel this is too detailed for the guide. Most of that is not public interface,
and if tomorrow something is added or removed in those chains we do not want
to come here to maintain it. Also, linking to a gist is not a good idea in a guide.

We could have a more broad description of what goes in what order, the most key and
public things.

This reverts commit 862a05edf3af128f25a87999936262b733ed781e.
 2013-02-02 10:27:52 +01:00
Guillermo Iguaran
784ed154c3 Refactor --rc option 2013-02-02 00:36:43 -05:00
Guillermo Iguaran
9cb386d9d6 Merge pull request #9147 from amparo-luna/custom_rc 
Add --rc option to support the load of a custom rc file
 2013-02-01 21:27:06 -08:00
David
6e2cba1c8b test for issue 8931 2013-02-02 13:00:52 +08:00
Amparo Luna
5f1dc8e3b7 Add --rc option to support the load of a custom rc file 2013-02-01 23:17:41 -05:00
Garrett Heinlen
10c262c75d Fix link to point to new RefineryCMS repo 2013-02-01 20:06:12 -06:00
Guillermo Iguaran
3e1f23125d Merge pull request #9149 from robertomiranda/remove-ref-best-standards-support 
Remove BestStandardsSupport References
 2013-02-01 13:39:26 -08:00
robertomiranda
a83183c721 Remove BestStandardsSupport references 2013-02-01 16:37:35 -05:00
Steve Klabnik
f2c7a5d5df Fix markdown syntax in actionpack CHANGELOG. 
Starting a line with an octothorpe makes an <h1>
 2013-02-01 11:33:31 -08:00