Commit Graph

51371 Commits

Author SHA1 Message Date
Mehmet Emin İNAÇ
4355725cdc Remove redundant 'like' from doc of slice! method [ci skip] 2015-05-26 10:53:05 +03:00
Yves Senn
b8c31fd9b9 Merge pull request #16938 from akshay-vishnoi/remove-deprication
Remove `.superclass_delegating_accessor`.
2015-05-26 09:26:55 +02:00
Matthew Draper
2d261ba43c Merge pull request #20296 from vngrs/use_memoization_to_minimize_memory_usage
Use memoization while accessing request headers for minimizing memory usage
2015-05-26 03:36:38 +09:30
Mehmet Emin İNAÇ
b197a1adc5 Use memoization while accessing request headers for minimizing memory usage 2015-05-25 20:07:46 +03:00
Abdelkader Boudih
88c883b2f9 Merge pull request #20295 from rohandaxini/patch-1
Fixed the grammatical mistake in the sentence [ci skip]
2015-05-25 16:39:22 +01:00
Rohan Daxini
498ff4800a Fixed the grammatical mistake in the sentence [ci skip] 2015-05-25 21:05:46 +05:30
Rafael Mendonça França
5e92f9022f Merge pull request #20248 from ronakjangir47/remove_mocha
Remove use of mocha in the railties generators tests
2015-05-25 11:01:02 -03:00
Rafael Mendonça França
f4fb48365b Merge pull request #20294 from yoongkang/american_spelling
Fix spelling mistakes
2015-05-25 10:47:04 -03:00
Kasper Timm Hansen
7a08b2c4c0 Merge pull request #20293 from davydovanton/doc-duration
Update documentation for Duration#to_s
2015-05-25 15:45:41 +02:00
Anton Davydov
2c725896b2 [skip ci] Update documentation for Duration#to_s 2015-05-25 16:36:37 +03:00
Yoong Kang Lim
f55fe55d5a Fix spelling mistakes 2015-05-25 23:26:15 +10:00
Zachary Scott
d0a370ec93 Merge branch 'master' of github.com:rails/rails 2015-05-24 21:18:34 -07:00
Zachary Scott
83d0252fe3 Add missing type reference here 2015-05-24 21:18:09 -07:00
Zachary Scott
6a074044df Merge pull request #20288 from brian-davis/brian-davis
Grammar fix to Active Record Basics guide. [ci skip]
2015-05-24 20:24:05 -07:00
Brian Davis
55c79e66d3 Grammar fix to Active Record Basics guide. [ci skip] 2015-05-24 19:50:20 -07:00
Abdelkader Boudih
ac1368a367 Merge pull request #20286 from davydovanton/doc-deprecation-behavior
Add documentation for Deprecation::Behavior module
2015-05-25 00:03:58 +01:00
Anton Davydov
0f53b010f9 [skip ci] Add documentation for Deprecation::Behavior module 2015-05-25 01:51:04 +03:00
Zachary Scott
c0c90af41a s/contstant/constant re #20282 [ci skip] 2015-05-24 10:52:04 -07:00
Zachary Scott
53592a5959 Merge pull request #20282 from davydovanton/doc-proxy-wrappers
Add documentation for DeprecatedConstantProxy#class
2015-05-24 10:49:22 -07:00
Anton Davydov
f671cbecf4 [skip ci] Add documentation for DeprecatedConstantProxy#class 2015-05-24 20:38:53 +03:00
Claudio B.
c2ded92e3a Merge pull request #20270 from imtayadeway/tw/association-basics-docs
association basics docs fixes
2015-05-24 09:12:34 -07:00
Santiago Pastorino
9882f9e43c Merge pull request #20265 from benpickles/gitignore-keeps
Omit .keep in .gitignore when generated with --skip-keeps.
2015-05-24 11:43:54 -03:00
Santiago Pastorino
fee34594be Merge pull request #20260 from tgxworld/remove_deprecation_warning
Remove deprecation warning.
2015-05-24 11:42:29 -03:00
Akshay Vishnoi
20c1484993 Remove .superclass_delegating_accessor. Refer #14271 2015-05-24 12:15:22 +05:30
Zachary Scott
d6f59eac65 Merge pull request #20279 from y-yagi/assert_difference_example
use keyword arguments in HTTP request methods of assert_difference example [ci skip]
2015-05-23 23:34:42 -07:00
Claudio B.
281581f76f Merge pull request #20278 from dleve123/cleanup-contributing-docs-section
Cleanup docs for contributing to rails docs
2015-05-23 18:07:15 -07:00
yuuji.yaginuma
aa8672a5ba use keyword arguments in HTTP request methods of assert_difference example [ci skip] 2015-05-24 08:34:15 +09:00
Daniel Levenson
0fcef173d4 Reword sentences in contributing docs for clarity.
[skip ci]

- removes use "squash" where it doesn't apply to git
- "is a help" -> "helps"
- "if your comment simply says" -> "... simply reads"
2015-05-23 19:05:56 -04:00
Daniel Levenson
1cb94077d9 Reword a sentence about GH Issues in contributing guide.
[skip ci]

"Everyone's Issues" read pretty weird to me, specifically
the use of capitalization. I changed the link text
to be "issue list", which seems to better "go with
the flow", IMHO.
2015-05-23 18:53:21 -04:00
Aaron Patterson
c10630b642 remove useless ivar
I should have deleted this earlier with 42e66fac38b54dd53d062fb5d3376218ed2ffdae
2015-05-23 11:39:43 -07:00
Aaron Patterson
cf985d1a4e add a branch to eliminate multiple nil checks
if we add an else conditional to the `presence` check, we can eliminate
the second `||` branch in the caller
2015-05-23 11:38:23 -07:00
Arun Agrawal
989296ff09 Merge pull request #20275 from prathamesh-sonpatki/remove-div-for-from-guides
Remove div_for from guides [ci skip]
2015-05-23 15:14:52 +02:00
Prathamesh Sonpatki
d3da208048 Remove div_for from guides [ci skip]
Followup of https://github.com/rails/rails/pull/20244.
2015-05-23 17:47:20 +05:30
Tim Wade
5a81779610
[ci skip] Fix markdown issue in association basics docs.
The quoted underscore is being intepreted as markdown, causing the
entire phrase to be italicized.
2015-05-22 21:37:42 -07:00
Tim Wade
f2e2086d53
[ci skip] Use spaceship operator to indicate precedence. 2015-05-22 21:37:01 -07:00
Tim Wade
2ec1fe4379
[ci skip] Fix grammar/syntax in AR assocation basics. 2015-05-22 21:23:57 -07:00
Aaron Patterson
42e66fac38 move request id manipulation to the request object
this way we can keep the knowledge of `env` hash keys in one place.
2015-05-22 16:29:16 -07:00
Zachary Scott
334140c927 Merge pull request #20231 from karanarora/Spelling-fix
Rails documentation standard is american english. [ci skip]
2015-05-22 14:35:16 -07:00
karanarora
0750330941 Spelling/typo/grammatical fixes [ci skip]
spelling fix [ci skip]

example to be consistent [ci skip]

grammatical fix

typo fixes [ci skip]
2015-05-23 03:01:33 +05:30
Ben Pickles
46fedb4782 Omit .keep in .gitignore when generated with --skip-keeps. 2015-05-22 13:32:06 +01:00
Guo Xiang Tan
3d4004ab63 Remove deprecation warning.
https://travis-ci.org/rails/rails/jobs/63594316#L1982
2015-05-22 19:16:47 +08:00
Yves Senn
3873fc5c1c Merge pull request #20255 from eliotsykes/link-associations-to-exists-guide
Link association.exists?(...) to AR::Base.exists? guide [ci skip]
2015-05-22 10:44:09 +02:00
Eliot Sykes
4311f05124 Link association.exists?(...) to API docs [ci skip] 2015-05-22 09:27:51 +01:00
Yves Senn
1214f0b74f Merge pull request #20254 from eliotsykes/link-relatively-to-configuring-guide
Make link to configuring guide relative [ci skip]
2015-05-22 09:21:12 +02:00
Eliot Sykes
b539760014 Make link to configuring guide relative [ci skip] 2015-05-22 07:55:54 +01:00
Rafael Mendonça França
023d50c583 Merge pull request #20252 from waynn/patch-5
"maybe" => "may be"
2015-05-22 00:49:09 -03:00
Waynn Lue
f25997a9d9 "maybe" => "may be" 2015-05-21 20:11:41 -07:00
Rafael Mendonça França
d13b4e2fc4 Merge pull request #20251 from davydovanton/doc-memory-store
Add nodoc label for protected Cache methods
2015-05-21 19:21:46 -03:00
Anton Davydov
15df1dc2b0 [skip ci] Add nodoc label for protected Cache methods 2015-05-22 00:42:26 +03:00
Rafael Mendonça França
dc537669f2 Merge pull request #20250 from davydovanton/doc-mem-cache-store
Update documentation for MemCacheStore::build_mem_cache [ci skip]
2015-05-21 17:30:13 -03:00