Aaron Patterson
4589b2419b
require that all blocks have arity of 2
2011-11-18 10:51:11 -08:00
Aaron Patterson
3178cc9a80
copy options keys to the right place so that undo will work correctly
2011-11-18 10:51:11 -08:00
Aaron Patterson
ecbae99478
no need for type checking
2011-11-18 10:51:11 -08:00
Aaron Patterson
636405d2a6
cleaning up variable names to match method parameter names
2011-11-18 10:51:10 -08:00
Aaron Patterson
33543ac871
stop doing is_a? checks on the resource type
2011-11-18 10:51:10 -08:00
Aaron Patterson
648f6113d1
move constants to methods since nothing else is using them
2011-11-18 10:51:10 -08:00
Aaron Patterson
7459ba4f6c
pushing hash validation up
2011-11-18 10:51:10 -08:00
Aaron Patterson
494ab25772
breaking match down to smaller methods
2011-11-18 10:51:10 -08:00
Aaron Patterson
76780c34f5
some refactoring of the match method
2011-11-18 10:51:09 -08:00
Vijay Dev
dda6787f44
mailer guide - update info about using default host. Fixes #3642
2011-11-19 00:07:50 +05:30
Vijay Dev
48b580a03b
Merge branch 'master' of github.com:lifo/docrails
2011-11-18 23:11:46 +05:30
Vijay Dev
9d035292ba
remove unneeded params from issue tracker url
2011-11-18 23:10:12 +05:30
Vijay Dev
5a2db4c7c3
put back the removed eg
2011-11-18 23:09:30 +05:30
Aaron Patterson
2debbe1581
Merge pull request #3683 from christos/schema_introspection_speedup
...
Only used detailed schema introspection when doing a schema dump.
2011-11-18 09:37:29 -08:00
Vijay Dev
581ba1d946
Merge pull request #3681 from sikachu/fix_test_variable
...
Update variable's name in the test case to reflect the class we're testing
2011-11-18 09:33:26 -08:00
Christos Zisopoulos
280b2b725b
Only used detailed schema introspection when doing a schema dump.
...
Fixes #3678
2011-11-18 18:29:47 +01:00
Prem Sichanugrist
0e2156d334
Update variable's name in the test case to reflect the class we're testing
2011-11-18 11:51:05 -05:00
Jon Leighton
d4119e144a
Merge pull request #3680 from rubys/master
...
This fix causes the AWDwR test to go back to being green on Rails master.
2011-11-18 07:21:57 -08:00
Sam Ruby
42954c426b
Stop db:seed from performing a reload of the db
...
Fix regression introduced by 38d26b0cb56d82093889efa95992a35ba3bb9f29
2011-11-18 10:05:06 -05:00
Vijay Dev
1c4564b620
Merge pull request #3666 from oscardelben/databases_rake_cleanup
...
Cleanup of databases.rake psql env variables
2011-11-18 04:21:56 -08:00
Xavier Noria
307fc122f6
release instructions: new section about docs generation
2011-11-18 13:05:25 +01:00
Philip Arndt
bc9b1e0a10
Fixed typo: expect -> expected
2011-11-18 23:50:14 +13:00
Vijay Dev
96792d2756
Merge pull request #3669 from parndt/patch-1
...
Fixed typo: expect -> expected
2011-11-17 23:40:33 -08:00
Edward Anderson
fe88745d5f
Fix a number_with_delimiter :separator example
2011-11-17 20:10:49 -05:00
lest
e8d57f361a
_html translation should escape interpolated arguments
2011-11-17 23:07:39 +00:00
Xavier Noria
1079724fe6
Revert "warn the user values are directly interpolated into _html translation strings"
...
Reason: After another round of discussion, it has been
decided to let interpolation deal with unsafe strings
as it should do.
This reverts commit d57d8098fc269a26ea0051a9027a33af1a9a4b2b.
2011-11-17 23:59:19 +01:00
Aaron Patterson
a437986f43
allow people to set a local .Gemfile so that things like ruby-debug are not required for regular development
2011-11-17 14:41:53 -08:00
Xavier Noria
d57d8098fc
warn the user values are directly interpolated into _html translation strings
2011-11-17 23:07:06 +01:00
Philip Arndt
e375970725
Fixed typo: expect -> expected
2011-11-18 10:17:16 +13:00
Vijay Dev
9b534060bf
update guide: db:structure:dump produces structure.sql now
2011-11-18 01:17:21 +05:30
Aaron Patterson
a2f14e2344
Revert "Merge pull request #1163 from amatsuda/sexier_migration_31"
...
This reverts commit 0e407a90413d8a19002b85508d811ccdf2190783, reversing
changes made to 533a9f84b035756eedf9fdccf0c494dc9701ba72.
Conflicts:
activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb
activerecord/test/cases/migration_test.rb
2011-11-17 10:29:28 -08:00
Aaron Patterson
649f2513a4
Revert "Merge pull request #3603 from vijaydev/change_table_without_block_arg"
...
This reverts commit 81fad6a270ec3cbbb88553c9f2e8200c34fd4d13, reversing
changes made to 23101de283de13517e30c4c3d1ecc65525264886.
Conflicts:
activerecord/test/cases/migration_test.rb
2011-11-17 10:29:28 -08:00
Oscar Del Ben
a89fabbb02
Cleanup of databases.rake psql env variables
2011-11-17 18:49:47 +01:00
Sunny Ripert
8d17af23ef
Guides: better example to find the last sent email
2011-11-17 17:05:53 +01:00
José Valim
d8b2b6a183
Merge pull request #3663 from atambo/master
...
Move schema_format :sql config setting from test.rb to application.rb
2011-11-17 07:10:11 -08:00
Alex Tambellini
0af93089de
Move schema_format :sql config setting from test.rb to application.rb
...
I've moved the schema_format :sql config setting to application.rb because you would
never enable this only for the test environment. If you use database constraints
or database specific data types you would want all of your environments to use them.
2011-11-17 09:44:17 -05:00
José Valim
e2d3060a68
Merge pull request #3654 from wildchild/label_i18n
...
Fix impractical I18n lookup in nested fields_for
2011-11-17 00:02:49 -08:00
Vijay Dev
e6f3299158
Merge pull request #3658 from arunagw/fix_initialize_var_name
...
It should be @calculated_ip not @calculate_ip
2011-11-16 23:30:45 -08:00
Arun Agrawal
c3ae1d2aec
It should be @calculated_ip not @calculate_ip
...
We are using @calculated_ip.
@calculate_ip is no where used
2011-11-17 12:50:19 +05:30
Vijay Dev
4148a7ca7d
Merge pull request #3656 from arunagw/readline_to_read
...
No need to `readlines` then `join`, just use `read` ❤️
2011-11-16 23:00:40 -08:00
Arun Agrawal
5ccd9bcc1a
No need to readlines
then join
, just use read
❤️
...
same as 4c1a1933cbc5ab96efe340a3b31ac5fee12c99c8
2011-11-17 12:24:40 +05:30
Alexander Uvarov
c2b6f63bbe
Fix impractical I18n lookup in nested fields_for
2011-11-17 12:37:00 +06:00
Aaron Patterson
e367142255
Initialize our instance variables.
2011-11-16 16:55:11 -08:00
Aaron Patterson
70f9b74a49
Merge pull request #3649 from indirect/remote_ip
...
Fixes for Request#remote_ip (no middleware, all proxies)
2011-11-16 16:44:09 -08:00
Aaron Patterson
4c1a1933cb
No need to readlines
then join
, just use read
❤️
2011-11-16 16:18:00 -08:00
capps
64a3175eea
"denoted" instead of "donated"
...
"parentheses" instead of "use brackets"
2011-11-16 15:57:54 -08:00
Aaron Patterson
bb95e81538
Adding a deprecation warning for use of the schema_info table.
2011-11-16 15:51:25 -08:00
Aaron Patterson
97ca6358c5
Join method uses empty string by default, so remove it
2011-11-16 15:40:20 -08:00
Aaron Patterson
b96aaf8ccb
dbfile isn't supported anymore, so remove
2011-11-16 15:31:37 -08:00
Aaron Patterson
ca69408b49
Reduce schema format tests
2011-11-16 15:31:37 -08:00