TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
20,491 Commits 2 Branches 0 Tags 294 MiB
4bc9bacd94
Commit Graph

20491 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Aaron Patterson
4bc9bacd94 refactor elaborate group_by in to a normal group_by 2011-01-18 15:52:57 -08:00
Aaron Patterson
36d6678690 removing usesless variable assignments 2011-01-18 15:52:56 -08:00
Nick Sutterer
7091d800b8 fixed a missing require that causes trouble when using AS in a non-rails env. 2011-01-18 23:28:51 +01:00
Aaron Patterson
54de7048a5 Merge branch 'template_error' into merge 
* template_error:
  Ensure original exception message is present in both Template::Error#message and Template::Error#inspect.
  ActiveSupport::Deprecation.silence no longer needed.
 2011-01-18 10:52:37 -08:00
Aaron Patterson
e6881217ed fixing bug where 1.8 hangs while running pg tests 2011-01-18 10:49:50 -08:00
Christos Trochalakis
7dab186fde Issue one Cache#read command instead of two in the case of a fragment cache hit 2011-01-18 09:52:11 -08:00
Aaron Patterson
11fe2161ce remove unnecessary module_eval 2011-01-18 09:36:33 -08:00
John Firebaugh
cc446eee99 Class.__subclasses__ was removed from Rubinius. 
https://github.com/evanphx/rubinius/issues/issue/11
2fccbb5dad
 2011-01-18 15:02:41 +08:00
Michael Koziarski
199d1abeb2 Use the derived request_method from AD::Request rather than the raw REQUEST_METHOD from rack. 
This takes _method into account so the log shows the method which ActionController sees.
 2011-01-18 14:43:54 +13:00
Mikel Lindsaar
6854358964 Removing unused method argument 2011-01-18 12:06:21 +11:00
Mikel Lindsaar
b141fa6280 Cleaning up style, concat inside method calls is ugly 2011-01-18 12:06:21 +11:00
Mikel Lindsaar
3b584aee95 Fixing redundant escape in regex 2011-01-18 12:06:21 +11:00
Mikel Lindsaar
ad8dc5ab89 Should use standard ruby signature for respond_to 2011-01-18 12:06:20 +11:00
Mikel Lindsaar
b72cd29e53 Fixing spelling 2011-01-18 12:06:20 +11:00
Aaron Patterson
9d549986dd remove useless conditional 2011-01-17 16:42:34 -08:00
Aaron Patterson
d780d1f508 ordering can change depending on ruby version, so parse the JSON and verify data structure equality 2011-01-17 16:06:55 -08:00
Aaron Patterson
6a8f7f0e04 minitest added @__io__, so we should ignore it too 2011-01-17 14:53:44 -08:00
Aaron Patterson
1333020448 fixing space errors 2011-01-17 14:45:24 -08:00
Aaron Patterson
990e6a1b3a fixing wrong test 2011-01-17 14:43:29 -08:00
Aaron Patterson
9702159373 removing more unused variables 2011-01-17 14:33:34 -08:00
Aaron Patterson
fdfabc99e8 fixing unused variable warnings 2011-01-17 14:22:17 -08:00
Jon Leighton
7a3f05f43d Add CHANGELOG entry for the addition of create_association! methods on has_one and belongs_to 2011-01-16 13:43:54 -08:00
Jon Leighton
d1521719c5 Removed support for accessing attributes on a has_and_belongs_to_many join table. This has been documented as deprecated behaviour since April 2006. Please use has_many :through instead. A deprecation warning will be added to the 3-0-stable branch for the 3.0.4 release. 2011-01-16 13:43:54 -08:00
Jon Leighton
c4458b3602 Rename some variables 2011-01-16 13:43:54 -08:00
Jon Leighton
8aedd722e1 Use self.target= in HasOneThroughAssociation too 2011-01-16 13:43:54 -08:00
Jon Leighton
b7594a0756 find_target can also go into SingularAssociation 2011-01-16 13:43:53 -08:00
Jon Leighton
f1a15c2197 Abstract a bit more into SingularAssociation 2011-01-16 13:43:53 -08:00
Jon Leighton
115eedbb41 Use self.target= rather than @target= as the former automatically sets loaded 2011-01-16 13:43:53 -08:00
Jon Leighton
ef79b91784 Abstract common code from BelongsToAssociation and HasOneAssociation into SingularAssociation 2011-01-16 13:43:53 -08:00
Jon Leighton
bf24fe810c belongs_to records should be initialized within the association scope 2011-01-16 13:43:53 -08:00
Jon Leighton
3ef693724c Document the new create_association! method on one-to-one associations 2011-01-16 13:43:53 -08:00
Jon Leighton
52c47556b7 Add create_association! for belongs_to 2011-01-16 13:43:53 -08:00
Aaron Patterson
8f88a28416 change sqlite3-ruby => sqlite3 in the generators 2011-01-16 13:29:08 -08:00
Aaron Patterson
421e06f090 updating gem dependency for sqlite3 2011-01-16 12:55:28 -08:00
Xavier Noria
15e71347f6 updates AR's CHANGELOG with changes in 9e64dfa and ad343d7 2011-01-16 18:55:35 +01:00
Santiago Pastorino
bbcdc864a6 README.rdoc is a template 2011-01-15 04:13:43 -02:00
Alexey Nayden
a9163b547c Complex struct encoding fix 
[#6077 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-01-15 00:06:26 -02:00
Alexey Nayden
d2c17dbd11 Complex struct encoding test 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-01-15 00:06:17 -02:00
Santiago Pastorino
d75ff73a72 plugin new generator should generate config/routes.rb file for full engines 2011-01-14 23:34:10 -02:00
Aaron Patterson
0aef847927 push !loaded? conditional up 2011-01-14 17:08:27 -08:00
Aaron Patterson
b8ed2d5ddf return early in case the left or right side lists are empty 2011-01-14 17:03:15 -08:00
Aaron Patterson
75e29e871e only find_target can raise the exception, so isolate the rescue around that call 2011-01-14 16:57:14 -08:00
Aaron Patterson
f548054700 we always have a target, so stop checking 2011-01-14 16:54:02 -08:00
Aaron Patterson
f5d2cb9cac we should use [] instead of Array.new 2011-01-14 16:50:26 -08:00
Aaron Patterson
17687e4f96 @target is always a list, so stop doing is_a? checks 2011-01-14 16:47:31 -08:00
Aaron Patterson
2afd6c75f1 move complex logic to it's own method 2011-01-14 16:46:02 -08:00
Aaron Patterson
a0a69b045a loaded? will not raise an AR::RecordNotFound exception, so move the rescue inside the conditional 2011-01-14 15:58:59 -08:00
Aaron Patterson
c326969745 reduce funcalls by using falsey objects 2011-01-14 14:45:46 -08:00
Aaron Patterson
dc11a77ab7 write the delegate method directly to avoid delegate callstack overhead 2011-01-14 14:40:11 -08:00
Aaron Patterson
ef4ffed660 reduce some lasigns 2011-01-14 14:30:47 -08:00