José Valim
4f35d5a18b
Merge pull request #4007 from exviva/expand_cache_key_for_one_element_array
...
Fix expanding cache key for single element arrays
2011-12-16 14:40:09 -08:00
Xavier Noria
0065f37826
AS::Concern is not really needed for AR::Explain
2011-12-16 12:12:05 -08:00
José Valim
05316ba127
Merge pull request #4006 from devton/validation_error_on_message_is_empty_part_2
...
Fixed bug when error message is an empty string.
2011-12-16 11:24:45 -08:00
Antonio Roberto
66e747b461
Fixed bug when error message is an empty string.
2011-12-16 17:17:14 -02:00
Vijay Dev
5f6bcd74fd
Merge pull request #3780 from marcbowes/master
...
Fix favicon_link_tag help text
2011-12-16 11:13:39 -08:00
Vijay Dev
bd84b2bb5d
Merge branch 'master' of github.com:lifo/docrails
2011-12-16 23:34:00 +05:30
Olek Janiszewski
abe915f237
Fix expanding cache key for single element arrays
...
In short:
expand_cache_key(element) should not equal expand_cache_key([element])
This way a fragment cache key for an index page with only a single
element in the collection is different than a fragment cache for a
typical show page for that element.
2011-12-16 17:58:25 +01:00
Jon Leighton
f307f4d884
Delete obsolete comment
2011-12-16 14:52:02 +00:00
Jon Leighton
eba581846e
Fix the build on postgres. Note: we should probably actually make schema mutations bust the cache.
2011-12-16 14:51:22 +00:00
Jon Leighton
7b1eeea5bc
Should clear the primary keys cache also
2011-12-16 13:52:07 +00:00
Jon Leighton
7f20bb995a
Don't store defaults in the schema cache
2011-12-16 13:52:07 +00:00
Jon Leighton
dee94d8ab5
Defaults hash can go on the model
2011-12-16 13:52:07 +00:00
Jon Leighton
0b08ff7d92
Cache columns at the model level.
...
Allows two models to use the same table but have different primary keys.
2011-12-16 13:52:07 +00:00
José Valim
4fe76f4f27
Wait a full second so we have time for changes to propagate
2011-12-16 13:22:06 +01:00
José Valim
dbe28f3cb0
Fix failing asset test.
2011-12-16 11:43:29 +01:00
José Valim
6481bc5f49
Update CHANGELOGs and guides.
2011-12-16 10:45:59 +01:00
José Valim
654df86b7b
Show detailed exceptions no longer returns true if the request is local in production.
2011-12-16 10:45:59 +01:00
José Valim
192e55c38e
Do not raise an exception if an invalid route was generated automatically.
2011-12-16 10:45:59 +01:00
José Valim
5359262695
ShowExceptions should understand X-Cascade responses from exceptions app.
2011-12-16 10:45:59 +01:00
José Valim
7dd1c751f9
Improve the specs on exceptions app.
2011-12-16 10:45:59 +01:00
José Valim
02127e6406
Allow a custom exceptions app to set.
2011-12-16 10:45:59 +01:00
José Valim
deef8dd682
Extract the rendering of public exceptions pages into a Rack app.
2011-12-16 10:45:59 +01:00
José Valim
d142572567
Get rid of the close checks since we cannot reliably close the session anyway.
2011-12-16 10:45:59 +01:00
Piotr Sarnacki
8015f906d5
Merge pull request #4002 from arunagw/warning_removed_grouped_expression
...
Warning removed "warning: (...) interpreted as grouped expression"
2011-12-16 00:45:20 -08:00
Arun Agrawal
aa39149b2f
Warning removed "warning: (...) interpreted as grouped expression"
2011-12-16 10:30:20 +05:30
Xavier Noria
dbfc6b8b3a
removes Ruby constraint in RedCloth dependency
2011-12-15 15:22:14 -08:00
Xavier Noria
5e0dec5e10
it's -> its
2011-12-15 12:57:33 -08:00
Jon Leighton
2b22564c4e
Move DefaultScope and NamedScope under Scoping
2011-12-15 20:45:42 +00:00
Jon Leighton
17ad71e514
Let AttributeMethods do its own including etc
2011-12-15 20:45:42 +00:00
Jon Leighton
ceb33f8493
Split out most of the AR::Base code into separate modules 🍰
2011-12-15 20:45:37 +00:00
José Valim
8854bf29a3
Set up delegations also for to_a and arel branches.
2011-12-15 20:59:05 +01:00
José Valim
b17bc58c76
Move delegation reponsibilities of Relation to a module. Also precompile method missing calls for rofscale.
2011-12-15 20:47:26 +01:00
José Valim
1e8b751813
Make with_scope public so we stop using send 💣
2011-12-15 20:47:26 +01:00
Xavier Noria
22bd21dc0f
Merge pull request #3998 from rafacv/master
...
Small typo in Rails::Engine documentation
2011-12-15 11:09:30 -08:00
Rafael Valverde
4baf145375
Fixed small typo in the Rails::Engine documentation.
2011-12-15 17:03:19 -02:00
José Valim
1af2a1d0f5
Improve delegate list to avoid method missing.
2011-12-15 20:01:56 +01:00
José Valim
26e7400cc5
Fix diagnostics page for routing errors.
2011-12-15 19:43:49 +01:00
José Valim
283a087634
Clean up the cache before the request in case we are running in the reload_classes_only_on_change schema.
2011-12-15 18:48:10 +01:00
José Valim
de947c621d
There isn't a column_hash. It was being invoked by method missing.
2011-12-15 17:09:48 +01:00
Jon Leighton
8dba32f125
Fix #3987 .
2011-12-15 13:23:28 +00:00
José Valim
d7e714adac
Merge pull request #3994 from whilefalse/sass_cache_gitignore
...
Added .sass-cache/ directory to the genrated gitignore in engines.
2011-12-15 04:56:10 -08:00
Jon Leighton
0ddb9d6409
Merge pull request #3991 from akaspick/attrfix
...
Allow nested attributes in associations to update values in it's owner o...
2011-12-15 04:50:13 -08:00
Steven Anderson
54f60c1063
Added .sass-cache/ directory to the genrated gitignore in engines.
2011-12-15 12:38:52 +00:00
Alexander
bdcc27155d
Merge pull request #74 from abonec/master
...
Fixed typo in comments
2011-12-15 00:16:43 -08:00
José Valim
ad87752ad6
Merge pull request #3990 from ugisozols/master
...
Remove autoload for non-existent file
2011-12-14 21:10:47 -08:00
Uģis Ozols
8d827325d0
Remove autoload for non-existent file.
2011-12-15 06:52:42 +02:00
Aaron Patterson
e9382474fd
seed file was already tested for existence. ಠ_ಠ
2011-12-14 19:09:31 -08:00
Andrew Kaspick
774ff18c09
Allow nested attributes in associations to update values in it's owner object. Fixes a regression from 3.0.x
2011-12-14 20:13:03 -06:00
Nick Howard
dcd59f2d9f
escape assigns[:person], assigns[person] etc in actioncontroller testcase
2011-12-14 15:38:15 -07:00
Aaron Patterson
b6105b0b59
updating arel and journey dependencies
2011-12-14 13:26:49 -08:00
