TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
29,379 Commits 2 Branches 0 Tags 294 MiB
500c9a161c
Commit Graph

29379 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Santiago Pastorino
500c9a161c Revert "Merge pull request #5750 from ahoward/master" 
This reverts commit 174cf8b22064c3999dfa685014d5b31ac993bb54, reversing
changes made to 7ecd6a731bd60665bc6de94095137f0b2c4ada2a.
The reverted commit improved the performance in the wrong place, now we
have added this 6ddbd1844a6fd6aca2992f5f75c9f605cf89808f improvement.
 2012-04-08 22:44:37 -03:00
Santiago Pastorino
6ddbd1844a Inline the symbolize_keys/stringify_keys methods 
user     system      total        real
symbolize_keys  5.980000   0.070000   6.050000 (  6.048187)
new_symbolize_keys  4.310000   0.050000   4.360000 (  4.364745)
 2012-04-08 22:30:20 -03:00
Santiago Pastorino
2e43159959 Remove Fixnum#to_sym support in 1.8.7 2012-04-08 22:10:03 -03:00
Jeremy Kemper
9f37f335f2 Merge pull request #5718 from benedikt/master 
Removes caching from ActiveRecord::Core::ClassMethods#relation
 2012-04-08 11:30:18 -07:00
Jeremy Kemper
e4f911aa2a Fix a couple more script[type=text/javascript] tests affected by #5748 2012-04-08 07:28:31 -07:00
Jeremy Kemper
0032da1b3e Merge pull request #5748 from ai/no_type_in_html5 
Remove unnecessary in HTML 5 type attribute with default value
 2012-04-08 06:56:44 -07:00
Vijay Dev
d2726a9500 Merge pull request #5773 from trevor/patch-1 
url in comments - active_support/core_ext/integer/time.rb
 2012-04-08 02:20:55 -07:00
Trevor Wennblom
c5abd0604d update stdlib doc urls in comments - active_support/core_ext/[integer|numeric]/time.rb 
http://stdlib.rubyonrails.org/ last updated in 2005
 2012-04-07 19:03:49 -05:00
Xavier Noria
206974a97c adds a new test case for titleize 2012-04-08 01:10:08 +02:00
Piotr Sarnacki
0864d6d378 Merge pull request #5759 from romanvbabenko/refactor/rails_module_singleton_class_varibles 
Class variables has been fixed to Singleton instance variables at Rails ...
 2012-04-07 15:07:16 -07:00
Xavier Noria
af422bf3c5 Merge pull request #5772 from lest/patch-4 
use extract_options! in cycle helper
 2012-04-07 15:03:27 -07:00
Xavier Noria
4b685aad7b revises the regexp used in titleize 
The regexp used in titleize matches saxon genitive
and other contractions, only to call capitalize on
the captured text and have the apostrophe upcased
which yields the apostrophe itself. It is more
clear that the regexp matches just what it has to
match.
 2012-04-07 23:58:44 +02:00
Vijay Dev
cf9664adcf fix markup error [ci skip] 2012-04-08 02:13:51 +05:30
Vijay Dev
b653c29bbe avoid empty api pages 2012-04-08 01:56:41 +05:30
Sergey Nartimov
fd3f550c94 use extract_options! in cycle helper 2012-04-07 22:03:17 +03:00
Vijay Dev
bcd2269658 Merge branch 'master' of github.com:lifo/docrails 2012-04-07 22:11:47 +05:30
Ryan Bigg
ef493c9259 Don't use arel_table in published_and_commented example in querying guide 2012-04-07 11:29:18 -05:00
Vijay Dev
91b0ffc4fa Merge pull request #5766 from lest/patch-4 
pass default value as argument to fetch
 2012-04-07 08:04:44 -07:00
Vijay Dev
83d4ce6a25 Revert "Documents that ActiveRecord instances also support []/[]= methods for reading/writing attributes" 
This reverts commit a49fe6ec2cb9f22a3b18d7db5ae2ee90325e9d09.

Reason: The existing doc about using self[:attribute] is clear enough.
 2012-04-07 16:58:32 +05:30
Vijay Dev
5916403991 Revert "Where migration can get wrong help added" 
This reverts commit b11113f924d2eb2acbe836954d17a02163f45275.
 2012-04-07 16:47:32 +05:30
Vijay Dev
e0672a8e3b copy editing [ci skip] 2012-04-07 16:47:28 +05:30
Alexey Vakhov
c007d871e6 Fix example action dispatch in mime type 2012-04-07 14:54:55 +06:00
Sergey Nartimov
13688cf8a9 pass default value as argument to fetch 2012-04-06 22:18:21 +03:00
Rodrigo Rosenfeld Rosas
a49fe6ec2c Documents that ActiveRecord instances also support []/[]= methods for reading/writing attributes 
Only write_attribute and read_attribute were documented and there was no mention to this alternative.
 2012-04-06 11:32:22 -03:00
Anil Wadghule
871cc8c429 Fix 'Everyday Git' link 2012-04-06 14:50:45 +05:30
xyctka@gmail.com
5890ced113 Better class name 2012-04-06 10:04:26 +01:00
xyctka@gmail.com
74fa0d3db0 Update Custom Exception Handler section of Internationalization guide 
The previous example with just_raise_that_exception method
stopped working because MissingTranslation is not an instance of
Exception class any more, but has a +to_exception+ method.

Also the cleaner way is to re-raise only the desired exception, passing
 everything else to the default ExceptionHandler.

 Additionally this re-raising conflicts with Pluralization backend thus
 we have to add a check that certain missing translation keys should
 be ignored allowing the backend to fall back to the default
 pluralization rule.
 2012-04-06 10:01:34 +01:00
Roman V. Babenko
1e36e02df3 Class variables has been fixed to Singleton instance variables at Rails module 2012-04-06 07:59:57 +03:00
Xavier Noria
29089bf6fa revises requires of some AS deprecation files 2012-04-05 14:33:47 -07:00
Xavier Noria
8927987506 documents the contract for the argument of AD::Routing::RouteSet#url_for 2012-04-05 14:28:03 -07:00
Sandip Ransing
b11113f924 Where migration can get wrong help added 2012-04-06 01:11:42 +05:30
Sandip Ransing
e59b669792 Improvement to migration guide 2012-04-06 00:44:56 +05:30
Xavier Noria
e535faaee7 Merge pull request #5751 from rafaelfranca/fix-build 
Fix url_for when options is nil
 2012-04-05 11:44:17 -07:00
Rafael Mendonça França
ddbd1e4adb Make url_for work when option is nil and default_url_options has 
stringified keys
 2012-04-05 15:14:00 -03:00
Rafael Mendonça França
8f4cf26d69 Fix url_for when options is nil 
RouteSet#url_for was modifying the options hash that belong to the
caller
 2012-04-05 15:12:42 -03:00
José Valim
ca879d203b Merge pull request #5753 from carlosantoniodasilva/as-remove-require-and-warnings 
Remove circular require from AS Deprecation, and fix warnings
 2012-04-05 10:54:51 -07:00
Carlos Antonio da Silva
b621ded813 Initialize variables in file update checker to avoid warnings 2012-04-05 14:49:03 -03:00
Carlos Antonio da Silva
b1e55041eb Remove not used require from as to avoid circular requires 2012-04-05 14:48:01 -03:00
Vijay Dev
163258ba2a Merge branch 'master' of github.com:lifo/docrails 2012-04-05 22:30:30 +05:30
Vijay Dev
16512704fc lets not show too much output and shadow the intention [ci skip] 2012-04-05 22:28:47 +05:30
Vijay Dev
8a82204a42 minor fixes [ci skip] 2012-04-05 22:21:27 +05:30
Vijay Dev
c94e45088a fix boolean value in guide [ci skip] 2012-04-05 22:14:26 +05:30
Vijay Dev
ba60686ad9 Revert "Update activemodel rdoc links" 
This reverts commit ddb987551357d30301ab8cd99f4580988fa83340.

Reason: The links must be relative so that they will work both in edge
and stable api sites.
 2012-04-05 22:11:07 +05:30
Xavier Noria
64462039c0 Merge pull request #5182 from castlerock/content_tag_instead_string 
content_tag used instead string for option
 2012-04-05 09:39:17 -07:00
Aaron Patterson
174cf8b220 Merge pull request #5750 from ahoward/master 
mo fasta and mo betta the url_for
 2012-04-05 09:31:39 -07:00
Xavier Noria
7ecd6a731b Merge pull request #5707 from morgoth/remove-unnecessary-block-in-fetch 
removed unnecessary block when using fetch
 2012-04-05 08:55:19 -07:00
ara.t.howard
99c08c702e url_for: avoid a nil check. unroll a loop. handle most common case 1st. 2012-04-05 07:30:54 -06:00
José Valim
91cb99e9e4 Merge pull request #4446 from ayamomiji/patch-1 
prevent the cache sweeper ignores NoMethodError
 2012-04-05 06:20:02 -07:00
Xavier Noria
acae4fd4ed Merge pull request #3084 from esad/master 
Dependency fix for activesupport
 2012-04-05 05:57:22 -07:00
Xavier Noria
4adaf7bab4 Merge pull request #5747 from mneisen/patch-1 
Optimistic locking: lock_version needed type information.
 2012-04-05 04:52:44 -07:00