Commit Graph

18119 Commits

Author SHA1 Message Date
José Valim
b4f304b7b6 Fix a bug where symbols and strings were not behaving the same in the router. [#5431 state:resolved] 2010-08-24 10:26:25 -03:00
Andrew White
2fb0cbec02 When custom resource actions are specified using strings add the default name and action if the string is a valid ruby method name.
[#5431 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-24 10:26:25 -03:00
Krekoten' Marjan
a0284791df Fix test of generated Gemfile with mysql selected as DB driver
[#5435 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-08-24 09:38:20 -03:00
Andrew White
02aabbd19e Use symbols when specifying custom resource actions 2010-08-24 07:06:53 +01:00
Trevor Turk
cbacc9700e Note about how to exit the console in the Getting Started guide 2010-08-24 00:13:33 -05:00
David Heinemeier Hansson
21b1f29720 Master is now targeting 3.1.0.beta 2010-08-23 21:44:57 -05:00
David Heinemeier Hansson
96f3bcb816 Master is now targeting 3.1.0.beta 2010-08-23 21:43:47 -05:00
David Heinemeier Hansson
0d657132b0 mysql db defaults to mysql2 gem 2010-08-23 21:41:16 -05:00
David Heinemeier Hansson
3409f2c691 Depend on latest arel RC 2010-08-23 21:27:41 -05:00
Santiago Pastorino
363fe5faf9 Point guides to bundler 1.0.0.rc.6 2010-08-23 23:26:25 -03:00
David Heinemeier Hansson
b983145dfc Depend on latest Bundler RC 2010-08-23 21:24:22 -05:00
David Heinemeier Hansson
eb873f7133 Prefer the mysql2 gem for MySQL database.ymls 2010-08-23 21:19:53 -05:00
Santiago Pastorino
bb75c33754 Config is deprecated on 1.8.8 and 1.9.3 use RbConfig 2010-08-23 23:10:36 -03:00
Aaron Patterson
6f4d100761 marking sql literals as sql literals 2010-08-23 18:48:29 -07:00
Aaron Patterson
ecbdec115b making variable names a little more clear 2010-08-23 18:48:28 -07:00
José Valim
b6e28cea8c Update CHANGELOG for ActionPack. 2010-08-23 21:54:19 -03:00
Aaron Patterson
2e8e6e581f we should mark sql strings as sql literals 2010-08-23 14:28:15 -07:00
Aaron Patterson
5931a1dbd3 sql literal strings should be marked as sql literal strings 2010-08-23 13:57:22 -07:00
Aaron Patterson
ee9e1570be we should mark strings as SQL Literal values 2010-08-23 13:30:12 -07:00
Brian Lopez
6d796a71d2 mysql2 adapter is being maintained in the mysql2 gem itself
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-08-23 15:59:51 -03:00
Brian Lopez
bde3d7fbaf no need to depend on mysql2 master anymore
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-08-23 15:50:26 -03:00
Raimonds Simanovskis
2fc29524e1 use database from ARUNIT_DB_NAME environment variable when running tests on Oracle 2010-08-23 10:50:21 -07:00
Neeraj Singh
13ebf69ae4 unscoped does not work when chained with named_scope 2010-08-23 05:45:11 -04:00
Xavier Noria
3538dc0d7a removes words moved in previous edit of the generator generator USAGE 2010-08-23 09:44:56 +02:00
Xavier Noria
d0858cdf0e generators guide: edit pass 2010-08-23 09:40:37 +02:00
Xavier Noria
28c8d17d28 adds USAGE to the generator generator USAGE (not sure this meta thing is any good at 8:12 AM with little coffee) 2010-08-23 09:40:27 +02:00
Aaron Patterson
cdef4450e5 removing unused code 2010-08-22 17:15:56 -07:00
Raimonds Simanovskis
8f171b4d69 Do not use time zone in test_read_attributes_before_type_cast_on_datetime for Oracle database
As currently string_to_time method is not doing time zone conversion to database time zone
2010-08-22 16:35:55 -07:00
Raimonds Simanovskis
f82b1e756a updated test_should_record_timestamp_for_join_table for Oracle 2010-08-22 16:35:48 -07:00
Santiago Pastorino
04ee54f3fc Bump up rack-mount to 0.6.12 2010-08-22 20:28:37 -03:00
Xavier Noria
b587bfd589 Merge remote branch 'rails/master' 2010-08-23 01:21:43 +02:00
Santiago Pastorino
9992a1a4bf type fixed 2010-08-22 19:59:36 -03:00
Santiago Pastorino
8d1ee434da Silence warnings for Encoding.default_external= and Encoding.default_internal= 2010-08-22 18:43:31 -03:00
Andrew White
ae2c60734a Cache the symbolized path parameters using a instance variable in the request object rather than the environment hash. This it to prevent stale parameters in later routing constraints/redirects as only the normal path parameters are set by Rack::Mount.
Also if a constraint proc arity is more than one, pass the symbolized path parameters
as the first argument to match redirect proc args and provide easier access.

[#5157 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-22 16:17:26 -03:00
Santiago Pastorino
d79a010976 Set default_internal and default_external on AS for testing purposes 2010-08-22 02:23:41 -03:00
Santiago Pastorino
3c0158955a Set default_internal and default_external on AM for testing purposes 2010-08-21 22:53:04 -03:00
Santiago Pastorino
1d888d465b Move encoding settings for testing purposes to abstract_unit file 2010-08-21 22:37:53 -03:00
Raphomet
7a090b0216 Trifling typos
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-08-21 19:20:42 -03:00
Evgeniy Dolzhenko
c0549ed2e5 Fix docs to reference ActiveRecord::LogSubscriber
since Rails::LogSubscriber doesn't seem to be defined anymore
2010-08-21 09:39:37 +04:00
Brian Lopez
82e389ed30 reload bob after his journy to a new timezone 2010-08-20 20:00:03 -07:00
Jeremy Kemper
c211d904ba Revert "Just add connection management middleware if running in a concurrent environment."
This reverts commit 6b29dc876fe185881d46731c3ae170478a3828fe.
2010-08-20 18:55:02 -07:00
Xavier Noria
3cd9627bd8 prevent RDoc from autolinking "Rails" in the API home page 2010-08-21 02:25:45 +02:00
Xavier Noria
63bb639036 requires horo 1.0.2 2010-08-21 02:25:45 +02:00
Nick Sieger
2277c51555 Fix hash modification during iteration in Mapper [#5420]
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-08-20 18:27:02 -03:00
Andrew White
7c9bf45b0d Support routing constraints in functional tests
Extend assert_recognizes and assert_generates to support passing
full urls as the path argument. This allows testing of routing
constraints such as subdomain and host within functional tests.

[#5005 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-20 14:51:25 -03:00
Aaron Patterson
0420fb5647 adding FOUND_ROWS to the connect flags for mysql2 2010-08-20 10:16:22 -07:00
Xavier Noria
0c75ec51a9 Merge remote branch 'rails/master' 2010-08-20 17:18:57 +02:00
Neeraj Singh
87398e531d Patch for Lighthouse ticket #5419 has been been applied. So reverting this one.
Revert "documentation regarding after_validation"

This reverts commit c24aa2f2dca52e1b0ee644e407389f6e89f53007.
2010-08-20 11:08:25 -04:00
Neeraj Singh
2ffa50f5a9 after_validation should be called irrespective of the result of validation.
I confirmed that this is the behavior on 2.3.x .

[5419 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-20 11:24:43 -03:00
Neeraj Singh
c24aa2f2dc documentation regarding after_validation 2010-08-20 09:48:07 -04:00