Commit Graph

21210 Commits

Author SHA1 Message Date
Jon Leighton
532f915037 Referencing a table via the ON condition in a join should force that table to be eager-loaded via a JOIN rather than via subsequent queries. 2011-03-07 08:51:17 -08:00
Aaron Patterson
9cee693213 Merge branch 'master' of github.com:rails/rails
* 'master' of github.com:rails/rails: (44 commits)
  Fixed indentation in actionmailer base_test [#6538 state:committed]
  remove unused assigned variable
  removes merge conflicts
  removes Examples headers introduced in 9b96de6
  Revert "Fixed identation in actionmailer base_test"
  Report the correct value of nil.id in the exception message as different ruby implementations may have different values, for example Rubinius returns 53 for nil.id.
  Improve testing of cookies in functional tests: - cookies can be set using string or symbol keys - cookies are preserved across calls to get, post, etc. - cookie names and values are escaped - cookies can be cleared using @request.cookies.clear
  more style changes
  Some style changes
  style changes
  Revert "style changes"
  Raise ArgumentError if route name is invalid [#6517 state:resolved]
  style changes
  Allow model to be inherited from Hash [#6487 state:resolved]
  styles applied for usage
  added failing test for fields_for with a record object that inherits from Hash
  Fixed identation in actionmailer base_test
  wrong SQL statement
  commas to set off expressions that interrupt sentence flow
  typo changes
  ...
2011-03-07 08:50:50 -08:00
Xavier Noria
2159e9eb64 Merge branch 'active_model_unused_variable' of https://github.com/pacoguzman/rails into pacoguzman-active_model_unused_variable 2011-03-07 00:44:57 +01:00
Dalibor Nasevic
c528297d17 Fixed indentation in actionmailer base_test [#6538 state:committed]
Signed-off-by: Xavier Noria <fxn@hashref.com>
2011-03-07 00:37:45 +01:00
Paco Guzman
7e9d45cc7f remove unused assigned variable 2011-03-06 22:24:22 +01:00
Xavier Noria
3a621e7be4 removes merge conflicts 2011-03-06 20:34:56 +01:00
Xavier Noria
89d825d021 Merge branch 'master' of git://github.com/lifo/docrails 2011-03-06 17:52:30 +01:00
Xavier Noria
6ce844a3c1 removes Examples headers introduced in 9b96de6
Example headers are discouraged in the API guidelines.
Code just flows with the text. They may be good in
places where there's a lot of stuff and structure may
add clarity
2011-03-06 17:49:39 +01:00
Xavier Noria
8bbc5b4f5f Revert "Fixed identation in actionmailer base_test"
Please excuse the revert. Albeit the commit is totally
innocent, docrails has a strong no-code policy we need
to enforce. Please feel free to submit the fix as a
patch and assign it to me, I'll apply right away.

This reverts commit d8462510c5378f9204778ffb9df4fdbece7dccd0.
2011-03-06 17:42:42 +01:00
Andrew White
5e7ce47fb9 Report the correct value of nil.id in the exception message
as different ruby implementations may have different values,
for example Rubinius returns 53 for nil.id.

[#6444 state:resolved]
2011-03-06 15:23:31 +00:00
Andrew White
31f09f9dbc Improve testing of cookies in functional tests:
- cookies can be set using string or symbol keys
- cookies are preserved across calls to get, post, etc.
- cookie names and values are escaped
- cookies can be cleared using @request.cookies.clear

[#6272 state:resolved]
2011-03-06 12:49:44 +00:00
suchasurge
b99fb66fb7 more style changes 2011-03-06 10:44:52 +01:00
suchasurge
9b96de6f3d Some style changes 2011-03-06 10:26:24 +01:00
JudeArasu
ac59a2a1d6 style changes 2011-03-06 12:55:56 +05:30
JudeArasu
2cd3dcabe2 Revert "style changes"
This reverts commit 1d4826937e438ebcd6a2f9e29d2e466a43fef7a8.
2011-03-06 12:53:23 +05:30
Andrew White
e00867bc43 Raise ArgumentError if route name is invalid [#6517 state:resolved] 2011-03-06 07:08:50 +00:00
JudeArasu
1d4826937e style changes 2011-03-06 11:38:18 +05:30
Alexander Uvarov
0509bf35f1 Allow model to be inherited from Hash [#6487 state:resolved]
Signed-off-by: Andrew White <andyw@pixeltrix.co.uk>
2011-03-06 05:28:35 +00:00
JudeArasu
e80db417ed styles applied for usage 2011-03-06 10:53:44 +05:30
Diego Carrion
dff73dec22 added failing test for fields_for with a record object that inherits from Hash
Signed-off-by: Andrew White <andyw@pixeltrix.co.uk>
2011-03-06 05:18:56 +00:00
Aaron Patterson
09d3e89cf0 use sort_by instead of sort() 2011-03-05 20:01:06 -08:00
Dalibor Nasevic
d8462510c5 Fixed identation in actionmailer base_test 2011-03-06 00:27:37 +01:00
Aaron Patterson
74818a3543 use Arel::Table#alias rather than passing the :as parameter 2011-03-05 11:56:24 -08:00
Akira Matsuda
22faa2c86d wrong SQL statement 2011-03-06 03:29:23 +09:00
Xavier Noria
9092052cb0 merges rails 2011-03-05 12:06:43 +01:00
Xavier Noria
2076817629 revises the RDoc of Hash#reverse_merge 2011-03-05 11:57:32 +01:00
Xavier Noria
f6a5449d43 copy-edits 819762c
* simplifies some sentences
* use a more neutral language with less you/yours
2011-03-05 11:57:32 +01:00
Xavier Noria
5f99a899a8 copy-edits 108561f 2011-03-05 11:57:32 +01:00
JudeArasu
b12a4a9296 typo changes 2011-03-05 11:57:32 +01:00
R.T. Lechow
737abe4b4d Railties typos. 2011-03-05 11:56:35 +01:00
R.T. Lechow
87e9e3f9af Action Pack typos. 2011-03-05 11:56:35 +01:00
R.T. Lechow
a1b4d8e7b2 Active Record typos. 2011-03-05 11:56:34 +01:00
R.T. Lechow
273700cbd0 Active Support typos. 2011-03-05 11:56:34 +01:00
R.T. Lechow
48841dd6ae Active Resource typos. 2011-03-05 11:56:34 +01:00
R.T. Lechow
86c15d8b89 Active Model typos. 2011-03-05 11:56:34 +01:00
tashian
e95b965926 Properly escaped a + in the dynamic segments TIP 2011-03-05 11:56:33 +01:00
Jonathon D. Jones
3eca9d5b43 Adds link to Object.blank? from Object.present? 2011-03-05 11:56:33 +01:00
mjy
045ca30394 fixes a missmatched column in example 2011-03-05 11:56:33 +01:00
JudeArasu
d735672aa5 Spelling mistake 2011-03-05 11:56:33 +01:00
Dalibor Nasevic
3457db712e Correct spelling for Base64 in action_mailer 2011-03-05 11:56:33 +01:00
Dalibor Nasevic
3673a6981e Removed link to un-existing Issues page on Github 2011-03-05 11:56:33 +01:00
Lars Smit
9b01284c3e Added some new advice on applying patches 2011-03-05 11:56:32 +01:00
Ben Orenstein
67af97c4c1 Fix incorrect example. 2011-03-05 11:56:32 +01:00
Ben Orenstein
ea6a2b7c11 Fix incorrect word. 2011-03-05 11:56:32 +01:00
Rodrigo Navarro
3f97f056f9 Pointing out that dynamic_form plugin must be installed to be able to use error_messages and error_messages_for view helpers. 2011-03-05 11:56:32 +01:00
Ben Orenstein
eef713dd66 Clean up wording. 2011-03-05 11:56:31 +01:00
Vijay Dev
e15973ce7c use resources in place of map.resources 2011-03-05 11:56:31 +01:00
Ben Orenstein
f305c60816 Clarify comment by removing french reference ('a la'). Should improve readability for non-native english speakers. 2011-03-05 11:56:31 +01:00
Ben Orenstein
ac4c5e9722 Example descriptions and their examples were flipped. Fix. 2011-03-05 11:56:31 +01:00
Ben Orenstein
8f526b30f4 Warn people that these methods are deprecated. 2011-03-05 11:56:31 +01:00