TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
4,053 Commits 2 Branches 0 Tags 294 MiB
5589c734a8
Commit Graph

4053 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jeremy Kemper
5589c734a8 Improve yaml fixtures error reporting. Closes #6205. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5104 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-13 23:31:54 +00:00
Jeremy Kemper
9aeddc5538 script/server creates the tmp/pids directory. Closes #6204. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5103 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-13 23:25:02 +00:00
David Heinemeier Hansson
6b70c799f8 All verbs should use formatted urls [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5097 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-13 04:14:18 +00:00
David Heinemeier Hansson
73a8d7393f Make sure that formatted routes for all verbs are created. Still needs to resolve two failing tests after this refactoring [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5096 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-13 04:04:19 +00:00
Jeremy Kemper
89840c40ce Load helpers in alphabetical order for consistency. Resolve cyclic javascript_helper dependency. Closes #6132, closes #6178. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5095 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-12 22:07:18 +00:00
Jeremy Kemper
7661c2b50a Skip params with empty names, such as the &=Save query string from <input type=submit/>. Closes #2569. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5094 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-12 20:57:09 +00:00
Jeremy Kemper
74f60c032e alias_method_chain works with accessor= methods also. Closes #6153. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5091 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-12 07:10:43 +00:00
Jeremy Kemper
3c0e7b1b51 Fix script/console --sandbox for internal transactions changes. Closes #5738. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5088 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-12 01:17:11 +00:00
David Heinemeier Hansson
b0a32f85c2 test svn 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5087 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-12 01:09:52 +00:00
Jamis Buck
3f0952d9df Fix assert_tag so that :content => "foo" does not match substrings, but only exact strings. Use :content => /foo/ to match substrings. closes #2799 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5086 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-10 02:51:38 +00:00
Jamis Buck
5bf41ed8bc Add test case to test attribute matching by assert_tag 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5082 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-09 22:05:21 +00:00
Jamis Buck
45b5555f4c Make mime version default to 1.0. closes #2323 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5081 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-09 21:56:38 +00:00
Jamis Buck
4d9ca4d9fb Make sure quoted-printable text is decoded correctly when only portions of the text are encoded. closes #3154. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5080 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-09 21:14:43 +00:00
Jamis Buck
3e7aa0391f Make sure DOS newlines in quoted-printable text are normalized to unix newlines before unquoting. closes $166 and #4452 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5079 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-09 20:16:42 +00:00
Jeremy Kemper
0a84624bd7 Optimistic locking: raise ActiveResource::ResourceConflict on 409 Conflict response. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5078 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-09 00:11:12 +00:00
David Heinemeier Hansson
2c6747f858 Split Form.serialize into Form.serialize and Form.serializeElements. The latter can be used stand-alone to serialize an array of elements you pass in, instead of the entire form [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5077 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-08 22:12:40 +00:00
David Heinemeier Hansson
e2d8451024 We cant make MySQL 5 happy if it means making SQLite and PostgreSQL cry. So currently MySQL 5 is not fully supported for Rails when youre using eager loading (closes #6133, #6135). I have contacted MySQL to make them fix http://bugs.mysql.com/bug.php?id=13551 [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5075 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-08 22:01:00 +00:00
David Heinemeier Hansson
d7e4f5f22e Since to_sing, we need to check for empty string 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5074 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-08 19:23:33 +00:00
David Heinemeier Hansson
84bfdafa08 Added parentheses around FROM clauses generated by Base and associations since MySQL 5 claim that to be the standard (and will screw up joins if its not there), see http://bugs.mysql.com/bug.php?id=13551 [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5073 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-08 18:14:02 +00:00
Jeremy Kemper
f1b639cffb Update descriptive messages for exceptions thrown by cgi_methods. Closes #6103. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5070 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-08 07:25:14 +00:00
Rick Olson
8d9e6609f8 Basic validation support [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5068 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-08 00:07:30 +00:00
Jeremy Kemper
7c4b6a55b6 Rollback [4917]. Closes #785. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5067 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-07 21:34:35 +00:00
Nicholas Seckar
9d9ac01c7d Add descriptive messages to the exceptions thrown by cgi_methods. Closes #6091. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5066 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-07 20:10:14 +00:00
Nicholas Seckar
840b5763ff Too much dotware 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5065 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-07 16:55:59 +00:00
Nicholas Seckar
e3c2151f7f Remove the uncanny default of adding all app/models/*/ directories to the load path. References #6031. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5064 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-07 16:53:58 +00:00
Thomas Fuchs
a5df861852 Fix loop_on_multiple_args to work, again (not my day), fixes #6078 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5063 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-07 14:16:58 +00:00
Thomas Fuchs
cb6309bcc9 Ahem, now for real 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5062 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-07 12:57:39 +00:00
Thomas Fuchs
984312cf85 Fix a warning in prototype_helper_test, fixes #6077 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5061 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-07 12:56:48 +00:00
Thomas Fuchs
8734da9bca Update JavaScriptGenerator#show/hide/toggle/remove to new Prototype syntax for multiple ids, fixes #6068 [petermichaux@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5057 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-07 09:19:35 +00:00
Nicholas Seckar
00685ad8fd Update UrlWriter to support :only_path. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5054 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-06 22:21:36 +00:00
Nicholas Seckar
93659978d5 Fix loadable_constants_for_path to handle load paths that do not end with a slash. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5053 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-06 20:31:28 +00:00
David Heinemeier Hansson
5a5f85d5be Get symbol definitions of methods converted to strings [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5045 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-06 04:00:37 +00:00
Rick Olson
5360e47431 added passing test for using partials with an xml builder 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5044 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-06 03:51:45 +00:00
David Heinemeier Hansson
83313fccc0 Backed out of locals hash as it caused trouble with Builder, see ticket for more 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5043 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-06 03:38:11 +00:00
David Heinemeier Hansson
8c9ce617c9 Fixed JavaScriptHelper#link_to_function and JavaScriptHelper#button_to_function to have the script argument be optional [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5039 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-06 01:31:04 +00:00
Nicholas Seckar
7441b19d0c Fix logic error in determining what was loaded by a given file. Closes #6039. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5035 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-05 23:36:14 +00:00
David Heinemeier Hansson
951b4d2799 Still need the regular assertions 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5028 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-05 23:04:14 +00:00
Nicholas Seckar
1d554b84f8 Equate Kernel.const_missing with Object.const_missing. Fixes #5988. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5023 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-05 22:36:28 +00:00
David Heinemeier Hansson
bd09d9aafb caller is necessary for proper trace in deprecation 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5021 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-05 22:08:33 +00:00
David Heinemeier Hansson
9598176390 Better bundling of new assertions and make integration tests work again 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5020 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-05 21:28:22 +00:00
David Heinemeier Hansson
85fbb22f07 Backed out of new_record? to new? transformation as it would screw up existing models that did boolean calls on "new" attributes [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5018 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-05 18:54:24 +00:00
David Heinemeier Hansson
9d7e6432b2 Deprecated ActiveRecord::Base.new_record? in favor of ActiveRecord::Base.new? (old version still works until Rails 2.0) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5017 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-05 18:48:10 +00:00
David Heinemeier Hansson
d48322ecca Proper description syntax for test tasks (closes #5308) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5016 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-05 15:35:50 +00:00
Thomas Fuchs
4f68dcb035 Update to script.aculo.us 1.6.3 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5015 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-05 10:42:41 +00:00
Kent Sibilev
7cdd0d6ecf Don't convert value if it's already of an appropriate type. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5013 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-05 04:37:43 +00:00
Sam Stephenson
899c1b0157 Update to Prototype 1.5.0_rc1 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5012 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-05 04:17:06 +00:00
Jeremy Kemper
26b76ea4ce load expects a Hash 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5008 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-05 00:02:17 +00:00
Michael Koziarski
b445ab986a Rename quote to quote_value so the name can be used in AR models. #3628 [Koz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5007 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-04 23:41:13 +00:00
Jeremy Kemper
97487c4e11 load nil is noop. use new? instead of new_resource? 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5006 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-04 23:36:13 +00:00
David Heinemeier Hansson
1d4d037b0d Added access to nested attributes in RJS (closes #4548) [richcollins@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5004 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-04 20:54:10 +00:00