TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
52,830 Commits 2 Branches 0 Tags 294 MiB
578618d8e6
Commit Graph

52830 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Rafael Mendonça França
578618d8e6 Merge pull request #21366 from amitsuroliya/remove_unused_variable 
Remove more unused block arguments
 2015-08-25 14:08:17 -03:00
amitkumarsuroliya
8f0073bba1 Remove more unused block arguments 2015-08-25 22:23:23 +05:30
Rafael Mendonça França
9eb7ee2cda Merge pull request #21374 from rodzyn/protected_not_needed 
Make `assert_index` private
 2015-08-25 13:03:46 -03:00
Marcin Olichwirowicz
a1772bba5d Make assert_index private 
This `protected` keyword looks like some leftover, since
we are not using explicit receiver, this should go under `private`
 2015-08-25 17:58:51 +02:00
Rafael Mendonça França
e84cc9afe4 Merge pull request #21345 from aditya-kapoor/trim-ap 
Trim out least needed controllers from AP test suite
 2015-08-25 12:44:34 -03:00
Santiago Pastorino
61ebc20cdf Merge pull request #21372 from yui-knk/fix/revert_change_column_default 
Make `change_column_default` to work
 2015-08-25 12:19:20 -03:00
Rafael Mendonça França
57105d99bc Merge pull request #21371 from NehaGautam/neha-remove_set 
remove unused require ‘set’
 2015-08-25 12:04:25 -03:00
Robin Dupret
f59de082bf Fix a tiny typo [ci skip] 2015-08-25 16:13:34 +02:00
Robin Dupret
f150decfe2 A quick pass over the testing guide 
* Fixtures are loaded for all the tests by default (not only model and
  controller tests).
* Fix a few typos and improve the markup at some levels.
* Wrap changes to 80 chars

[ci skip]
 2015-08-25 16:13:34 +02:00
yui-knk
c90008a86e Make change_column_default to work 
This is fix of #20018 which removes `change_column_default` from
array, so `CommandRecorder#method_missing` catches
`change_column_default` and @delegate's method is called.

This PR

* fix this bug
* define `ReversibleAndIrreversibleMethods` const making clear
  which this array means to prevent these miss
 2015-08-25 22:40:15 +09:00
NehaGautam
c23e06c969 remove unused require ‘set’ 2015-08-25 18:54:53 +05:30
Robin Dupret
a70e6f1cb3 Merge pull request #21074 from vrybas/rdoc-fix-typo-belongs-to-inverse-of-class-name 
RDoc: fix wrong model name `:inverse_of` with `:belongs_to` [ci skip]
 2015-08-25 15:04:28 +02:00
Yves Senn
211c31d271 Merge pull request #21369 from agrimm/documentation_fix_21364 
[ci skip] Fix #21364 error in documentation about ActiveRecord::Enum
 2015-08-25 13:32:59 +02:00
Andrew Grimm
4c4aaa4aa3 [ci skip] Fix #21364 error in documentation about ActiveRecord::Enum 2015-08-25 18:39:33 +10:00
Rafael Mendonça França
f3e68ec16a Merge pull request #21094 from aditya-kapoor/add-missing-ap-tests 
add missing test for action regexp for routing
 2015-08-25 03:10:23 -03:00
Rafael Mendonça França
72f2dd49b1 Merge pull request #21365 from justanshulsharma/remove_unused_variable 
Remove unused block arguments
 2015-08-25 01:18:21 -03:00
Anshul Sharma
7b1c783630 Remove unused block arguments 2015-08-25 09:31:12 +05:30
Rafael Mendonça França
aaacc67fe2 Merge pull request #21363 from amitsuroliya/remove_unused_variable 
Remove unused block arguments
 2015-08-24 23:29:02 -03:00
amitkumarsuroliya
65c4076927 Remove unused block arguments 2015-08-25 07:49:47 +05:30
Aaron Patterson
211f55d4fd use caller_locations instead of caller 
We have `caller_locations`, so we don't need to parse the strings in the
callstack.
 2015-08-24 18:39:35 -07:00
Aaron Patterson
c82248ea86 remove more direct env mutations 2015-08-24 17:07:48 -07:00
Aaron Patterson
d4e1f58fd8 remove another @env access 2015-08-24 16:39:47 -07:00
Aaron Patterson
cccc759ff7 remove more direct access to env 2015-08-24 16:14:42 -07:00
Aaron Patterson
a1ff5585bd fewer calls to env 
We don't want to directly access the env hash
 2015-08-24 15:59:30 -07:00
Rafael Mendonça França
f5f4d135a2 Merge pull request #21361 from olleicua/master 
minor documentation improvement [ci skip]
 2015-08-24 19:37:29 -03:00
Aaron Patterson
c25cf09c13 override controller_class on the request 
Just like the other places.  We need to refactor this because the code
is almost identical to that in the action pack tests
 2015-08-24 15:18:29 -07:00
Sam Auciello
12208d4f66 minor documentation improvement [ci skip] 2015-08-24 18:00:40 -04:00
Aaron Patterson
c4c5918b68 stop using @env in the GET / POST methods 
I want to implement this with something besides `@env` in the future, so
lets stop directly referencing it.
 2015-08-24 14:57:05 -07:00
Aaron Patterson
ec9c237acc rm useless method 
superclass already has this method, so remove this one
 2015-08-24 14:21:27 -07:00
Aaron Patterson
7a62cc7d22 remove dead code 💣 2015-08-24 14:11:37 -07:00
Aaron Patterson
9b20b1cc0f pull up dispatcher allocation 
the dispatcher class isn't configurable anymore, so pull up allocation
to the method that needs it.
 2015-08-24 14:05:54 -07:00
Aaron Patterson
59e3b648c3 directly ask the request for the controller class 
Now that we don't have subclasses depending on this method (they augment
the request class instead of the dispatch class) we can remove this
method and directly ask the request object for the controller class
 2015-08-24 14:01:11 -07:00
Aaron Patterson
74020eb255 use make_set helper method to generate route sets 
We should keep the route set generation logic in one place
 2015-08-24 13:59:40 -07:00
Aaron Patterson
b0e7db9ad9 remove useless ivar 2015-08-24 13:49:52 -07:00
Aaron Patterson
31cc4d621f remove setter for the dispatcher class 
we don't need it anymore.  We always use the same dispatcher in tests.
 2015-08-24 13:49:52 -07:00
Aaron Patterson
2237ee0596 subclass and delegate rather than mutating existing objects 
If we subclass and augment the superclass, then we don't need to have
setters for particular things on the superclass.
 2015-08-24 13:49:52 -07:00
Rafael Mendonça França
bd94e6de37 Merge pull request #21359 from Gaurav2728/gaurav-remove_unused_require_file 
temp files are no more require
 2015-08-24 17:10:41 -03:00
Gaurav Sharma
a50872d51d temp files are no more require 
`💅`
 2015-08-25 01:36:05 +05:30
Aaron Patterson
337684fa28 use a custom request class to determine the controller class 
controller class resolution has been moved to the request object, so we
should override that method instead of relying on the RouteSet to
generate the controller class.
 2015-08-24 12:06:41 -07:00
Rafael Mendonça França
518ae9f055 Pass the correct formats 2015-08-24 15:36:14 -03:00
Rafael Mendonça França
face604266 Pass formats to lookup_context 
Before we were changing the state of the lookup_context for the duration
of the with_layout_format block, but since we already know the formats
we can just pass it explicitly.

Related with 8d7ce0f22aee09d20091a4dc58cb379a09d13e26
 2015-08-24 15:16:59 -03:00
Rafael Mendonça França
b58808ed6a Allow release when CHANGELOG is changed 2015-08-24 15:07:27 -03:00
Nick Sutterer
c0daa02c24 remove useless case in #resolve_layout. 2015-08-24 15:07:25 -03:00
Nick Sutterer
8d7ce0f22a remove LookupContext#with_layout_format by passing formats for layouts explicitely. 2015-08-24 15:07:25 -03:00
Robin Dupret
be19bf3728 Merge pull request #21354 from yui-knk/fix/migration_file_timestamp 
[ci skip] Fix migration file's timestamp
 2015-08-24 19:04:50 +02:00
Carlos Antonio da Silva
35decf4b6b Merge pull request #21339 from deepj/unused-block-arguments 
Remove unused block arguments
 2015-08-24 13:40:03 -03:00
Rafael Mendonça França
9e5ba3c86b Merge pull request #21355 from akihiro17/remove-variables 
Remove unused variables
 2015-08-24 13:36:10 -03:00
Rafael Mendonça França
c5abac2b31 Merge pull request #21342 from yui-knk/test/add_assert_method 
Add `assert_nothing_raised` to make clear test case perpose
 2015-08-24 13:19:39 -03:00
Rafael Mendonça França
1c1ad2b746 Merge pull request #21267 from davidcornu/rails-server-port-env-var 
Use the PORT environment variable for rails server
 2015-08-24 12:11:36 -03:00
Sean Griffin
35161a7f53 Further fix failing tests caused by #21350 2015-08-24 08:10:48 -06:00