Commit Graph

2158 Commits

Author SHA1 Message Date
Michael Koziarski
59709d9188 Ensure radio_button works as expected with values other than strings.
Thanks to:
*  grant.mcinnes@utoronto.ca
*  rails@jeffcole.net



git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2573 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-14 02:07:51 +00:00
Jeremy Kemper
acb80e3d0e Escape query strings in the href attribute of URLs created by url_helper. #2333
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2572 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-13 22:44:45 +00:00
Nicholas Seckar
2cad95d851 Improved line number reporting for template errors
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2571 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-13 21:58:20 +00:00
David Heinemeier Hansson
c45ea78c6a Cleaned it up a bit.. Dependencies can be declared inline
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2570 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-13 20:55:05 +00:00
Marcel Molina
ebf618b7fc Delegate access to a customized primary key to the conventional id method. Closes #2444.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2569 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-13 20:44:39 +00:00
David Heinemeier Hansson
f0448f5631 Fixed that Time#change should also reset usec when also resetting minutes #2459 [ikeda@dream.big.or.jp]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2568 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-13 20:28:55 +00:00
David Heinemeier Hansson
43b6a74fb1 Added :locals support for render :inline #2463 [mdabney@cavoksolutions.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2567 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-13 20:26:39 +00:00
David Heinemeier Hansson
e646786a76 Refactored cleanly
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2564 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-13 20:04:13 +00:00
Jeremy Kemper
e4b3f8b0eb Fix Logger compatibility test
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2563 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-13 20:02:49 +00:00
Jamis Buck
99f3ae0845 Fix errors caused by assigning a has-one or belongs-to property to itself
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2562 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-13 19:21:45 +00:00
Jeremy Kemper
2f9a19cb83 git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2561 5ecf4fe2-1ee6-0310-87b1-e25e094e27de 2005-10-13 19:06:23 +00:00
Jeremy Kemper
88c3416ffd r3581@sedna: jeremy | 2005-10-13 12:20:42 -0700
Preserve order of fixture declarations.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2560 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-13 19:06:15 +00:00
Jeremy Kemper
a04d80b753 r3580@sedna: jeremy | 2005-10-13 12:03:37 -0700
svn:ignore AR debug.log


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2559 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-13 19:06:09 +00:00
Jeremy Kemper
33eb297edf r3579@sedna: jeremy | 2005-10-13 12:02:01 -0700
decrease need to edit AR mysql connect details by setting socket to mysql_config --socket.  if it doesn't work on your platform, well, you would've had to edit it anyway.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2558 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-13 19:06:04 +00:00
Jeremy Kemper
896c9c9d69 r3578@sedna: jeremy | 2005-10-13 12:00:03 -0700
svn:ignore both sqlite and sqlite3 db fixtures


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2557 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-13 19:05:59 +00:00
Jeremy Kemper
effe522515 r3577@sedna: jeremy | 2005-10-13 11:55:20 -0700
Add in_memory_connection for SQLite3 AR tests.  Uses :dbfile => ':memory:' so we don't have to manage db files.  It seems a bit quirky, so I'm including it as a separate connection type until we iron out the details.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2556 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-13 19:05:54 +00:00
Jeremy Kemper
6627b828a1 r3576@sedna: jeremy | 2005-10-13 11:31:50 -0700
Update fcgi_dispatcher_test for old changes to the FCGI handler: processing attr was removed, USR1 behaves the same (sets when_ready = :exit) whether or not currently handling request.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2555 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-13 19:05:48 +00:00
Jeremy Kemper
9a7ff1433a r3575@sedna: jeremy | 2005-10-13 11:22:13 -0700
Eliminate warning for redefined MemCache constant.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2554 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-13 19:05:41 +00:00
Jeremy Kemper
9c8227973c r3574@sedna: jeremy | 2005-10-13 11:16:51 -0700
More precise Logger version test to account for distributions that don't keep Ruby and its stdlib in sync.  Logger#silence yields self for convenience.  Logger unit tests.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2553 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-13 19:05:32 +00:00
Jamis Buck
634da0f010 Fix script/server to use the environment given by the -e toggle
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2552 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-13 18:13:22 +00:00
Sam Stephenson
4b72a4b12f Unset the X-Requested-With header when using the xhr wrapper in functional tests. Closes #2352.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2551 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-13 18:09:27 +00:00
Tobias Lütke
f60f76eab0 modified javascript_helper testcase to back up #2097
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2550 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-13 17:39:14 +00:00
Sam Stephenson
24c3599cc0 Support using different database adapters for development and test with ActiveRecord::Base.schema_format = :ruby
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2549 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-13 04:12:32 +00:00
Marcel Molina
140a5f8f7b Optimize postgresql selects.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2548 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-13 03:01:33 +00:00
Jamis Buck
a91423ed5b Make webrick work with session(:off)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2547 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-13 00:05:32 +00:00
Marcel Molina
af0df03fd3 Update DB2 adapter. Closes #2206.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2546 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-12 23:42:54 +00:00
Marcel Molina
f175547e58 Corrections to SQLServer native data types. Closes #2267.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2545 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-12 23:13:07 +00:00
Marcel Molina
d4576673c0 Unescape paths before writing cache to file system. Closes #1877.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2544 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-12 22:57:04 +00:00
Sam Stephenson
f49dc37e71 Wrap javascript_tag contents in a CDATA section and add a cdata_section method to TagHelper. Closes #1691.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2543 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-12 22:47:39 +00:00
Marcel Molina
b840e4ed50 Deprecated ActiveRecord::Base.threaded_connection in favor of ActiveRecord::Base.allow_concurrency.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2542 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-12 22:37:28 +00:00
Marcel Molina
0e0e774085 Protect id attribute from mass assigment even when the primary key is set to something else. Closes #2438.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2541 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-12 19:59:13 +00:00
Marcel Molina
f0b2b637ea Add test coverage for customized primary keys including a failing test for #2444.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2540 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-12 19:55:46 +00:00
Jamis Buck
de42f26df7 Make sure ENV['RAILS_ENV'] and RAILS_ENV are kept in sync
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2539 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-12 12:44:03 +00:00
Jamis Buck
42bcbcb043 Honor the runner -e toggle even if the RAILS_ENV constant has already been set
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2538 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-12 12:41:23 +00:00
Marcel Molina
7aa1ba7ff0 Misc doc fixes (typos/grammar/etc). Closes #2445.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2537 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-12 03:43:28 +00:00
David Heinemeier Hansson
6823f57b27 Use the correct scope for Rake tasks
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2536 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-12 01:07:57 +00:00
Jamis Buck
8946804b8a Make xyz_tag(..., :id => "foo") work again
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2535 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-12 01:05:29 +00:00
David Heinemeier Hansson
6fe5f65d87 Migrating should also dump the latest schema
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2534 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-12 00:02:11 +00:00
Marcel Molina
2948910b56 Misc doc fixes (typos/grammar/etc.). Closes #2430.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2533 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-11 03:55:49 +00:00
Marcel Molina
31219f009c Add test coverage for content_columns. Closes #2432.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2532 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-11 03:51:58 +00:00
Marcel Molina
cb8c807085 Fix typo in CHANGELOG.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2531 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-11 03:42:10 +00:00
Marcel Molina
dcc2263b3a Speed up for unthreaded environments. Closes #2431.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2530 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-11 03:40:11 +00:00
Marcel Molina
31ae8121e4 Optimization for Mysql selects using mysql-ruby extension greater than 2.6.3. Closes #2426.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2529 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-11 03:10:07 +00:00
Jamis Buck
0efeeba780 Speed improvement for session_options. #2287. [skaes@web.de]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2527 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-11 01:53:31 +00:00
Marcel Molina
9025e5d47f Make cacheing binary files friendly with Windows. Closes #1975.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2524 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-11 01:06:05 +00:00
Marcel Molina
064842f516 Convert boolean form options form the tag_helper. Recloses #809.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2523 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-10 21:34:51 +00:00
Sam Stephenson
0886bb391d Fixed that an instance variable with the same name as a partial should be implicitly passed as the partial :object. Closes #2269.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2522 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-10 20:35:13 +00:00
Sam Stephenson
e3655ef733 Fix Element.toggle logic
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2521 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-10 19:09:40 +00:00
Marcel Molina
d736568f41 Speed up the setting of table_name. Closes #2428.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2520 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-10 18:59:56 +00:00
Jamis Buck
08a010eb1b Require rails_version instead of version
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2519 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-10 16:13:49 +00:00