TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
26,534 Commits 2 Branches 0 Tags 294 MiB
5da90b3483
Commit Graph

26534 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jon Leighton
5da90b3483 Fix #3890. (Calling proxy_association in scope chain.) 2011-12-08 20:10:04 +00:00
José Valim
ebd71fd0e3 Fix a regression and also fix broken test. 2011-12-08 21:00:34 +01:00
Vijay Dev
94dcbe8115 fix nodocs 2011-12-09 01:15:54 +05:30
Vijay Dev
120861c023 add haml and slim to the list of extensions supported by rake notes 2011-12-09 01:02:27 +05:30
Vijay Dev
965f6f22aa fix comments 2011-12-09 01:02:27 +05:30
Vijay Dev
c81bb97753 minor text change 2011-12-09 01:02:27 +05:30
José Valim
d1abf29e79 Remove NilClass whiners feature. 
Removing this feature causes boost in performance when using Ruby 1.9.

Ruby 1.9 started to do implicit conversions using `to_ary` and `to_str`
in some STDLIB methods (like Array#join). To do such implicit conversions,
Ruby 1.9 always dispatches the method and rescues the NoMethodError exception
in case one is raised.

Therefore, since the whiners feature defined NilClass#method_missing, such
implicit conversions for nil became much, much slower. In fact, just defining
NilClass#method_missing (even without the whiners feature) already causes a
massive slow down. Here is a snippet that shows such slow down:

    require "benchmark"
    Benchmark.realtime { 1_000.times { [nil,nil,nil].join } }

    class NilClass
      def method_missing(*args)
        raise NoMethodError
      end
    end

    Benchmark.realtime { 1_000.times { [nil,nil,nil].join } }
 2011-12-08 20:28:09 +01:00
José Valim
7280787a53 Improve cache on route_key lookup. 2011-12-08 19:53:16 +01:00
Aaron Patterson
3cae753963 fixing eval'd line numbers. 2011-12-08 10:39:12 -08:00
Aaron Patterson
d80e4ee20e Regexp.union seems to have different results in 1.8 2011-12-08 10:20:14 -08:00
José Valim
859a4556dd Revert accidental change from cattr_accessor to class_attribute. 2011-12-08 19:01:15 +01:00
Xavier Noria
b989b80960 Merge pull request #3909 from laserlemon/patch-1 
Add dependency status (a la build status) to the README
 2011-12-08 09:30:31 -08:00
Steve Richert
255c485d63 Add dependency status (a la build status) to the README 2011-12-08 12:17:28 -05:00
José Valim
7b1930a9b2 Merge pull request #3908 from kennyj/should_use_default_charset 
Fix a failure in railties on ruby 1.8.x
 2011-12-08 08:55:03 -08:00
kennyj
d4d2e8eb2e Fix testcase an error on ruby 1.8.x. 
In Ruby 1.8.x, config.encoding sets $KCODE.
Therefore, the possible values are UTF8, SJIS, or EUC.
And, if we set SJIS, we'll has the error. Because some rails sources are written in utf-8 encoding.
 2011-12-09 01:42:34 +09:00
José Valim
1bad06aebe Merge pull request #3906 from kennyj/fix_warnings_for_params_wrapper_test 
Fix warning for params_wrapper_test.rb
 2011-12-08 07:56:07 -08:00
José Valim
67cc07e0c4 Just use the proc if there is a chance of layout lookup. 2011-12-08 16:51:47 +01:00
José Valim
239262fee0 Optimize layout lookup to avoid double calls. 2011-12-08 16:39:06 +01:00
José Valim
efc28a7f70 Some small optimizations and improvements to benchmark code. 2011-12-08 16:39:06 +01:00
José Valim
06ac7d3ee0 Add performance scripts from wycats/rails-simple-benches to actionpack. 2011-12-08 16:39:06 +01:00
José Valim
0008918059 Remove rb-fsevent from Gemfile. 2011-12-08 16:39:06 +01:00
kennyj
3ade2f8e89 Fix warning for params_wrapper_test. 2011-12-08 23:09:09 +09:00
Xavier Noria
c2aadf8935 updates the host and port of publish_docs, and changes the release instructions to use the task rather than curl (thanks to Vijay Dev for spotting this one) 2011-12-08 14:03:42 +01:00
Xavier Noria
4936fc35a0 use our own fork of sdoc while Vijay's fix is not applied to voloko/sdoc 2011-12-08 04:57:09 -08:00
Xavier Noria
2fe5834ddc releasing instructions: updates the URLs that triggers stable docs generation and publishing 2011-12-08 12:35:57 +01:00
José Valim
bf34a360dd Merge pull request #3900 from jfturcot/accessible_wrap_params 
ParamsWrapper only wrap the accessible attributes when they were set
 2011-12-08 01:13:14 -08:00
Jon Leighton
188b8c39da Fix broken test_exists_query_logging from the table_exists? change 2011-12-08 09:06:15 +00:00
Jean-Francois Turcot
677f968b77 Add information to the changelog about the changes to ActionController::ParamsWrapper 2011-12-08 04:03:55 -05:00
José Valim
e2e9eabc58 Remove dead broken code from AD::Request 2011-12-08 09:30:27 +01:00
José Valim
f84bf83b9b Merge pull request #3888 from kennyj/should_use_default_charset 
Assign config.encoding to AD::Response.default_charset at the initialization time.
 2011-12-08 00:18:09 -08:00
José Valim
0144f4f023 Merge pull request #3901 from mark-rushakoff/inflection-regex-fix 
Fix inflection regexes for mouse, mice
 2011-12-08 00:04:45 -08:00
Mark Rushakoff
6f253fb440 Fix inflection regexes for mouse, mice 2011-12-07 23:14:02 -08:00
Jean-Francois Turcot
d5526218e4 ParamsWrapper only wrap the accessible attributes when they were set 2011-12-07 22:50:01 -05:00
Aaron Patterson
a505b13774 moving ignored regexp to the instance 2011-12-07 17:42:05 -08:00
Aaron Patterson
38a8f7f8ba speeding up ignored sql testing 2011-12-07 17:32:01 -08:00
Aaron Patterson
76c29a64b9 Use a hash to look up column definitions 2011-12-07 17:25:31 -08:00
Aaron Patterson
7e176a6d12 try to normalize the objects passed to column() 2011-12-07 16:18:39 -08:00
Aaron Patterson
483a3cf287 automatically add the column definition to the columns list if creating a new one 2011-12-07 16:01:53 -08:00
Aaron Patterson
1fc47a1a84 stop calling String#to_s so frequently 2011-12-07 15:35:27 -08:00
Aaron Patterson
8523784265 the required sqlite3 adapter responds to encoding, so stop checking. 2011-12-07 15:01:04 -08:00
José Valim
30f0d7bac8 Remove #:nodoc: from partial renderer. 2011-12-07 19:16:14 +01:00
José Valim
12be0a5985 Merge pull request #3895 from kennyj/should_use_freezed_constant 
Should use freezed string constant here.
 2011-12-07 10:15:07 -08:00
José Valim
6867212261 Merge pull request #3889 from kielkowicz/master 
Annotating haml and slim file
 2011-12-07 10:14:26 -08:00
kennyj
0a958d8468 Use freezed string constant. Some string literals is used repeatedly. 2011-12-08 02:19:15 +09:00
Kazimierz Kiełkowicz
c6e6ce437c Moves migrations tests from railties/test/application/rake_test.rb to railties/test/application/rake/migrations_test.rb 2011-12-07 17:34:29 +01:00
Kazimierz Kiełkowicz
c45f744bb0 Move rake notes test to railties/test/application/rake/notes_test.rb 2011-12-07 17:31:31 +01:00
Kazimierz Kiełkowicz
8188d265a1 Update source_annotation_extractor comment. 2011-12-07 17:30:03 +01:00
José Valim
0df2ef3ef4 Merge pull request #3884 from sikachu/master-fix_layout 
Allow layout fallback when using `layout` method
 2011-12-07 08:00:45 -08:00
Santiago Pastorino
4f107384f0 Merge pull request #3894 from kelyar/master 
reversible migration example
 2011-12-07 07:10:27 -08:00
Evgeniy Kelyarsky
dd647d938e reversible migration example had missing block parameter 2011-12-07 17:03:51 +02:00