Commit Graph

26686 Commits

Author SHA1 Message Date
José Valim
654df86b7b Show detailed exceptions no longer returns true if the request is local in production. 2011-12-16 10:45:59 +01:00
José Valim
192e55c38e Do not raise an exception if an invalid route was generated automatically. 2011-12-16 10:45:59 +01:00
José Valim
5359262695 ShowExceptions should understand X-Cascade responses from exceptions app. 2011-12-16 10:45:59 +01:00
José Valim
7dd1c751f9 Improve the specs on exceptions app. 2011-12-16 10:45:59 +01:00
José Valim
02127e6406 Allow a custom exceptions app to set. 2011-12-16 10:45:59 +01:00
José Valim
deef8dd682 Extract the rendering of public exceptions pages into a Rack app. 2011-12-16 10:45:59 +01:00
José Valim
d142572567 Get rid of the close checks since we cannot reliably close the session anyway. 2011-12-16 10:45:59 +01:00
Piotr Sarnacki
8015f906d5 Merge pull request #4002 from arunagw/warning_removed_grouped_expression
Warning removed "warning: (...) interpreted as grouped expression"
2011-12-16 00:45:20 -08:00
Arun Agrawal
aa39149b2f Warning removed "warning: (...) interpreted as grouped expression" 2011-12-16 10:30:20 +05:30
Xavier Noria
dbfc6b8b3a removes Ruby constraint in RedCloth dependency 2011-12-15 15:22:14 -08:00
Xavier Noria
5e0dec5e10 it's -> its 2011-12-15 12:57:33 -08:00
Jon Leighton
2b22564c4e Move DefaultScope and NamedScope under Scoping 2011-12-15 20:45:42 +00:00
Jon Leighton
17ad71e514 Let AttributeMethods do its own including etc 2011-12-15 20:45:42 +00:00
Jon Leighton
ceb33f8493 Split out most of the AR::Base code into separate modules 🍰 2011-12-15 20:45:37 +00:00
José Valim
8854bf29a3 Set up delegations also for to_a and arel branches. 2011-12-15 20:59:05 +01:00
José Valim
b17bc58c76 Move delegation reponsibilities of Relation to a module. Also precompile method missing calls for rofscale. 2011-12-15 20:47:26 +01:00
José Valim
1e8b751813 Make with_scope public so we stop using send 💣 2011-12-15 20:47:26 +01:00
Xavier Noria
22bd21dc0f Merge pull request #3998 from rafacv/master
Small typo in Rails::Engine documentation
2011-12-15 11:09:30 -08:00
Rafael Valverde
4baf145375 Fixed small typo in the Rails::Engine documentation. 2011-12-15 17:03:19 -02:00
José Valim
1af2a1d0f5 Improve delegate list to avoid method missing. 2011-12-15 20:01:56 +01:00
José Valim
26e7400cc5 Fix diagnostics page for routing errors. 2011-12-15 19:43:49 +01:00
José Valim
283a087634 Clean up the cache before the request in case we are running in the reload_classes_only_on_change schema. 2011-12-15 18:48:10 +01:00
José Valim
de947c621d There isn't a column_hash. It was being invoked by method missing. 2011-12-15 17:09:48 +01:00
Jon Leighton
8dba32f125 Fix #3987. 2011-12-15 13:23:28 +00:00
José Valim
d7e714adac Merge pull request #3994 from whilefalse/sass_cache_gitignore
Added .sass-cache/ directory to the genrated gitignore in engines.
2011-12-15 04:56:10 -08:00
Jon Leighton
0ddb9d6409 Merge pull request #3991 from akaspick/attrfix
Allow nested attributes in associations to update values in it's owner o...
2011-12-15 04:50:13 -08:00
Steven Anderson
54f60c1063 Added .sass-cache/ directory to the genrated gitignore in engines. 2011-12-15 12:38:52 +00:00
José Valim
ad87752ad6 Merge pull request #3990 from ugisozols/master
Remove autoload for non-existent file
2011-12-14 21:10:47 -08:00
Uģis Ozols
8d827325d0 Remove autoload for non-existent file. 2011-12-15 06:52:42 +02:00
Aaron Patterson
e9382474fd seed file was already tested for existence. ಠ_ಠ 2011-12-14 19:09:31 -08:00
Andrew Kaspick
774ff18c09 Allow nested attributes in associations to update values in it's owner object. Fixes a regression from 3.0.x 2011-12-14 20:13:03 -06:00
Aaron Patterson
b6105b0b59 updating arel and journey dependencies 2011-12-14 13:26:49 -08:00
Xavier Noria
800252ca71 let sdoc say which version of rdoc we depend on 2011-12-14 22:23:17 +01:00
José Valim
2a10b914ad Merge pull request #3988 from lest/fix-date-select
fix separator insertion in date_select helper
2011-12-14 12:37:22 -08:00
Sergey Nartimov
caa1c19787 fix separator insertion in date_select helper 2011-12-14 23:20:23 +03:00
Jon Leighton
889e8bee82 Fix #3672 again (dependent: delete_all perf) 2011-12-14 19:20:19 +00:00
Jon Leighton
8a37970312 Remove that there copy/pasted code 💣 2011-12-14 17:34:35 +00:00
Jon Leighton
909b337da8 Don't try to autosave nested assocs. Fixes #2961. 2011-12-14 17:28:59 +00:00
Jon Leighton
18bf30982b Cache column defaults on model. ~30% on Model.new due to avoiding repeatedly fetching connection. 2011-12-14 16:14:47 +00:00
Jon Leighton
7b0edbb9f2 Avoid super; speeds up Model.new by about 12% 2011-12-14 16:14:47 +00:00
José Valim
e3a4eb4b40 Close the response body on cascade pass, closes #3975. 2011-12-14 17:03:35 +01:00
Jon Leighton
19bea9f1bd Stop the build asploding on 1.8.7 2011-12-14 15:31:12 +00:00
Jeremy Kemper
384a60a16c Merge pull request #3981 from choonkeat/master
Fix url_for options[:subdomain] to allow objects as values
2011-12-14 07:07:05 -08:00
Jon Leighton
bb44e5a80a Use a separate module for 'external' attribute methods. 2011-12-14 14:51:57 +00:00
choonkeat
5f67cfeda1 Fix url_for options[:subdomain] to allow objects as values
* e.g. blog_url(subdomain: current_user) instead of blog_url(subdomain: current_user.to_param)
2011-12-14 22:43:42 +08:00
Piotr Sarnacki
a5589db063 Merge pull request #3979 from kommen/dbconsole_db_config
dbconsole: Use the app's database_configuration instead of duplicating loading code.
2011-12-14 05:48:04 -08:00
Dieter Komendera
6cbe2709d6 dbconsole: Use the app's database_configuration instead of duplicating code. 2011-12-14 14:08:41 +01:00
Jon Leighton
665ef116ac Add return for 1.8.7 2011-12-14 11:11:12 +00:00
Jon Leighton
3ab49f87e4 Unfluff the CI.
With transactional fixtures enabled, the session records would end up in
@_current_transaction_records, and at the end of the transaction,
methods would be called on them that would trigger method_missing and
trigger attribute methods to be generated.

However, at this point the sessions table would not exist, and the
columns were not cached, so an exception would be raised because we
can't find the columns to generate attribute methods for.

Not sure exactly why this didn't crop up before but there have been
changes to the schema cache code and perhaps that means that column data
that was cached previously at that point is now uncached.
2011-12-14 11:05:00 +00:00
José Valim
f3531a8fc9 Clean up details keys before some tests to expire the cache. 2011-12-14 09:23:34 +01:00