Commit Graph

48528 Commits

Author SHA1 Message Date
Sean Griffin
68a6c8ecc4 Convert add_references to use kwargs
While we still aren't accepting PRs that only make changes like this,
it's fine when we're actively working on a method if it makes our lives
easier.
2014-12-22 13:47:11 -07:00
Sean Griffin
99a6f9e60e Add a foreign_key option to references while creating the table
Rather than having to do:

    create_table :posts do |t|
      t.references :user
    end

    add_foreign_key :posts, :users

You can instead do:

    create_table :posts do |t|
      t.references :user, foreign_key: true
    end

Similar to the `index` option, you can also pass a hash. This will be
passed as the options to `add_foreign_key`. e.g.:

    create_table :posts do |t|
      t.references :user, foreign_key: { primary_key: :other_id }
    end

is equivalent to

    create_table :posts do |t|
      t.references :user
    end

    add_foreign_key :posts, :users, primary_key: :other_id
2014-12-22 13:47:10 -07:00
Sean Griffin
a9c0c46263 Convert references to kwargs
While we aren't taking PRs with these kinds of changes just yet, they
are fine if we're actively working on the method and it makes things
easier.
2014-12-22 13:47:10 -07:00
Sean Griffin
9fff631a06 Skip byebug on all non-MRI rubies, fix tests
The changes in #18149 added tests for the app generator, but only fixed
it for the plugin generator (I should have let CI finish though I think
it would have failed as an allowed failure).
2014-12-22 13:43:58 -07:00
Sean Griffin
569c674773 Merge pull request #18149 from arthurnn/byebug_on_mri
Only add debugger/byebug if on MRI
2014-12-22 13:31:30 -07:00
Arthur Neves
0bb73f03e4
Only add debugger/byebug if on MRI 2014-12-22 15:27:56 -05:00
Sean Griffin
32f30d22d5 Add force: true to table created in tests
If the test is interrupted in a way that the teardown block fails to
run, the tests will fail to run until the table is removed manually
without this option.
2014-12-22 12:49:34 -07:00
Sean Griffin
b0f2b94dd3 Correctly handle limit on int4 and int8 types in PG
PG doesn't register it's types using the `int(4)` format that others do.
As such, if we alias `int8` to the other integer types, the range
information is lost. This is fixed by simply registering it separately.

The other option (which I specifically chose to avoid) is to pass the
information of the original type that was being aliased as an argument.
I'd rather avoid that, since an alias should truly be treated the same.
If we need different behavior for a different type, we should explicitly
register it with that, and not have a conditional based on aliasing.

Fixes #18144

[Sean Griffin & ysbaddaden]
2014-12-22 09:55:41 -07:00
Zachary Scott
0369808917 Merge branch 'master' of github.com:rails/rails 2014-12-22 11:11:32 -05:00
Zachary Scott
3cc9359c2d Remove this section, it adds no real value [ci skip] 2014-12-22 11:11:12 -05:00
Arthur Neves
58b7567bda
Use serve_static_files in guides, take 2 [skip ci] 2014-12-22 10:27:44 -05:00
Arthur Neves
85f7924af1
Use serve_static_files in guides [skip ci] 2014-12-22 10:22:14 -05:00
Zachary Scott
cd01f9f9c5 Add subheadings for these sections [ci skip] 2014-12-22 10:12:06 -05:00
Zachary Scott
eb93e70263 I'm sorry but I would rather not link to a 7 year old blog post [ci skip] 2014-12-22 10:07:15 -05:00
Zachary Scott
2526b95f20 Remove this line since we are using Rake to run our tests [ci skip] 2014-12-22 10:03:03 -05:00
Zachary Scott
a6d9049dc0 s/are edited and rerun/required modifications [ci skip] 2014-12-22 09:50:20 -05:00
Yves Senn
3b34cf3042 document the return of db:test:prepare. Closes #18136. [ci skip]
This is a doc follow-up to #17739.

/cc @zzak
2014-12-22 15:37:59 +01:00
Sean Griffin
41f1323e74 Correctly handle Float -> BigDecimal with unspecified precision
Fixes #18122
2014-12-22 07:08:31 -07:00
Zachary Scott
d610cd0ff8 Merge pull request #18099 from robsonmarques/fix_active_model_errors_add_docs
Fix inaccurate docs in active_model errors [ci skip]
2014-12-22 06:53:12 -05:00
Zachary Scott
84af1e6d07 s/a unobtrusive/an unobtrusive [ci skip] 2014-12-22 06:51:21 -05:00
Zachary Scott
bac74d66ec Merge pull request #18105 from andreynering/guides-csrf
Add note about Ajax and CSRF-Token [ci skip]
2014-12-22 06:50:10 -05:00
Zachary Scott
a1ec6a5d1a Merge pull request #18125 from codeodor/master
Clarify ActiveRecord testing guidelines [ci skip]
2014-12-22 06:45:33 -05:00
Zachary Scott
e77f24b937 Merge pull request #18131 from y-yagi/fix_command_in_plugins_guide
`bin/rake` does not exist in plugin directory [ci skip]
2014-12-22 06:41:24 -05:00
Zachary Scott
334f620858 Better explain number of assertions per test [ci skip] 2014-12-22 03:29:34 -08:00
Zachary Scott
0cf3f9adf5 Remove duplicate description of the previous line [ci skip] 2014-12-22 03:29:16 -08:00
Zachary Scott
f2852298a1 Fix NOTE for method naming in Ruby and add intro sentence to next section.
[ci skip]
2014-12-22 03:25:40 -08:00
Zachary Scott
e36d79fbde Removed run-on sentence and replace with sectional comments [ci skip] 2014-12-22 03:25:18 -08:00
Zachary Scott
0145cc6e50 Better explain how test() methods get defined and kill this run-on sentence.
[ci skip]
2014-12-22 03:24:22 -08:00
Zachary Scott
2d224a6b67 We may only look at some of the methods available from TestCase [ci skip] 2014-12-22 03:23:23 -08:00
Zachary Scott
d6fc5af1df Better explain what test_helper.rb is designed for [ci skip] 2014-12-22 03:17:13 -08:00
Robson Marques
ebaf4e40cd Fix inaccurate docs in active_model errors [ci skip]
The default value for the argument `message` in
`ActiveModel::Errors#add` has a new behavior
since ca99ab2481d44d67bc392d0ec1125ff1439e9f94.

Before
  person.errors.add(:name, nil)
  # => ["is invalid"]

After
  person.errors.add(:name, nil)
  # => [nil]
2014-12-22 09:06:30 -02:00
Yves Senn
a407bb245b Merge pull request #18132 from rochefort/fix-typo-nodoc
Fix typo in nodoc [ci skip]
2014-12-22 09:23:35 +01:00
rochefort
2114e6bf29 Fix typo in nodoc 2014-12-22 17:14:58 +09:00
yuuji.yaginuma
1581348f28 bin/rake does not exist in plugin directory [ci skip] 2014-12-22 13:45:03 +09:00
Guillermo Iguaran
d402b15d39 Merge pull request #18129 from claudiob/remove-unused-sheep-fixture-from-action-view
Remove unused Sheep fixture from AV
2014-12-21 22:36:31 -05:00
claudiob
7375c17114 Remove unused Sheep fixture from AV
The `Sheep` fixture was added in eb23754e when moving template tests
from actionpack to actionview, but it's not actually used in ActionView tests.

The `Sheep` fixture is only used to test `uncountable` in ActiveModel tests,
and is already defined in activemodel/test/models/sheep.rb
2014-12-22 04:02:35 +01:00
Xavier Noria
e21bd33319 Merge pull request #18126 from Decagon/patch-1
Remove extra bullet in README.md [ci skip]
2014-12-21 21:59:12 +01:00
Decagon
f35322d2be Remove bullet 2014-12-21 16:28:25 -04:00
Carlos Antonio da Silva
060bf50caa Merge pull request #18118 from vipulnsward/fix-validation-message
Validation test fixes
2014-12-21 16:36:34 -02:00
Sean Griffin
c9a953a17e Merge pull request #18119 from joker1007/add_require_core_ext_hash_to_activejob
Add 'require' for Hash#with_indifferent_access to active_job/arguments.rb
2014-12-21 10:46:22 -07:00
Sammy Larbi
f5489f9ab4 Clarify ActiveRecord testing guidelines [ci skip]
1. Specify that you need to create the test databases, and that no special
   Rails command needs to be run to do that.
2. Although the underscore style of `rake test_mysql` works, make the
   documentation of running the tests in RUNNING_UNIT_TESTS.rdoc
   consistent with the "Contributing..." guide.
3. Promote "Testing Active Record" to not be a subsection of
   "Running a Single Test," since it doesn't make sense as a subsection
   of that.
2014-12-21 10:18:46 -06:00
Abdelkader Boudih
ef529c6371 Merge pull request #18124 from jonatack/patch-8
Testing guide grammar fix
2014-12-21 15:10:08 +00:00
Jon Atack
2f1cf8101f Testing guide grammar fix
[skip ci]
2014-12-21 16:06:46 +01:00
joker1007
7b76f05cd1 Add 'require' for Hash#with_indifferent_access
ActiveJob::Arguments uses Hash#with_indifferent_access.
But, activejob gem does not require Hash extension library.
When we use activejob as standalone,
we need extra require statement. This is unhandy.

This commit fixes it.
2014-12-21 21:03:16 +09:00
Vipul A M
732bba8d4c - Fixed unused variable
- Changed test to verify complete message instead of verifying if message contains text.
2014-12-21 13:28:20 +05:30
Zachary Scott
651bba1bfe We will be using the application already created in the Getting Started guide.
[ci skip]
2014-12-20 19:02:47 -08:00
Zachary Scott
a504cbee78 Merge pull request #18114 from jonatack/patch-8
Follow-up to d971021 [skip ci]
2014-12-20 16:26:08 -08:00
Jon Atack
74ddf0051f Follow-up to d9710212 [skip ci] 2014-12-21 00:36:01 +01:00
Zachary Scott
4ad9d68581 Fixture data is accessible by a local method, and not a variable [ci skip] 2014-12-20 15:30:55 -08:00
Zachary Scott
72752643bb Shorten the explaination of this to fit on one line [ci skip] 2014-12-20 15:26:17 -08:00