TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
17,391 Commits 2 Branches 0 Tags 294 MiB
6ce761c8d9
Commit Graph

17391 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Santiago Pastorino
6ce761c8d9 This example is better for guides and gem/plugins docs 2010-07-20 13:08:03 -07:00
José Valim
d4151d7f0a Fix a failing test in Railtie and properly define all severity levels in MockLogger for LogSubscriber. 2010-07-20 21:21:14 +02:00
Aaron Patterson
e1df4b9568 adding a reader for loaded, initializing @loaded to false 2010-07-20 09:15:09 -07:00
José Valim
9df9c4bac0 Add a test for elapsed and require missing benchmark file. 2010-07-20 17:07:18 +02:00
José Valim
51d2db0a63 Add missing require to metal/streaming.rb 2010-07-20 09:56:16 +02:00
José Valim
325592038e Fix typo on CHANGELOG. 2010-07-20 00:22:34 -07:00
Kouhei Sutou
a6e95ba554 fix mixed encoding logs can't be logged. 
[#4807 state:committed]

Signed-off-by: Kouhei Sutou <kou@cozmixng.org>
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-07-19 14:55:58 -07:00
Bryan Helmkamp
e466354edb Extract ParameterFilter class from FilterParameters mixin 
Signed-off-by: wycats <wycats@gmail.com>
 2010-07-19 13:44:43 -07:00
Aaron Patterson
202fb79e86 reusing the time instrumentation from the instrumenter rather than Benchmark. [#5098 state:open] 2010-07-19 13:44:11 -07:00
José Valim
c3c349ec3e Remove assert_valid. It was already deprecated on Rails 2.3. 2010-07-19 22:35:17 +02:00
Santiago Pastorino
17600eb435 Remove unused orig_handler and unneeded parentheses 2010-07-20 04:32:08 +08:00
Santiago Pastorino
d39c3b179c Test added, we shouldn't log sql calls when logger is not on debug? mode 2010-07-20 04:32:08 +08:00
Aaron Patterson
1b26c66ce4 mocking out debing? call in the MockLogger 2010-07-19 13:19:28 -07:00
Daniel Guettler
38f0161aab Minor performance improvment in notifications/fanout and active_record/log_subscriber [#5098 state:open] 2010-07-19 11:45:50 -07:00
Aaron Patterson
ad4ef4226f avoid const lookup. we know what these constants are in advance 2010-07-19 10:31:24 -07:00
Aaron Patterson
dd4e81df86 avoid call to Array#first 2010-07-19 10:21:45 -07:00
Łukasz Strzałkowski
bd4b3d8b2f Added missing require of remove_method 2010-07-19 23:44:50 +08:00
Łukasz Strzałkowski
661fd98aad Make use of redefine_method, removed some more redefining warnings 2010-07-19 23:44:50 +08:00
Łukasz Strzałkowski
7637b7184a Test for behaviour of befeore_type_cast when operating on datetime colmun 2010-07-19 23:44:49 +08:00
Łukasz Strzałkowski
010eda2eb5 Removed warnings about method redefining 2010-07-19 23:44:48 +08:00
Łukasz Strzałkowski
fc71d59219 Introduced redefine_method 2010-07-19 23:44:46 +08:00
Łukasz Strzałkowski
247886e1b4 Removed warnings when a variable is shadowed 2010-07-19 23:44:45 +08:00
José Valim
b22c11fa53 Add missing entries and tidy up CHANGELOG. 2010-07-19 15:14:26 +02:00
José Valim
70f7ba3e3b There is absolutely no need to use __send__ here. 2010-07-19 14:56:09 +02:00
José Valim
ab6ff85906 No need to create a new module in the previous commit. 2010-07-19 14:50:38 +02:00
Neeraj Singh
33c5689e2d Exceptions from views should be rescued based on the original exception. If a handler for original exception is missing then apply ActiveView::TemplateError 
[#2034 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-19 14:50:38 +02:00
Aaron Patterson
ad8f4dfc50 avoid proc activation every time a log message is made 2010-07-18 17:37:39 -07:00
Aaron Patterson
8cbb89c0bf subscriber does not need to be a block, but an object that responds to #call 2010-07-18 17:20:20 -07:00
Aaron Patterson
b2c8a5fd3e Notifier API == Fanout API, so replace Notifier with Fanout as they quack the same 2010-07-18 16:49:29 -07:00
Aaron Patterson
234b969946 tap the subscriber for easier return value 2010-07-18 15:39:32 -07:00
Aaron Patterson
2cbef6996c bind method is not needed, so goodbye! <3 <3 <3 2010-07-18 15:37:23 -07:00
Santiago Pastorino
3870366092 Float comparison adjustment 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-18 19:28:46 +02:00
Neeraj Singh
0fce4ae57f expected value should come first in assert_equal 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-18 15:13:38 +02:00
Neeraj Singh
6caf943ace primary_keys_test reads better than pk_test 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-18 15:13:29 +02:00
Neeraj Singh
b58e1c52f7 fixing typo 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-18 15:13:21 +02:00
Neeraj Singh
df6aa8e246 removing extra whitespaces 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-18 15:13:14 +02:00
José Valim
291adcd588 Set session options id to nil is respected and cancels lazy loading. 2010-07-18 12:51:03 +02:00
Ivan Torres
cdfa11409c select :include_blank or :prompt should return escaped string [#5099 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-18 11:32:00 +02:00
Neeraj Singh
1f499e6d4c fixing the ternary operation where the logic is very confusing. 
[#5136 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-18 11:31:54 +02:00
Subba Rao Pasupuleti
4a0d7c1a43 save on parent should not cascade to child unless child changed [#3353 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-18 11:31:29 +02:00
José Valim
e210895ba9 Avoid uneeded queries in session stores if sid is not given. 2010-07-18 11:02:08 +02:00
José Valim
fa98eca75b Add console hook to force ActiveRecord::Base to be loaded when console starts avoiding reference loops. 2010-07-18 11:02:07 +02:00
Aaron Patterson
cfca55949f convert duration to an attr_reader 2010-07-17 16:03:56 -07:00
Santiago Pastorino
cebe5c2fac It's not needed to initialize the attr when calling mattr_writer 2010-07-18 06:06:58 +08:00
Nick Quaranto
7aec9f9c02 Removing ActionDispatch::Http::FilterParameters#fitered_parameters alias 2010-07-18 06:04:55 +08:00
Aaron Patterson
606d8fdfc8 drained? is never called 2010-07-17 14:45:59 -07:00
Aaron Patterson
fa73e777a1 private method is not needed 2010-07-17 14:44:29 -07:00
Aaron Patterson
4226c93779 removing Binding class 2010-07-17 14:35:44 -07:00
Aaron Patterson
9c80f5b391 use === to avoid regular expression creation, and speed up string comparison 2010-07-17 13:14:38 -07:00
Xavier Noria
631b9564d2 Merge remote branch 'docrails/master' 2010-07-17 20:00:48 +02:00