TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
2,587 Commits 2 Branches 0 Tags 294 MiB
7355d9f1bd
Commit Graph

2587 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Marcel Molina
7355d9f1bd Make the db_schema_dump task honor the SCHEMA environment variable if present the way db_schema_import does. Closes #2931. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3136 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 08:01:41 +00:00
Jeremy Kemper
60091c1e2a r3241@asus: jeremy | 2005-11-20 23:26:28 -0800 
Active Support is warnings-safe.  References #1792.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3135 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 07:29:51 +00:00
Jeremy Kemper
9a77e2f2be r3240@asus: jeremy | 2005-11-20 23:22:34 -0800 
Introduce enable_warnings counterpart to silence_warnings.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3134 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 07:29:44 +00:00
Jeremy Kemper
d792427301 r3239@asus: jeremy | 2005-11-20 23:21:37 -0800 
Test for absence of instance vars rather than nil so we don't get a warning.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3133 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 07:29:39 +00:00
Jeremy Kemper
5129de7bbd r3220@asus: jeremy | 2005-11-20 03:19:22 -0800 
Enable Action Mailer warnings in unit tests.  adv_attr_accessor hecks for presence of instance variable before getting it.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3132 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 07:29:33 +00:00
Jeremy Kemper
d1ac316fa4 r3219@asus: jeremy | 2005-11-20 03:07:19 -0800 
silence necessary warnings in logger test.  guard against multiple requires in kernel test.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3131 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 07:29:27 +00:00
Jeremy Kemper
7ed37c82a9 r3218@asus: jeremy | 2005-11-20 03:06:32 -0800 
alias old format_message before overriding it


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3130 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 07:29:22 +00:00
Jeremy Kemper
ddc863c134 r3217@asus: jeremy | 2005-11-20 03:06:01 -0800 
warnings-safe inherited alias for class_inheritable_attributes


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3129 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 07:29:17 +00:00
Jeremy Kemper
3148216cbb r3216@asus: jeremy | 2005-11-20 03:05:20 -0800 
simplify cattr_ and mattr_accessor


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3128 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 07:29:12 +00:00
Jeremy Kemper
a821c3dd93 r3215@asus: jeremy | 2005-11-20 02:05:56 -0800 
Eliminate double-requires due to Ruby seeing different paths to the same file.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3127 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 07:29:04 +00:00
Jeremy Kemper
1a44b9cf1a r3214@asus: jeremy | 2005-11-20 02:03:05 -0800 
Parenthesize args in Inflections


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3126 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 07:28:59 +00:00
Jeremy Kemper
27f96c7d11 r3213@asus: jeremy | 2005-11-20 02:01:28 -0800 
Turn on warnings for tests.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3125 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 07:28:54 +00:00
Jeremy Kemper
edc7c521b8 Turn warnings on when loading a file if Dependencies.mechanism == :load. Common mistakes such as redefined methods will print warnings to stderr. References #752. References #1792. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3124 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 07:06:33 +00:00
Sam Stephenson
2b6e2bfed7 Have the lighttpd server script report the actual ip to which the server is bound. Closes #2903. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3123 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 06:19:25 +00:00
Marcel Molina
9a37fd44cb Add plugin library directories to the load path after the lib directory so that libraries in the lib directory get precedence. Closes #2910. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3122 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 05:55:35 +00:00
Marcel Molina
f14625bb46 Make help for the console command more explicit about how to specify the desired environment in which to run the console. Closes #2911. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3120 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 05:33:13 +00:00
Marcel Molina
dd198e259f Pull out Array#to_strings in favor of more general Symbol#to_proc. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3119 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 02:17:10 +00:00
Marcel Molina
69bf71f5e9 Add Symbol#to_proc, which allows for, e.g. [:foo, :bar].map(&:to_s). 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3118 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 02:15:32 +00:00
Jeremy Kemper
e9b26c52a2 Fix grammar error in [3115]. References #2966. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3117 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 02:14:31 +00:00
Sam Stephenson
f212c88315 Pass multiple arguments to Element.show and Element.hide in JavaScriptGenerator instead of using iterators 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3116 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 01:54:36 +00:00
Jeremy Kemper
a0293c80f0 Improve expire_fragment documentation. Closes #2966. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3115 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-21 01:08:30 +00:00
Marcel Molina
5d785dbc11 Add Array#to_strings which to_s's all elements in an array. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3114 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 22:36:02 +00:00
Marcel Molina
baa2ab5ac3 Add extended_by, extend_with_included_modules_from and copy_instance_variables_from to Object. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3113 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 22:32:40 +00:00
Marcel Molina
55a3979a09 Correct docs for automatic layout assignment. Closes #2610. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3111 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 18:50:09 +00:00
Jeremy Kemper
dfa8aa0e1e PostgreSQL: the purge_test_database Rake task shouldn't explicitly specify the template0 template when creating a fresh test database. Closes #2964. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3110 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 12:00:46 +00:00
Jeremy Kemper
da9f713d2c r3209@asus: jeremy | 2005-11-20 01:04:22 -0800 
If sessions are disabled, return a hash that raises an error when it's accessed.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3109 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 09:06:43 +00:00
Jeremy Kemper
63b792162b Make data writer private. Marshal/unmarshal handle nil. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3108 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 08:15:51 +00:00
Jeremy Kemper
c7bc10b2e4 Log ActiveRecordStore debugging. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3107 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 08:07:33 +00:00
Marcel Molina
f18463f99e Add tasks to create, drop and rebuild the MySQL and PostgreSQL test databases. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3105 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 07:45:04 +00:00
Jeremy Kemper
991189b58d Document request.env and request.host. Strip trailing whitespace. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3103 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 05:31:33 +00:00
Jeremy Kemper
c2bb269cd5 Allows generator to specify migrations directory. References #2960. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3101 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 05:13:59 +00:00
Jeremy Kemper
cd8686b456 r3173@asus: jeremy | 2005-11-18 23:34:41 -0800 
Ticket 2731 - sessions
 r3185@asus:  jeremy | 2005-11-19 18:02:51 -0800
 eliminate const redefinition warning
 r3186@asus:  jeremy | 2005-11-19 19:25:50 -0800
 Use :database option instead of :dbfile
 r3187@asus:  jeremy | 2005-11-19 19:34:31 -0800
 Data writer assigns to instance var.  Since nothing is calling write_attribute on the data column except for marshal_data, simplify data reader to lazy-unmarshal the data column (no worrying whether it's already unmarshaled)
 r3188@asus:  jeremy | 2005-11-19 19:35:40 -0800
 Explicitly create the session class so that subsequent requests for the session can find it in the database.  This is masking a problem with the controller losing its @session instance var and therefore requesting a new session.
 r3189@asus:  jeremy | 2005-11-19 19:36:40 -0800
 Using create unnecessarily  broadens the existing duck-typing so use new + save instead.
 r3194@asus:  jeremy | 2005-11-19 20:28:17 -0800
 Test creation of another instance while first instance is still active.  Should return same session_id.
 r3195@asus:  jeremy | 2005-11-19 20:39:45 -0800
 Always create new AR sessions rather than trying too hard to avoid database traffic.  References #2731.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3100 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 04:41:59 +00:00
Jeremy Kemper
9b9578fa47 Introducing the session_migration generator. Creates an add_session_table migration. References #2958. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3098 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-20 04:21:06 +00:00
Jeremy Kemper
81c5242f43 r3181@asus: jeremy | 2005-11-19 02:52:24 -0800 
Mark connections for verification.  Retrieve connection verifies before returning a connection.  Verification tests whether the connection is marked then reconnects if the connection is inactive.  All active connections are marked for verification after a request is handled.  References #428.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3096 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-19 10:55:11 +00:00
Jeremy Kemper
77e0b7986e Use query methods rather than readers in boolean tests for [3092]. References #2945. Closes #2949. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3094 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-19 10:00:14 +00:00
Jeremy Kemper
2ed6d365bb Correct boolean handling in generated reader methods. References #2945. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3092 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-19 09:53:36 +00:00
Sam Stephenson
d777e506f2 Update to Prototype 1.4.0_rc4. Closes #2943 (old Array.prototype.reverse behavior can be obtained by passing false as an argument) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3091 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-19 06:59:07 +00:00
Jeremy Kemper
b51c3399eb Don't generate read methods for columns whose names are not valid ruby method names. References #2946. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3089 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-19 06:47:26 +00:00
Sam Stephenson
b3c65bc849 Use Element.update('id', 'html') instead of uid=501(sam) gid=501(sam) groups=501(sam), 81(appserveradm), 79(appserverusr), 80(admin).innerHTML = 'html' in JavaScriptGenerator#replace_html so that script tags are evaluated 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3086 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-18 18:03:45 +00:00
Marcel Molina
62fe5bbfb1 Make rjs templates always implicitly skip out on layouts. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3084 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-18 08:32:17 +00:00
Jeremy Kemper
97d5f4acdf script/console uses RAILS_ENV environment variable if present. Closes #2932. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3083 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-18 07:33:28 +00:00
Jeremy Kemper
ae76e22731 Windows: eliminate the socket option in database.yml. Closes #2924. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3082 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-18 07:30:05 +00:00
Jeremy Kemper
db871c8d54 Eliminate nil from newly generated logfiles. References #2927. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3081 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-18 05:28:00 +00:00
Jeremy Kemper
fb3fc46cdd Correct length for the truncate text helper. Closes #2913. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3080 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-18 01:25:39 +00:00
Sam Stephenson
173544f56c Update to Prototype 1.4.0_rc3. Closes #1893, #2505, #2550, #2748, #2783. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3079 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-18 00:53:11 +00:00
Marcel Molina
06e74b6c91 Add support for new rjs templates which wrap an update_page block. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3078 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-17 21:28:59 +00:00
Jeremy Kemper
fd66ccb016 Document :force option to create_table. References #2921. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3075 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-17 20:48:10 +00:00
Jeremy Kemper
86da56a654 Don't add the same conditions twice in has_one finder sql. References #2916. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3074 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-17 20:45:38 +00:00
Jeremy Kemper
e9a4e4d88b Inline a method used by render_partial. Closes #2881. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3073 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-17 19:08:53 +00:00
Tobias Lütke
60e425af33 replaced constant Plugin in documentation rake task with plugin local variable. This caused typo's migrations to fail because of name space collisions [Eridius] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3069 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-17 04:58:48 +00:00