TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
49,170 Commits 2 Branches 0 Tags 294 MiB
773dd2598d
Commit Graph

49170 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Juanito Fatas
773dd2598d [ci skip] Add some more code highlights. 2015-02-10 22:42:41 +08:00
claudiob
124d4d59a0 Do not use the same name for two :belongs_to 
A model cannot have two `:belongs_to` with the same exact name, so
we are better off avoiding this code in our examples, which might
mislead users in thinking it's admissible.

[ci skip]
 2015-02-06 10:50:44 -08:00
Vipul A M
0f67f00d94 AM#Dirty doc fixes 
- Grammar fixes
- Add doc for changes_include?
-  implemntations => implementations
 2015-02-01 13:43:35 +05:30
Vipul A M
db41078566 Fix description for AM::Callbacks 2015-01-31 11:59:02 +05:30
Vipul A M
64f1c888f2 Wording fixes for :skip_after_callbacks_if_terminated callbacks option 2015-01-31 11:56:38 +05:30
Juanito Fatas
fa3108a9ef [ci skip] Add a missing space in t.belongs_to argument. 2015-01-29 15:30:47 +08:00
Vijay Dev
3f96b6973b Merge branch 'master' of github.com:rails/docrails 2015-01-15 07:28:21 +00:00
Sean Griffin
d8e710410e Only use the _before_type_cast in the form when from user input 
While we don't want to change the form input when validations fail,
blindly using `_before_type_cast` will cause the input to display the
wrong data for any type which does additional work on database values.
 2015-01-14 17:08:25 -07:00
Sean Griffin
b67990cf34 Add tests with an explanation of why we're using _before_type_cast 
If you entered incorrect input into a form (particularly with a
numericality validation), we should not replace what you typed in with
`0`, since clicking submit a second time would essentially be the same
as erroneously accepting the junk input as 0.
 2015-01-14 16:46:04 -07:00
Sean Griffin
99b6cf5381 Revert "Don't use the _before_type_cast version of attributes in the form" 
This reverts commit 787e22bb491bd8c36db1e9734261c4ce02c5c5fd.
 2015-01-14 16:44:06 -07:00
Sean Griffin
787e22bb49 Don't use the _before_type_cast version of attributes in the form 
We should never be ignoring valuable information that the types may need
to give us. The reason that it originally used `_before_type_cast` is
unclear, but appears to date back long enough that the reasons may not
be relevant today. There is only one test that asserts that it uses the
before type cast version, but it gives no context as to why and uses a
mock which does not simulate the real world.

Fixes #18523.
 2015-01-14 15:42:24 -07:00
Sean Griffin
df73d696f5 Go through normal where logic in destroy with locking 
Building the Arel AST, and manipulating the relation manually like this
is prone to errors and breakage as implementation details change from
underneath it.
 2015-01-14 15:25:15 -07:00
Sean Griffin
9a21774d73 Go through normal where logic in destroy 
Building the Arel AST, and manipulating the relation manually like this
is prone to errors and breakage as implementation details change from
underneath it.
 2015-01-14 15:08:08 -07:00
Sean Griffin
aa31d21f5f Don't default to YAML dumping when quoting values 
This behavior exists only to support fixtures, so we should handle it
there. Leaving it in `#quote` can cause very subtle bugs to slip
through, by things appearing to work when they should be blowing up
loudly, such as #18385.
 2015-01-14 13:58:09 -07:00
Rafael Mendonça França
855cca0662 Merge pull request #18521 from andrewvida/master 
Correct the views that the mail method sends in API docs.
 2015-01-14 17:47:52 -02:00
Andrew Vida
29a2977af5 Correct views mail method sends in API docs 2015-01-14 14:43:58 -05:00
Xavier Noria
9311d27c07 Merge pull request #18510 from prathamesh-sonpatki/some-more-in-on-github 
Changed "in GitHub" to "on GitHub" [ci skip]
 2015-01-14 12:18:39 +01:00
Prathamesh Sonpatki
bd13ff68ef Changed "in GitHub" to "on GitHub" [ci skip] 
- Followup of https://github.com/rails/rails/pull/18503.
 2015-01-14 16:37:36 +05:30
Robin Dupret
cc4a83f655 Merge pull request #18509 from prathamesh-sonpatki/cg-typo 
Fix typo in ActionView CHANGELOG [ci skip]
 2015-01-14 12:06:06 +01:00
Prathamesh Sonpatki
6ff026a1cd Fix typo in ActionView CHANGELOG [ci skip] 2015-01-14 16:34:09 +05:30
Xavier Noria
7ba24831d7 Merge pull request #18503 from vipulnsward/guides-in-on 
Changed `IN` to `ON` in markdown renderer condition
 2015-01-14 11:35:34 +01:00
Akira Matsuda
864c640965 require 'rails' if not include_all_railties, just as 'rails/all' does 2015-01-14 19:21:13 +09:00
Yves Senn
8d0783941c Merge pull request #18500 from nippysaurus/typo_fix 
Grammar: "By default, Rails loads generators from your load path." [ci skip]
 2015-01-14 09:15:47 +01:00
Yves Senn
69eadfd35c Merge pull request #18504 from vipulnsward/extract-date 
Extract `Date` header to string constant in Http Response, similar to other headers
 2015-01-14 09:13:40 +01:00
Yves Senn
6f9f5fb258 Merge pull request #18502 from y-yagi/fix_autoloading_guide 
fix link in autoloading guide [ci skip]
 2015-01-14 09:01:43 +01:00
Vipul A M
822dc9133e Extract Date header to string constant in Http Response, similar to other headers 2015-01-14 12:37:58 +05:30
Vipul A M
5cfaf5a46e - Changed IN to ON in markdown renderer condition 
- Changed `IN` to `ON` in all note sentences in guides.
 2015-01-14 11:52:13 +05:30
Vipul A M
34dc028e75 Fixed spacing issues on code comments in ActiveJob Basics guide. 
Before: http://take.ms/z39h2
After: http://take.ms/Mo0G3
 2015-01-14 11:47:24 +05:30
yuuji.yaginuma
fe9f8fb56a fix link in autoloading guide [ci skip] 2015-01-14 13:22:51 +09:00
Michael Dawson
fad2ae2a37 improve grammar 2015-01-14 13:26:49 +10:00
Sean Griffin
850159bd2c Merge pull request #18478 from yoshiokatsuneo/active_record_connection_pool_error_disconnect 
ActiveRecord: On reconnection failure, release only failed connetion.
 2015-01-13 12:31:52 -07:00
Abdelkader Boudih
6cf71be0ae Merge pull request #18491 from dreeve/form-for-guide-fix-generated-action 
Fix form_for guide binding a form to an object. [ci skip]
 2015-01-13 19:15:16 +00:00
Andrew White
275111f699 Merge pull request #18489 from Envek/ru_timezones 
Add missing time zone definitions for Russian Federation
 2015-01-13 18:53:56 +00:00
Derek Reeve
b5c1bbbee0 Fix form_for guide binding a form to an object. 
The HTML generated using
    url: { action: :create}
will not generate the form action "/articles/create", it should generate
the form action "/articles" for a new object.
 2015-01-13 10:19:59 -08:00
Abdelkader Boudih
3f14d6a727 Merge pull request #18490 from andreynering/security-guides-remove-resource 
Guides: Removing reference to blog that is not updated anymore [ci skip]
 2015-01-13 18:09:36 +00:00
Andrey Nering
9c021884ed Guides: Removing reference to blog that is not updated anymore [ci skip] 2015-01-13 15:54:45 -02:00
David Heinemeier Hansson
78a4884777 Merge pull request #18476 from Alamoz/scaffold_index_view_grammar 
Clean up grammar in scaffold index view, by removing the word 'Listing' ...
 2015-01-13 09:27:58 -08:00
Sean Griffin
0b2e0528df Add the method_source gem to the default Gemfile 
Fixes #18473
 2015-01-13 10:24:10 -07:00
Andrey Novikov
f996dcf7ef Add missing time zone definitions for Russian Federation 
Also sync Russian Federation time zones with `zone.tab` file from tzdata version 2014j.
 2015-01-13 20:11:13 +03:00
David Heinemeier Hansson
1302edf3e5 Stop promoting rack-cache usage at the moment (not so common or important to deserve that billing) 2015-01-13 08:03:48 -08:00
David Heinemeier Hansson
646349511e Show how to change the queuing backend for ActiveJob in production 2015-01-13 08:02:50 -08:00
David Heinemeier Hansson
b9b28d8a2f Set all asset options together 2015-01-13 07:59:41 -08:00
Rafael Mendonça França
233029e90c Merge pull request #18471 from ahmad-alkheat/master 
Added the SQL equivalent of the find_by method. [ci skip]
 2015-01-13 13:20:08 -02:00
Claudio B.
19b4b0dff1 Merge pull request #18480 from karpah/patch-1 
Update asset pipeline guide
 2015-01-13 00:11:20 -08:00
Claudio B.
1af5c969f3 Merge pull request #18479 from mechanicles/change-a-to-an-for-html 
Change a to an for HTML word [ci skip]
 2015-01-13 00:07:48 -08:00
Rebecca Skinner
da1b830253 Digesting is now enabled by default in development 2015-01-13 14:34:10 +08:00
Santosh Wadghule
f5fced2bb9 Change a to an for HTML word [ci skip] 2015-01-13 11:20:34 +05:30
Yoshioka Tsuneo
33fdb7f292 ActiveRecord: On reconnection failure, release only failed connetion. 
On reconnection failure, all the connection was released.
But, it is better to release only failed connection.
This patch changes not to release all the connection but release
only failed connection.
 2015-01-13 13:49:40 +09:00
Adrien Lamothe
d202b73f68 Clean up grammar in scaffold index view, by removing the word 'Listing' from list title. 2015-01-12 18:20:04 -08:00
Ahmad Al-kheat
edbc9468d5 Updated active_record_querying.md 
Added the SQL equivalent of the find_by method

Update active_record_querying.md

Update active_record_querying.md
 2015-01-12 18:19:48 -05:00