44812 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Timm	83f1563ee6	Support for changes in SelectorAssertions.	2014-06-16 21:04:19 +02:00
Timm	28fd5ebd2e	Included rails-dom-testing in rails_info_controller_test.rb	2014-06-16 21:04:19 +02:00
Timm	648f7481e4	Fixed deprecated selector in form_collections_helper_test.rb with from catch_invalid_selector. Sweet.	2014-06-16 21:04:19 +02:00
Timm	82e0705bdf	Removed sanitizers- and scrubbers_test.rb. They are in rails-html-sanitizer.	2014-06-16 21:04:19 +02:00
Timm	93f2cd8645	Included DomAssertions in url_helper- and atom_feed_helper_test.rb.	2014-06-16 21:04:18 +02:00
Timm	72ce9a49cb	Removed assert_select test file, since it has been moved to rails-dom-testing.	2014-06-16 21:04:18 +02:00
Timm	5dc57db4b5	Required rails-dom-testing in test_case.rb	2014-06-16 21:04:18 +02:00
Timm	6061472b8c	Changed deprecation message in dom and selector assertions in Action Dispatch.	2014-06-16 21:04:18 +02:00
Timm	5ac99b09c4	Exchanged requiring of action view assertions with rails dom testing assertions.	2014-06-16 21:04:17 +02:00
Timm	c287572d21	Removed ActionView::Assertions. Getting ready to exchange with Rails::Dom::Testing::Assertions.	2014-06-16 21:04:17 +02:00
Timm	94ca27b190	Added rails-dom-testing and rails-html-sanitizer to Gemfile. Added tests for assert_select_email.	2014-06-16 21:04:17 +02:00
Timm	fa916af696	Removed tag.rb, since it is actually removed, not just deprecated. [ci skip]	2014-06-16 21:04:17 +02:00
Timm	a766a025e6	Moved ActionView::Assertions dependency from Action Pack's lib to abstract_unit.rb.	2014-06-16 21:04:16 +02:00
Timm	2e8132444f	Changed ActiveSupport::Derprecation.silence to assert_deprecated.	2014-06-16 21:04:16 +02:00
Timm	68e08fe8c9	Silenced deprecation warnings in the tests. Documentation uses present tense. Changed deprecation message to not use you. Also returning from rescue block in catch_invalid_selector to abort reraising the exception.	2014-06-16 21:04:16 +02:00
Timm	9ef95a7019	Added deprecation warning for invalid selectors and skipping assertions.	2014-06-16 21:04:16 +02:00
Timm	535a3b6af7	Nokogiri leaves '<' unescaped, so the assert_select looking for '&lt;' will never work. Switched to assert_matching the reponse body.	2014-06-16 21:04:15 +02:00
Timm	af05b01505	Added tests for TargetScrubber.	2014-06-16 21:04:15 +02:00
Timm	15382e9793	Rounded out PermitScrubber tests. Extracted helper methods to a ScrubberTest class.	2014-06-16 21:04:15 +02:00
Timm	b4cfb59f42	Moved some tests to scrubbers_test.rb. Added better testing of accessor validation.	2014-06-16 21:04:15 +02:00
Timm	facc4f3c0a	Added some test coverage for PermitScrubber.	2014-06-16 21:04:14 +02:00
Timm	ddc24fda90	Changed PermitScrubber's direction to bottom up to align better with Loofah's strip scrubber.	2014-06-16 21:04:14 +02:00
Timm	7f9106d5d9	Now only requiring Loofah in the places where it is needed.	2014-06-16 21:04:14 +02:00
Timm	19406dad7d	Minor rewording in TargetScrubber documentation.	2014-06-16 21:04:14 +02:00
Timm	7cd2eb516e	Added deprecation notice to actionpack changelog.	2014-06-16 21:04:14 +02:00
Timm	240ac66705	Updated Action View changelog entries with more information about the changes in the API. Removed mention of mentor (at his request).	2014-06-16 21:04:13 +02:00
Timm	dd19557551	Stylistic improvements in ActionView::Assertions::DomAssertions.	2014-06-16 21:04:13 +02:00
Timm	0a0d151bb8	Now returning html if html is blank? in FullSanitizer and WhiteListSanitizer. This means it'll return false if called with false, however that is not a valid use case.	2014-06-16 21:04:13 +02:00
Timm	5430487d85	Stylistic improvements. Some light documentation for remove_xpaths.	2014-06-16 21:04:13 +02:00
Timm	170f414928	Removed require's for html-scanner.	2014-06-16 21:04:12 +02:00
Timm	229092ffee	Changed test expectation from '<<' to '' with string to sanitize '<<<bad html>' in sanitizers_test.	2014-06-16 21:04:12 +02:00
Timm	4e97d7585a	Added deprecation warning to ActionDispatch::Assertions::TagAssertions.	2014-06-16 21:04:12 +02:00
Timm	cb865e1a7b	Removed dom_assertion method since it created bugs.	2014-06-16 21:04:12 +02:00
Timm	01e6e1d491	Fixed uninitialized constant ActionView::HTML error entered after recent git rebase.	2014-06-16 21:04:12 +02:00
Timm	2563c2cec3	Removed a bunch of duplicated tests in SanitizeHelperTest.	2014-06-16 21:04:11 +02:00
Timm	7f7a1b5d6b	Removed unnecessary documentation in DomAssertions.	2014-06-16 21:04:11 +02:00
Timm	97d20b1417	Removed case statement in equal_children? used child.element? instead.	2014-06-16 21:04:11 +02:00
Timm	905d2bc605	Reworked some internal documentation for equal_attribute_nodes?.	2014-06-16 21:04:11 +02:00
Timm	d6067e8193	Changed attributes_are_equal? to equal_attribute_nodes? which takes attribute_nodes instead of nodes.	2014-06-16 21:04:10 +02:00
Timm	73c690d4fd	Removed html_strings variable, no splat operator needed.	2014-06-16 21:04:10 +02:00
Timm	bab54e4e52	Changed back to =~ or == comparison in HTMLSelector filter.	2014-06-16 21:04:10 +02:00
Timm	62171784fe	Simplified the removal of xpaths in remove_xpaths. Added more tests for remove_xpaths.	2014-06-16 21:04:10 +02:00
Timm	c1a7864930	Fixed: added apostrophe to possessive noun.	2014-06-16 21:04:09 +02:00
Timm	5169b00330	Extracted: create Regexp from match_with and use =~ to compare instead of checking .is_a? Regexp every time through the loop.	2014-06-16 21:04:09 +02:00
Timm	e600b3a341	Changed conditional check in filter. Removed weird comments.	2014-06-16 21:04:09 +02:00
Timm	4b55c0aa2e	Moved: initial assignment of @selector_is_second_argument is now in initialize.	2014-06-16 21:04:09 +02:00
Timm	cabef1415a	Changed: using duck typing instead of requiring subclasses of Node and NodeSet.	2014-06-16 21:04:08 +02:00
Timm	65ed2b6371	Renamed: HTMLSelector css_selector to selector.	2014-06-16 21:04:08 +02:00
Timm	9a536bc195	Removed unnecessary lines from HTMLSelector initialize.	2014-06-16 21:04:08 +02:00
Timm	ce4396b366	Changed: put selector extraction into selector_from, which is renamed to extract_selector.	2014-06-16 21:04:08 +02:00