Commit Graph

16458 Commits

Author SHA1 Message Date
Jaime Iniesta
844b195292 Fixed XHTML on activerecord_validation_callbacks guide 2010-05-24 19:00:37 +02:00
Jaime Iniesta
d85b3ef3c1 Added info about guides validation to Contribute guide 2010-05-24 18:30:47 +02:00
Jaime Iniesta
781692d583 Fixed minor typo on credits 2010-05-24 18:12:24 +02:00
Jaime Iniesta
3391cb903e Merge branch 'w3c_validator' 2010-05-24 18:07:48 +02:00
Jaime Iniesta
7db557f152 New rake validate_guides task to validate output/*.html against the W3C Validator 2010-05-24 18:07:08 +02:00
Rohit Arondekar
c36374e768 Getting Started, don't forget to link to yourself if you are adding to the changelog. 2010-05-21 06:53:45 -07:00
Rohit Arondekar
0244b43ecd Minor typo fix in callbacks.rb of abstract_controller 2010-05-20 03:23:21 -07:00
Xavier Noria
7f07cc364a Merge remote branch 'rails/master' 2010-05-19 23:29:39 +02:00
Xavier Noria
b9fcd8d71f in Ruby things in general happen at runtime, no need to specify that 2010-05-19 23:27:09 +02:00
Santiago Pastorino
61001e766d group :mri deleted in favor of RUBY_ENGINE and RUBY_VERSION usage.
Allow use json, yajl-ruby and nokogiri on MRI and Rubinius only.
jruby-debug added only for jruby platform

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-05-19 21:32:45 +02:00
Neeraj Singh
39a246f545 Final iteration of use better testing methods
[#4652 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-05-19 21:31:51 +02:00
Anil Wadghule
bdb2871df7 Fix xml serialization test [#4650 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-05-19 13:02:13 +02:00
Santiago Pastorino
5573ab2047 Enable ruby-debug only for MRI
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-05-19 12:59:53 +02:00
Santiago Pastorino
715f7c0b7c Fixes a test on transaction_callbacks_test.rb
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-05-19 12:59:47 +02:00
Santiago Pastorino
59c7b0c23a Avoid instance variable @output_buffer not initialized
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-05-19 12:59:29 +02:00
Neeraj Singh
b462952886 Use better assertion methods for testing
[#4645 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-05-19 10:18:36 +02:00
Neeraj Singh
1c3d2a5a60 Updating the doc with the info that class_inheritable_accessor
copies properties to child at runtime
2010-05-19 01:29:15 -04:00
Josiah Ivey
695cabce39 Testing guide: Replace removed word 2010-05-18 23:04:10 -05:00
Josiah Ivey
256e13b3a3 Testing guide: Grammar, punctuation, and emphasize that test/unit is only the default 2010-05-18 22:55:15 -05:00
Marius Nuennerich
aa4fe9fb33 fix documentation typo
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-05-18 19:29:17 -03:00
Xavier Noria
b753b4a076 removes deprecations of last_(month|year) from master, they will be deprecated in 2.3 instead 2010-05-19 00:20:10 +02:00
Jeremy Kemper
223d6415d0 Revert "Don't carry default value when changing column for a binary type on MySQL"
Broke mysql tests.

This reverts commit edec1afe25014749f0e2df86d27477b45586a9e3.

Conflicts:

	activerecord/test/cases/migration_test.rb

[#3234 state:open]
2010-05-18 11:02:39 -07:00
Étienne Barrié
3809c80cd5 make add_index and remove_index more resilient; new rename_index method; track database limits
[#3452 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2010-05-18 10:55:41 -07:00
José Valim
d3e62fc57c Avoid creating a Rack::Response object in the cookie middleware since it may stream the body. 2010-05-18 17:47:56 +02:00
Santiago Pastorino
03c3d1eb84 Fixes transaction callbacks tests
[#4640 state:committed]

Signed-off-by: wycats <wycats@gmail.com>
2010-05-18 19:32:37 +04:00
Ian White
b439d85a19 Nested records (re: autosave) are now updated even when the intermediate parent record is unchanged [#4242 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-05-18 16:13:00 +02:00
Neeraj Singh
ce20b93606 assert_equal should be used instead of assert
[#4629 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-05-18 16:13:00 +02:00
Neeraj Singh
0ef13afef5 expected value should come first in assert_equal
[#4630 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-05-18 16:13:00 +02:00
Neeraj Singh
d00afeaeed Use assert_equal correctly in actionmailer test (exposing one as broken)
[#4626 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-05-18 16:12:59 +02:00
Neeraj Singh
0dab076a08 Better error messages for some of ActiveSupport tests
[#4635 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-05-18 16:12:59 +02:00
Neeraj Singh
c00f8e49ad assert should be replaced with assert_equal in a particular test case
[#4636 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-05-18 16:12:59 +02:00
Pratik Naik
5ddc904941 Remove Model.clear_default_scope 2010-05-18 12:22:23 +01:00
José Valim
c536835957 Cut the fat and make session stores rely on request.cookie_jar and change set_session semantics to return the cookie value instead of a boolean. 2010-05-18 03:18:23 +02:00
rohit
8e3c3b06dc Fixed numericality validator in ActiveModel to reject hex numbers for floats completely [#4622 state:commited]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-05-18 03:10:56 +02:00
rohit
05e3fb45ee Add a valid hex that shouldn't be valid to ActiveModel numericality tests [#4622 state:commited]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-05-18 03:10:55 +02:00
Neeraj Singh
73f0e1a842 Use assert_respond_to because it has better error messaging
[#4628 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-05-18 02:12:06 +02:00
José Valim
26e645fa00 Remove deprecated methods since 2-3-stable. 2010-05-18 02:11:50 +02:00
José Valim
0c3cde404a Kill legacy dispatcher. 2010-05-18 02:07:59 +02:00
José Valim
25f7c030e4 Simplify cookie_store by simply relying on cookies.signed. 2010-05-18 02:05:20 +02:00
José Valim
941b653627 Rely on set and delete cookie logic from rack. 2010-05-18 01:51:45 +02:00
Rizwan Reza
8c5e1652c7 Renames Array#rand -> Array#random_element
Signed-off-by: Xavier Noria <fxn@hashref.com>
2010-05-17 23:03:16 +02:00
wycats
f09d8f3e68 Merge remote branch 'origin/master' 2010-05-17 19:51:30 +04:00
wycats
c3b7471c69 Merge branch 'encodings' 2010-05-17 19:42:00 +04:00
wycats
80b60671f7 Revert "Moved encoding work in progress to a feature branch."
This reverts commit ade756fe42423033bae8e5aea8f58782f7a6c517.
2010-05-17 19:41:54 +04:00
wycats
02c36cf5cb Make sure encoding changes don't break 1.8 2010-05-17 19:39:38 +04:00
Santiago Pastorino
c7e6777961 Added default currency values to NumberHelper and pass them to I18n.translate
[#4604 state:committed]

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-05-17 17:39:33 +02:00
José Valim
107c6381a0 Allow root to be given in the resources scope without need to specify :on => collection. 2010-05-17 17:39:32 +02:00
Jeremy Kemper
5371242384 Valid hex strings aren't valid float column values, to match the integer restriction. [#4622 state:resolved] 2010-05-17 07:58:26 -07:00
Paco Guzman
c2fb8afaa0 Use assert_equal correctly in transaction callback tests (exposing some of them as broken)
[#4612]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2010-05-17 07:16:53 -07:00
Josiah Ivey
ea9398f9ba Guides: Fix numerous broken links 2010-05-16 21:58:47 -05:00