Commit Graph

23375 Commits

Author SHA1 Message Date
Jon Leighton
86bbba1ffb Add support for using an ARCONFIG environment variable to specify the location of the config.yml file for running the tests 2011-06-12 19:08:16 +01:00
Jon Leighton
15e289147e Oops, this should have been in the last commit 2011-06-12 19:05:29 +01:00
Jon Leighton
c52520166b Make assert_no_queries literally enforce that there are no queries. As in, not a single line of SQL should be sent to the database, not even stuff that is ignored by assert_queries. The argument being that if you write assert_no_queries, you really do not want there to be any queries. 2011-06-12 18:50:24 +01:00
Jon Leighton
232c66a1ba If we're going to use a global variable, let's at least namespace it 2011-06-12 18:38:39 +01:00
Jon Leighton
b09bbdb8bf Replace inline lambdas with named methods 2011-06-12 18:19:22 +01:00
Jon Leighton
14e6bbb149 Refactor tests to be less brittle 2011-06-12 18:19:21 +01:00
Jon Leighton
de01a64102 Move BEGIN and COMMIT into IGNORED_SQL rather than having them as a special case in assert_queries 2011-06-12 18:19:21 +01:00
benedikt
fa8dfad765 Don't wrap operations on collection associations in transactions when they are not needed, so the connection adapter does not send empty BEGIN COMMIT transactions blocks to the database. 2011-06-12 18:19:21 +01:00
Andrew White
1fa059cd01 Define ActiveSupport#to_param as to_str - closes #1663 2011-06-12 15:32:46 +01:00
Xavier Noria
cd99784d99 Merge branch 'master' of github.com:rails/rails 2011-06-12 15:04:15 +02:00
Xavier Noria
caadef9dd4 backslash insertion for RDoc main page ignores code blocks, also adds comments to explain what's this hack about 2011-06-12 15:03:28 +02:00
José Valim
04407a7b8a Make i18n tests more robust. 2011-06-12 12:45:09 +02:00
Xavier Noria
de757af8b0 revises the pattern that excludes generator templates in API generation
With the previous pattern RDoc processed

    railties/lib/rails/generators/rails/plugin_new/templates/test/%name%_test.rb

and that resulted in a spurious "<" class.
2011-06-12 12:09:08 +02:00
Piotr Sarnacki
e591d14b9c Update changelog with #1552 feature: add hidden field before select[multiple=true] 2011-06-11 18:24:05 +02:00
José Valim
82568bedae Update CHANGELOG. 2011-06-11 18:03:13 +02:00
José Valim
410a42860b Get rid of the alternate namespace lookup. 2011-06-11 18:01:26 +02:00
Piotr Sarnacki
f5e1548c1b Merge pull request #1552 from bogdan/select
Fixing select[multiple] html specification problem.
2011-06-11 08:21:22 -07:00
José Valim
e294009b07 No need for a configuration option here. 2011-06-11 17:10:16 +02:00
José Valim
28f2b981fc Merge pull request #549 from dlee/utf8_enforcer
Utf8 enforcer param customization
2011-06-11 08:04:06 -07:00
José Valim
1829dd9175 Merge pull request #1647 from neerajdotname/make_tests_stronger
Make tests stronger, cleaner and slimmer
2011-06-11 08:01:52 -07:00
David Lee
9b305983e3 Remove utf8_enforcer_param config option 2011-06-11 01:58:26 -07:00
David Lee
91e3046b71 Make utf8_enforcer_tag an overrideable method 2011-06-11 01:58:26 -07:00
David Lee
fa3fc52069 Make utf8 enforcer param customizeable 2011-06-11 01:58:26 -07:00
David Lee
1cbe917237 There are no snowmen here 2011-06-11 01:58:26 -07:00
Neeraj Singh
f3c9f32664 remove meaningless assert true 2011-06-11 03:11:06 -04:00
Neeraj Singh
6688b6393a expected message should come first 2011-06-11 03:11:06 -04:00
Neeraj Singh
5da89af6f6 try not to use assert_blank when nil will would
be considered as failure

Test for specific value to the extent possible
2011-06-11 03:11:05 -04:00
Santiago Pastorino and José Ignacio Costa
94df84a8a4 Revert "Make sure that we don't perform in-place mutation on SafeBuffer string"
This reverts commit 115e80dccc65c3ed9a9750649d9ca4ea2a7e64f1.
2011-06-10 23:08:00 -03:00
Santiago Pastorino
adef9764ae Merge pull request #1644 from smartinez87/warns
Remove unused variable causing warning in 1.9.3
2011-06-10 18:35:14 -07:00
Sebastian Martinez
c4ddc6f693 Remove unused variable causing warning in 1.9.3 2011-06-10 21:10:06 -03:00
Aaron Patterson
a4ee5038c1 Merge pull request #1642 from sikachu/master-render-inline
Render inline fix for master
2011-06-10 16:29:58 -07:00
Xavier Noria
ca312b6612 s/Bundle/Bundler/ 2011-06-11 01:18:08 +02:00
Xavier Noria
4699c93301 Merge branch 'master' of git://github.com/lifo/docrails 2011-06-11 00:59:46 +02:00
thoefer
029290f3de Fixed minor typo: 'Arraw' to 'Array' 2011-06-11 00:54:42 +02:00
Prem Sichanugrist
115e80dccc Make sure that we don't perform in-place mutation on SafeBuffer string
This will make sure `render :inline` is working.

Closes #1633
2011-06-10 18:51:48 -04:00
Prem Sichanugrist
3757798856 Update CHANGELOG to mention the json_escape change, and rearrange stuff a bit. 2011-06-10 18:50:57 -04:00
Xavier Noria
6c58585ff5 shell out to run bundler on app generation, see rationale in the comment 2011-06-10 23:43:24 +02:00
José Valim
8eb2b519f2 Merge pull request #1631 from vijaydev/runner-help
rails runner without any options should show usage information
2011-06-10 06:45:52 -07:00
Vijay Dev
880371ef2b make 'rails runner' show usage when run without any options 2011-06-10 18:48:50 +05:30
José Valim
78acd17f31 Merge pull request #1567 from BDQ/engine_migrations
Ensure engine migrations are copied in correct sequence
2011-06-10 04:43:43 -07:00
Brian Quinn
25ad43015c Updated test to ensure correct sequence when copying engine/plugin migrations. 2011-06-10 12:12:50 +01:00
Brian Quinn
9f2e91414f Ensure engine migrations are copied in the same sequence that they are required. 2011-06-10 12:11:45 +01:00
Andrew White
0bcbcdfdad Ensure number helpers can handle HTML safe strings - closes #1597. 2011-06-10 11:32:28 +01:00
Xavier Noria
90c4885766 Merge pull request #1523 from raghunadhd/refactor_regex
rafactored the regex related code in the mapper class
2011-06-10 03:27:45 -07:00
ganesh
262a42b12e shallow_path example updated 2011-06-10 15:53:55 +05:30
Raghunadh
46ecb53fc2 removed the unnecessary back slashes from the regular expression 2011-06-10 13:39:24 +05:30
José Valim
2bda229c2f Merge pull request #1625 from neerajdotname/page_caching
Three minor fixes to tests
2011-06-10 00:29:50 -07:00
Neeraj Singh
06d772c0ce add missing ensure 2011-06-10 02:48:44 -04:00
Neeraj Singh
fdbe8eb08c replaced and with && as per coding guidelines 2011-06-10 02:27:57 -04:00
Neeraj Singh
49d032929b The test name is misleading. It says
test_should_cache_with_trailing_slash_on_url

A trailing slash is removed when a page is cached.

What the test meant to say was : a url with trailing slash
should be cached and the cached page should not have any
trailing slash.

This patch clarifies the name a bit.
2011-06-10 02:24:37 -04:00