TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
38,875 Commits 2 Branches 0 Tags 294 MiB
8998441967
Commit Graph

38875 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Karunakar (Ruby)
8998441967 used flat_map instead of map.flatten 2013-07-25 21:58:26 +05:30
Steve Klabnik
ca3074c434 Merge pull request #11582 from steveklabnik/add_bin 
rake -> bin/rake
 2013-07-25 08:32:42 -07:00
Rafael Mendonça França
cd4feb31ce Merge pull request #11341 from arunagw/added-missing-actionview-to-install 
Added description in actionview gemspec.
 2013-07-25 07:12:11 -07:00
Carlos Antonio da Silva
7a44832899 ✂️ [ci skip] 2013-07-25 08:49:00 -03:00
Carlos Antonio da Silva
156da53eaa Merge pull request #11591 from ankit8898/typo 
Typo fix [ci skip]
 2013-07-25 04:46:25 -07:00
Carlos Antonio da Silva
0b06e901c8 Merge pull request #11593 from rajcybage/fix_test_models 
change function def self.table_name to self.table_name
 2013-07-25 04:44:26 -07:00
Rajarshi Das
5a2a703fe8 change function def self.table_name to self.table_name 
change def self.primary_key to self.primary_key

change def self.primary_key to self.primary_key
 2013-07-25 17:13:08 +05:30
Ankit Gupta
c213bf174f Typo fix 
[skip ci] Fixing the typo which is formed a not required link.  Check here http://api.rubyonrails.org/classes/ActionController/Base.html  under paramters section
keeping it under tt tag
 2013-07-25 11:57:27 +01:00
Akira Matsuda
4dd47fb9d5 More unused associations in AR test models 2013-07-25 18:52:31 +09:00
Akira Matsuda
962d2d2737 Clean up unused associations in AR test model 2013-07-25 17:29:09 +09:00
Akira Matsuda
44f785357c Use Ruby 2.0 caller_locations instead of caller if available 
* we no more have to manipulate the each caller strings by ourselves using caller_locations

* caller_locations runs slightly faster, and creates less objects than good old caller
Benchmark (loading an Engine 1000 times):
  caller: 262.89 ms
  caller_locations: 186.068 ms
 2013-07-25 17:13:53 +09:00
Akira Matsuda
3c6f35dc03 Privatize non-test method 2013-07-25 17:08:43 +09:00
Andrew White
4db0637d55 Allow overriding of all headers from passed environment hash 
Allow REMOTE_ADDR, HTTP_HOST and HTTP_USER_AGENT to be overridden from
the environment passed into `ActionDispatch::TestRequest.new`.

Fixes #11590
 2013-07-25 07:54:57 +01:00
Rafael Mendonça França
7af0ae919f Merge pull request #11585 from vipulnsward/hstore_change 
Cleanup task for informing about hstore
 2013-07-24 13:02:24 -07:00
Rafael Mendonça França
7b9a4728a0 Merge pull request #11584 from Peeja/actionmailer-guide-typo 
ActionMailer Guide: Should be "different formats".
 2013-07-24 12:52:34 -07:00
Vipul A M
1235b630fe Cleanup task for informing about hstore 2013-07-25 01:11:41 +05:30
Peter Jaros
2e0a9941a8 AM Guide: Should be "different formats". 2013-07-24 15:23:48 -04:00
Steve Klabnik
ef39ab4095 rake -> bin/rake 2013-07-24 14:50:51 -04:00
José Valim
fa265346a9 Merge pull request #11559 from bughit/11533_to_proc 
don't convert mailer default values to procs
 2013-07-24 10:13:50 -07:00
Rafael Mendonça França
758b2c3777 Merge pull request #11579 from kennyj/refactor_20130724 
Simplify select_one method.
 2013-07-24 08:57:55 -07:00
Rafael Mendonça França
82a76dfd18 Merge pull request #11570 from joelcogen/harmonize_text_field_and_area 
text_area should handle nil value option like text_field
 2013-07-24 08:53:57 -07:00
kennyj
098c9c8bc9 Fix indentation. 2013-07-24 23:26:33 +09:00
kennyj
19291bff34 Simplify select_one method. 
The select_all method always returns ActiveRecord::Result instance,
and the ActiveRecord::Result includes Enumerable mixin.
If #empty?, #first method returns nil. Thus we can simplify this method.
 2013-07-24 23:24:22 +09:00
Joel Cogen
1424873948 text_area should handle nil value option like text_field 2013-07-24 08:39:17 +02:00
Carlos Antonio da Silva
3a4d0b1e29 Refactor to use flat_map 2013-07-23 21:13:22 -03:00
Aaron Patterson
ee7516436e oops! 2013-07-23 17:08:04 -07:00
Aaron Patterson
67978d6245 eliminate conditional in JoinHelper 2013-07-23 17:02:14 -07:00
Aaron Patterson
b8aebb0261 acually get the actual source reflection 😢🔫 2013-07-23 17:02:14 -07:00
Guillermo Iguaran
2aa20b3638 Merge pull request #11107 from nettsundere/password-confirmation-fix 
Fix secure_password password_confirmation validations
 2013-07-23 16:56:36 -07:00
Vladimir Kiselev
3be0cdfa55 Fix secure_password password_confirmation validations 2013-07-24 03:14:15 +04:00
Aaron Patterson
844efb2bb0 stop relying on side effects of const_missing 2013-07-23 15:02:43 -07:00
Aaron Patterson
f38b544442 add a specific factory method rather than using new 2013-07-23 14:43:32 -07:00
Zachary Scott
b017562382 Use GeneratedAttribute#column_name if #reference? scaffold_generator in _form view [Fixes #11573] 2013-07-23 18:06:44 -03:00
Aaron Patterson
eb8d48eb3e factory methods should not have side effects. 
Move model mutation to the methods that are called on the model.
 2013-07-23 13:12:25 -07:00
Aaron Patterson
5f169b2aed extract mutation from generation method 2013-07-23 13:06:57 -07:00
Rafael Mendonça França
f8ea7c8b00 Merge pull request #11566 from rajcybage/master 
add the missing middleware in command line guides rake about [ci skip]
 2013-07-23 05:32:04 -07:00
Aaron Patterson
e69d804b5e habtm can only ever be an association reflection 2013-07-22 22:27:25 -07:00
Rajarshi Das
8690b1a895 add the missing middleware in command line guides rake about [ci skip] 2013-07-23 10:19:44 +05:30
Aaron Patterson
6e24d501d3 use the predicate method 2013-07-22 18:46:56 -07:00
Carlos Antonio da Silva
fe820a772d Stop reading the same file twice for testing different content 
assert_file already gives this functionality for free by passing
multiple contents.
 2013-07-22 22:43:38 -03:00
Aaron Patterson
d531ac0b9a AR::Base does not need to know how to create reflection objects 2013-07-22 18:28:54 -07:00
Aaron Patterson
e20dd73df4 remove unnecessary reader 2013-07-22 18:14:48 -07:00
Aaron Patterson
0aa6872dc5 only flatten one side 2013-07-22 18:12:01 -07:00
Aaron Patterson
7085aae901 extend by adding relationships rather than monkey patching 2013-07-22 18:11:36 -07:00
Aaron Patterson
bb1492e334 decouple extensions from association object state 2013-07-22 17:59:42 -07:00
Guillermo Iguaran
1ccc132832 Merge pull request #11558 from kennyj/bump_mysql2_to_0_3_13 
Uses mysql2 0.3.13 or later.
 2013-07-22 15:03:28 -07:00
Alex Tsukernik
49185875a5 don't convert mailer default values to procs 
Invoke mailer defaults as procs only if they are procs, do not convert
with to_proc.  That an object is convertible to a proc does not mean it's
meant to be always used as a proc.  Fixes #11533
 2013-07-22 14:25:20 -04:00
kennyj
71d29251a5 Uses mysql2 0.3.13 or later 2013-07-23 02:50:24 +09:00
Carlos Antonio da Silva
1c4eb13345 Leave the knowledge of boolean tag values to content tag 
content tag already knows which tags are boolean and the values that
should generate them when a truthy value is passed, so leave this logic
for it instead of duplicating when generating options tags.
 2013-07-22 14:39:45 -03:00
Carlos Antonio da Silva
b973852feb Use merge! to avoid a new hash and change some spots to 1.9 hash style 2013-07-22 14:36:10 -03:00