TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
57,833 Commits 2 Branches 0 Tags 294 MiB
94660de4e5
Commit Graph

57833 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Vipul A M
94660de4e5
Document config.action_dispatch.ignore_accept_header and config.action_dispatch.x_sendfile_header in configuring guide 2016-05-11 03:54:02 +05:30
Vipul A M
bc7a626956
More missing true literal quotings 2016-05-11 03:19:45 +05:30
Vipul A M
d6e1c83512
Lets be consistent in the usage of true/false across this guide. It should be quoted as how other config options are. They are already quoted at many places. This change, makes this usage consistent. Note that, this is quoting literal values true and false, not truthy values 2016-05-11 03:10:38 +05:30
Vipul A M
8b59b5e75e
Document missing smtp config over at configuring guide. [ci skip] 2016-05-11 02:59:30 +05:30
Vipul A M
9f525e87ab
This config still applies for Rails 4 Apps and we need to mention it, what was needed before. [ci skip] 2016-05-11 02:50:30 +05:30
Prathamesh Sonpatki
4ac4421afd
Asset Pipeline: Remove outdated comment about config.assets.digest [ci skip] 2016-05-08 18:50:42 -04:00
Prathamesh Sonpatki
d4530c9c90
Asset pipeline: Remove documentation about outdated config.assets.compress option 
[ci skip]
 2016-05-08 18:50:42 -04:00
Vipul A M
e8e9b6f25e s/words_connnector/words_connector/ 
[ci skip]
 2016-05-03 16:16:28 -05:00
Jay Hayes
43cb7acc01 Fix code formatting in docs 2016-05-03 11:37:17 -05:00
Vipul A M
25f829e43f Add example for UnknownAttributeError 
[ci skip]
 2016-05-02 03:08:59 +05:30
Prathamesh Sonpatki
707b5c00ab
Active Model: Messages for strict validation always convert attributes to human readable form [ci skip] 2016-05-01 13:41:57 -05:00
Vipul A M
7b37e3edaf Move comment up to the class, for both of the methods, and document on class level why we are doing this. 
[ci skip]
 2016-05-01 02:44:52 +05:30
Vijay Dev
9d1bf059c0 Merge branch 'master' of github.com:rails/docrails 
Conflicts:
	guides/source/configuring.md
 2016-04-29 16:00:15 +00:00
Kasper Timm Hansen
4a446220a6 Merge pull request #24776 from prathamesh-sonpatki/aj-release-notes 
Active Job: Add note about ability to configure adapters on per job basis in CHANGELOG and release notes
 2016-04-29 10:35:44 +02:00
Andrew White
f0a6cce78e Merge pull request #24762 from Envek/solid_durations_2 
[FIX] Change 1.week to create 1 week durations instead of 7 days durations.
 2016-04-29 08:36:43 +01:00
Guillermo Iguaran
97988829eb Merge pull request #24781 from maclover7/rm-env 
Remove last uses of `@env[]` and `@env[]=`
 2016-04-28 23:13:07 -05:00
Prathamesh Sonpatki
1d6f012718
Active Job: Add note about ability to configure adapters on per job basis in CHANGELOG and release notes. 
[ci skip]
 2016-04-29 07:26:26 +05:30
Jon Moss
e0b5a773cc Remove last uses of @env[] and @env[]= 
Last August (2015), @tenderlove worked to remove all `@env[]` and `@env[]=`, in
favor of using `set_header`, `get_header`, etc. (Here's an [example
commit](f16a33b68e)).

This PR should remove the last uses of these methods, and fully convert
them to the newly standardized API.
 2016-04-28 20:26:58 -04:00
Rafael França
03b62b8420 Merge pull request #24653 from kbrock/kinder_locking_column 
schema_load triggers 2nd schema_load (via locking)
 2016-04-28 18:54:31 -03:00
Keenan Brock
ba05b3c218 test the number of times the schema is loading 2016-04-28 17:48:41 -04:00
Keenan Brock
dffbba1e2a schema_load triggers 2nd schema_load (via locking) 
Currently, loading the schema (schema_load)
accesses the locking column (locking_column)
which defaults the value (reset_locking_column)
which invalidates the schema (reload_schema_from_cache)
which forces another schema load.

Good news:
The second schema_load does accesses locking_column,
but locking_column is set, so it does not reset_locking_column
and it does not trigger an infinite loop.

The solution is not invalidate the cache while default locking_column
 2016-04-28 17:48:41 -04:00
Rafael França
ef5c46d2ee Merge pull request #24770 from vipulnsward/guieds-type 
Pass over debugging guide
 2016-04-28 18:42:31 -03:00
Kasper Timm Hansen
39144740e8 Merge pull request #24772 from javiervidal/broken_links_ryandaigle 
Fix broken links to ryandaigle.com [ci skip]
 2016-04-28 17:33:59 +02:00
Javier Vidal
c6ca3de5c6 Fix broken links to ryandaigle.com [ci skip] 2016-04-28 17:27:00 +02:00
Vipul A M
9bc6015a48 Pass over debugging guide 
[ci skip]
 2016-04-28 20:00:06 +05:30
Vipul A M
895add262f Merge pull request #24764 from deivid-rodriguez/review_debugging_guide 
Review the `byebug` debugging guide [ci skip]
 2016-04-28 18:32:37 +05:30
David Rodríguez
7fb381d247 Review the byebug debugging guide 
* Several formatting fixes.
* Updated command outputs to latest version.
* Minor rewordings.

[ci skip]
 2016-04-28 14:55:51 +02:00
Vipul A M
afc4976cc7 Merge pull request #24765 from ralinchimev/fix-inconsistencies-in-rails-documentation-generate-controller-examples 
Fix inconsistent usage of a capital letter in rails generate examples [ci skip]
 2016-04-28 14:04:50 +05:30
Ralin Chimev
94481da342 Fix inconsistent usage of capital letter in rails generate command examples 2016-04-28 11:08:10 +03:00
Andrey Novikov
434df0016e
Change 1.week to create 1 week durations instead of 7 days durations. 
This is just to remove astonishment from getting `3600 seconds` from typing `1.hour`.
 2016-04-28 03:45:05 +03:00
Richard Schneeman
2c7d7c6745 Merge pull request #24761 from rubys/patch-3 
Update to the Rails 5 version of the book [ci skip]
 2016-04-27 19:25:42 -05:00
Sam Ruby
e95b139ab5 Update to the Rails 5 version of the book 2016-04-27 20:20:12 -04:00
Rafael França
da2dc68c86 Merge pull request #24759 from vipulnsward/push-initilizer-to-end 
Push action_view.collection_caching to be called towards the end
 2016-04-27 18:34:55 -03:00
Vipul A M
31458a94a6 Push action_view.collection_caching to be called towards the end, since it depends on being called after action_controller.set_configs. 
This causes, other AV initializers after it to be called after all of AC initializers, which get pulled in before since action_controller.set_configs gets called.
Hence, push initializer depending on after hook, to be called after all initializers for this railtie are done.
 2016-04-28 02:51:10 +05:30
eileencodes
f7a986012a Prep Rails 5 beta 4 2016-04-27 15:48:47 -05:00
eileencodes
ba907d6caa Fix release script to allow pre release gems 
This addition of `--pre` fixes the issue we were seeing when installing
a local copy of a pre-release rails version.
 2016-04-27 15:48:47 -05:00
Kasper Timm Hansen
940124a226 Respect gospel of Railties Gods: no on_load with after. 
We don't need no stinking `on_load` where we're going! Because
people far wiser than me (@rafaelfranca and @jeremy) know that
passing `:after` means the lib is already loaded.
 2016-04-27 22:24:28 +02:00
Jeremy Daer
c1ad19c92f
Revert "Change 1.week to create 1 week durations instead of 7 days durations." 
Regression: adding minutes/hours to a time would change its time zone

This reverts commit 1bf9fe75a6473cb7501cae544cab772713e68cef.
 2016-04-27 14:36:22 -05:00
Kasper Timm Hansen
abff83e60e Merge pull request #24752 from lsylvester/collection_caching-after-set_configs 
Ensure action_controller.cache_store is set up before configuring the collection_cache
 2016-04-27 13:56:14 +02:00
Lachlan Sylvester
4266a61285 make the collection_caching initializer run after the Action Controller configs are setup 2016-04-27 20:49:37 +10:00
Jon Moss
791bdf6fb3 Merge pull request #24747 from Erol/fix-configuration-guide-typo 
Fix typo in Configuration Guide [ci skip]
 2016-04-26 20:54:07 -04:00
Erol Fornoles
46e6a0c68c Fix typo in Configuration Guide [ci skip] 2016-04-27 08:41:41 +08:00
Derek Prior
cacded5a0e Add more info to insecure URL generation error 
I always appreciate having a bit more information as to why something is
now an error. We can use this error to tell people why what they were
previously doing is insecure and give them hints on how to fix it.

Signed-off-by: Kasper Timm Hansen <kaspth@gmail.com>
 2016-04-26 22:14:03 +02:00
Jeremy Daer
f03c27cad2
Merge pull request #24723 from lvl0nax/array_split_fix 
Little perfomance fix for Array#split.
 2016-04-26 11:41:16 -05:00
Richard Schneeman
8d4ffc81fb Merge pull request #24737 from Erol/fix-guides-typo 
Fix typo in Rails Guides [ci skip]
 2016-04-26 09:45:10 -05:00
Erol Fornoles
0aab9c6008 Fix typo in Rails Guides [ci skip] 2016-04-26 22:32:42 +08:00
lvl0nax
ffb1df52c1 Little perfomance fix for Array#split. 
Calculating -------------------------------------
before    40.770k i/100ms
after    58.464k i/100ms
-------------------------------------------------
before    629.568k (± 5.0%) i/s -      3.180M
after      1.159M (± 4.5%) i/s -      5.788M
 2016-04-26 09:21:56 +03:00
arktisklada
9d63111499
Clear ActionMailer deliveries on setup and teardown 
Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
 2016-04-25 22:41:18 -05:00
Jeremy Daer
9364d50654
Merge pull request #24641 from rafaelfranca/fix-per-form-token-with-full-url 
Discart the schema and host information when building the per-form token
 2016-04-25 21:03:33 -05:00
Alexey Shein
420730b10b
Do not cache ActiveSupport::TimeZone#utc_offset 
This can be an issue when TZInfo::TimeZone#current_period is refreshed
due to timezone period transition, but it's not reflected in
ActiveSupport::TimeZone object.

For example, on Sun, 26 Oct 2014 22:00 UTC, Moscow changed its TZ from
MSK +04:00 to MSK +03:00 (-1 hour). If ActiveSupport::TimeZone['Moscow']
happens to be initialized just before the timezone transition, it will
cache its stale utc_offset even after the timezone transition.

This commit removes cache and fixes this issue.

Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
 2016-04-25 20:55:33 -05:00