Commit Graph

13218 Commits

Author SHA1 Message Date
Carlhuda
98f77e0827 Rename named_url_helpers to url_helpers and url_helpers to url_for 2010-02-26 15:04:50 -08:00
Santiago Pastorino
f10a019452 no more warning ambiguous first argument; put parentheses or even spaces on log_subscriber_test 2010-02-26 14:54:18 -08:00
Santiago Pastorino
b25c41e6d8 no more warning interpreted as argument prefix on association_preload.rb 2010-02-26 14:54:10 -08:00
Santiago Pastorino
b4b158ee10 no more interpreted as grouped expression warnings on array_ext_test 2010-02-26 14:54:02 -08:00
Yehuda Katz
1e95f019bb Fix 1.9 issue 2010-02-26 14:31:29 -08:00
Jeremy Kemper
47260598be CI: restore sudo for bundler gem install 2010-02-26 09:14:12 -08:00
Jeremy Kemper
e1daf3fb73 Remove bin dir from .gitignore 2010-02-26 08:09:09 -08:00
José Valim
e6dffb70e6 reload! on console now works as expected. [#3822 status:resolved] 2010-02-26 12:09:39 +01:00
José Valim
bd36418c51 Fix controller_path returnsing an empty string in Ruby 1.8.7 [#4036 status:resolved] 2010-02-26 11:51:21 +01:00
Tobias Bielohlawek
4db72b702f fixed a 'RecordNotFound' bug when calling 'reload' on a object which doesn't met the default_scope conditions, added test [#3166 status:resolved]
The reload method didn't made use of 'with_exclusive_scope' when reloading the object. This lead to a RecordNotFound exception, in case the object doesn't met the default_scope condition (anymore) - which is obviously a bug. This quick fix makes use of with_exclusive_scope in the reload method as well. See test for full example.

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-02-26 11:14:16 +01:00
Dr Nic Williams
b56b9ee7d6 #add_source: Fixed docco + added required newline to line added to Gemfile
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-02-26 11:11:35 +01:00
Henry Hsu
bf9a0ae12b Fix a bug where default_scope was overriding attributes given on model initialization [#3218 status:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-02-26 11:09:43 +01:00
Ramon Soares
79c47abe6c the folder public/javascripts should be created by default [#4027 status:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-02-26 10:54:44 +01:00
José Valim
36a234609d Update thor dependency. 2010-02-26 10:51:13 +01:00
José Valim
5893baa683 Add autoload to generators modules and fix failing test. 2010-02-26 10:44:53 +01:00
José Valim
b48beb6986 Add missing require on abstract_controller/collector [#4061 status:resolved] 2010-02-26 10:27:06 +01:00
Carlhuda
f863045c45 Rename metaclass to singleton_class 2010-02-25 17:56:58 -08:00
Carlhuda
8760add31a Get URL helpers working again in integration tests. 2010-02-25 17:53:30 -08:00
Carlhuda
fc4582fb66 Final pass at removing the router from a global constant 2010-02-25 17:53:29 -08:00
Carlhuda
36fd9efb5e Continued effort to deglobalize the router 2010-02-25 17:53:01 -08:00
Carlhuda
9a5be2e5a8 Get Railties tests passing 2010-02-25 17:53:01 -08:00
Carlhuda
1fb2c6f635 Get ActionMailer's tests passing with the non global router 2010-02-25 17:53:01 -08:00
Carlhuda
a278f23310 Fix all of AP's tests with the non global router 2010-02-25 17:53:01 -08:00
Carlhuda
4b038f638d Merge branch 'master' of github.com:rails/rails 2010-02-25 17:53:01 -08:00
Carlhuda
226dfc2681 WIP: Remove the global router 2010-02-25 17:53:00 -08:00
José Valim
76237f163f Application detection should also allow dots in the path. 2010-02-26 02:35:14 +01:00
Jeremy Kemper
1ff7e566fd Bump to Bundler 0.9.8. Remark on RubyGems 1.3.6 fix. 2010-02-25 16:55:42 -08:00
Jeremy Kemper
6e78fdbef0 Remove doubled period 2010-02-25 16:45:59 -08:00
Jeremy Kemper
e2795383cf Update plugin tasks dirs deprecation warning 2010-02-25 16:32:24 -08:00
Jeremy Kemper
66d537852b Bump i18n for new public I18n.normalize_keys 2010-02-25 15:06:11 -08:00
Jeremy Kemper
2ba6049506 Accept array of attributes as arg also, like 2.3 2010-02-25 13:07:48 -08:00
Jeremy Kemper
763f32ab47 metaclass deprecated in 2.3.6 2010-02-25 11:12:27 -08:00
Jeremy Kemper
ffc45f3e71 Fix dangling klass reference 2010-02-25 11:01:15 -08:00
Jeremy Kemper
0b87d114bd Missed singleton_class 2010-02-25 10:57:29 -08:00
Jeremy Kemper
c7f9e8c06c Fix test on 1.8.8. Broken by inherited hook now running before Class.new block. 2010-02-25 10:46:29 -08:00
Thomas R. Koll
45ceacd6de load_path is expecting a String in the application.rb generator
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2010-02-25 10:45:34 -08:00
Jeremy Kemper
f7b0a857e9 Use Object#singleton_class instead of #metaclass. Prefer Ruby's choice. 2010-02-25 09:32:29 -08:00
Jeremy Kemper
6b12d74026 Commented metaprogramming turned out to be noisier not clearer 2010-02-25 09:28:18 -08:00
David Heinemeier Hansson
bf0f14579a let the rails command recurse upwards looking for script/rails, and exec ruby on it for better portability [Xavier Noria] (Closes #4008) 2010-02-25 08:32:37 -08:00
David Heinemeier Hansson
a524d42acc Merge branch 'master' of github.com:rails/rails 2010-02-25 08:31:49 -08:00
Santiago Pastorino
f76eaa4b7c add time_separator for minutes only if minutes aren't hidden
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2010-02-25 08:31:02 -08:00
Santiago Pastorino
529d0f5812 add time_separator for minutes only if minutes aren't hidden
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2010-02-24 18:40:44 -08:00
José Valim
df85ab41c1 Renamed LocalizedCache to DetailsCache. 2010-02-24 22:17:26 +01:00
José Valim
9d7d6cd7ba Use render instead render_to_body. 2010-02-24 22:17:25 +01:00
José Valim
a39c7505bd Cleanup render callstack and make render(:json => {}, :status => 401) work again. 2010-02-24 22:17:25 +01:00
Carl Lerche
6a061187e2 Remove ActionController::Base.resources_path_names 2010-02-24 10:52:16 -08:00
Carl Lerche
ba57575e03 Remove references to ActionDispatch::Routing::Routes in favor of Rails.appication.routes. 2010-02-24 10:52:16 -08:00
José Valim
60ca754b97 Remove the renderer option from the hash. 2010-02-24 15:45:33 +01:00
Yehuda Katz
ae933a093d Fix render :file => "#{Rails.root}/public/404.html", :status => :not_found. Closes #8994 2010-02-23 22:45:42 -08:00
Carlhuda
47498a7f59 Woops, forgot to actually add active_support/core_ext/file/path.rb 2010-02-23 17:42:26 -08:00