TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
91,784 Commits 2 Branches 0 Tags 294 MiB
a054307bbc
Commit Graph

91784 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
David Heinemeier Hansson
f0572dc6c3 Missing CR for style 2024-05-14 16:57:31 -07:00
Rafael Mendonça França
f4d2b209d6
Merge pull request #51557 from grcooper/grcooper/pass-options-to-write-entry 
[Bugfix] Pass options along to write_entry in handle_expired_entry method
 2024-05-14 19:11:43 -04:00
Graham Cooper
b09ae673ab
Pass options to write_entry in handle_expired_entry method 2024-05-14 22:56:50 +00:00
David Heinemeier Hansson
33592402f9 Remove default .env from Kamal and just rely on .env.erb (Closes #51829) 2024-05-14 15:36:43 -07:00
Carlos Antonio da Silva
5e3611ea5a
Merge pull request #51732 from Shopify/fix-rails-console-prompt 
Avoid setting fixed app name in console prompt
 2024-05-14 18:56:21 -03:00
Rafael Mendonça França
d60890c653
Merge pull request #51828 from Shopify/refacotor-change-generator 
Refactor change generator database implementation
 2024-05-14 16:51:23 -04:00
Andrew Novoselac
764489b095 Refactor change generator database implementation 
The database object does not need to know about the other packages in the Dockerfile. This info is only needed for the change generator so lets move it there.
 2024-05-14 15:59:01 -04:00
Rafael Mendonça França
4b4171b80e
Merge pull request #51827 from Shopify/remove-unsupported-db-templates 
Remove Oracle, SQLServer and Jbdc templates
 2024-05-14 15:52:18 -04:00
Rafael Mendonça França
282d6efc62
Don't require Kamal 2024-05-14 19:18:46 +00:00
Andrew Novoselac
08d82adf80 Remove Oracle, SQLServer and Jbdc templates 
These are no longer used as of rails/rails@5b91084 so the templates can be removed.
 2024-05-14 14:56:49 -04:00
Andrew Novoselac
de7bf12e46 Remove support for SQLServerAdapter, OracleAdapter and JBDC adapters in tests 
As of rails/rails@8eae753 we are no longer supporting these and do not need to test them.
 2024-05-14 14:56:16 -04:00
Rafael Mendonça França
af33bef906
Install kamal as a development gem 
We need this gem to be able to run the generators test.

Closes #51816.
 2024-05-14 18:48:55 +00:00
Rafael Mendonça França
b967d51346
Merge pull request #51819 from tnir/tn-mysql2-on-mac-pr44766 
Remove deprecated problem from local dev guide
 2024-05-14 14:14:46 -04:00
Rafael Mendonça França
52b417bca6
This will be released in 7.2, not 8 2024-05-14 18:05:40 +00:00
Eileen M. Uchitelle
245af31c30
Merge pull request #51823 from Shopify/gm/memoize-queue_adapter_for_test 
[Bugfix] Memoize `queue_adapter_for_test`
 2024-05-14 13:27:52 -04:00
Eileen M. Uchitelle
db4bbb7b63
Merge pull request #51825 from Shopify/fix-gemfile-lock 
Fix outdated Gemfile.lock
 2024-05-14 13:26:27 -04:00
George Ma
9b069eed46 Add regression test for memoized queue adapter 2024-05-14 13:06:48 -04:00
Andrew Novoselac
4c243279ac Fix outdated Gemfile.lock 
rails/rails@8eae753 removed jruby and oracle gems from the Gemfile but did not update Gemfile.lock
 2024-05-14 12:36:55 -04:00
George Ma
94c6de51bc Memoize queue_adapter_for_test 
Co-authored-by: Étienne Barrié <etienne.barrie@shopify.com>
 2024-05-14 12:21:23 -04:00
Takuya Noguchi
b9b23111b4 Remove deprecated problem from local dev guide 
mysql2 gem, as of mysql2 0.5.6, can now be compiled
with openssl@3 without any option on macOS. Also as
openssl@1.1 got EOL'd on 2023-09-11, we should not
recommend to use it.

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
 2024-05-14 14:35:18 +00:00
Carlos Antonio da Silva
0be846c893
Merge pull request #51758 from taketo1113/fix-changed-cidr2 
PostgreSQL Cidr#change? raise an error of NoMethodError: undefined method `prefix' for nil, when creating a record with an empty value of inet/cidr column.
 2024-05-14 09:59:51 -03:00
Ryuta Kamizono
1b6b1a9cb9
Merge pull request #51788 from fatkodima/batch_enumerator-destroy_all-returns-rows-number 
Change `BatchEnumerator#destroy_all` to return the total number of affected rows
 2024-05-14 21:13:55 +09:00
Jean Boussier
a8d26789a4
Merge pull request #51815 from byroot/cached-find-by-connection-lease 
Eliminate `lease_connection` call in `cached_find_by`
 2024-05-14 15:20:07 +09:00
Jean Boussier
33f6c49118 Appease the linter 2024-05-14 15:19:03 +09:00
Jean Boussier
4ca838b899 Eliminate lease_connection call in cached_find_by 
Fix: https://github.com/rails/rails/issues/51811
 2024-05-14 15:12:12 +09:00
Jean Boussier
2e7dc14943
Merge pull request #51810 from Shopify/cache-association-loaded 
Only serialize associations that were loaded
 2024-05-14 09:37:39 +09:00
Jean Boussier
db4dba78c9 Only serialize associations that were loaded 
Fix: https://github.com/rails/rails/issues/51807

`association_cached?` only means the Association object was
created, not that the records were loaded.

Co-Authored-By: benk-gc <bkyriakou@gocardless.com>
 2024-05-14 09:37:23 +09:00
David Heinemeier Hansson
bee3fa41ca
Add Kamal by default to Rails 8 (#51798) 
* Add Kamal by default
 2024-05-13 17:32:42 -07:00
Taketo Takashima
c395b99f11 Fix PostgreSQL Cidr#change?: NoMethodError: undefined method prefix for nil 2024-05-14 08:43:51 +09:00
fatkodima
94af7c181a Change BatchEnumerator#destroy_all to return the total number of affected rows 2024-05-13 22:54:25 +03:00
Rafael Mendonça França
8eae75379c
Remove jruby and oracle related gems from Gemfile 
We are only know goign to support mysql2, trilogy, postgresql and sqlite3
adapters in Rails.
 2024-05-13 19:19:04 +00:00
Ryuta Kamizono
36885949a9
Merge pull request #51787 from fatkodima/fix-touch_all-with-aliased-attribute-for-update 
Fix `ActiveRecord::Relation#touch_all` with custom attribute aliased as attribute for update
 2024-05-14 03:55:58 +09:00
Rafael Mendonça França
a0e8ea1341
Add Highlights section in the Rails 7.1 release notes 2024-05-13 18:41:52 +00:00
Rafael Mendonça França
66eda9c1d9
Merge pull request #51789 from Shopify/reference-devcontainer-guides-in-dockerfile 
Reference the dev container guides in a comment in the production doc…
 2024-05-13 14:29:20 -04:00
Rafael Mendonça França
a70d89c519
Merge pull request #51766 from Shopify/revert-actionable-errors-retry 
Revert "Merge pull request #50941 from andrewn617/actionable-cli"
 2024-05-13 18:28:42 +00:00
Rafael Mendonça França
a4d58ddea7
This will be released in 7.2 2024-05-13 18:20:53 +00:00
Rafael Mendonça França
cb1c789ca2
Merge pull request #51765 from Shopify/refactor-devcontainer-implementation 
Clean up database generators implementation
 2024-05-13 14:19:44 -04:00
Andrew Novoselac
eeec15c02c Point user to devcontainer for containerized dev environment 2024-05-13 14:12:14 -04:00
Rafael Mendonça França
5c933a3d82
Merge pull request #51791 from duduribeiro/add-name-to-devcontainer-compose 
Add name to DevContainer compose file
 2024-05-13 14:10:47 -04:00
Andrew Novoselac
c1bc7ee82e Refactoring Database generators 
Extract all the DB information (gems, dockerfile packages, devcontainer etc.) into an object. This let's us remove the growing number of case statements in this code.
 2024-05-13 14:07:47 -04:00
Andrew Novoselac
5b91084f20 Remove support for oracle, sqlserver and JRuby specific database adapters from the new and db:system:change commands. The supported options are sqlite3, mysql, postgresql and trilogy. 2024-05-13 14:07:47 -04:00
Rafael Mendonça França
3e08223ece
Fix rubocop 
See https://github.com/rubocop/rubocop/issues/12898 for the issue.
 2024-05-13 18:04:01 +00:00
Cadu Ribeiro
f63d344ce9 Add name to DevContainer compose file 
Currently when you generate a project the compose.yaml generated
file does not include the top-level name property. Not having this
top-level name property makes all containers / volumes started by
devcontainer to be prepended with the folder name, which is
`devcontainer` in the case of the .devcontainer/compose.yml` file.

This is ok if you run only one project with devcontainer but starts
to get problem if you run multiple projects. If you have one project
that runs on postgresql 15 and a new one that runs on postgresql 16 it
will fail to boot the postgresql container because both devcontainers is
using the same volume: `devcontainer_postgres-data`.

This commit fixes this by setting the top-lavel name property with
the project name, which will make the containers and volumes to be
prepended with the project name and not with `devcontainer`.
 2024-05-13 14:26:46 -03:00
Rafael Mendonça França
bf59d363fb
Clean CHANGELOG for 8.0 2024-05-13 16:55:52 +00:00
Rafael Mendonça França
dc96d29d2b
Reapply "Rails 8 will target Ruby 3.3+ only for new apps" 
This reverts commit 64ab211892ba53a5709bcb543121337df45e0c81.
 2024-05-13 16:46:39 +00:00
Rafael Mendonça França
37fd0e7fe4
Development of Rails 8.0 starts now 
🎉
 2024-05-13 16:45:20 +00:00
Carlos Antonio da Silva
a6e2bb04dd
Merge pull request #51651 from heka1024/support-duration-in-xml 
Support duration in `ActiveSupport::XmlMini`
 2024-05-13 13:34:50 -03:00
Rafael Mendonça França
749d337809
Merge pull request #51804 from zzak/lint-debugger 
Enable Lint/Debugger
 2024-05-13 12:27:50 -04:00
Rafael Mendonça França
48d628501f
Merge pull request #51808 from koic/suppress_rubocop_output_when_code_generation 
Suppress RuboCop output when there are no offenses in code generation
 2024-05-13 12:19:28 -04:00
Yasuo Honda
d2cf718093
Merge pull request #51806 from yahonda/follow_up_51571 
Use `foreign_key` option for destroy_async test models
 2024-05-13 22:18:31 +09:00