Commit Graph

2680 Commits

Author SHA1 Message Date
Aaron Patterson
a3f96f16f4 save a few method calls 2010-10-22 17:31:28 -07:00
Aaron Patterson
cc12047372 removing wtfalse 2010-10-22 13:37:51 -07:00
Xavier Noria
d619b9d1d1 Merge branch 'master' of git://github.com/lifo/docrails 2010-10-19 23:07:29 +02:00
Xavier Noria
df044ec4ac explains why ERB::Util#h is removed before being re-aliased 2010-10-18 17:24:30 +02:00
Santiago Pastorino
460c4efd71 Merge CHANGELOGs from 3-0-stable 2010-10-18 12:24:41 -02:00
Neeraj Singh
ea14396c45 replace if ! with unless
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-10-17 12:26:32 -02:00
Neeraj Singh
a38e653a6d json_escape makes json invalid doc change [#1485 state:resolved] 2010-10-16 21:57:19 +02:00
Rob Zolkos & Xavier Noria
bc1bcddede implements weeks_ago and prev_week for Date/DateTime/Time [#5122 state:committed] 2010-10-16 02:23:23 +02:00
Aaron Patterson
eaa7605e2f Revert "refactor delete a little"
This reverts commit f3f34bce8fc2895e05c4a06bb4105d6155fa423d.
2010-10-15 10:23:05 -07:00
Xavier Noria
21ff8849bb in regexps, the dot in a character class is not a metacharacter 2010-10-15 16:31:00 +02:00
Xavier Noria
13f7f89bda Merge branch 'master' of git://github.com/lifo/docrails 2010-10-14 23:15:23 +02:00
Aaron Patterson
ab1a661533 Revert "speeding up flattened version of OrderedHash.[]"
This reverts commit 9c53e82d66d0c34b8f35609b7972f28521d5794d.
2010-10-13 21:06:07 -07:00
Aaron Patterson
9c53e82d66 speeding up flattened version of OrderedHash.[] 2010-10-13 21:04:42 -07:00
Aaron Patterson
f3f34bce8f refactor delete a little 2010-10-13 20:51:51 -07:00
Aaron Patterson
86b02e7bb1 use unless instead of if ! 2010-10-13 20:44:26 -07:00
Aditya Sanghi
a0b53b25b6 fix time.to_formatted_time(:time) example 2010-10-13 01:39:22 +05:30
wycats
cc8e386d08 Always pull in version for frameworks (standardize autoload / require / none) 2010-10-10 16:12:04 -07:00
Barry Sears
de05e1c33c Make ActiveSupport load own version.
[#5739 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-10-10 19:46:49 -02:00
Wincent Colaiuta
f659a1576f Fix misleading advice to add 'memcache' to Gemfile
[#5539 state:committed]

Commit 57144388f removed the hard-coded dependency on the memcache-client
gem, and added this warning advising people to install it if needed. The
problem is, however, that if people follow the advice literally and install
the 'memcache' gem, they will wind up with a completely different thing,
which is not API compatible with the memcache-client gem and which Rails
can't work with.

So, be explicit and tell users to install the 'memcache-client' gem.

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-10-10 14:30:22 -02:00
Andrea Campi
d80afed620 Override #store to be consistent with #[].
[#5775 state:resolved]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-10-10 14:06:44 -02:00
José Valim
f1f2fb8ae7 Cleanup logger a bit. 2010-10-08 16:14:39 +02:00
Xavier Noria
db520042b3 Merge branch 'master' of git://github.com/lifo/docrails 2010-10-06 23:16:13 +02:00
Erik Michaels-Ober
19a5f99685 Fix copy/paste bug
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-10-06 09:21:01 +02:00
Aaron Patterson
b7c49cedba calling correct method on minitest for test name when teardown callback fails 2010-10-04 09:34:34 -07:00
Aaron Patterson
ccf228b027 [#5406 state:resolved] calling the correct method on minitest to obtain the test name 2010-10-04 09:33:35 -07:00
Marcelo Giorgi
860d7c566b Correct documentation that references how *_filter of action_pack are translated into set_callback/run_callback's (from active_support) invocations. 2010-10-03 20:54:08 -02:00
Santiago Pastorino
5836af8f8b PERF: more Hash + map changes 2010-10-03 16:33:46 -02:00
Aaron Patterson
6e1df2ca46 remove another lolinject 2010-10-01 17:55:39 -07:00
Aaron Patterson
61e8b23fe5 speed up index_by by removing a lolinject 2010-10-01 17:37:34 -07:00
Aaron Patterson
ff2fdcc52b removing AS::Testing::Default in favor of just undefing default_test 2010-10-01 17:22:42 -07:00
Emilio Tagua
71acc2737a Move uri parser to AS as URI.parser method to reuse it in AP and ARes. 2010-09-28 11:38:35 +08:00
Xavier Noria
dc5336e7f4 revises RDoc of Hash#to_param to be more precise about ordering 2010-09-28 00:36:53 +02:00
Xavier Noria
10dec0e65e let Hash#to_param and Hash#to_query sort again
This was a regression introduced in 5c858220085dc4ddc1bec496747059dfbe32f1da. We bring
sorting back because people rely on it, eg for constructing consistent cache keys.
2010-09-28 00:32:20 +02:00
Neeraj Singh
bfc986811c Test for after_create callback order in ActiveSupport [#5703 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-27 23:12:10 +02:00
Neeraj Singh
72c1e19c33 after_create in ActiveModel should in the order specified
[#5650 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-27 23:11:31 +02:00
José Valim
fe0251e408 Merge remote branch 'miloops/warnings'
Conflicts:
	actionpack/lib/action_controller/metal/url_for.rb
2010-09-27 21:00:54 +02:00
José Valim
6067d16200 Call it compile_methods! and do the same on AM. 2010-09-27 20:43:56 +02:00
thedarkone
77efc20a54 Make assert_valid_keys slightly faster. 2010-09-27 17:45:59 +02:00
thedarkone
4c360c15e5 No need for an extra wrapper array. 2010-09-27 17:45:59 +02:00
thedarkone
f2e0b3575e Use native attr_* macros for performance reasons. 2010-09-27 17:45:58 +02:00
thedarkone
320382ccd3 Creating singleton class for every object whenever the instance-level accessor is used quite is expensive. 2010-09-27 17:45:58 +02:00
thedarkone
5a518487fe Try to use Hash's native #[] for speed. 2010-09-27 17:45:58 +02:00
thedarkone
8cda132136 Make InheritableOptions's constructor more flexible. 2010-09-27 17:45:58 +02:00
thedarkone
918dc27345 Compile ActionController::Base.config's methods to avoid method_missing overhead. 2010-09-27 17:45:58 +02:00
Emilio Tagua
6b135f7e46 Remove method if already exists to avoid warnings. 2010-09-27 11:19:22 -03:00
Krekoten' Marjan
1b7d30bfc9 Fix 'warning: method redefined' [#5551 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-25 11:06:55 +02:00
Andrew Kaspick
fb08e334d6 memoized protected methods should remain protected
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-09-24 20:31:12 -03:00
Aaron Patterson
a0db7be4af attr_accessor_with_default should raise an ArgumentError not a RuntimeError 2010-09-24 14:48:57 -07:00
Emilio Tagua
c88deaf5ee Use map, no need to use inject here.
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-09-22 18:08:04 -03:00
Emilio Tagua
7047d83ec5 Perf: speed up json encoding.
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-09-22 18:08:04 -03:00