TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
91,220 Commits 2 Branches 0 Tags 294 MiB
a457b121a0
Commit Graph

91220 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
fatkodima
a457b121a0 Fix copying virtual columns when altering a table in sqlite3 2024-04-09 20:47:37 +03:00
Carlos Antonio da Silva
8feeab2338 Add missing ostruct require on AR test suite 
Similar to 50515fb45f36dfad067adbdda9fee41fcb326ca9, make sure we
require `ostruct` where we use `OpenStruct`, to get the build back to
green, while we work to remove its usage on tests. (see #51510.)

Sample error:

```
Error:
ActiveRecord::Encryption::ConfigurableTest#test_installing_autofiltered_parameters_will_add_the_encrypted_attribute_as_a_filter_parameter_using_the_dot_notation:
NameError: uninitialized constant ActiveRecord::Encryption::ConfigurableTest::OpenStruct
    test/cases/encryption/configurable_test.rb:45:in `block in <class:ConfigurableTest>'
```
 2024-04-09 13:56:02 -03:00
Carlos Antonio da Silva
1e444dd0dd
Merge pull request #51527 from p8/guides/ignore-file-path-comments-in-code-blocks 
Remove example filepaths from code blocks in guides when using the copy button.

Some code examples use commented out paths for the path where the code should be written to. These paths can be ignored in the clipboard when using the "copy" button.
 2024-04-09 13:10:22 -03:00
Eileen M. Uchitelle
95d3b2eb3d
Merge pull request #51517 from Shopify/composite-foreign-key-should-set-query-constraints-option 
Ensure association's `foreign_key:` and `query_constraints:` options …
 2024-04-09 11:36:11 -04:00
eileencodes
50515fb45f
Add more ostruct requires 
`ostruct` was being implictly required by the `json` gem. But once it
was upgraded, these tests failed to initialize `OpenStruct`.

While we're trying to remove `ostruct` usage in #51510, CI is currently
failing so I'm pushing these in the mean time.
 2024-04-09 11:34:44 -04:00
Petrik
56a759a22b Remove example filepaths from code blocks in guides 
Some code examples use commented out paths for the path where the code
should be written to. These paths can be ignored in the clipboard when
using the "copy" button.

Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
 2024-04-09 17:01:29 +02:00
Nikita Vasilevsky
ac6217d6fa
Ensure association's foreign_key: and query_constraints: options behave the same 2024-04-09 14:52:17 +00:00
Petrik de Heus
d37c533139
Merge pull request #51529 from p8/guides/properyl-escape-sql-comments-in-examples 
Use SQL comments for SQL code blocks in guides [ci-skip]
 2024-04-09 16:44:50 +02:00
Carlos Antonio da Silva
7661c17ba8
Merge pull request #51355 from asavageiv/alan/update-docs 
Replace Order with Book in "Creating Namespaced Models" section
of docs for consistency [ci skip]
 2024-04-09 11:42:36 -03:00
Petrik
21ae70375c Use SQL comments for SQL code blocks in guides [ci-skip] 2024-04-09 16:41:53 +02:00
Carlos Antonio da Silva
52dfdbd11c
Merge pull request #51484 from akhilgkrishnan/fix-hover-text-decorator 
Fix textdecorator specificity on hovering in guides index [ci skip]
 2024-04-09 11:21:51 -03:00
Carlos Antonio da Silva
ca36a8083a
Merge pull request #51519 from duduribeiro/remove-duplicated-devcontainer-features-key 
Remove duplicated features attribute on devcontainer.json.tt
 2024-04-09 11:21:02 -03:00
Petrik de Heus
526d0eca7b
Merge pull request #51528 from p8/guides/properly-escape-comments-in-erb-examples 
Properly escape paths in erb example code blocks in guides [ci-skip]
 2024-04-09 16:20:17 +02:00
Carlos Antonio da Silva
0e3989a45c
Merge pull request #51526 from joshuay03/enqueue-after-transaction-commit-defaults-typos 
Minor improvement in `enqueue_after_transaction_commit` docs
in the new framework defaults file. [ci skip]
 2024-04-09 11:19:03 -03:00
Eileen M. Uchitelle
6f32c7b2e9
Merge pull request #51513 from fatkodima/create_table-force-and-if_not_exists 
Raise when both `:force` and `:if_not_exists` provided to `create_table`
 2024-04-09 10:14:30 -04:00
Petrik
e641b546ef Properly escape paths in erb example code blocks in guides [ci-skip] 2024-04-09 16:05:02 +02:00
Joshua Young
b0f6d77e99 Fix minor typos in enqueue_after_transaction_commit default docs 2024-04-09 23:55:35 +10:00
Cadu Ribeiro
e2333c6e80 Remove duplicated features attribute on devcontainer.json.tt 2024-04-09 10:43:24 -03:00
Ridhwana
a7e3798965
[RF-DOCS] Action View Helpers Documentation [ci-skip] (#51432) 
Review and improve the Action View Helpers guide.

- Reorganize sections, in most cases moving most commonly used helpers up, grouping some of the formatting ones together
- Expand with more examples and a few new methods
- Link back to the API of each helper whenever possible
- Remove WIP

Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
 2024-04-09 10:21:57 -03:00
fatkodima
e8bf57894e Raise when both :force and :if_not_exists provided to create_table 
Co-authored-by: Allison Phillips <aly@thanx.com>
 2024-04-08 23:46:48 +03:00
Akhil G Krishnan
521ca4eb5b Fix textdecorator specificity on hovering in index 2024-04-08 23:22:58 +05:30
Carlos Antonio da Silva
8ad19d9865 Minor tweaks / improvements to recent changelog/api docs [ci skip] 2024-04-08 14:48:44 -03:00
Carlos Antonio da Silva
4939f39627
Merge pull request #51512 from fatkodima/improve-cable-config-example 
Improve ActionCable redis config example [skip ci]
 2024-04-08 13:56:02 -03:00
Vipul A M
efd42121f8
Merge pull request #51515 from Earlopain/update-guides-default-content_types_allowed_inline 
Update default value for `content_types_allowed_inline` in guides [ci-skip]
 2024-04-08 10:39:20 -04:00
Earlopain
05e5d083fb
Update default value for content_types_allowed_inline in guides 2024-04-08 16:33:24 +02:00
Petrik de Heus
5a1db86b5e
Merge pull request #51514 from p8/activerecord/changelog-typos 
Fix small typo's in ActiveRecord Changelog [ci-skip]
 2024-04-08 16:02:49 +02:00
Petrik
79f0c6504d Fix small typo's in ActiveRecord Changelog [ci-skip] 2024-04-08 15:58:14 +02:00
Jean Boussier
3700aa90e3 Fix a typo in activerecord/CHANGELOG.md 2024-04-08 12:19:29 +02:00
fatkodima
f638b8b768 Improve ActionCable redis config example [skip ci] 2024-04-08 00:30:19 +03:00
fatkodima
bad7ff1664
Merge pull request #51450 from fatkodima/remove-stale-comment 
Counter cache columns are not marked as readonly [skip ci]
 2024-04-06 12:41:24 +03:00
fatkodima
bb779f929f Counter cache columns are not marked as readonly [skip ci] 2024-04-06 12:39:08 +03:00
fatkodima
3461e0073f
Merge pull request #51498 from Uaitt/fields_for_documentation_improvements 
Tweak documentation for `#fields_for` [skip ci]
 2024-04-06 12:30:52 +03:00
fatkodima
2e2a3c3fa4
Merge pull request #51506 from alonsogarciapablo/patch-1 
[ci skip] Update "Running EXPLAIN" section in the "Active Record Query Interface" guide
 2024-04-06 12:21:16 +03:00
Pablo Alonso
46a1d7f0b2
Update active_record_querying.md 2024-04-05 23:59:53 +02:00
Matthew Draper
dbb5c4a703
Merge pull request #51497 from bensheldon/preparable-in 
Allow `IN` with subselect to be preparable
 2024-04-06 08:04:23 +10:30
Jean Boussier
83a1cff603
Merge pull request #51505 from p8/activejob/improve-enqueue-after-commit-changelog 
Update `enqueue_after_transaction_commit` changelog [ci-skip]
 2024-04-05 21:31:15 +02:00
Petrik
52f37c4d81 Update enqueue_after_transaction_commit changelog [ci-skip] 
The config option accepts `:never`, `:always` and `:default`.
 2024-04-05 21:26:28 +02:00
Jean Boussier
2b9366af55
Merge pull request #51503 from Shopify/record-ping-on-every-actioncable-message 2024-04-05 19:53:51 +02:00
yauhenisushkevich
2a71de9cca
Record ping on every actioncable message 2024-04-05 15:23:52 +00:00
Lorenzo Zabot
7d6c3d48cd Documentation improvement for #fields_for 2024-04-05 15:33:47 +02:00
Ben Sheldon [he/him]
2182419d81
Allow IN with subselect to be preparable 2024-04-04 21:36:39 -07:00
Jean Boussier
84c4598c93
Merge pull request #51457 from fatkodima/add-sql-queries-to-log 
Add queries count to template rendering instrumentation
 2024-04-04 17:38:23 +02:00
fatkodima
6369e92fbb Add queries count to template rendering instrumentation 2024-04-04 18:25:06 +03:00
Jean Boussier
58158c0f8c
Merge pull request #51478 from kmcphillips/mysql-parse-version-error 
Raise named exception in `AbstractMysqlAdapter` when DB reports an invalid version
 2024-04-04 17:15:45 +02:00
Jean Boussier
f613ba8f78
Merge pull request #51480 from albus522/dg/improve-vips-analyzer 
Be a lot more memory efficient analyzing images with ruby-vips
 2024-04-04 16:55:36 +02:00
Jean Boussier
30753c1929
Merge pull request #51489 from p8/guides/improve-enqueue-after-transaction-commit-documentation 
Fix documentation for `enqueue_after_transaction_commit`
 2024-04-04 16:53:22 +02:00
Jean Boussier
539fcc5d6d
Merge pull request #51491 from fatkodima/missing-ostruct-require 
Add missing `ostruct` require to `http_token_authentication_test.rb`
 2024-04-04 16:52:40 +02:00
Jean Boussier
6d42bf4716
Merge pull request #51492 from Shopify/arel-nary-or 
Arel: make `Or` nodes "Nary" like `And`
 2024-04-04 16:43:41 +02:00
Jean Boussier
9b841c1796
Merge pull request #51490 from Shopify/remove-git-source 
Stop generating files with `git_source(:github)`
 2024-04-04 15:30:26 +02:00
Jean Boussier
40d6385123 Stop generating files with git_source(:github) 
This has been built-in in Bundler for years now, and the
builtin version is much better as it allows to point to a PR
directly.
 2024-04-04 15:04:16 +02:00