TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
27,649 Commits 2 Branches 0 Tags 294 MiB
a977b2588e
Commit Graph

27649 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Carlos Antonio da Silva
a977b2588e Remove method missing handling when action is not found, use action missing instead 
Do not create a method_missing method to handle not found actions, use
the action_missing method provided by Rails instead.
 2012-01-17 10:04:38 -02:00
Carlos Antonio da Silva
53596d0913 Refactor render nothing/text => nil logic, and move to right place 
Options :nothing and :text => nil should be handled by
ActionController::Rendering instead.
 2012-01-17 10:04:38 -02:00
Carlos Antonio da Silva
6244d16eaf Move render :nothing and :text => nil options to AC::Rendering 2012-01-17 10:04:38 -02:00
Carlos Antonio da Silva
562a12df29 Rename test class and fix tests to keep consistency 
Based on 50d23bc2bd3653b3c66e480c22ae97c5f7fd7f62.
 2012-01-17 10:04:38 -02:00
Carlos Antonio da Silva
bb33e88833 Remove deprecated logic to render templates starting with / 
render :template => "/foo/bar"
 2012-01-17 10:04:38 -02:00
Carlos Antonio da Silva
497004858d Remove relative url root setting from ENV var 
This is already being set by Rails configuration.
 2012-01-17 10:04:37 -02:00
Carlos Antonio da Silva
71566c3573 Remove rescue_action from compatibility module and tests 2012-01-17 10:04:37 -02:00
Carlos Antonio da Silva
1ae9e60b8a Remove other old compatibility constants 2012-01-17 10:04:37 -02:00
Carlos Antonio da Silva
6f8b1e3a85 Remove constant already defined in exceptions module 2012-01-17 10:04:37 -02:00
Carlos Antonio da Silva
bc50cb31d6 Remove old compatibility methods not being used 2012-01-17 10:04:37 -02:00
José Valim
4280b20cde Merge pull request #4494 from Dreamfa11/patch-0 
Validates method should not change options argument
 2012-01-17 03:01:54 -08:00
dreamfall
7c3a5ec499 whitespaces 2012-01-17 13:19:30 +03:00
dreamfall
e84998cc21 validates method should not change options argument 2012-01-17 13:18:58 +03:00
José Valim
5f8274efe1 Merge pull request #4490 from EmmanuelOga/master 
when validating a record, if a validation context is used, use the same context when validating related records
 2012-01-17 00:27:39 -08:00
José Valim
81e837e810 Merge pull request #4484 from lest/patch-1 
use thread variable in TaggedLogging
 2012-01-17 00:24:08 -08:00
Piotr Sarnacki
a200446c53 Merge pull request #4491 from pkondzior/master 
Wrong behavior of ActiveModel::Errors#dup is causing regressions on Rails master
 2012-01-16 23:30:18 -08:00
Paweł Kondzior
6174d3ba24 Remove redundant #to_sym 2012-01-16 23:24:14 -08:00
Paweł Kondzior
5313eab695 Fix ActiveModel::Errors#dup 
Since ActiveModel::Errors instance keeps all error messages as hash
we should duplicate this object as well.

Previously ActiveModel::Errors was a subclass of ActiveSupport::OrderedHash,
which results in different behavior on `dup`, this may result in regression for
people relying on it.
 2012-01-16 23:22:51 -08:00
Emmanuel Oga
9b15e01c21 validate related records in the same validation context as parent. 
E.G.:

```ruby
class Parent < ActiveRecord::Base
  has_one :child
  validates_presence_of :name, :on => "custom_context"
  validates_associated :child
end

class Child < ActiveRecord::Base
  belongs_to :parent
  validates_presence_of :name, :on => "custom_context"
end

p = Parent.new(:name => "Montoto", :child => Child.new)
p.valid?(:custom_context) # => Returns true, even though the child is not valid under the same context.
```
 2012-01-17 01:40:17 -03:00
Aaron Patterson
21afd9b96d stop more ddl changes 2012-01-16 15:24:27 -08:00
Aaron Patterson
86a73cd849 stop ddl modifications for another test 2012-01-16 15:23:16 -08:00
Aaron Patterson
b731593e1a use one based indexes for the mock migrations 2012-01-16 15:19:34 -08:00
Aaron Patterson
867f504abd stop making ddl changes for migrator tests 2012-01-16 15:05:55 -08:00
Sergey Nartimov
6e76f8f5c0 use thread variable in TaggedLogging 
previous solution can cause race conditions under GIL-free ruby implementations
 2012-01-17 01:40:01 +03:00
Aaron Patterson
ccbd201936 actually use the variable I created. 💣 thanks @exviva 2012-01-16 14:02:57 -08:00
Aaron Patterson
15daa149b4 move another migrator to use sensors 2012-01-16 14:02:57 -08:00
Jon Leighton
8c0c0838cf Make it more explicit that the feature is deprecated, not removed. 2012-01-16 21:35:21 +00:00
Jon Leighton
a2dab46cae Deprecate inferred JOINs with includes + SQL snippets. 
See the CHANGELOG for details.

Fixes #950.
 2012-01-16 21:32:12 +00:00
Jon Leighton
46ea4442f3 infer references from Relation#order 2012-01-16 21:17:18 +00:00
Jon Leighton
a84a20e1cd store references as a string 2012-01-16 21:17:18 +00:00
Jon Leighton
f6cc6651f2 Avoid sanitize_sql when we can use Relation#where instead 2012-01-16 21:17:18 +00:00
Jon Leighton
ee7f666035 automatically add references when we can 2012-01-16 21:17:17 +00:00
Jon Leighton
4429f16c0a Make referencing an included item trigger eager loading 2012-01-16 21:17:17 +00:00
Jon Leighton
4c4760a619 Add ActiveRecord::Relation#references (#950) 2012-01-16 21:17:17 +00:00
Jon Leighton
d13627d532 Revert "Deprecate implicit eager loading. Closes #950." 
This reverts commit c99d507fccca2e9e4d12e49b4387e007c5481ae9.
 2012-01-16 21:17:17 +00:00
Aaron Patterson
247d274cab moving verbosity tests to the migrator test, removing ddl changes 2012-01-16 11:28:00 -08:00
Aaron Patterson
536433845d silencing migrator tests, refactoring the migration test helper 2012-01-16 11:21:20 -08:00
Aaron Patterson
7312b8318f fix tests on sqlite3 2012-01-16 11:01:58 -08:00
Aaron Patterson
8037c51083 prefer method sensors over actual ddl changes 2012-01-16 10:57:31 -08:00
Aaron Patterson
8739a42c38 testing the current version method 2012-01-16 10:33:39 -08:00
Aaron Patterson
5b833f53f6 test that migrations have connections, and method missing delegates 2012-01-16 10:14:09 -08:00
Aaron Patterson
0691866104 making sure the temp connection and the real connection are different after dup 2012-01-16 10:03:33 -08:00
Aaron Patterson
f84478f46e Merge pull request #4462 from spohlenz/fix-routing-tests 
Stub ip method of alternative request class in router tests
 2012-01-16 09:16:03 -08:00
Vijay Dev
56d980b7f7 Merge branch 'master' of github.com:lifo/docrails 2012-01-16 22:05:12 +05:30
Vijay Dev
7af8ee7658 minor edits in getting started guide 2012-01-16 22:04:25 +05:30
Vijay Dev
ddc63fbbc1 copy editing asset pipeline changes 2012-01-16 22:03:59 +05:30
Piotr Sarnacki
8e8982cf3b Add ActiveModel::Errors#delete, which was not available after move to use delegation 2012-01-16 17:23:40 +01:00
José Valim
3100b99b54 Merge pull request #4480 from lest/use-rack-body-proxy 
Use Rack::BodyProxy
 2012-01-16 08:05:31 -08:00
Sergey Nartimov
23cb3d2f09 use rack from master branch 
it's needed until new rack release with Rack::BodyProxy fixes
b06ef82876
 2012-01-16 14:42:23 +03:00
Sergey Nartimov
2b812408c9 use Rack::BodyProxy in activerecord middlewares 2012-01-16 14:36:41 +03:00