TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
36,218 Commits 2 Branches 0 Tags 294 MiB
b307210d49
Commit Graph

36218 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Teo Hui Ming
b307210d49 UTF-8 encode all keys and values in nested params hash. 2013-03-15 09:17:03 +08:00
Aaron Patterson
cf065777d0 pg is the only adapter that supports the xml type, so push the method down 2013-03-14 17:53:51 -07:00
Aaron Patterson
ee46011137 Apparently people were mutating this array. :'( 
This reverts commit abba61e2bbe320894ba8449ebdf778a1d2af545b.
 2013-03-14 17:48:35 -07:00
Aaron Patterson
abba61e2bb hashes are ordered, so just use the columns_hash ivar 2013-03-14 17:33:44 -07:00
Aaron Patterson
772c18e028 use the method so we do not depend on internal ivars 2013-03-14 17:23:55 -07:00
Aaron Patterson
d5f4b5382a extract factory method and push common code up to abstract adapter 2013-03-14 17:15:24 -07:00
Aaron Patterson
b7b6c22d78 Merge pull request #9713 from imanel/live_stale 
Handle conditional get in live requests
 2013-03-14 13:39:51 -07:00
Bernard Potocki
2651b597f2 Handle conditional get in live requests - this will prevent error when using stale on live streams(issue #9636) 2013-03-14 09:13:10 +01:00
Steve Klabnik
36f7732e82 Merge pull request #9711 from vipulnsward/moar_cleanups 
MOAR cleanups of unused variables.
 2013-03-13 22:59:23 -07:00
Vipul A M
d338a0feaf MOAR cleanups. 2013-03-14 10:47:13 +05:30
Steve Klabnik
a3c8e4add7 Add extra clarifying line in docs. [ci skip] 2013-03-13 15:27:49 -07:00
Steve Klabnik
5bf6d8e7c1 Fix docs: response -> request. 
Even though I read it carefully, my brain tricked me. 😢
 2013-03-13 15:20:23 -07:00
Steve Klabnik
02caa02527 Merge pull request #9698 from garethrees/request_documentation 
Add documentation to ActionDispatch::Request
 2013-03-13 15:16:26 -07:00
Rafael Mendonça França
a0920bc6ce Merge pull request #9690 from trevorturk/upgrade-notes 
Rails 4 upgrade notes about clashing named route selection changes
 2013-03-13 13:44:13 -07:00
Carlos Antonio da Silva
16466e188f Merge pull request #9699 from rubys/scaffold_password_digest 
Add support for generate scaffold password:digest

* adds password_digest attribute to the migration
* adds has_secure_password to the model
* adds password and password_confirmation password_fields to _form.html
* omits password from index.html and show.html
* adds password and password_confirmation to the controller
* adds unencrypted password and password_confirmation to the controller test
* adds encrypted password_digest to the fixture
 2013-03-13 13:12:21 -07:00
Sam Ruby
3008994d1e Add support for generate scaffold password:digest 
* adds password_digest attribute to the migration
* adds has_secure_password to the model
* adds password and password_confirmation password_fields to _form.html
* omits password entirely from index.html and show.html
* adds password and password_confirmation to the controller
* adds unencrypted password and password_confirmation to the controller test
* adds encrypted password_digest to the fixture
 2013-03-13 16:06:33 -04:00
Carlos Antonio da Silva
cd9f7508df Move some railties changelog entries to the top [ci skip] 2013-03-13 14:03:14 -03:00
Andrew White
02482671dd Merge pull request #9700 from senny/6513_integration_test_headers 
rework passing headers and env variables in integration tests
 2013-03-13 08:42:26 -07:00
Yves Senn
a709246d17 Http::Headers respects dotted env vars, symbols, headers with numbers. 2013-03-13 16:41:00 +01:00
Yves Senn
9af59b2468 allow headers and env to be passed in IntegrationTest. 
Closes #6513.
 2013-03-13 16:41:00 +01:00
Yves Senn
e2a5de2bb2 refactor, Http::Headers stores headers in env notation 
Also:
cleanup, use consistent syntax for `Http::Header` and test.
 2013-03-13 16:40:47 +01:00
Yves Senn
8945be464f Http::Headers respects headers that are not prefixed with HTTP_ 2013-03-13 16:27:47 +01:00
Carlos Antonio da Silva
b5493c83f5 Merge pull request #9694 from vipulnsward/change_from_each_to_each_value_in_http_params 
Change from each to each_value in http/parameters since we don't use key
 2013-03-13 04:33:04 -07:00
Gareth Rees
f4d9f332c4 Add documentation to ActionDispatch::Request 2013-03-13 10:21:47 +00:00
Andrew White
14a9a4ae00 Merge pull request #9696 from senny/typo_in_changelog 
fix typo in Active Record CHANGELOG [ci skip]
 2013-03-13 01:21:54 -07:00
Yves Senn
5ed4696b67 fix typo in Active Record CHANGELOG [ci skip] 2013-03-13 09:11:48 +01:00
Andrew White
dff86e6ea0 Add regression tests for #9678 
The bug with `ActiveSupport::TimeZone.parse` described in #9678 was
unwittingly fixed in 005d910 so add some tests to prevent regression.
 2013-03-13 05:46:34 +00:00
Vipul A M
0c61d97ac1 Change from each to each_value in http/parameters since we don't use key 2013-03-13 08:52:07 +05:30
Aaron Patterson
7169e4c715 removing out of date comment. ❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️ @pixeltrix 2013-03-12 14:15:01 -07:00
Aaron Patterson
ed9e3f699a drop memory consumption and startup speed by switching to define_method 2013-03-12 14:10:21 -07:00
Trevor Turk
d717882eb5 Document change to clashing named route selection from journey commit 98a9802a 2013-03-12 15:07:17 -05:00
Rafael Mendonça França
9ca55c2bb5 Merge pull request #9687 from stouset/patch-1 
Also quote extension name in disable_extension
 2013-03-12 09:30:42 -07:00
Stephen Touset
2076a93979 Also quote extension name in disable_extension 
A patch was committed recently which quoted the extension name in the SQL for `enable_extension`. But the same wasn't done for `disable_extension`.
 2013-03-12 09:29:06 -07:00
Carlos Antonio da Silva
d25a82280f Stop calling "super" twice in Rails::Server#app 
Cache the value of "super" in a variable and use it instead.
 2013-03-12 10:10:18 -03:00
Carlos Antonio da Silva
6e07658fcf Remove manual "return true" from AS::TZ match method 2013-03-12 10:10:18 -03:00
Rafael Mendonça França
824a58a75a Merge pull request #9676 from neerajdotname/9567-destroy-should-call-destroy-all 
dependent: :destroy should call destroy_all
 2013-03-12 06:01:07 -07:00
Carlos Antonio da Silva
8881723d13 Merge pull request #9615 from mmb/copy_table_binary_sqlite 
Pass column to quote when copying a sqlite table.

To make quote escape binary data correctly it needs the column passed in.
 2013-03-12 04:30:37 -07:00
Carlos Antonio da Silva
466ff9310a Merge pull request #9681 from vipulnsward/fix_typo_in_module_name 
Fix typo in DependenciesTestHelpers module name
 2013-03-12 03:55:30 -07:00
Matthew M. Boedicker
d3e5118e7d Pass column to quote when copying a sqlite table. 
To make quote escape binary data correctly it needs the column passed in.
 2013-03-11 23:14:46 -07:00
Vipul A M
8778e1c4af Fix typo in DependenciesTestHelpers module name 2013-03-12 10:33:32 +05:30
Carlos Antonio da Silva
f278deb712 Fix typo [ci skip] 2013-03-11 23:04:34 -03:00
Neeraj Singh
c3829d3186 dependent: :destroy should call destroy_all 
Commit https://github.com/rails/rails/pull/9668 shows warning
when `delete_all` is invoked with `:dependent` option
`:destroy`.

Unfortunately invoking `Post.destroy_all` invokes
`post.comments.delete_all` as part of `has_many` callbacks.

This commit ensures that instead `post.comments.destroy_all` is
invoked and in the process no warning is generated.

See issue #9567 for details .
 2013-03-11 20:50:22 -04:00
Xavier Noria
cae93be0ca promotes change_column_null to the migrations API 2013-03-11 23:13:12 +01:00
Xavier Noria
efa5307f18 quick pass over the RDoc of schema_statements.rb [ci skip] 2013-03-11 22:37:53 +01:00
Xavier Noria
efb534e1bb documents how to DROP DEFAULT [ci skip] 2013-03-11 22:15:08 +01:00
Xavier Noria
67b486142b Merge pull request #9668 from neerajdotname/9567-delete-all-warning 
Show warning message if delete_all is firing callbacks
 2013-03-11 13:33:22 -07:00
Neeraj Singh
d71eaf3e3f Show warning message if delete_all is firing callbacks 
`post.comments.delete_all` will fire callbacks if :dependent option is
:destroy . It will be fixed in Rails 4.1 . In the meantime display
a warning . Look at #9567 for details .
 2013-03-11 16:32:17 -04:00
Carlos Antonio da Silva
816e7d1449 Replace assert_(no_)match args from regexps to strings to remove warnings 
Using regexps as arguments without parentheses end up raising:

    warning: ambiguous first argument; put parentheses or even spaces
 2013-03-11 15:54:43 -03:00
Carlos Antonio da Silva
c7ba4c7c98 Skip fetching path if the iteration is going to be skipped 2013-03-11 15:54:43 -03:00
Santiago Pastorino
5da8c1627c There's no need to install test group in travis 2013-03-11 15:51:24 -03:00