TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
81,289 Commits 2 Branches 0 Tags 294 MiB
b99b14a1cf
Commit Graph

81289 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Xavier Noria
b99b14a1cf Delete AS::Dependencies.autoloaded? 2021-08-23 09:04:35 +02:00
Xavier Noria
39a7658b61 Deletes spurious spaces 2021-08-23 00:49:18 +02:00
Xavier Noria
a10611c5a1
Merge pull request #43071 from rails/descendants-tracker 
Remove autoloading logic from AS::DescendantsTracker
 2021-08-23 00:47:57 +02:00
Xavier Noria
340b39ea31 Remove autoloading logic from AS::DescendantsTracker 
The descendants tracker is a generic tracker that you can use anywhere.
In particular, outside Rails applications.

Should provide API to clear only a subset of classes, but in my view
should know nothing about autoloading. That is a concern of client code.
 2021-08-23 00:24:26 +02:00
Xavier Noria
6a2a824e85 Namespace fixture classes in this test 
This test was defining classes with common names like `Parent` or `Child` in the
top-level namespace. Better to have them below a custom one.
 2021-08-22 22:08:28 +02:00
Jonathan Hefner
99c67db17d
Merge pull request #43069 from p8/activerecord/improve-where-docs-with-hash 
Don't use redundant curly braces in `where` examples [ci-skip]
 2021-08-22 12:02:36 -05:00
Petrik
d6527e64b3 Don't use redundant curly braces in where examples [ci-skip] 
In 411ccbdab2608c62aabdb320d52cb02d446bb39c redundant curly braces for
hash arguments were removed from most of the code base.
The docs of the `where` methods still use redundant curly braces, so
lets remove them as well.
 2021-08-22 17:20:42 +02:00
Ryuta Kamizono
f0bd1085cd
Merge pull request #43065 from seanpdoyle/active-storage-fixture-guides 
[GUIDES]: Fix ActiveStorage::FixtureSet.blob YAML

[ci-skip]
 2021-08-22 11:49:53 +09:00
Xavier Noria
324883dc50 Delete extra empty line 2021-08-22 01:28:14 +02:00
Xavier Noria
7c09e59bca Restore AJ autoloading test 
This commit restores the test deleted in

    cd22ecbfc2

Active Job should not test things about autoloading, this would
belong to the railties test suite probably. However, there, it feels
a bit too distant from here.

Imperfect, but on a second thought I believe this trade-off is better.
 2021-08-22 01:23:14 +02:00
Xavier Noria
194866854f Restore autoloading test for STI 
This commit restores the test deleted in

    fc7c029467

Active Record should not test things about autoloading, this would
belong to the railties test suite probably. However, there, it feels
a bit too distant from here.

Imperfect, but on a second thought I believe this trade-off is better.
 2021-08-22 01:13:00 +02:00
Sean Doyle
5cdb20fd33 [GUIDES]: Fix ActiveStorage::FixtureSet.blob YAML 
Resolves incorrect fixture guide YAML paths, and compacts the
`FixtureSet.blob` call to a single line to resolve syntax highlighting
quirks.
 2021-08-21 18:04:24 -04:00
Xavier Noria
e933dc0b84 Let the Action Pack autoload with Zeitwerk 2021-08-21 20:20:23 +02:00
Xavier Noria
c192feb3eb Update Gemfile.lock 2021-08-21 10:35:03 +02:00
Xavier Noria
fc9a179033 Depends on Zeitwerk 2.5.0.beta2 2021-08-21 01:23:21 +02:00
Xavier Noria
e9f38a164e
Merge pull request #43058 from rails/del-private-constantize 
Delete AS::Dependencies.(safe_)constantize
 2021-08-20 18:25:48 +02:00
Xavier Noria
38e82daee8 Delete AS::Dependencies.safe_constantize 2021-08-20 17:51:05 +02:00
Xavier Noria
3e3504bdaa Delete AS::Dependencies.constantize 2021-08-20 09:47:22 +02:00
Jonathan Hefner
074c7f50c5
Merge pull request #43018 from ChaelCodes/document-order 
[DOCS] Improve Documentation for ActiveRecord's order Method [ci-skip]
 2021-08-19 09:20:11 -05:00
Rachael Wright-Munn
d6a38d2c43 Improve Documentation around the options that can be passed to order. 
Co-authored-by: Petrik de Heus <petrik@deheus.net>
Co-authored-by: Jonathan Hefner <jonathan@hefner.pro>
 2021-08-19 09:16:25 -05:00
Ryuta Kamizono
64a3bb892f
Merge pull request #43052 from p8/activerecord/change-joins-docs 
Improve description of ActiveRecord.joins [ci-skip]
 2021-08-19 21:26:44 +09:00
Petrik
bdd7e24bf2 Improve description of ActiveRecord.joins [ci-skip] 
Joins is the plural of join. So "a joins" doesn't seem correct.
To make it clear joins is a SQL term, we can upcase it just like the
descriptions for GROUP, HAVING and SELECT.
 2021-08-19 14:05:01 +02:00
Xavier Noria
6b5915895b
Merge pull request #43048 from rails/drop-orphan-methods 
Drop orphan methods in AS::Dependencies
 2021-08-19 00:32:22 +02:00
Xavier Noria
d4ab55e901 Delete orphan requires in AS::Dependencies 2021-08-19 00:14:06 +02:00
Xavier Noria
c640deef99 Delete AS::Dependencies.explicitly_unloadable_constants 2021-08-18 23:26:29 +02:00
Xavier Noria
fb9a33d602 Delete AS::Dependencies.mechanism 2021-08-18 23:26:25 +02:00
Xavier Noria
0f2d2ba87d Delete AS::Dependencies.load? 2021-08-18 23:26:20 +02:00
Xavier Noria
ed1571ddc0 Delete AS::Dependencies.autoloadable_module? 2021-08-18 23:26:16 +02:00
Xavier Noria
c1a89b57df Delete AS::Dependencies.load_once_path? 2021-08-18 23:26:12 +02:00
Xavier Noria
bde4b04323 Delete AS::Dependencies.uninitialized_constant 2021-08-18 23:26:07 +02:00
Xavier Noria
bc2cd69c22 Delete AS::Dependencies::WatchStack 2021-08-18 23:26:03 +02:00
Xavier Noria
dd5d632a6b Delete AS::Dependencies.constant_watch_stack 2021-08-18 23:25:59 +02:00
Xavier Noria
e5cdd54525 Delete AS::Dependencies.will_autoload? 2021-08-18 23:25:54 +02:00
Xavier Noria
2105d1ed3e Delete AS::Dependencies.mark_for_unload 2021-08-18 23:25:49 +02:00
Xavier Noria
7788697797 Delete AS::Dependencies.loading 2021-08-18 23:25:49 +02:00
Xavier Noria
4ba449aafb Delete AS::Dependencies.loaded 2021-08-18 23:25:49 +02:00
Xavier Noria
46576a4555 Delete AS::Dependencies.history 2021-08-18 23:25:49 +02:00
Xavier Noria
5102fdeacf Delete AS::Dependencies.remove_constant 2021-08-18 23:25:49 +02:00
Xavier Noria
2b31655493 Delete AS::Dependencies.new_constants_in 2021-08-18 23:25:49 +02:00
Xavier Noria
e24ae73021 Delete AS::Dependencies.qualified_name_for 2021-08-18 23:25:49 +02:00
Xavier Noria
1b92154ff4 Delete AS::Dependencies.autoload_module! 2021-08-18 23:25:49 +02:00
Xavier Noria
7b2223be8b Delete AS::Dependencies.remove_unloadable_constants! 2021-08-18 23:25:49 +02:00
Xavier Noria
d3ffcafb14 Delete AS::Dependencies.load_file 2021-08-18 23:25:44 +02:00
Xavier Noria
805067e6d2 Delete AS::Dependencies.loadable_constants_for_path 2021-08-18 23:25:35 +02:00
Xavier Noria
98381b7ba2 Delete AS::Dependencies.require_or_load 2021-08-18 22:44:59 +02:00
Xavier Noria
1343a3a67d Delete AS::Dependencies.load_missing_constant 2021-08-18 22:43:52 +02:00
Xavier Noria
27262897c7 Delete AS::Dependencies::Loadable 2021-08-18 22:31:07 +02:00
Xavier Noria
a7a217212b Delete AS::Dependencies::ModuleConstMissing 2021-08-18 22:27:55 +02:00
Xavier Noria
627037fa8b Delete AS::Dependencies.depend_on 2021-08-18 22:24:08 +02:00
Xavier Noria
cb0c746b7d Revises the autoloading guide [skip ci] 2021-08-18 21:37:50 +02:00