Commit Graph

41488 Commits

Author SHA1 Message Date
Carlos Antonio da Silva
b9c9766cd4 Fix typo [ci skip] 2013-12-21 15:03:32 -02:00
Xavier Noria
273045d6d5 optimizes array conversion in AC::Parameters 2013-12-21 14:22:08 +01:00
Xavier Noria
269424b0bb refactors AC::Parameters#fetch
AC::Parameters#fetch was refactored in 7171111 to prevent self mutation, but
in doing so it hardcodes logic #convert_hashes_to_parameters is supposed to
encapsulate.

Better leave the delegation, and add a way to avoid mutating self in there.
2013-12-21 13:47:26 +01:00
Guillermo Iguaran
e219bf0ebc Test with 2.1.0-rc1 2013-12-20 22:21:28 -05:00
David Heinemeier Hansson
f39fce5b7d Merge pull request #13425 from kassio/master
Generates html and text templates for mailers by default.
2013-12-20 17:23:38 -08:00
Xavier Noria
92f9ff8cc3 converts hashes in arrays of unfiltered params to unpermitted params [fixes #13382] 2013-12-21 01:16:38 +01:00
Aaron Patterson
fbb79b517f fix url connections for sqlite3 2013-12-20 16:13:34 -08:00
Kassio Borges
02c814c992 html and text templates for mailers by default 2013-12-20 18:34:57 -02:00
Rafael Mendonça França
d0ffa7f853 Merge pull request #13422 from rwz/master
Bump Jbuilder version to 2.0.0
2013-12-20 07:47:42 -08:00
Pavel Pravosud
e1aaa2ff73 Bump Jbuilder version to 2.0.0 2013-12-20 10:35:32 -05:00
Yves Senn
15e442b523 Merge pull request #13415 from schneems/schneems/database-no-username
Do not expect database user with app name to exist
2013-12-19 23:37:48 -08:00
Kenta Murata & Akira Matsuda
9e997e9039 Fix AS::NumberHelper results with large precisions
before:
  ActiveSupport::NumberHelper.number_to_rounded '3.14159', precision: 50
  => "3.14158999999999988261834005243144929409027099609375"
after:
  ActiveSupport::NumberHelper.number_to_rounded '3.14159', precision: 50
  => "3.14159000000000000000000000000000000000000000000000"
2013-12-20 16:26:35 +09:00
Jeremy Kemper
c437a98aca Merge pull request #13188 from imanel/skip_deep_munge
Add configuration option to optionally disable deep_munge

Conflicts:
	actionpack/CHANGELOG.md
2013-12-19 23:39:17 -07:00
Guillermo Iguaran
0516841968 Merge pull request #13418 from ma2gedev/update_sass_rails_4_0_0
Use sass-rails 4.0.0
2013-12-19 21:13:37 -08:00
Takayuki Matsubara
15ad57311c Use sass-rails 4.0.1 2013-12-20 12:34:24 +09:00
Richard Schneeman
fdb67ebd62 Merge pull request #13417 from TalkativeTree/comments_change
fix CollectionAssociation's comments
2013-12-19 18:53:22 -08:00
schneems
dece621a21 Do not expect database user with app name to exist
By default when creating a project with `--database=postgresql` the `config/database.yml` file that is generated has a user specified that is the same as the app name

```
development:
  adapter: postgresql
  encoding: unicode
  database: <%= app_name %>_development
  pool: 5
  username: <%= app_name %>
  password:
```

This is counterintuitive and would rarely be valid. By default postgres creates a user with the current user name (http://www.postgresql.org/docs/9.3/static/database-roles.html) "it will have the same name as the operating system user that initialized the database cluster":

```
$ whoami
schneems
```

If the `username` is left out postgresql will assume that you wish to log in as the default user

```
$ psql -c '\du'
                             List of roles
 Role name |                   Attributes                   | Member of
-----------+------------------------------------------------+-----------
 schneems  | Superuser, Create role, Create DB, Replication | {}
```

A good sensible default then for auto generated `database.yml` files is to remove the `username`, and have postgres attempt to connect to the database as the currently logged in user.

Instead of submitting with a blank password, don't submit a password.
2013-12-19 21:41:52 -05:00
Ben Angel
855ded6679 change CollectionAssociation's comments to say Association instead of AssociationProxy to match changes for 3.1 removing Association proxy. 2013-12-19 18:35:24 -08:00
Guillermo Iguaran
d6ac7d72c5 Merge pull request #13326 from schneems/schneems/add-asset-flag
Flag `config.assets.raise_runtime_errors` in dev
2013-12-19 17:39:53 -08:00
schneems
2ff2f1ba52 Flag config.assets.raise_runtime_errors in dev
By default `config.assets.raise_runtime_errors` should be set to `true` in development for new apps.

Source: https://github.com/rails/sprockets-rails/pull/100
2013-12-19 20:37:18 -05:00
Lauro Caetano
6de454fb05 Merge pull request #13357 from taryneast/master
Describe precision + scale in migrations guide
2013-12-19 14:51:39 -08:00
Rafael Mendonça França
ccaa3e47c4 Merge pull request #13412 from arthurnn/quote_id_not_id
quoting: Check if id is a valid method before using it
2013-12-19 13:57:14 -08:00
Rafael Mendonça França
ecde74e1b0 Merge pull request #13411 from schneems/schneems/runner-command-dash-c
Make `rails runner` command options more obvious
2013-12-19 13:55:52 -08:00
Taryn East
e2c17cfb2b [ci skip] Describe precision + scale in migrations
Telling somebody that "precision sets the precision" is not very helpful.
Newbies want to know what precision is *for*, likewise with scale.

So I've added a very brief description for each.
2013-12-20 08:55:13 +11:00
Rafael Mendonça França
cf15e027b9 Improve CHANGELOG entry [ci skip] 2013-12-19 19:53:26 -02:00
Arthur Neves
4a720a2cde quoting: Check if id is a valid method before using it
Need to check if valud also respond_to :id before calling it, otherwise
things could explode.
2013-12-19 16:51:28 -05:00
Rafael Mendonça França
3ea8403554 Merge pull request #13344 from ccutrer/fix-from-default-select
fix default select when from is used
2013-12-19 19:48:46 -02:00
schneems
3fa4e1671f Make rails runner command options more obvious
We're surrounding the options in angle brackets `<>` as is convention in `curl`:

```
$ curl --help
Usage: curl [options...] <url>
```

And then in square brackets `[]` with bars `|` as in `tar`:

```
$ tar --help
...
Create: tar -c [options] [<file> | <dir> | @<archive> | -C <dir> ]
```

To further clarify that the command can be used with both, we now show examples:

```
Examples:
    rails runner 'puts Rails.env'
        This runs the code `puts Rails.env` after loading the app

    rails runner path/to/filename.rb
        This runs the Ruby file located at `path/to/filename.rb` after loading the app
```

This format was taken from the `find` man pages:

```
EXAMPLES
     The following examples are shown as given to the shell:

     find / \! -name "*.c" -print
             Print out a list of all the files whose names do not end in .c.

     find / -newer ttt -user wnj -print
             Print out a list of all the files owned by user ``wnj'' that are newer than the file ttt.
```

The the text at the bottom is also shifted to improve readability.
2013-12-19 15:43:03 -06:00
Cody Cutrer
847e9a95da fix default select when from is used 2013-12-19 14:40:13 -07:00
Carlos Antonio da Silva
e4cde5d58c Fix indent in PG array tests
[ci skip]
2013-12-19 19:14:23 -02:00
Rafael Mendonça França
04ad814bb9 Make sure multiline string is not accepted by the regexp 2013-12-19 17:28:19 -02:00
Rafael Mendonça França
bfdae1775a Make possible to use symbol as the verifier name 2013-12-19 17:06:40 -02:00
Rafael Mendonça França
61f6b47204 Change the message verifier argument to verifier_name 2013-12-19 17:05:22 -02:00
Xavier Noria
87fc20a4aa revises the release notes about message verifiers (second take) [ci skip] 2013-12-19 20:01:24 +01:00
Xavier Noria
d0829f46db Revert "revises the release notes about message verifiers [ci skip]"
This reverts commit 293a1a68992ba3e3e80f9f0f685e866ff79bf11a.
2013-12-19 19:59:48 +01:00
Xavier Noria
293a1a6899 revises the release notes about message verifiers [ci skip]
Example code does not run yet with beta1.
2013-12-19 19:58:40 +01:00
Rafael Mendonça França
33566770ee Merge pull request #13408 from JuanitoFatas/remove-tt
Remove <tt> tag in 4_1_release notes. [ci skip].
2013-12-19 10:51:20 -08:00
Juanito Fatas
729f45a209 Remove <tt> tag in 4_1_release notes. [ci skip]. 2013-12-20 02:43:58 +08:00
Vijay Dev
a3b1105ada Merge branch 'master' of github.com:lifo/docrails 2013-12-20 00:10:30 +05:30
Xavier Noria
3968870d31 couple of tweaks to the release notes [ci skip] 2013-12-19 18:24:46 +01:00
Vijay Dev
4dd8b0b548 Revert "Update contributing_to_ruby_on_rails.md"
This reverts commit 41ba51f4850a8cd2fe69789011ac33366366d32f.

[ci skip]
2013-12-19 22:51:17 +05:30
Vijay Dev
3351c2d466 Revert "Update security.md"
This reverts commit f4804fafecdc057988575b4516afe9ca1d5f42fc.

[ci skip]
2013-12-19 22:51:01 +05:30
Vijay Dev
1406630b21 Revert "Fix on-site markdown rendering [ci skip]"
This reverts commit 427db6b9d2b35a72f3c017eb19a2e1e800b0a7a3.

[ci skip]
2013-12-19 22:50:25 +05:30
Vijay Dev
f858691744 Revert "Underscore in markdown should be escaped with backslash [ci skip]"
This reverts commit b58f3a641795e1777aa3e12a853c34ff512acfb9.

Reason: Discussion in b58f3a6417

[ci skip]
2013-12-19 22:50:17 +05:30
Xavier Noria
320ac8ef5a pass over half of the release notes [ci skip] 2013-12-19 18:09:28 +01:00
Rafael Mendonça França
f70e94cbd2 Merge pull request #13406 from hincupetru/master
Fixed configurable.rb regular expression name check
2013-12-19 08:35:48 -08:00
Hincu Petru
4cb30d9f8b Fixed configurable.rb regular expression name check 2013-12-19 17:30:01 +00:00
Carlos Antonio da Silva
3b10ad0874 Fix assertions for testing unknown formats using Mime::NullType 2013-12-19 14:19:41 -02:00
Rafael Mendonça França
553b2a74fa Merge pull request #13404 from JuanitoFatas/remove-tt
[ci skip] Remove <tt> tag in 4_1_release notes.
2013-12-19 07:57:25 -08:00
Juanito Fatas
f4e744d38d [ci skip] Remove <tt> tag in 4_1_release notes. 2013-12-19 23:53:16 +08:00