TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
89,864 Commits 2 Branches 0 Tags 294 MiB
c1f3d6851e
Commit Graph

89864 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Hartley McGuire
c1f3d6851e
Remove unused DeprecatedConstantAccessor include 
deprecate_constant removed in 23344d4b8cc36bb8ae3db209e0365b70469118d2
 2023-11-26 12:38:21 -05:00
Jonathan Hefner
9f18c04697
Merge pull request #50169 from jonathanhefner/app_generator_test-fix-arm64 
Fix generator tests on `arm64` platforms
 2023-11-25 17:02:14 -06:00
Jonathan Hefner
0b02dce15f Fix generator tests on arm64 platforms 
Follow-up to #47516 / #47492.

When running generator tests on `arm64` platforms, there is an extra
`lock --add-platform` command in `@bundle_commands` which causes
`assert_match %r"^exec rails ...", @bundle_commands[2]` to fail.

However, `run_generator_using_prerelease` isn't really concerned with
`lock --add-platform` commands; it is only concerned with the `install`
and `exec rails` commands, and the contents of the `Gemfile` when those
commands were executed.

Therefore, this commit removes `lock --add-platform` command-related
assertions from `run_generator_using_prerelease` and puts them into a
dedicated `test_generation_runs_bundle_lock_for_linux` test.  This
approach makes `run_generator_using_prerelease` less brittle.  This
change also fixes a technically incorrect assertion wherein the contents
of the `Gemfile` during the `lock --add-platform` command was checked
instead of the contents during the `exec rails` command.

Fixes #50168.

Co-authored-by: zzak <zzakscott@gmail.com>
 2023-11-25 16:42:10 -06:00
Eugene Kenny
b744c8d0f5
Merge pull request #50164 from Aerdayne/do-not-overwrite-aj-logger 
Do not overwrite AJ logger if it is supplied
 2023-11-25 19:05:39 +00:00
Aerdayne
e03cc187f5 Do not overwrite AJ logger if it is supplied 
Use conditional assignment within 'active_job.logger' initializer
 2023-11-25 09:36:45 +01:00
Jonathan Hefner
354d68e8a6
Merge pull request #50153 from akhilgkrishnan/improve-documentation-for-excerpt 
Improve documentation for excerpt text helper [skip ci]
 2023-11-25 00:52:54 -06:00
Akhil G Krishnan
4c9d56a5c4 Improve documentation for excerpt text helper 
Co-authored-by: Jonathan Hefner <jonathan@hefner.pro>
 2023-11-25 11:16:28 +05:30
Jonathan Hefner
df2961b3d7 Put Ruby code in ERB tags [ci-skip] 
This allows the code to be properly syntax-highlighted.
 2023-11-24 17:57:17 -06:00
Jonathan Hefner
ed694bfe0a Remove unused variable in code example [ci-skip] 2023-11-24 17:52:33 -06:00
Jonathan Hefner
4bfa69a785 Revise TextHelper#concat code example [ci-skip] 
This simplifies the code example, and avoids putting `%>` _inside_ an
ERB tag, which confuses the syntax highlighter.
 2023-11-24 17:19:47 -06:00
Jonathan Hefner
ca5c27ed63 Format inline code [ci-skip] 2023-11-24 16:47:20 -06:00
Jonathan Hefner
1d604a459b Quote example output strings [ci-skip] 
This portrays the return values more accurately and, in some cases,
fixes syntax highlighting when using the upcoming version of SDoc
(thanks to its heuristic for detecting Ruby code vs HTML code).
 2023-11-24 16:22:57 -06:00
Jonathan Hefner
dc53bb9c27 Fix prose indentation [ci-skip] 
Prior to this commit, the prose was formatted as a code example.
 2023-11-24 16:13:03 -06:00
Jonathan Hefner
357a49d901
Merge pull request #50165 from jonathanhefner/follow-up-48290-selector 
Fix submit button selector for `type`-less buttons
 2023-11-24 15:49:37 -06:00
Jonathan Hefner
701e17b910 Fix submit button selector for type-less buttons 
Follow-up to #48290.

The `:is(button, input)[type='submit']` selector does not match `button`
elements that omit the `type` attribute in favor relying on its default
value (which is `"submit"`).

Co-authored-by: Javan Makhmali <javan@javan.us>
 2023-11-24 15:36:13 -06:00
Jonathan Hefner
209a1a18c4
Merge pull request #50161 from fatkodima/remove-duplicate-line 
Remove duplicate  assignment from ActiveRecord's Rakefile
 2023-11-24 14:30:53 -06:00
fatkodima
62c0e86404 Remove duplicate assignment from ActiveRecord's Rakefile 2023-11-24 19:39:59 +02:00
Gannon McGibbon
82e33e44bf
Merge pull request #49819 from gmcgibbon/integration_with_routes 
Make with_routing test helper work for integration tests
 2023-11-23 22:48:19 -06:00
Gannon McGibbon
d46d5ce610 Make with_routing test helper work for integration tests 
Adds support for with_routing test helpers in ActionDispatch::IntegrationTest.
Previously, this helper didn't work in an integration context because
the rack app and integration session under test were not mutated.
Because controller tests are integration tests by default, we should
support test routes for these kinds of test cases as well.
 2023-11-23 22:10:45 -06:00
Jonathan Hefner
04f29cb134 Format inline code [ci-skip] 2023-11-23 11:56:56 -06:00
Jonathan Hefner
f1d3acedb5 Include Preview#url in service_urls_expire_in list [ci-skip] 2023-11-23 11:52:39 -06:00
Jonathan Hefner
252cc95d12 Link to API docs [ci-skip] 2023-11-23 11:51:49 -06:00
Jonathan Hefner
06f0710061 Prevent autolink to method's own class [ci-skip] 
Linking to a class from within its own documentation is more confusing
than helpful.
 2023-11-23 11:46:16 -06:00
Jonathan Hefner
c209fb3a0b
Merge pull request #50149 from fatkodima/fix-flaky-test 
Fix flaky db warnings test
 2023-11-23 11:29:46 -06:00
fatkodima
5375a91470 Fix flaky db warnings test 2023-11-23 19:16:54 +02:00
Jonathan Hefner
54dc0b306a Link to api.rubyonrails.org instead of edgeapi [ci-skip] 2023-11-23 11:13:15 -06:00
Vipul A M
408faa2d42
Merge pull request #49743 from yoshixi/improve-action-mailbox-incineration-doc-1 
Improve docs for the action-mail box incineration
 2023-11-23 18:23:31 +05:30
Rafael Mendonça França
e7ea111e3b
Merge pull request #50144 from rails/rm-deprecations-1 
Remove deprecations part 1
 2023-11-22 19:38:25 -03:00
Rafael Mendonça França
03dae98092
Remove deprecated :exponentially_longer value for the :wait in retry_on 2023-11-22 22:13:59 +00:00
Rafael Mendonça França
798289699d
Remove deprecated support to set numeric values to scheduled_at attribute 2023-11-22 22:13:06 +00:00
Rafael Mendonça França
2a761d23d2
Remove deprecated primitive serializer for BigDecimal arguments 2023-11-22 22:13:03 +00:00
Rafael Mendonça França
ec2c2666c2
Remove deprecated support to set Rails.application.config.action_dispatch.show_exceptions to true and false 2023-11-22 22:12:10 +00:00
Rafael Mendonça França
30193dc087
Remove deprecated speaker, vibrate, and vr permissions policy directives 2023-11-22 22:12:09 +00:00
Rafael Mendonça França
d088d9132f
Remove deprecated Rails.application.config.action_dispatch.return_only_request_media_type_on_content_type. 2023-11-22 22:12:08 +00:00
Rafael Mendonça França
43e42c1ea8
Remove deprecated comparison between ActionController::Parameters and Hash 2023-11-22 22:12:07 +00:00
Rafael Mendonça França
87bc1190fb
Remove deprecated constant AbstractController::Helpers::MissingHelperError 2023-11-22 22:12:03 +00:00
Rafael Mendonça França
b2f96d07d4
Remove deprecated constant ActionDispatch::IllegalStateError 2023-11-22 22:11:43 +00:00
Rafael Mendonça França
992a126c6e
Remove deprecated params via :args for assert_enqueued_email_with 2023-11-22 22:11:32 +00:00
Rafael Mendonça França
2bd6cf5177
Remove deprecated config.action_mailer.preview_path 2023-11-22 22:11:31 +00:00
Rafael Mendonça França
6be9ba2207
Merge pull request #50049 from kmcphillips/mysql-warnings-empty 
Handle case in MySQL where the `ActiveRecord.db_warnings_action` is not called even when a DB query has warnings
 2023-11-22 19:02:06 -03:00
Jonathan Hefner
a5d243f573
Merge pull request #50143 from danbernier/fix-dirty-was-docs 
Fix ActiveModel::Dirty#*_was documentation [ci skip]
 2023-11-22 13:39:13 -06:00
Daniel Bernier
417b84a0d1
Fix Dirty#*_was documentation 
The docs illustrated `*_change`, not `*_was`, leaving the reader to have to guess.
 2023-11-22 14:24:57 -05:00
Rafael Mendonça França
9c6fe5b2b5
Merge pull request #50138 from rails/rm-remove-duplication 
Remove duplication between `alias_attribute_method_definition` and `define_proxy_call`
 2023-11-22 14:54:15 -03:00
Jonathan Hefner
5407776169
Merge pull request #50137 from jonathanhefner/active_record-no_database_error-message 
Tweak message for `NoDatabaseError`
 2023-11-22 11:34:39 -06:00
Rafael Mendonça França
139e806e5c
Remove duplication between alias_attribute_method_definition and define_proxy_call 2023-11-22 17:27:05 +00:00
Rafael Mendonça França
8ec3843cd8
Make duplication explicit between alias_attribute_method_definition and define_proxy_call 2023-11-22 17:20:46 +00:00
Jonathan Hefner
acf00cb5f8 Tweak message for NoDatabaseError 
This tweaks various phrasing and puts the "To create the database"
instructions next to the relevant bullet point instead of at the end of
the message.
 2023-11-22 11:13:35 -06:00
Rafael Mendonça França
01492e329f
Extract common logic to build mangled method names to a method 2023-11-22 17:13:28 +00:00
Hartley McGuire
f0b587b260
Merge pull request #50134 from skipkayhil/hm-doc-fh-ff 
Fix preposition in fields_for doc [ci-skip]
 2023-11-22 09:12:45 -05:00
Hartley McGuire
28c4f6b598
Fix preposition in fields_for doc 
Followup to 2a5e9bc85b291b276d382f4a2f80c73f35c24b1a
 2023-11-22 09:07:17 -05:00