TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
89,368 Commits 2 Branches 0 Tags 294 MiB
c9da2694de
Commit Graph

89368 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jean Boussier
c9da2694de
Merge pull request #49621 from Shopify/log-subscriber-semantic-logger-compatibility 
ActiveSupport::LogSubscriber restore compatibility with SemanticLogger
 2023-10-13 14:34:06 +02:00
Jean Boussier
e01d1e25dd ActiveSupport::LogSubscriber restore compatibility with SemanticLogger 
Fix: https://github.com/rails/rails/pull/49563

The semantic_logger gems doesn't behave exactly like stdlib logger
in that `SemanticLogger#level` returns a Symbol while stdlib `Logger#level`
returns an Integer.

Because of this we can't simply compare integers, we have to use the
various `#{level}?` methods.
 2023-10-13 14:21:23 +02:00
Jean Boussier
2239749134
Merge pull request #49612 from Shopify/action-view-capture-nil-not-blank 
Fix `capture` view helper for HAML and Slim
 2023-10-13 08:29:47 +02:00
Jean Boussier
79a242dc54 Fix capture view helper for HAML and Slim 
Ref: https://github.com/rails/rails/pull/47194#issuecomment-1760334146

They both give the buffer as return value of the capture block
which confuses the `capture` helper.

Ideally we wouldn't have to check for that, but it's
an acceptable tradeoff for backward compatibility.
 2023-10-13 08:27:09 +02:00
Jonathan Hefner
1705fa2bf4
Merge pull request #49617 from cattekin/cast_guides 
Use correct tense of `cast` for guides [ci-skip]
 2023-10-12 23:01:19 -05:00
Edward Tippett
2130d523b4 Use correct tense of cast for guides 
Switch to `cast` for describing the past tense actions.

`casted` is a common mistake, but not correct English.
 2023-10-13 13:07:07 +10:30
Rafael Mendonça França
ab3b206e58
Merge pull request #49592 from fatkodima/pg-table-name-length-back-to-63 
Return back maximum allowed PostgreSQL table name to 63 characters
 2023-10-13 00:43:17 +02:00
Rafael Mendonça França
7ead85fecf
Merge pull request #49613 from paulreece/bun_install_clarification 
[ci skip] Bun docs troubleshooting
 2023-10-13 00:41:05 +02:00
paulreece
f5668a0b18 Just clarifies a little the bun installation process and gives people instructions what to do if it did not install. 2023-10-12 18:01:38 -04:00
Carlos Antonio da Silva
31d66f72de
Merge pull request #48767 from c960657/mailer-preview-wrap 
Prevent header wrapping in email preview
 2023-10-12 18:09:34 -03:00
Carlos Antonio da Silva
056396fea6
Merge pull request #49609 from p8/railties/thor-enum 
Use Thor's enum for class_options
 2023-10-12 17:21:23 -03:00
Petrik
b8a3efeee3 Use Thor's enum for class_options 
In 11a6adc4fb6172e9af081e20c5f68ca023e3bd8a custom code was added to
restrict values for some `rails new` options.
We don't need to implement this when it's already supported by Thor.

This also adds `none` as an option to the asset_pipeline as used in:
`railties/test/generators/shared_generator_tests.rb:320`.
 2023-10-12 21:01:53 +02:00
fatkodima
bd9d7c006a Return back maximum allowed PostgreSQL table name to 63 characters 2023-10-12 20:02:12 +03:00
Rafael Mendonça França
13722f21ee
Merge pull request #49594 from akhilgkrishnan/rails-new-database-desc-consistancy 
Add consistent option description for --database on rails new
 2023-10-12 18:55:01 +02:00
Adrianna Chang
4c30ca5934
Merge pull request #49605 from Earlopain/unlogged-table-docs 
Fix code example for create_unlogged_tables
 2023-10-12 11:05:39 -04:00
Earlopain
430d962a79
Fix code example for create_unlogged_tables [ci skip] 2023-10-12 16:31:23 +02:00
Akhil G Krishnan
f953178a75 Add consistant option description for --database on rails new 
Review changes added
 2023-10-12 19:52:28 +05:30
Carlos Antonio da Silva
bbf4fc9efb
Merge pull request #49603 from y0608/patch-1 
Fix broken link in AR validations guide [ci skip]
 2023-10-12 10:44:16 -03:00
Carlos Antonio da Silva
837b8d992c
Merge pull request #49602 from Earlopain/49600-followup 
Update filter_parameters default in configuring guide [ci skip]
 2023-10-12 10:40:59 -03:00
Y.I
bb638b4143
Typo: broken link 2023-10-12 16:30:14 +03:00
Earlopain
227aa4e8c0
Update filter_parameters default in configuring guide [ci skip] 2023-10-12 14:45:55 +02:00
Carlos Antonio da Silva
3d5b2eefa2
Merge pull request #49600 from Earlopain/filter-params-email 
Add email to the list of default filter parameters

Email addresses are considered personal data. While not quite on the same level of sensitivity as the other parameters in the list any application that implements signup through email without SSO inadvertently logs this information.
 2023-10-12 09:12:59 -03:00
Carlos Antonio da Silva
5103ab167e Fix numbered list and indentation of code blocks on upgrade guide 
Otherwise they are considered separate lists instead of a sequence
within the same list. This also renders the code block with extra
indent, as part of the item they belong to.

Also use `Active Record Encryption` with capital letters consistently.

[ci skip]
 2023-10-12 08:46:39 -03:00
Earlopain
5af6d285fd
Add email to the list of default filter parameters 2023-10-12 13:39:57 +02:00
Ryuta Kamizono
d5aeb51beb
Merge pull request #49596 from frenkel/fix/credentials-server-doc 
Fix documentation for credentails server start command
 2023-10-12 20:29:18 +09:00
Ryuta Kamizono
a3695553d4
Merge pull request #49595 from jbampton/fix-grammar 
test(ruby): fix grammar
 2023-10-12 20:23:53 +09:00
Ryuta Kamizono
68b119a361
Merge pull request #49598 from fatkodima/fix-identity-columns-pg-9 
Fix detecting `IDENTITY` columns for PostgreSQL < 10
 2023-10-12 20:18:28 +09:00
fatkodima
796e36451f Fix detecting IDENTITY columns for PostgreSQL < 10 2023-10-12 12:30:33 +03:00
fatkodima
cb1a13aeab Fix ActiveRecord tests for PostgreSQL < 10 2023-10-12 12:29:27 +03:00
Frank Groeneveld
2b3782ed8f Fix documentation for credentails server start command 2023-10-12 10:21:23 +02:00
John Bampton
130c0c173a test(ruby): fix grammar 2023-10-12 16:29:58 +10:00
Jonathan Hefner
d7aee014cb Fix monospace formatting [ci-skip] 2023-10-11 23:51:34 -05:00
Jonathan Hefner
5021b46396 Remove unnecessary monospace formatting [ci-skip] 2023-10-11 23:47:52 -05:00
Jonathan Hefner
08c4d63c9a
Merge pull request #49593 from jbampton/fix-spelling 
guides/source/asset_pipeline.md: fix spelling [ci-skip]
 2023-10-11 23:43:21 -05:00
John Bampton
6cd5254111 guides/source/asset_pipeline.md: fix spelling 2023-10-12 13:54:00 +10:00
Rafael Mendonça França
90a6f3663b
Merge pull request #49587 from jdelStrother/patch-2 
Advise upgraders to set active_record.encryption.hash_digest_class
 2023-10-12 01:12:36 +02:00
Jonathan del Strother
5f68493cda
Advise upgraders to set active_record.encryption.hash_digest_class 
This is currently documented in new_framework_defaults, but deserves highlighting more explicitly to help anyone upgrading from older versions.
 2023-10-11 22:51:59 +00:00
Rafael Mendonça França
7228da34b9
Merge pull request #49532 from akhilgkrishnan/base-template-for-7-2-release-note 
Added base template for rails 7.2 release note [skip ci]
 2023-10-11 23:03:13 +02:00
Rafael Mendonça França
60fc83f4e1
Merge pull request #49535 from t27duck/check_rails_new_options 
Disallow invalid values for rails new options
 2023-10-11 22:55:12 +02:00
Rafael Mendonça França
fc8d9ed843
Merge pull request #49553 from tricknotes/update-rails-ujs-build 
Updated `@rails/ujs` files to follow 8e3449908c59858384ae230d1416c7dcabc8c2dc
 2023-10-11 22:44:41 +02:00
Jonathan Hefner
deb51b0895
Merge pull request #49589 from fatkodima/fix-flaky-fixtures-test 
Load `author_addresses` fixtures for `ActiveRecordMessagePackTest`
 2023-10-11 15:44:33 -05:00
Rafael Mendonça França
2f853e6bed
Merge pull request #49585 from akhilgkrishnan/update-7-1-to-7-2 
Updated the rails version in 7.1 to 7.2 in guide [skip ci]
 2023-10-11 22:01:30 +02:00
fatkodima
17609f4ccd Load author_addresses fixtures for ActiveRecordMessagePackTest 2023-10-11 22:57:39 +03:00
Matthew Draper
42efd02a87
Merge pull request #49515 from dustinbrownman/main 
Don't log enqueuing details when the job wasn't enqueued
 2023-10-11 20:22:29 +02:00
Dustin Brown
be9d0f05a4 Don't include enqueuing info when job wasn't enqueued 2023-10-11 10:57:36 -07:00
Carlos Antonio da Silva
c8c95f424e
Merge pull request #49580 from p8/guides/format-html-attributes 
Recommend fixed-width fonts for HTML and CSS as well in documentation [ci-skip]
 2023-10-11 14:23:27 -03:00
Rafael Mendonça França
452c9f6c71
Merge pull request #49538 from akhilgkrishnan/capitalize-framework-names 
Capitalize framework names [skip ci]
 2023-10-11 17:04:27 +02:00
Akhil G Krishnan
41e86d4286 Updated the rails version in 7.1 to 7.2 in guide [skip ci] 2023-10-11 20:26:23 +05:30
Eileen M. Uchitelle
bfd981ebb4
Merge pull request #49539 from akhilgkrishnan/docs-update-7-0-to-7-1 
Updated the rails version in 7.0 to 7.1 in guide [skip ci]
 2023-10-11 10:17:44 -04:00
Akhil G Krishnan
72fae17f92 Updated the rails version in 7.0 to 7.1 in guide [skip ci] 2023-10-11 19:45:22 +05:30