TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
28,518 Commits 2 Branches 0 Tags 294 MiB
d03076f206
Commit Graph

28518 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Arun Agrawal
d03076f206 put and patch both are allowed for update 2012-02-25 09:40:50 +05:30
Xavier Noria
84cd58f2ac fixes a test: rake routes now includes PATCH for resources 2012-02-24 17:21:45 -08:00
Aaron Patterson
9ef701d659 use regular ruby for fewer method calls. we do not need 🎁s! 2012-02-24 16:55:22 -08:00
Xavier Noria
3008188cd6 consistently mention first patch, then put 
There was a mix, sometimes patch first, sometimes put first.
Use always patch first, since this is going to be the
primary verb for updates.
 2012-02-24 16:35:48 -08:00
Xavier Noria
b7a094536d uses PATCH for the forms of persisted records, and routes PATCH and PUT to the update action of resources 2012-02-24 16:25:41 -08:00
Xavier Noria
31ceb5e67b decouples the implementation of the inflector from its test suite 
Trying alternative implementations of the inflections
is hard because the suite is coupled with the current
one, setting ivars by hand etc. This commit relies on
initialize_dup, as long as you maintain that one you
can tweak the implementation.
 2012-02-24 15:06:17 -08:00
Xavier Noria
004326ecea removes the reconnect key from the database.yml generated for MySQL 
The reconnect flag does not play nicely with transactions and so
it is of little use in Rails applications. Thus, albeit supported
by mysql2, it does not deserve such a prominent place in the
generated database.yml, which should be a representative config
example. Note that the flag is false by default.

Advanced users know from mysql2 docs that the flag is available.
 2012-02-24 21:04:38 +01:00
Xavier Noria
5d70791ed0 explains why reconnect is false by default in the database.yml generated for MySQL 2012-02-24 18:50:51 +01:00
Xavier Noria
9d1f1b1ea9 removes verify_active_connections! 
The method verify_active_connections! was used in
the old days (up to 2.1 I think) by the dispatcher
to verify the connections, but nowadays we do that
in a different way and this method is obsolete.
 2012-02-24 09:11:59 -08:00
Aaron Patterson
e04fa0e589 Merge pull request #5144 from nashby/input-name-nil 
correct fetching :name option in form fields
 2012-02-24 08:42:52 -08:00
Vijay Dev
335fac56b6 Merge pull request #5143 from mguterl/update_running_unit_tests_doc 
Update with new task names for building mysql and postgresql databases
 2012-02-23 11:59:27 -08:00
Vasiliy Ermolovich
f0a5d32537 correct fetching :name option in form fields 2012-02-23 22:04:09 +03:00
Michael Guterl
6c384a6d9f Update with new task names for building mysql and postgresql databases 2012-02-23 09:49:48 -05:00
José Valim
af988ef5b0 Merge pull request #5139 from mhfs/remove_next_migration_number 
Remove unused implementation of next_migration_number
 2012-02-23 05:47:16 -08:00
Andrew White
5093915aae Document the :host option for force_ssl 2012-02-23 13:35:15 +00:00
Santiago Pastorino
68a977e497 Merge pull request #5140 from fbuenemann/fix/autoflush-wrong-template 
Move config.autoflush_log to correct template
 2012-02-23 05:30:33 -08:00
Andrew White
c04a08470f Update documentation for force_ssl - closes #5023. 2012-02-23 13:25:13 +00:00
Pat Allan
ab838900f8 SSL should not be disabled by default in any environment. 2012-02-23 13:25:13 +00:00
Felix Bünemann
fb9a919ce3 Use consistent whitespace for commented options. 2012-02-23 13:39:27 +01:00
Felix Bünemann
7549a7839b Move config.autoflush_log to correct template. 
This accidentally ended up in the development template
instead of the production template, where it makes
most sense.
 2012-02-23 13:32:57 +01:00
Marcelo Silveira
846a9bcae8 Remove unused implementation of next_migration_number 2012-02-23 09:56:34 -02:00
José Valim
ed988eece0 Avoid inspecting the whole route set, closes #1525 2012-02-23 12:49:18 +01:00
José Valim
06d2d4c40b Merge pull request #5138 from avakhov/remove-unused-global-var 
Remove unused global variable in controller filters test
 2012-02-23 00:38:06 -08:00
José Valim
541dbf4104 Merge pull request #5137 from avakhov/remove-skip-filter-block-param 
Remove skip_filter block param
 2012-02-23 00:36:26 -08:00
Alexey Vakhov
2b1c85365b Remove unused global variable in controller filters test 2012-02-23 11:36:20 +04:00
Alexey Vakhov
9e1b2d8174 Remove skip_filter block param 2012-02-23 11:25:31 +04:00
Aaron Patterson
3f8dc559ec Merge pull request #5084 from johndouthat/patch-1 
Remove reference to rails_legacy_mapper, which isn't compatible with 3.2...
 2012-02-22 15:57:15 -08:00
Aaron Patterson
abf3f67e27 Merge pull request #4998 from fbuenemann/feature/configurable-log-flushing 
Make automatic log flushing configurable
 2012-02-22 15:56:43 -08:00
Felix Bünemann
4a98a3059f Always default to flushing enabled 2012-02-23 00:38:34 +01:00
Felix Bünemann
681a574cbe Advertise autoflush option in production template 2012-02-23 00:32:55 +01:00
Felix Bünemann
0f3d426a16 Make log autoflushing configurable 2012-02-23 00:32:55 +01:00
Xavier Noria
5497432d71 updates CHANGELOGs to register changes in 002713c 2012-02-22 21:09:57 +01:00
Aaron Patterson
a328f2ffd2 add some tests, yay! 2012-02-22 11:05:03 -08:00
Aaron Patterson
36d9fd7332 Merge pull request #5133 from rafaelfranca/fix-build 
Only set ActionView configuration inside the on_load block
 2012-02-22 10:56:17 -08:00
Rafael Mendonça França
60585d2ef2 Only set ActionView configuration inside the on_load block 2012-02-22 16:54:26 -02:00
Aaron Patterson
cdc1885d41 Merge pull request #5132 from rafaelfranca/fix-build 
Fix routes inspection order
 2012-02-22 10:05:40 -08:00
Rafael Mendonça França
a870d06c0a Fix routes inspection order 2012-02-22 16:03:24 -02:00
Aaron Patterson
ef5670effd Merge pull request #5119 from kennyj/fix_5114 
Testcase for GH #5114.
 2012-02-22 09:55:26 -08:00
Xavier Noria
7f2548e34d Merge pull request #5130 from dlee/revised_patch_verb 
Add config.default_method_for_update to support PATCH
 2012-02-22 09:00:53 -08:00
David Lee
002713c645 Add config.default_method_for_update to support PATCH 
PATCH is the correct HTML verb to map to the #update action. The
semantics for PATCH allows for partial updates, whereas PUT requires a
complete replacement.

Changes:
* adds config.default_method_for_update you can set to :patch
* optionally use PATCH instead of PUT in resource routes and forms
* adds the #patch verb to routes to detect PATCH requests
* adds #patch? to Request
* changes documentation and comments to indicate support for PATCH

This change maintains complete backwards compatibility by keeping :put
as the default for config.default_method_for_update.
 2012-02-22 08:47:10 -08:00
José Valim
f28d9f1548 Merge pull request #5128 from bogdan/deprecate_rescuable 
AS::Callbacks: deprecate rescuable option
 2012-02-22 07:55:54 -08:00
Bogdan Gusiev
10bac29b33 AS::Callbacks: deprecate rescuable option 2012-02-22 17:43:13 +02:00
Santiago Pastorino
157ea76306 format lookup for partials is derived from the format in which the template is being rendered 
Closes #5025 part 2
 2012-02-22 11:12:03 -02:00
José Valim
a95f730ea4 Merge pull request #5124 from bquorning/prefer-||-over-'or'-for-boolean-operations 
Prefer || over 'or' for boolean operations
 2012-02-22 01:27:20 -08:00
Benjamin Quorning
5742f12b78 Prefer || over 'or' for boolean operations 2012-02-22 10:13:27 +01:00
Aaron Patterson
66b7eb1927 bumping up arel 2012-02-21 16:15:12 -08:00
Aaron Patterson
fd398475af prepared statements can be disabled 2012-02-21 16:15:12 -08:00
Santiago Pastorino
349d5a686a Merge pull request #5118 from castlerock/ordered_options_from_hash 
ordered_options will work if inherited from Hash, remove OrderedHash usage
 2012-02-21 15:23:07 -08:00
Aaron Patterson
19c7124c4f more ruby 2.0 respond_to? changes 2012-02-21 11:37:00 -08:00
Aaron Patterson
5d0c1814ad ruby 2.0 makes protected methods return false for respond_to, so pass true as the second param 2012-02-21 10:33:16 -08:00