Timm
|
d6067e8193
|
Changed attributes_are_equal? to equal_attribute_nodes? which takes attribute_nodes instead of nodes.
|
2014-06-16 21:04:10 +02:00 |
|
Timm
|
73c690d4fd
|
Removed html_strings variable, no splat operator needed.
|
2014-06-16 21:04:10 +02:00 |
|
Timm
|
bab54e4e52
|
Changed back to =~ or == comparison in HTMLSelector filter.
|
2014-06-16 21:04:10 +02:00 |
|
Timm
|
62171784fe
|
Simplified the removal of xpaths in remove_xpaths. Added more tests for remove_xpaths.
|
2014-06-16 21:04:10 +02:00 |
|
Timm
|
c1a7864930
|
Fixed: added apostrophe to possessive noun.
|
2014-06-16 21:04:09 +02:00 |
|
Timm
|
5169b00330
|
Extracted: create Regexp from match_with and use =~ to compare instead of checking .is_a? Regexp every time through the loop.
|
2014-06-16 21:04:09 +02:00 |
|
Timm
|
e600b3a341
|
Changed conditional check in filter. Removed weird comments.
|
2014-06-16 21:04:09 +02:00 |
|
Timm
|
4b55c0aa2e
|
Moved: initial assignment of @selector_is_second_argument is now in initialize.
|
2014-06-16 21:04:09 +02:00 |
|
Timm
|
cabef1415a
|
Changed: using duck typing instead of requiring subclasses of Node and NodeSet.
|
2014-06-16 21:04:08 +02:00 |
|
Timm
|
65ed2b6371
|
Renamed: HTMLSelector css_selector to selector.
|
2014-06-16 21:04:08 +02:00 |
|
Timm
|
9a536bc195
|
Removed unnecessary lines from HTMLSelector initialize.
|
2014-06-16 21:04:08 +02:00 |
|
Timm
|
ce4396b366
|
Changed: put selector extraction into selector_from, which is renamed to extract_selector.
|
2014-06-16 21:04:08 +02:00 |
|
Timm
|
20615ec7e6
|
Changed: HTMLSelector comparisons renamed to equality_tests.
|
2014-06-16 21:04:08 +02:00 |
|
Timm
|
71aaddbd14
|
Changed: removed @selected and @page variables from HTMLSelector since one method used them. Passed the values directly to there instead.
|
2014-06-16 21:04:07 +02:00 |
|
Timm
|
75789d5326
|
Changed: return early from compare_doms if the two doms don't have the same number of children.
|
2014-06-16 21:04:07 +02:00 |
|
Timm
|
1825edccf2
|
Renamed: remove_xpaths tests no longer prefixed with sanitizer.
|
2014-06-16 21:04:07 +02:00 |
|
Timm
|
97c5e6fa02
|
Changed: remove_xpaths called with String returns String, while called with Loofah fragment returns Loofah fragment. Added tests for this.
|
2014-06-16 21:04:07 +02:00 |
|
Timm
|
9a3a59eaae
|
Fixed: spelling mistake in SanitizeHelperTest.
|
2014-06-16 21:04:06 +02:00 |
|
Timm
|
9dac1e8b8f
|
Removed duplication in assert_dom_equal and assert_dom_not_equal.
|
2014-06-16 21:04:06 +02:00 |
|
Timm
|
86c6f5b1d9
|
Changed wording of missing selector argument exception message in css_select.
|
2014-06-16 21:04:06 +02:00 |
|
Timm
|
bffa6469b7
|
Reworked root and selector conditional assignment in css_select.
|
2014-06-16 21:04:06 +02:00 |
|
Timm
|
5a14dbf521
|
Added related Nokogiri issue link to tests that fail with unknown encoding ASCII-8BIT.
|
2014-06-16 21:04:05 +02:00 |
|
Timm
|
63e0fa7d8f
|
Moved Action Pack changelog message to Action View. Clarified Dom and Selector assertions changes in there.
|
2014-06-16 21:04:05 +02:00 |
|
Timm
|
dddf86a3b7
|
Trimmed deprecation message for ActionDispatch::Assertions::SelectorAssertions.
|
2014-06-16 21:04:05 +02:00 |
|
Timm
|
53f25ae348
|
Removed :nodoc: from PermitScrubber.
|
2014-06-16 21:04:05 +02:00 |
|
Timm
|
d6a6d42e7e
|
Reworked documentation for PermitScrubber and TargetScrubber.
|
2014-06-16 21:04:05 +02:00 |
|
Timm
|
349230e823
|
Fixed: spelling error.
|
2014-06-16 21:04:04 +02:00 |
|
Timm
|
b13d22bff5
|
Initialized tags and attributes to nil.
|
2014-06-16 21:04:04 +02:00 |
|
Timm
|
39df4028a2
|
Refactored scrub to keep_node? instead of scrub_node calling it. Also added ability to stop traversing by returning STOP from scrub_node.
|
2014-06-16 21:04:04 +02:00 |
|
Timm
|
557806f402
|
Changed PermitScrubber to be even more extensible. Updated TargetScrubber to be compliant. Updated documentation for PermitScrubber and TargetScrubber for clarity.
|
2014-06-16 21:04:04 +02:00 |
|
Timm
|
ea57c7cc85
|
Changed PermitScrubbers documentation to list override points for subclasses. Renamed should_remove_attributes? to should_scrub_attributes?.
|
2014-06-16 21:04:03 +02:00 |
|
Timm
|
ac0d778fe9
|
Already killed off LinkScrubber. Changed it instead to be TargetScrubber, which is more general, while still allowing maximum code reuse.
|
2014-06-16 21:04:03 +02:00 |
|
Timm
|
1cdc511b90
|
Added LinkScrubber to remove duplication in LinkSanitizer. As such made PermitScrubber easier to subclass.
|
2014-06-16 21:04:03 +02:00 |
|
Timm
|
739ecdf753
|
Changed FullSanitizer sanitize to use tap method instead of temporary variable.
|
2014-06-16 21:04:03 +02:00 |
|
Timm
|
d1de087467
|
Extracted the common xpaths to remove into XPATHS_TO_REMOVE.
|
2014-06-16 21:04:03 +02:00 |
|
Timm
|
945e7f529e
|
Refactored remove_xpaths to use duck typing and read better.
|
2014-06-16 21:04:02 +02:00 |
|
Timm
|
f428aeaa19
|
Changed explanation for no duck typing of custom scrubbers.
|
2014-06-16 21:04:02 +02:00 |
|
Timm
|
3ca10618a0
|
Added correct requires in html-scanner tests. Sanitizers are not based on html-scanner anymore, so sanitizer_test.rb is removed.
|
2014-06-16 21:04:02 +02:00 |
|
Timm
|
748f28157b
|
Require ActionView::Assertions in ActionController test_case.rb.
|
2014-06-16 21:04:02 +02:00 |
|
Timm
|
7b2e753c1c
|
Marked test_feed_xhtml as pending. See description in the test.
|
2014-06-16 21:04:01 +02:00 |
|
Timm
|
dea8ddbca1
|
Removed copyright notice since we aren't relying on html-scanner anymore.
|
2014-06-16 21:04:01 +02:00 |
|
Timm
|
09454dcca9
|
Removed require for active_support/core_ext/object/inclusion since in? isn't used anywhere.
|
2014-06-16 21:04:01 +02:00 |
|
Timm
|
95c517b6d6
|
Moved Dom and Selector assertions from ActionDispatch to ActionView.
|
2014-06-16 21:04:01 +02:00 |
|
Timm
|
9f73f9f38c
|
Fixed: assert_select_encoded finds the right content. No longer uses a <encoded> wrapper. Updated tests to reflect this.
|
2014-06-16 21:04:00 +02:00 |
|
Timm
|
1bc0bece5b
|
Removed mention of css_select supporting substitution values. It is not tested anywhere.
|
2014-06-16 21:04:00 +02:00 |
|
Timm
|
6fd74dc00e
|
Updated documentation to state more things about css selectors with substitution values.
|
2014-06-16 21:04:00 +02:00 |
|
Timm
|
9020abe0e9
|
Reworked the wrapping root in NodeSet implementation in css_select.
|
2014-06-16 21:04:00 +02:00 |
|
Timm
|
77d0333c08
|
Wrapped element to search in NodeSet. Changed selectors to selector.
|
2014-06-16 21:03:59 +02:00 |
|
Timm
|
ea5f3ba0e2
|
Moved around alias line.
|
2014-06-16 21:03:59 +02:00 |
|
Timm
|
f2c9734be0
|
Returning from filter if matches are empty.
|
2014-06-16 21:03:59 +02:00 |
|